From: Tim Chen <tim.c.chen@linux.intel.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Dave Hansen <dave.hansen@intel.com>,
Ying Huang <ying.huang@intel.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] mm: Force update of mem cgroup soft limit tree on usage excess
Date: Fri, 26 Feb 2021 16:56:28 -0800 [thread overview]
Message-ID: <781634ee-ffb9-598d-fdb6-0ae6067448b7@linux.intel.com> (raw)
In-Reply-To: <YDi2udQqIML6Vdpo@dhcp22.suse.cz>
On 2/26/21 12:52 AM, Michal Hocko wrote:
>>
>> Michal,
>>
>> Let's take an extreme case where memcg 1 always generate the
>> first event and memcg 2 generates the rest of 128*8-1 events
>> and the pattern repeat.
>
> I do not follow. Events are per-memcg, aren't they?
> __this_cpu_read(memcg->vmstats_percpu->targets[target]);
> [...]
> __this_cpu_write(memcg->vmstats_percpu->targets[target], next);
>
You are right. My previous reasoning is incorrect as the sampling is done per memcg.
I'll do some additional debugging on why memcg is not on the tree.
Tim
next prev parent reply other threads:[~2021-02-27 0:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 20:41 [PATCH v2 0/3] Soft limit memory management bug fixes Tim Chen
2021-02-17 20:41 ` [PATCH v2 1/3] mm: Fix dropped memcg from mem cgroup soft limit tree Tim Chen
2021-02-18 8:24 ` Michal Hocko
2021-02-18 18:30 ` Tim Chen
2021-02-18 19:13 ` Michal Hocko
2021-02-18 19:51 ` Tim Chen
2021-02-18 19:13 ` Michal Hocko
2021-03-04 17:35 ` Tim Chen
2021-03-05 9:11 ` Michal Hocko
2021-03-05 19:07 ` Tim Chen
2021-03-08 8:34 ` Michal Hocko
2021-02-17 20:41 ` [PATCH v2 2/3] mm: Force update of mem cgroup soft limit tree on usage excess Tim Chen
2021-02-19 9:11 ` Michal Hocko
2021-02-19 18:59 ` Tim Chen
2021-02-20 16:23 ` Tim Chen
2021-02-22 8:40 ` Michal Hocko
2021-02-22 17:41 ` Tim Chen
2021-02-22 19:09 ` Michal Hocko
2021-02-22 19:23 ` Tim Chen
2021-02-22 19:48 ` Tim Chen
2021-02-24 11:53 ` Michal Hocko
2021-02-25 22:48 ` Tim Chen
2021-02-26 8:52 ` Michal Hocko
2021-02-27 0:56 ` Tim Chen [this message]
2021-03-01 7:39 ` Michal Hocko
2021-02-25 22:25 ` Tim Chen
2021-03-02 6:25 ` [mm] 4f09feb8bf: vm-scalability.throughput -4.3% regression kernel test robot
2021-02-17 20:41 ` [PATCH v2 3/3] mm: Fix missing mem cgroup soft limit tree updates Tim Chen
2021-02-18 5:56 ` Johannes Weiner
2021-02-22 18:38 ` Tim Chen
2021-02-23 15:18 ` Johannes Weiner
2021-02-19 9:16 ` Michal Hocko
2021-02-19 19:28 ` Tim Chen
2021-02-22 8:41 ` Michal Hocko
2021-02-22 17:45 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=781634ee-ffb9-598d-fdb6-0ae6067448b7@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=vdavydov.dev@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox