From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6819BEB64DA for ; Wed, 5 Jul 2023 19:38:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8C398D0003; Wed, 5 Jul 2023 15:38:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3C538D0001; Wed, 5 Jul 2023 15:38:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C03978D0003; Wed, 5 Jul 2023 15:38:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B0A248D0001 for ; Wed, 5 Jul 2023 15:38:41 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6F5C31A0381 for ; Wed, 5 Jul 2023 19:38:41 +0000 (UTC) X-FDA: 80978570442.12.F517EE2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 2B7EA1C0027 for ; Wed, 5 Jul 2023 19:38:38 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i6l2zTjF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688585919; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2LkPXGfTtUH5FuOUrLUe3qSTFVo4QS+rW6uZwA0gLV4=; b=MFihAHkUwjWGyv3G6Yfd32bBVtSVX1fWnXyvEhj7AJ+1rU6Vh1rdxOUX14iBYApaeJe9m2 0bwsDlcmODNZQnIqP83mUoLXFw/p0K2sT1I5mfhc8wDHD3oFfkcoaCkv+i9+aBCk2WjEt9 lmVUEf5ssYdqSvX4l1yl9rWyN36C0fM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i6l2zTjF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688585919; a=rsa-sha256; cv=none; b=CsYmume/BnNZ8LXKwsUIyhIZNdF6JjCkgwUMfnzA+lBl7ddOoTaCu/kJcRXTmVmoPyEPy0 m4VmTJgYIkeKCYeATfMmrDuBENLOmEgla09yYiq0zkqTcNXVH7kj9s1ljLV8R35sAx+zpZ ADfERs7RFbNzKmg0NujlIjH7Mn9/6AM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688585918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2LkPXGfTtUH5FuOUrLUe3qSTFVo4QS+rW6uZwA0gLV4=; b=i6l2zTjFLdwUV6LfUxn81NHIbK9a1a6Ol68iOfpjBYtCqFDSqUcAzH/wm7XudJjVJ+Nr+i 8aUiuJIukYVdvpEnPedKk6GnJaZl9wajjQJZOPY2HEWJNGm78mKkE5PlZxHj/rjK9xufFX EfzA720obYRFyMALmDQUfMjwhRGEBZk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-327-vk70cA0vNQaq901NjTv2mw-1; Wed, 05 Jul 2023 15:38:37 -0400 X-MC-Unique: vk70cA0vNQaq901NjTv2mw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fbab56aac7so44180325e9.1 for ; Wed, 05 Jul 2023 12:38:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688585916; x=1691177916; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2LkPXGfTtUH5FuOUrLUe3qSTFVo4QS+rW6uZwA0gLV4=; b=NeLVaC3ujPEUefwlU9LR2hDJ29PgJYm1q0m3GgtVoIWb9FGQnWY4ud/ydtw192zZtc 8eKzmTwnfZQJvwVJh9dxHcyIh/CRgQs44lfEiY2LDoiBj7oFUw8KD7s+JUMujivLizdm /5ZP2i+W/7Rgp7vS7ptxwSGtrctEEIRwz7WLnupIqcBw7MInMTWysfqmlVP10SjTHYJy atHZ8WOSFXbfYpsa0uZoik7cOot1z3eZ68x1I1xq1P576h0retA/eCgVoqzWcZzEPJhM 3jEtP+k3Nf1E3AFjdyel5/Sy5rEB/rlI+S7c0iSZG/wWKzsdA8U2/6rrdOUZqMWS9D7U X2IQ== X-Gm-Message-State: AC+VfDyIaQpIf5p+IalnJnYRei+xytiBHA5Fz8jN/f14FOwmb/eTjjGa kjKFyF+5czCPV2BLCk/6/ZHhcrFOQReaX9HoUPh8+ts5Wz4q/2ydI0Fkh8kdtocdCE8tsJyHfda pMC240Pnth4M= X-Received: by 2002:a7b:ce87:0:b0:3f7:aad8:4e05 with SMTP id q7-20020a7bce87000000b003f7aad84e05mr16094668wmj.11.1688585915700; Wed, 05 Jul 2023 12:38:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5SinKO/39gyhOIO7laZxTzu6zK3ZRvtrbet5rKpwhogS74hv5oaCsyiZwcdYsNUGNWNi2Yew== X-Received: by 2002:a7b:ce87:0:b0:3f7:aad8:4e05 with SMTP id q7-20020a7bce87000000b003f7aad84e05mr16094648wmj.11.1688585915267; Wed, 05 Jul 2023 12:38:35 -0700 (PDT) Received: from ?IPV6:2003:cb:c71a:1c00:e2b1:fc33:379b:a713? (p200300cbc71a1c00e2b1fc33379ba713.dip0.t-ipconnect.de. [2003:cb:c71a:1c00:e2b1:fc33:379b:a713]) by smtp.gmail.com with ESMTPSA id 17-20020a05600c22d100b003fbd0c50ba2sm2978019wmg.32.2023.07.05.12.38.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 12:38:34 -0700 (PDT) Message-ID: <78159ed0-a233-9afb-712f-2df1a4858b22@redhat.com> Date: Wed, 5 Jul 2023 21:38:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 0/5] variable-order, large folios for anonymous memory To: Ryan Roberts , Andrew Morton , Matthew Wilcox , "Kirill A. Shutemov" , Yin Fengwei , Yu Zhao , Catalin Marinas , Will Deacon , Anshuman Khandual , Yang Shi Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230703135330.1865927-1-ryan.roberts@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230703135330.1865927-1-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2B7EA1C0027 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: xpo7qe5x46yybhtokptnwsb7ruzgtr4m X-HE-Tag: 1688585918-592445 X-HE-Meta: U2FsdGVkX18u1wug904S+dG1IqyNnS4cecVqfYVulgZxSrG7j1WPL+XWg8alIPaafqd+hZLwqBnH5P3TXGw5enesWz0J3JMSMHRcUi+DT2NU8E7PxzAM6j99MtyGLR/fsFtXlUS9ydyi1GBm2weKdpBt/f7v3f1AUZlbJ4Dlzw//rYNJlFx0vFm3/ybv72TcbR/Q+v61heaaYigYcOnn9IvEflhTVjV9yS8HISgnOj4BIvTQHcm8nPoepFlGF9FM68+NgSpvKXy08ch10odFL8svApoIfx8ipV1kMeam5gE94hJGw6NNbHPwafZlTrKtMHTW+v75NzKLeKGeF3zyWuo1pQrgZhKh8UHhVcr5tAByDrWoQKBdaRR/Uilcsn/Rg5D7/98RYlwc/1UQQ/yq2KKo6Z16H++TqS9kEGDx299tYSsGID7ZRQNk3Ayy09WY0Oid9acQTvpi6GoYuQfQ/XOBYEV7ynhbDvkvtSzrmRQcjPAgd/lcYDFgC0imRaAc/SmSmYMdHDMR4ttYrJTeHGJysoPElHT6I2gkDM7KZLUywyZoorApmA+CUj4ibm2HaAv1DhVnYour/GefX6GmlZC/wsNloJexNNqkCw3miblxkNKKz+cGdiBBL37YiQYpkrURgVEDeVdFdN2wGrVkv8W4lUS3VsupLdTY1AgkxxzF7/pp2V1VNyVNzAO9ldUm3S1oUuRPgpz1N135IZqS1DJyeetqI6ITxrQ5RMaossQzHn9QRd+hiOzyMl5Hfb8TjeQrqFB1h499+55718o29UdnjTmtsktdN8mhmppwz9h2XhUNMS19UgA3SZhwff9zbg47lCVg6cQ3g99UGmLxpEDOVNgdKpzqWWeqXyRXblMThXPBVAbYDZz82+2t6noMGkBIq0l4/pBnEKCBDHYkI6Uuq1uwj7RiBUw8sztSow0lrIkKoQsobWn8AErcqMMgZNOORaJzmOLJxmjEFqZ i9AmF5Ca OkncJ/3XuD9w5F+Nu4tLTnNy4df2WYOTY43cXulYLQwQHsWg7xKii6XXDcSv57WLw0TmBaOc0JgwuMoLEGO31sJv3EEnIticEl6QpUrHSNgpJIPw1mS0LGRiyIjYhzbL66kzsi3HUS4P3gSOlNkQ9CL2LrinnotVKrLYVwHA9W5VJvBAcmzmErhurjrhrBJbi+zeF0TWI/y3W6Ba+bLR5O53dfALct309kTawEYYfNQYjwi/Y/WeTUktk5bX6mW8iEYnqPDlIUWyTIT/iplKYXJ/oBxzGqQVHLp79R1G58Jzwleh4GpuzoeH+GKUqDclimiIpaBo78k6eUNDvSjIweoFRNUtBRoep3AH7E51ZcCIyZ3Q57Wlq7fy3rK8l1OsQkUYqgBjG0OMc/b3PL1tP+bAc9PfokFrc7oA+jsa2WSjShXMkbeAU194C0k9TvX/oD55AxFJbb95lUffUMn3+qjheD10wWPA4dddjMIzrdRss7vMHUVGm35/sAvn8NLAF4V9V8XzDiJPqba4qpYtlXsXDavLrAcqNmrXGV+KBxa0T3OiFMfiC9DrC8Sn3wSDP8Q/v8TbHZmikk6jEYh87JaXbIt5VGnH2mfj3AIC1GcKSF5s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.07.23 15:53, Ryan Roberts wrote: > Hi All, > > This is v2 of a series to implement variable order, large folios for anonymous > memory. The objective of this is to improve performance by allocating larger > chunks of memory during anonymous page faults. See [1] for background. > > I've significantly reworked and simplified the patch set based on comments from > Yu Zhao (thanks for all your feedback!). I've also renamed the feature to > VARIABLE_THP, on Yu's advice. > > The last patch is for arm64 to explicitly override the default > arch_wants_pte_order() and is intended as an example. If this series is accepted > I suggest taking the first 4 patches through the mm tree and the arm64 change > could be handled through the arm64 tree separately. Neither has any build > dependency on the other. > > The one area where I haven't followed Yu's advice is in the determination of the > size of folio to use. It was suggested that I have a single preferred large > order, and if it doesn't fit in the VMA (due to exceeding VMA bounds, or there > being existing overlapping populated PTEs, etc) then fallback immediately to > order-0. It turned out that this approach caused a performance regression in the > Speedometer benchmark. With my v1 patch, there were significant quantities of > memory which could not be placed in the 64K bucket and were instead being > allocated for the 32K and 16K buckets. With the proposed simplification, that > memory ended up using the 4K bucket, so page faults increased by 2.75x compared > to the v1 patch (although due to the 64K bucket, this number is still a bit > lower than the baseline). So instead, I continue to calculate a folio order that > is somewhere between the preferred order and 0. (See below for more details). > > The patches are based on top of v6.4 plus Matthew Wilcox's set_ptes() series > [2], which is a hard dependency. I have a branch at [3]. > > > Changes since v1 [1] > -------------------- > > - removed changes to arch-dependent vma_alloc_zeroed_movable_folio() > - replaced with arch-independent alloc_anon_folio() > - follows THP allocation approach > - no longer retry with intermediate orders if allocation fails > - fallback directly to order-0 > - remove folio_add_new_anon_rmap_range() patch > - instead add its new functionality to folio_add_new_anon_rmap() > - remove batch-zap pte mappings optimization patch > - remove enabler folio_remove_rmap_range() patch too > - These offer real perf improvement so will submit separately > - simplify Kconfig > - single FLEXIBLE_THP option, which is independent of arch > - depends on TRANSPARENT_HUGEPAGE > - when enabled default to max anon folio size of 64K unless arch > explicitly overrides > - simplify changes to do_anonymous_page(): > - no more retry loop > > > Performance > ----------- > > Below results show 3 benchmarks; kernel compilation with 8 jobs, kernel > compilation with 80 jobs, and speedometer 2.0 (a javascript benchmark running in > Chromium). All cases are running on Ampere Altra with 1 NUMA node enabled, > Ubuntu 22.04 and XFS filesystem. Each benchmark is repeated 15 times over 5 > reboots and averaged. > > 'anonfolio-lkml-v1' is the v1 patchset at [1]. 'anonfolio-lkml-v2' is this v2 > patchset. 'anonfolio-lkml-v2-simple-order' is anonfolio-lkml-v2 but with the > order selection simplification that Yu Zhao suggested - I'm trying to justify > here why I did not follow the advice. > > > Kernel compilation with 8 jobs: > > | kernel | real-time | kern-time | user-time | > |:-------------------------------|------------:|------------:|------------:| > | baseline-4k | 0.0% | 0.0% | 0.0% | > | anonfolio-lkml-v1 | -5.3% | -42.9% | -0.6% | > | anonfolio-lkml-v2-simple-order | -4.4% | -36.5% | -0.4% | > | anonfolio-lkml-v2 | -4.8% | -38.6% | -0.6% | > > We can see that the simple-order approach is responsible for a regression of > 0.4%. > > > Kernel compilation with 80 jobs: > > | kernel | real-time | kern-time | user-time | > |:-------------------------------|------------:|------------:|------------:| > | baseline-4k | 0.0% | 0.0% | 0.0% | > | anonfolio-lkml-v1 | -4.6% | -45.7% | 1.4% | > | anonfolio-lkml-v2-simple-order | -4.7% | -40.2% | -0.1% | > | anonfolio-lkml-v2 | -5.0% | -42.6% | -0.3% | > > simple-order costs 0.3 % here. v2 is actually performing higher than v1 due to > fixing the v1 regression on user-time. > > > Speedometer 2.0: > > | kernel | runs_per_min | > |:-------------------------------|---------------:| > | baseline-4k | 0.0% | > | anonfolio-lkml-v1 | 0.7% | > | anonfolio-lkml-v2-simple-order | -0.9% | > | anonfolio-lkml-v2 | 0.5% | > > simple-order regresses performance by 0.9% vs the baseline, for a total negative > swing of 1.6% vs v1. This is fixed by keeping the more complex order selection > mechanism from v1. > > > The remaining (kernel time) performance gap between v1 and v2 for the above > benchmarks is due to the removal of the "batch zap" patch in v2. Adding that > back in gives us the performance back. I intend to submit that as a separate > series once this series is accepted. > > > [1] https://lore.kernel.org/linux-mm/20230626171430.3167004-1-ryan.roberts@arm.com/ > [2] https://lore.kernel.org/linux-mm/20230315051444.3229621-1-willy@infradead.org/ > [3] https://gitlab.arm.com/linux-arm/linux-rr/-/tree/features/granule_perf/anonfolio-lkml_v2 > > Thanks, > Ryan Hi Ryan, is page migration already working as expected (what about page compaction?), and do we handle migration -ENOMEM when allocating a target page: do we split an fallback to 4k page migration? -- Cheers, David / dhildenb