From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F076EC83F25 for ; Mon, 21 Jul 2025 11:11:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 660296B0089; Mon, 21 Jul 2025 07:11:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6386D6B008C; Mon, 21 Jul 2025 07:11:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 574FF6B0092; Mon, 21 Jul 2025 07:11:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 46D506B0089 for ; Mon, 21 Jul 2025 07:11:16 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E83151A06D1 for ; Mon, 21 Jul 2025 11:11:15 +0000 (UTC) X-FDA: 83688005310.26.C7A63B6 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf14.hostedemail.com (Postfix) with ESMTP id E5D9C100005 for ; Mon, 21 Jul 2025 11:11:13 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=K7ajjDa8; spf=pass (imf14.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753096274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DnIbqCqg7JUChrhPkDwkGlZxQxz27HWtx39eq2JQF6U=; b=BQ2L1u+BBobYqaqApLfxqjfTfnQRqh0NQYqz4Z6cK/6GTR4WRUr1cJWnwYIS4mHpxQK66i Q1WElP9FLwCHDRxZBLmBwqMxSur5T7ZtRp203wKjLiXA+EREnI5V+XPsAmM9mV8qcd8Qp3 NtjfFJm006yT6Vtn+RkUXq0qXxwyjOA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753096274; a=rsa-sha256; cv=none; b=jXaQb1pLXf/sRfFGuLilu7E4H8DVnGUpgzogUizJb3jqP7kKoPtKurnBsWtHMIoDpnfAYV UPHq2GoDAssdZrnCJZ67/oYMoVw9QcDgF76wF3ntU/bNg/C1/fddpcvCyuL4lvB5msiDrm Zrq2Kx6i4oK9WI9q4BEeEIRZON4wP4o= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=K7ajjDa8; spf=pass (imf14.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-612bc52ac2bso6663669a12.2 for ; Mon, 21 Jul 2025 04:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753096272; x=1753701072; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DnIbqCqg7JUChrhPkDwkGlZxQxz27HWtx39eq2JQF6U=; b=K7ajjDa8YTvHDPtoxjsqFO1xtwbDUauAvwYFFZjZY5sWgl0F7dM4eqqsTRGRqbUApI hmFrOvZQy74y60o9feRcAjBZunO049V/xvcTRpPu6vxYYkoT3yMf2ibrXZudlBEXq3wg WneAOrrDE/9iBDa8IfZ/BOB8gmO2snIFqTthRPCY12f5Jx05YUIbSe2EqSpNZ8o0EQI7 3B8UwYwAZ4b1JcEDJHHrdpKa0eeBU4tPdeHkl4Gnm/Xb0XNuN6Va7Fj/H1jV8qMBnFR5 o2hoClwawk22btmjyREsnIaOR1mR6ejsa2QTQ1xp9Hx5mvFID0Y8Lh8Vs+dcbT2D+PPL H92A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753096272; x=1753701072; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DnIbqCqg7JUChrhPkDwkGlZxQxz27HWtx39eq2JQF6U=; b=OaykYFPNs9x4dl/s4HP84aS4SYfFoyePZFDoOsbopIQqUJyzB/v8xYOtIz+XgAoRFO NyzAxNn3HOaw+Hy1S5K7A01zv/yT4ZbIqbp2WXJlRtfI6bC9hTIj/+Cnv/Sv7baFIeu8 LwUwMNQzSVDdTbHzUrgMp3j5eESp00ijOgJrow74EfkgOB4xnEZX2/Ca70ODHDKVnd/F t6O/MWi7s/KBfMRZVuYueZXlkOAz3IPsmBPkequlf5XjLxdRus+hnqNjEGZW5KuJbFI5 BiRo2GHD2G5le31xPWNBF/YpGebW/C/sWyNyw1Afp9fWlJ6MYBRYxDdBe2ra6hVTO+e7 7VJw== X-Forwarded-Encrypted: i=1; AJvYcCUMmvp+N4tvXbN2RyQ5c0NvFWmXATnxB8yQa0AN3MGHAlppLnjaPOfLLF4rTaOXP1TsQpuR2fg9Gg==@kvack.org X-Gm-Message-State: AOJu0YzBOXyNSiXKg2AmcsXvQ4NoBUvSFPynMHyKetV+BVKQZTCB5ip0 PGt31Qgru7YRHKEUlPucHTRZhqrS5Irfzobgg6derWqNTK+4sZtpqcHr X-Gm-Gg: ASbGncsec38AXJH2kLJAGTLrMP/sI6jF0jeDziIIB8T2ONtsrxESJA72+rbIL9OUST4 UcwZwc+E4bAizBPe0IFSchEjZ9qU2UrwS36jkIjpH3rPe81u4OG4m44krebXB97en+IWnwH7oqt 9YVYlyDwNupOrZ6M5JwPpaysvdAkl3ZSdUHzxzDeejta9r1y98Igre3KzKpmzsIRilZ4sQo08Q1 Z8hrPd9IT5IzwgXWAis05RzeoTjfgy+2bXrQrBvR5qfQyXcycMp6raWCU3j3fq1IeE8qmKB52ux YErh+gea/ZjhSxAvte8V1PC+8FMmDOIN35NFRRnhonKYGDfndOnej0cziRVjK7U/e5QHKdpDYMI DWOwo1DLd9DZRDstORtglhc0UnsoHH4y7OYY= X-Google-Smtp-Source: AGHT+IHZCiqaXpmflAtItwVaPlH3VjQHk/jBIB6Bq5oI/tEB5I4tXMP1diqfcZBAAFQiHufovShJUw== X-Received: by 2002:a05:6402:524e:b0:607:425c:3c23 with SMTP id 4fb4d7f45d1cf-6128590ba42mr17312482a12.5.1753096271896; Mon, 21 Jul 2025 04:11:11 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::1ac? ([2620:10d:c092:600::1:23d3]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-612c907a5b1sm5274092a12.53.2025.07.21.04.11.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jul 2025 04:11:11 -0700 (PDT) Message-ID: <77ee68c4-f265-4e55-9889-43ab08f26efd@gmail.com> Date: Mon, 21 Jul 2025 12:12:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm, page_pool: introduce a new page type for page pool in page type To: Byungchul Park , linux-mm@kvack.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel_team@skhynix.com, harry.yoo@oracle.com, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, kuba@kernel.org, hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me, saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com, mbloch@nvidia.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, ilias.apalodimas@linaro.org, willy@infradead.org, brauner@kernel.org, kas@kernel.org, yuzhao@google.com, usamaarif642@gmail.com, baolin.wang@linux.alibaba.com, almasrymina@google.com, toke@redhat.com, bpf@vger.kernel.org, linux-rdma@vger.kernel.org References: <20250721054903.39833-1-byungchul@sk.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250721054903.39833-1-byungchul@sk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E5D9C100005 X-Stat-Signature: d9iugupgr5auyqk8pdz9rfpotqz8tkew X-Rspam-User: X-HE-Tag: 1753096273-8199 X-HE-Meta: U2FsdGVkX1+GPs3zBfkw0Kv4ixEjRooKmohV40R6MVDfcbAk1vWsFLZhucvLV36btS6iCIjnveRNVWXoXn5+uvlfBO9fvzlimf+H1qgZEH8M99Qh8uPxCsIJC4kQh0u/1j5Vd0khNH12ZNLi/UHmPFZYipHXB0T0G2eOZKZotUS26OVnYshBhDvJ9RYbRX/NzndeveY7a9p8WRf0+g82RLEmaQppDd+aQylkW0rtvdIklDG3cbsvr+p/WoHExbsFxNDS9dto0BBipjdDP5G3w7WncNIw9C0f6PiXzl2cepgtlgMaPh3ZMsJ+rFgTkEUM50V2fYzM/j0GTFlnXDPOBFBa3NTW+5+LR+XnwZGC1/8+WfuONV7ZGzSx3TayUJrSlOLE/VY6YKn84Z3Eu2vAj7eMxukHRRoCm5fl6X/E44UBOoi4zSyBYxYsqO5p8YHUYNE7TRkGsuF3m0Q9i6M2vn6BIn4BRiWgcqyOFb2a+0DqpgwVm+Zje9bYgL8hnBHQMqSBC7hoIeHZa5wfDjEqLxVaw1Wp7trltaMc8minP+R+ZtlCU4PpZIXNdxeSKa/s8ONWdQ8U6kUF86F3mHgyozOPN/EMroyL7ix0q5Kahtd+q/qWPXqTL7Qxo72RtTtIFMdovrRuYpqLcmgUdR8LmyuJSxvV3z3qL1UV8iHUCRWsuA6i8lEMTSV++YYlUi8fuWmJNJqvPOBiWPRAkqDHiWNOnraMr/iW2+sIhj0SeKdenJpshh9bwWhVwEp7mKlHVf8aVN1zctKnOvp8ieRqyELEXIEsEQFnApDy4EP775NmKhrQXG7tpPNl/Fj0euobCMqSV05Y8JATkXRSsfZVnTQ8LubBns/2jdPc96zH7dxELT/dvrMV/Taf2HuH+ANKSI8v+i2nGcpKYaz+JYPBxha8gA1iw/b9R9lG1myvPPHI1KN3YvAbOnWlqjZt5aArd6XqIUyEGJXXIoVaXxU MUmk4uXW buQPqiwOqvryoZDUhOrUXSA1xjLn/1gpZNx5OlsBGYox3nh3VwRmGZsbfi8wWvdjAbp2ydCePfn5JYBVXTx/do1/uMUpNJ+OzkTmDhB6ruIIvepEhbSv9JXWc7VO3zdepbG3BR5754O/IHjvDs3AT4g1OXKCfLqS11SIY+bI8jJo4wrwAUsTae6FMu/LTB4IM113DkReVb5QXC33104D2mSxA0ztjqlcwCI98gjQdfh4g47Vf7Id7gB6M/VP3bSx/8u3NfV1fKsHlFuo3vnJZ0tqnjJTSLlxplNUiw5aMZ5MBxO1g30x2OzuN3B79APx+/II8+3K20EltacOsEA+go0sAnIpe13ejleZJ97MCqpUiYSAMA5kzf3tngFvyPseIZ8Dxg+l+q3qdnPCpT/V06eU/Yokv5cxqvwdwtZWQovbzAJx/O9r+X1hJzZOfpuvZom62ttHiynZyiKZTYSdsrsiEirrXRWxmGd36Iuv8+r3Jw1WrRlhYKgKo9jB+AgoKMWDlC8uuFJNG8uwlZ0lVge+PagwXDKTAWenIR9aqbFtL5JIIGJM97JPhqTxHl7wXcJa5DedMIXJU4sF1d0huYp/iy5i2+TPeVpJ8XiocEBxRUM4V+DfsSeYiEocEbETbFfDP7LYhvzCiK5B7y+oIVLLHaQWZTUgMy7vQtcln2Yhat0gI8weyYBglI23NEzGyxSki X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/21/25 06:49, Byungchul Park wrote: > Hi, > > I focused on converting the existing APIs accessing ->pp_magic field to > page type APIs. However, yes. Additional works would better be > considered on top like: > > 1. Adjust how to store and retrieve dma index. Maybe network guys > can work better on top. > > 2. Move the sanity check for page pool in mm/page_alloc.c to on free. Don't be in a hurry, I've got a branch, but as mentioned before, it'll be for-6.18. And there will also be more time for testing. > This work was inspired by the following link by Pavel: The idea came from David, let's add Suggested-by: David Hildenbrand ...> - > static inline bool netmem_is_pp(netmem_ref netmem) > { > - return (netmem_get_pp_magic(netmem) & PP_MAGIC_MASK) == PP_SIGNATURE; > + if (netmem_is_net_iov(netmem)) This needs to return false for tx niovs. Seems like all callers are gated on ->pp_recycle, so maybe it's fine, but we can at least check pp. Mina, you've been checking tx doesn't mix with rx, any opinion on that? Question to net maintainers, can a ->pp_recycle marked skb contain not page pool originated pages or a mix? -- Pavel Begunkov