linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
	linuxppc-dev@lists.ozlabs.org
Cc: linux-mm@kvack.org, Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
	Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Subject: Re: [RFC v1 09/10] powerpc: book3s64: Make use of H_RPTI_TYPE_ALL macro
Date: Wed, 4 Mar 2026 10:07:10 +0100	[thread overview]
Message-ID: <77e64962-7c01-4f1a-8c15-e7a966741833@kernel.org> (raw)
In-Reply-To: <3fb34ebce6a92855ce6c20326c1f7f99097227e3.1772013273.git.ritesh.list@gmail.com>



Le 25/02/2026 à 12:04, Ritesh Harjani (IBM) a écrit :
> Instead of opencoding, let's use the pre-defined macro (H_RPTI_TYPE_ALL)
> at the following places.
> 
> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>

> ---
>   arch/powerpc/mm/book3s64/radix_tlb.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/powerpc/mm/book3s64/radix_tlb.c b/arch/powerpc/mm/book3s64/radix_tlb.c
> index 6ce94eaefc1b..7de5760164a9 100644
> --- a/arch/powerpc/mm/book3s64/radix_tlb.c
> +++ b/arch/powerpc/mm/book3s64/radix_tlb.c
> @@ -885,8 +885,7 @@ static void __flush_all_mm(struct mm_struct *mm, bool fullmm)
>   	} else if (type == FLUSH_TYPE_GLOBAL) {
>   		if (!mmu_has_feature(MMU_FTR_GTSE)) {
>   			unsigned long tgt = H_RPTI_TARGET_CMMU;
> -			unsigned long type = H_RPTI_TYPE_TLB | H_RPTI_TYPE_PWC |
> -					     H_RPTI_TYPE_PRT;
> +			unsigned long type = H_RPTI_TYPE_ALL;
>   
>   			if (atomic_read(&mm->context.copros) > 0)
>   				tgt |= H_RPTI_TARGET_NMMU;
> @@ -982,8 +981,7 @@ void radix__flush_tlb_kernel_range(unsigned long start, unsigned long end)
>   {
>   	if (!mmu_has_feature(MMU_FTR_GTSE)) {
>   		unsigned long tgt = H_RPTI_TARGET_CMMU | H_RPTI_TARGET_NMMU;
> -		unsigned long type = H_RPTI_TYPE_TLB | H_RPTI_TYPE_PWC |
> -				     H_RPTI_TYPE_PRT;
> +		unsigned long type = H_RPTI_TYPE_ALL;
>   
>   		pseries_rpt_invalidate(0, tgt, type, H_RPTI_PAGE_ALL,
>   				       start, end);
> @@ -1337,8 +1335,7 @@ void radix__flush_tlb_collapsed_pmd(struct mm_struct *mm, unsigned long addr)
>   			unsigned long tgt, type, pg_sizes;
>   
>   			tgt = H_RPTI_TARGET_CMMU;
> -			type = H_RPTI_TYPE_TLB | H_RPTI_TYPE_PWC |
> -			       H_RPTI_TYPE_PRT;
> +			type = H_RPTI_TYPE_ALL;
>   			pg_sizes = psize_to_rpti_pgsize(mmu_virtual_psize);
>   
>   			if (atomic_read(&mm->context.copros) > 0)



  reply	other threads:[~2026-03-04  9:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 11:04 [RFC v1 00/10] Misc powerpc fixes and refactoring Ritesh Harjani (IBM)
2026-02-25 11:04 ` [RFC v1 02/10] powerpc: book3s64: Fix unmap race with PMD THP migration entry Ritesh Harjani (IBM)
2026-03-04  8:54   ` Christophe Leroy (CS GROUP)
2026-02-25 11:04 ` [RFC v1 03/10] mm/debug_vm_pgtable.c: Add test to zap " Ritesh Harjani (IBM)
2026-02-25 11:04 ` [RFC v1 04/10] powerpc/64s/tlbflush-radix: Remove unused radix__flush_tlb_pwc() Ritesh Harjani (IBM)
2026-03-04  8:55   ` Christophe Leroy (CS GROUP)
2026-02-25 11:04 ` [RFC v1 05/10] powerpc/64s: Move serialize_against_pte_lookup() to hash_pgtable.c Ritesh Harjani (IBM)
2026-03-04  9:00   ` Christophe Leroy (CS GROUP)
2026-02-25 11:04 ` [RFC v1 06/10] powerpc/64s: Kill the unused argument of exit_lazy_flush_tlb Ritesh Harjani (IBM)
2026-03-04  9:02   ` Christophe Leroy (CS GROUP)
2026-02-25 11:04 ` [RFC v1 07/10] powerpc: book3s64: Rename tlbie_va_lpid to tlbie_va_pid_lpid Ritesh Harjani (IBM)
2026-03-04  9:04   ` Christophe Leroy (CS GROUP)
2026-02-25 11:04 ` [RFC v1 08/10] powerpc: book3s64: Rename tlbie_lpid_va to tlbie_va_lpid Ritesh Harjani (IBM)
2026-03-04  9:06   ` Christophe Leroy (CS GROUP)
2026-02-25 11:04 ` [RFC v1 09/10] powerpc: book3s64: Make use of H_RPTI_TYPE_ALL macro Ritesh Harjani (IBM)
2026-03-04  9:07   ` Christophe Leroy (CS GROUP) [this message]
2026-02-25 11:04 ` [RFC v1 10/10] powerpc: Add MMU_FTRS_POSSIBLE & MMU_FTRS_ALWAYS Ritesh Harjani (IBM)
2026-03-04  9:09   ` Christophe Leroy (CS GROUP)
2026-03-04  9:23     ` Ritesh Harjani
2026-02-25 11:42 ` [RFC v1 01/10] powerpc/pgtable-frag: Fix bad page state in pte_frag_destroy Ritesh Harjani
2026-02-25 11:04   ` Ritesh Harjani (IBM)
2026-03-04  8:53   ` Christophe Leroy (CS GROUP)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77e64962-7c01-4f1a-8c15-e7a966741833@kernel.org \
    --to=chleroy@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@kernel.org \
    --cc=hughd@google.com \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=ritesh.list@gmail.com \
    --cc=venkat88@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox