From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C570C3ABC9 for ; Fri, 9 May 2025 17:53:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF0066B000A; Fri, 9 May 2025 13:53:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9B866B008C; Fri, 9 May 2025 13:53:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8AE66B0093; Fri, 9 May 2025 13:53:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 892596B000A for ; Fri, 9 May 2025 13:53:55 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5DF321C9DAB for ; Fri, 9 May 2025 17:53:56 +0000 (UTC) X-FDA: 83424117672.14.667EEA6 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf10.hostedemail.com (Postfix) with ESMTP id 53C1DC0005 for ; Fri, 9 May 2025 17:53:54 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UVhWRp+Y; spf=pass (imf10.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746813234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AFB0VgN6jshFs8oHLmHjl8DGH2asagtJmEA8b7Wfb9c=; b=Dk/t7mh3dvwWKuI7on/UjBMjf7lwfiLenq3gscXTatARe8BdwlobWE2SpRHSeNEu2UQT3K /S3NSx+KRvpveRQCPaVHeypSFCePzlfEXctw5zKDe7PdwNALbk0Eomh5CMjuZyTpxMTSgx 9EWhPckUthsM51oomDFbAoEyXkvTu3Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746813234; a=rsa-sha256; cv=none; b=l3t9BOekMLXkKTFZ+2jUoHMvHniyKcNub/mzsFZrXSOkHwwjPXZrqyb2GfisA33nmRQntF SQWv6OKDO7zWLb5TrfqY6spUMuxbJQXjgxr2D24dC11DtO+SlVPOQhZM6HG+tEFN/+5Jkm bgM+IkoPm5RTFbkmGcfZCXDApF4rYXU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UVhWRp+Y; spf=pass (imf10.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-7376e311086so3527032b3a.3 for ; Fri, 09 May 2025 10:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746813233; x=1747418033; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=AFB0VgN6jshFs8oHLmHjl8DGH2asagtJmEA8b7Wfb9c=; b=UVhWRp+YPMIH1FY7DK0ls72S4X/fR4g639H0VW6EZ8Hu1Wz35OZZFlIRifdQ3uiVH+ QNRsFtR9RUogsBqrfSua3+5NKrbKoeH2OTtlPIiCwJzbqWuAcRGhlXrf2t4QTkDRxDpJ hMn9lvnphfCBYaqKaatEYPVc6miPs8x9AI4l4jEEtehdfyKnGlV9/R4Of/QU4mobBg6y 9PgFzeVXs6MaGbgOFiAfraFtUMvx0FF6qx3shHqN7gegGe17jYNWUgjINWm8zMkCe8ba /jpu1aKs9MHWEM9hI7WPcEQ6KcPEQaX4mMsT/7k5libosOcInVNLKW74z9ZHiH8jV5XH I50g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746813233; x=1747418033; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AFB0VgN6jshFs8oHLmHjl8DGH2asagtJmEA8b7Wfb9c=; b=LLkmRryrk7QHmRElxSazGNZurg+i98rj7HhH4xLu5ZNiFfqU8fOjC2v4NX+xFMkx62 V4HHYGHDrhuAs8wbg/XPeVhLV7wG70uRddTwpG1njHU1PkAWGxjQR67MECTsRr44S2KK dGe+4uIi8fmdArq7VFgKrOGwN+w7Tjor3XYJ09AQrPLbhW5H+DOEh8DDawcGl0MLBVAX m+BDV+88DNparWCBM+yRbNw92yHpKseb3wOTsjR3CHcSuS4PmVDqWEWZX687tIR4radH 75W7WV314jb+UO22kPWTtKbbAjH1FKX8+XYIY30jSJC1yHRj8b8R30hIpgeOqFvz1nbw BxAA== X-Forwarded-Encrypted: i=1; AJvYcCVXZIhwW8xMWdTCDLNBivkM5T4pGpqJkVolEk2QSuMATE5kIZgbQS/zbmXxG/7OIGv3ZtE5OSCl9w==@kvack.org X-Gm-Message-State: AOJu0Yxv3UyOSXTrS1kq5TcQHQGBe6UBj8eG7jpoJXtihS8EhlIB4+Kh rT3HpaMriCjzPwFCDVq02NOkqlS3MaUtI/jAYDd5s/GPRN8BGPRe X-Gm-Gg: ASbGncuu9UT73tF6E3xSXG7+Z/kNhfP6pSW4qUrli3vZ5QJrbzhoQAhWhAouBhDrIs0 Im9tV+IzyVq+rASv/FwjKw4Ahhnmil7xMY1iIx5JnXjBMcq0FuBn+j/TdRRU+il5vpuCcdangYi LOQC6vXQJfdWtDCMkDID2Mc1IU6E40IMAA1iZLIGj+8T/olMfs2aMOuSFzd4TMI/Hi+x4EiouKZ HOfZiXAPH5WgrLuIXab1kd+xIJAxMJBpY2gwNrYb8ud0DbTkq+RkZ7qwuhWraKW4FL+zqB0eSnT 4/JNFUul0t7xCv3amZJAtUVdGd96Yy5aJOmI0fx78tdHufnqxnKlvFQZ7WsDbSRH/fg5uqTu8cV 3hdGB+D1vskg= X-Google-Smtp-Source: AGHT+IF8Pqbc0KrpXByjaRVZMvgR0r7bGqi+uUdALYete6gAYw3tv3cg9NGYp0wW7orxCO5/5kksuQ== X-Received: by 2002:a05:6a00:3d43:b0:740:5927:bb8b with SMTP id d2e1a72fcca58-7423b3f75b3mr6043089b3a.0.1746813233145; Fri, 09 May 2025 10:53:53 -0700 (PDT) Received: from [192.168.2.117] (c-67-188-127-15.hsd1.ca.comcast.net. [67.188.127.15]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74237a402d6sm2039371b3a.146.2025.05.09.10.53.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 10:53:52 -0700 (PDT) Message-ID: <77ddbd18-894e-4187-a5b1-66e52deec980@gmail.com> Date: Fri, 9 May 2025 10:53:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: JP Kobryn Subject: Re: [PATCH v5 2/5] cgroup: use separate rstat trees for each subsystem To: Yosry Ahmed Cc: tj@kernel.org, shakeel.butt@linux.dev, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com References: <20250503001222.146355-1-inwardvessel@gmail.com> <20250503001222.146355-3-inwardvessel@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 73mdrkqffjc3q5y5dsu71mqhpmg6hrbk X-Rspamd-Queue-Id: 53C1DC0005 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1746813234-719657 X-HE-Meta: U2FsdGVkX1/oTWdOaet66iUOZxg23MuMXgj5C6RwNZ/jwNeCNHS3qhv1bw6ft/Tb+oTE0PjM1HQ/y5izXp/qlughwNxOaup7DpYZTfbHRv5HNzVR8ltwc2yAQnwXU017Ka664sh9vpcwst+v1uxfjJ8VHAxZd2s5qGxOSy2satxIPWfkB59h010XqUqBf5OyGvpDsEIIRdnD5eb1loO3/QWZG8kY4MT8MfuvXs8slGZp9NiT+jKt10f+clzZl78YjSXrNCFBo88B4X9ymPKe7akvq7JTiv0L0x93ft6wWxCilcvjmFeMJqW2JCEus1uuDRI0Py10m0hPeT/qdc6TivlFKux82WHiOoDPxPtfxQW/ElAVKN9sx89O9CfOgekI3mrvqttGgeyCcvjc/y8Wc0jhqGfHo0hametynMDd8+IqIEZMI9j8iUgHpSEXHykdy9VCt8K4LrJ2BsXV3/2FJNctmpcoXiIEHIOdBsCSFLXIk5SKky+Aa5tS81voKR8CbUvw/7I8vtkPF7+Yl0X3/HVLn72uppMp2AxbzWehtSlG0PHvG6boGu/XhlnfTKDiyKWc94XlhgweCWGmDe3F3lJIy7dUiRCrBQtHtHvdP55KFvLv2GqH2NyAbT8kS88mRr2Jcybje/EIka07cVZRbW0ubKDs+6VsZHkVDwnbRtzcsZFMwJuMPxz8CDWuQVDI2CDkuN85UzK+HLGqV/RoWHgPVJbDNmj/oY+j94GgzqFN20TeIpeDCZRjx/w1ZCbI+0kpXdO63T6wTtATz2W8hEniMCzyXYYm5clDdLrkLrsJmXWxilsqn9cYfzznaAwxd1HUOYJbYGv7TEkYVEStB9q04DZDyJwU5HzqoC4Jm34iQwHHI/2ToN4haB6lM8n/2hCLaBkKuRoSqgYtbR67G3i57gBmTYrWH+m6SqF+9LcBseKwsd+t4ErFLNRT2BHos0LIsH/OnK6/7pj5MN6 3I1LzvV6 7kLgwsC9N4yE1MvXT/yMrfeI9vjKG+bKlrWLSO8yfl481jGAx1C29tVnvGoVQqd3M7br40ahscxwLN4dzb5+t+mhQckuy3TlBMX1URqrUqkBNakV558rdBhmijvpZfao2KzwrHqiaKjlFBtN9WOCOpngzbCX1G6Bi6jouhj8wq4MvseoyafGeus1QH6iGOXvcPYT+DdELO3fq2MSfn8lZc5nxSRwnOXofsBTHkSaZHWlvuMbwaKFDBy7vwdbNFQzD+2dGhSk0QIHnRIcDA30iSIqPrJ1HWuL0LgSBsbxwNEphAMUEXz0mvl4IZnRZlFctr5Q6x8TYic85SfwTSs/SgtP7S0tgLd7LHAYSdfHFpQlxTCqHS/IcoHUXsyX2+/z4iwQyUxJXLYN1h5HiJURxTuWKmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/7/25 2:24 AM, Yosry Ahmed wrote: > On Fri, May 02, 2025 at 05:12:19PM -0700, JP Kobryn wrote: [..] >> @@ -6101,6 +6087,8 @@ static void __init cgroup_init_subsys(struct cgroup_subsys *ss, bool early) >> } else { >> css->id = cgroup_idr_alloc(&ss->css_idr, css, 1, 2, GFP_KERNEL); >> BUG_ON(css->id < 0); >> + >> + BUG_ON(css_rstat_init(css)); > > We call css_rstat_init() here for subsys css's that are not early > initialized, and in cgroup_setup_root() self css's. We can probably move > both calls into cgroup_init() as I mentioned earlier? I think it should stay here for two reasons. The first is because it must precede the call to online_css(). There is a stated assumption that css->css_online() is called (within online_css()) "after cgrp successfully completed all allocations" in the admin-guide. There is an example of this assumption in memcg_cgroup_css_online() in which the work for periodic flushing is enqueued. So if online_css() is called before css_rstat_init() there would be a race between flushing and initializing rstat for the css. The second reason is that calling css_rstat_init() on a subsystem css must also follow the call to init_and_link_css(), or else the css will not have any subsystem association at the point of rstat init. It would result in a subsystem css appearing to be the cgroup::self css since the cgroup_subsys_state::ss field would be NULL. > > Also, I think this version just skips calling css_rstat_init() for early > initialized subsys css's, without adding the patch that you talked about > earlier which protects against early initialized subsystems using rstat. > Right, that was a pre-existing constraint but I'll create that patch and prepend it to this series in the next rev.