From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 859E7C7EE30 for ; Wed, 25 Jun 2025 10:14:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 272DC6B009A; Wed, 25 Jun 2025 06:14:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2246E6B009D; Wed, 25 Jun 2025 06:14:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 112F16B00C2; Wed, 25 Jun 2025 06:14:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 014A96B009A for ; Wed, 25 Jun 2025 06:14:57 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 80C8CBFADA for ; Wed, 25 Jun 2025 10:14:57 +0000 (UTC) X-FDA: 83593514634.24.396FBF9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id F190BA0006 for ; Wed, 25 Jun 2025 10:14:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="L/wtGTNC"; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750846495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XjdslU0hJ7FdAOMc0fmPmVs8CPi2M/vDu4x7gBoGlaw=; b=VWxtTe5o1mGumzq7KKN+hGmd9S1Fmas9fRxQ6l42q2BSdyIcNRJhjivK8m08oNpVYb0fta CFa9d0xBVwipx1uPUWi7mkmA1sn+IepqNFg/EDPilaNOb1Kepow3hpnX8VzoSckvD22V2j a945JmNLHM4QnNLfT/JlcOCMqV5KH/w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750846495; a=rsa-sha256; cv=none; b=lVCm8qA7esgiEsvvYGHKymTeKuWwFD9rqpHfo6wTtPOxWg5kkNzHzA5Pm3xrjOPwgAnFu9 aSzJk6Pw/qnfMu3SoHgJsHWx2hgv3zms6fShy6dj6SX/Cx6Gda0+aGPZFOlc76SP/XBYt0 Dgb3K6ypijm97fgjOldOP/XjyD+kwUU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="L/wtGTNC"; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750846494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XjdslU0hJ7FdAOMc0fmPmVs8CPi2M/vDu4x7gBoGlaw=; b=L/wtGTNCF1/yqGhXCRQJRYiDUb66NXlDfCvEyadVfl04hwwrNR6iM1ilqR1fjV047UGksW lt7z6ut7RPi1O6hkd1RAGZnjOT0PKZO4W7XY2saU8XG+ZuUHZlR38weKEaI5an/16sMNSM bYviktckhVH5JmQZoNLn1nqOb+UtPkQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-LHryr58UONeqeu6thMc7Hw-1; Wed, 25 Jun 2025 06:14:53 -0400 X-MC-Unique: LHryr58UONeqeu6thMc7Hw-1 X-Mimecast-MFC-AGG-ID: LHryr58UONeqeu6thMc7Hw_1750846492 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-451ac1b43c4so7807895e9.0 for ; Wed, 25 Jun 2025 03:14:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750846492; x=1751451292; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XjdslU0hJ7FdAOMc0fmPmVs8CPi2M/vDu4x7gBoGlaw=; b=rVgdh7PPDYNTlpIoM7ULccBqZk/pcAHJzOxRjVejcCTvHXAFPxezjwI7WlP1XVccaO FA5maCU2pl5M3hOnM835y7zYw9aAwupgBCB0cmKFDMEsvtW0TJsE4+0WdypRU/ctHsIB K8aWGvIS0LP1BGC5eX46UExfM5QzyeyER4JLsKZD4FzLOdCbAHSVXKvlQEidi/aNYjim yRgxDIK8mj6Iqun2r6L6EZfKiwbHAxwyE1FYe5nKtA549FGiykWAXQ7Rs74/lXNkmrJV HrhEMxF9QjXwCePdOrbj4JC4PIx6/AuaXCo0uaGparGQj0aWkCd1stTfrNZ4/pxEhK30 SWGA== X-Forwarded-Encrypted: i=1; AJvYcCW6SV1MFA6SRamuBt2SeZdW4ERqGgTDPqyLFYmKypHe1lLkkj8LZUEL2WqMACrKuv2Q4jgN9BCqiQ==@kvack.org X-Gm-Message-State: AOJu0YxRMEcD66gZmwhp5t+hxOGr2xGAr4BMt711PYPtxuWkF+Py4ByX gSgsjus0WYRn0Exg0Oqze1iSDMCsPm/SQJ6WdkHIs7RKng3+p/xYMVZoO2HIFgxtujPY3xg2ag5 zzqx5AG0SmYquZZe9FThzkgHZep1xJdovP+5AUmWQN5qPAhSvZpMI X-Gm-Gg: ASbGncuzN1C6bmdnWvj7RXNDRQsWk4amCZdc/365kvVr0fU5QXeWRerWZqbWfKYhZUt xfNBPLhGRRp0600r4qywnh+V2BeO9gGWRvqREHVcDrqHOx4QU2B+k1TFb9Stg7r079F9AcX/Hcu 0sRIJ4IP1m39ZcJ/gO4vjz/bCt+oL2YZPgRM1mt07DDb1dOmGS4BNh4yCcSUad+knb+OrKmY8d0 A1MSa6P2A0VaTTzul7NWe5kP3oCFCeer7z97LMD77epMZUXMesE/4l1A9jje7j2Y4zEMgYKl+kV lO1dslfiRN5FmsHxyuqotDd0tPMv2/Nc4JrRicEOjhLqace3m6jeeA== X-Received: by 2002:a05:600c:348f:b0:450:d00d:588b with SMTP id 5b1f17b1804b1-45381ac2563mr24960695e9.9.1750846491753; Wed, 25 Jun 2025 03:14:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFH9JVXQGzeiIaOJETPwD0mhFgfVQwPa4nS7QJxUmuEV97nlCNLYTvAiF9sgliseCzUuOgbUg== X-Received: by 2002:a05:600c:348f:b0:450:d00d:588b with SMTP id 5b1f17b1804b1-45381ac2563mr24960365e9.9.1750846491347; Wed, 25 Jun 2025 03:14:51 -0700 (PDT) Received: from [192.168.3.141] (p57a1abde.dip0.t-ipconnect.de. [87.161.171.222]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453835798acsm10471655e9.10.2025.06.25.03.14.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 03:14:50 -0700 (PDT) Message-ID: <77dc3ddb-f748-48bf-8dc4-b8f904611f98@redhat.com> Date: Wed, 25 Jun 2025 12:14:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 10/14] mm/memory: factor out common code from vm_normal_page_*() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-11-david@redhat.com> <1ea2de52-7684-4e27-a8e9-233390f63eeb@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LmOgwa8evG6iGa2xc899WGKuQGY6DLHjygLNjFPycws_1750846492 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F190BA0006 X-Stat-Signature: pospghodwbdyik54urwu4o41a66xpraz X-Rspam-User: X-HE-Tag: 1750846494-877043 X-HE-Meta: U2FsdGVkX1+ynWMKVgzI4DDq75YnUkoVX8R44XQRWt2Pn641vznAAx3W8MhARmceEYjWkvW2rlHdFROQ5aAdwcCoPlbMEZR+elaTkXxeooT1neHIYKfi8In3jNwllStL3PcDwSRIz9afeLt3JFoldzvMdcWwW+we3NJXP6/MlGlx1iRB+p0eoWy3BpfHWOAzAAL9UH4p6Iw0BNQBo9aAvkUw16ZOFyQ5W9538KWb3QgseScftRKqRN/qg0Vn2wS+pvLAWPUpBWKxs1wzs7rtiKr9BYgsvfPdtVvPdHvhD9hLyDGV9gYG9HamweOCH1EtG4z65x2a/cpbgHk1HGjsPbYibmZau0hLQ6GwjNYCg7qMBAShUbZQzqDQ0Yy/7DSiPxS6ky5B9V4aUs1aA7r3UcHZ45CEMWiJ4gCyLwLQQ1DLLRjeBmmnb6oaRUWHFS/iiE2++BBu4p1OO9m6lIc0KaWTqDLyn7YX7boYZ2UbdAqnI5Cv7Ci5xrnaMuNetvQhWQAghuZXoWldU66lbL0I/HGI1kyVP372MlZ7hMqJOjL9CYYS55Lm9ckj5wZ+7nmA19lonGrupoovQ1+7WZHRcu1s4bGOR6KOBiuQ931d92Fh99ShkZb65Sh6PHNBxv7I7e6Y9yyUqF+nfLTg3WeMUesctDsJ0K/1h1lEXy43xWr1qSozL7JSG1T1u7QUu8u3NFgnz48FA0Fjv4i9vY+5fXyqZVGLyiXnXDw/I6VofnogxuMUJM22kLCbOaI4ioLBzqT9Hc8ErTrPVJB9yyuDozhLldhe9P21sYYKZLQnQyrSLt50kxVZ8pSGz8854MZx6wNVgEW0YCDKXnE4XOQvaKMtpMT0DPVapj3j/JngH/2jd+u2pGja+3DSCOoD84HG8fInOtx6HwYd1AXobO+7oy5EjQogqK0h6S4GAdndN92XroGoiEQge2h97ojUYKpEHUs9ACL4PJ1yI9VOuKe Z59BAUuY vcUTJqBrrShWav1URsIRJGO66DPzXqz4kBnpJQn2lHlhb/ezYMdKRsow3Nte4gwOtQrv+47iKzXDHwfYAuVXwZMJ6ARczN6sQxZ2OrHB0wAId5o9Ez1t+ZST9J6mlSyQw5CV25KyGhDQrqRJAEQBu/BChhoIAV1Q8IdGFQ4UL6XA3v1ap9ge2LBtQGRwarpbcXsQpa8XSSgfpeX0CTZDv4GZy1tk2RlpWfK02bBsJlawmKffFhG5eSOgoOR554s1E/Qds4WQXP8YXtG7FCsArk0qdaavDjXIQRA34Pb7I8055e045lE9bSc6lHmwBYg4KMCBsZsyae/JllzXlYaMKxC57tTZswH1wHPF0e6ql1p/CQef5wk5fiWFpb2rxgoPRiRr1/YoTme9+rjaPsniEEPXkGJiup/R7bKtyN+W8uOKa49Z9RkpuZq4zNpBbRAQyxxTXp0OyQRi1IwUigKT34E2FJvqrrCDc7XBAgOmkFJ/pnpLxx9Cd5kAHmQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.06.25 11:20, Oscar Salvador wrote: > On Wed, Jun 25, 2025 at 10:57:39AM +0200, David Hildenbrand wrote: >> I don't think that comment is required anymore -- we do exactly what >> vm_normal_page() does + documents, >> >> What the current users are is not particularly important anymore. >> >> Or why do you think it would still be important? > > Maybe the current users are not important, but at least a comment directing > to vm_normal_page like "See comment in vm_normal_page". > Here, and in vm_normal_page_pud(). > > Just someone has it clear why we're only checking for X and Y when we find a > pte/pmd/pud special. > > But not really a strong opinion here, just I think that it might be helpful. I was already debating with myself whether to add full kerneldoc for these functions ... but yeah, to me the link to "vm_normal_page()" is obvious, but we can just spell it out "see vm_normal_page()". -- Cheers, David / dhildenb