From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D942BE77188 for ; Fri, 3 Jan 2025 03:54:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A9166B0083; Thu, 2 Jan 2025 22:54:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 431FA6B0085; Thu, 2 Jan 2025 22:54:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2ADE96B0088; Thu, 2 Jan 2025 22:54:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0AAAA6B0083 for ; Thu, 2 Jan 2025 22:54:15 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 891B180159 for ; Fri, 3 Jan 2025 03:54:14 +0000 (UTC) X-FDA: 82964770266.03.6A9AE6C Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf19.hostedemail.com (Postfix) with ESMTP id 8E31D1A0003 for ; Fri, 3 Jan 2025 03:53:19 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=RWR4la2h; spf=pass (imf19.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735876413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ExtURrdtg4wvz/5S73kPKLfYL+g+cN7JWlBZcDSiUw0=; b=O3urTdZnGhKp0SJUS9zocUgxSXvlaF94ggQgQeXs0ibL6D2r2YsLsZ71bNA2/Yd1Rs460e 4frcsa1GlBD4LwlMbtN3ZdYcfAhsqC2gA005Wn3ZuIzCZu9GYYv3nxjKwVnPL4lP4SEw+S z5aWkBGcWZm5Gv4dvkpdBtYjNqYVTw8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=RWR4la2h; spf=pass (imf19.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735876413; a=rsa-sha256; cv=none; b=o8QYiCEJyaBlQmsO8lSTsyvptr53J5hsPICh3xkdfV/Yd+fcGuWXrWGFuwADRuTsimhskk +QNBqO4OtopjbgM4jH+G5hJjNDL8VL9tNTe45lHigcLTyMiF15HNfqAk8QYLvZzeu9G45/ lCewtSvqLquysZZ4KP8nFI6oRJuFjnM= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-21636268e43so79105825ad.2 for ; Thu, 02 Jan 2025 19:54:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1735876451; x=1736481251; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ExtURrdtg4wvz/5S73kPKLfYL+g+cN7JWlBZcDSiUw0=; b=RWR4la2hV63ZTss7Y6jR43MfMU81OtLUxhJSw5aLGG88nYrU/pikXx5QMSW2PLLNKF MUTW0Zt5IhnqOjsXthww3A3FvBeus09vnXSwDmnZDYApG5oL/PicPyH5SfW5U1JJfsZF os0PH8aWGHSy4RDclxaM/rY9pviiSjSFjmP98RX/KUyj1uY6a+MfjtzCDGtXp1xy+nXm ejyuiePtfsPgWnXpWbqNiRjXsjmZqzAS9c/UQtrQlbg/nqbUg0rFttYCjOAwNoZJrnoi 7NejaKM5OPtoKl2OrmjiKIrymlNYH1Ec815jx26/7FW1ElVYOzOOlXKQVe7sc7vNftxY e+2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735876451; x=1736481251; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ExtURrdtg4wvz/5S73kPKLfYL+g+cN7JWlBZcDSiUw0=; b=KxxsAD06iK24oRpe3W0wv/gk0S5uYHb6TASRBuol8SmlSxIt3PngroToIjz0FSFuBU rRI17kovWxSxCCy2AnSjP1qdTAR/1XY3eg8doRUuJ5xflAoM0vyxjMpabqceR7BjnzIv ra5qnAMlxHciYknBn40N9CeRFfOPeJrBt47e0PkkYD0l/8TCbbq3oPiJySEUOc6jdisW kb4BshdepXEwvwhUcslf1RR7bX1s11nhai4uleiT74iJ5/JrdMAvI/gNvo142nwEePKS JvrYB+eZ+ceUIm1/tUUYnLjMIz5uaorP2EkPCli8hia676ynI60y0XJOvufHLrlEnzv6 NPtA== X-Forwarded-Encrypted: i=1; AJvYcCXt35kE7H5Kq3GDrkxCTe60eU2AGSIewa0scA1vEBNthzVmg6Sj8Q7nG5uza23Jz2BJBgqn757z0g==@kvack.org X-Gm-Message-State: AOJu0YzQRcjlMIhRAQNnzD3v86PulmOjlEcSrIMuz/mOF01xxxYKp+Ae 9Li6W6klUzDW27AZ0ghogbomJf2+U7jSEC/eo8AOKaLqnK2LoPesLTNxf+QXp+k= X-Gm-Gg: ASbGncvtJL4bnswvN94iCFGjhlH/zejlxUHSmGzIMd/wOb/mZ2q8uq4pKo9a3uciU2O 6JhacOToKiMiq2kkq4EcL08V65w8BUZF8H5oRcduVcxrTVd1nT9yf31MUMFRJqDH+NCkvEy5ebn rNmtKzmNmctBYZ/uNO81EDAa2g8hc/XxbpjPojBMGMfjAeSkPY16X5BemppofnoXuB+KbeJbLpI yksemJJC0e3OIMjjIGbczJ5Bhk62lW1KcrqfdUU0gJG6C321Ykg/XdTk27wQ3x2TxNDwgmLfHip 0uT9OQ== X-Google-Smtp-Source: AGHT+IGRLBberTsNPcVz5fDDiJ496OTTAGvxwwTdPWwuUiji7gMKzctc+wxIQ/Y0LkCE8MhlfHWUlw== X-Received: by 2002:a05:6a21:6d86:b0:1e0:ae58:2945 with SMTP id adf61e73a8af0-1e5e081179bmr90059001637.31.1735876450877; Thu, 02 Jan 2025 19:54:10 -0800 (PST) Received: from [10.84.148.23] ([203.208.167.148]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8fba98sm25284573b3a.161.2025.01.02.19.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 19:54:10 -0800 (PST) Message-ID: <77c202bf-e0a3-45e7-bf8d-eef7903e3c64@bytedance.com> Date: Fri, 3 Jan 2025 11:53:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 04/15] mm: pgtable: add statistics for P4D level page table Content-Language: en-US To: Kevin Brodsky Cc: peterz@infradead.org, agordeev@linux.ibm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: <2fa644e37ab917292f5c342e40fa805aa91afbbd.1735549103.git.zhengqi.arch@bytedance.com> <237a3bf6-c24f-4feb-8d3d-bb3beb2fd18e@arm.com> From: Qi Zheng In-Reply-To: <237a3bf6-c24f-4feb-8d3d-bb3beb2fd18e@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8E31D1A0003 X-Rspamd-Server: rspam12 X-Stat-Signature: ykp3hqs4j9ij1oyc7q5x3zbu48purua3 X-Rspam-User: X-HE-Tag: 1735876399-957870 X-HE-Meta: U2FsdGVkX1/v5Oqs0k3cF0IqlwnYkIWg2CcRsSXcnUVBiA476J5g2A9IOjNZZ0uqYZMT9caNNXWNqXLxicCpztJ7d4aoIW96xS8z5wjkTI6hLPGXvaSdmWX8kx72AkEnn6hfZRa043cS+t5XH58C9fzEDTHz+LucLSJHUS92cnfn2eojbquB+ap+IFmUvR4cfthe0ZgSkdeD8rHkUAa2bxpuX5GiGfLcy18L3YR6J+S2yn/gTwTeTm/wVVesfenR72TCZR7OZIj0+VAmsInARbyqUgAib8NA/tUrvelSOkfkjHULZ3W47zbdEAVV9aIjzHfQK9oVIeCDU+KLGsMpZ+hUSGq0HgGpauaaJUHnOmDrjqKjMukPcszj1KRImViFXAPScM1xTV2SgrERWJmgus/MRMyOP9J9RFCJ+zY7H8bUPEWc8dx09Zy7pkYmKg1fvSQaJfDyX2e0onD8LtTSI5JMBhBEz1PvfwWqirawKZxBjqK6AKDqwrgpe/53maVLJNCQMX8fV/IIXdLxnCWHabPBgm6CX+bpFyACr5I2+QTs/m6FYN40kBtMhWn/JfFvkkWl9hcBkNcCXQySzW18tZDsIg6nSi66e6S5dfhNdfIHwPpbJClYAEl0gWWQA4YMkb5TXCFgsKyV0hCKnyiVj4Pwkf4UvbGy9ZK54vf0iGt31K08RxFwHZ9DYkTalq+pd2cIjuAmhSHiSmdU8+lkVtPDh6P3ocoA8czGWBw19+WsrJ9bhmGRuoraKw5QXCpgXimOM03vv6+7N8HRF4t3wiA6Mvts2aTn1VHi18wYoSABDGxjQwXZ327LUoaX/nQKFBdaT6WAaZ1g/PkNUTPCnC9Fu9ltP69a3gyIyybKKOcSlV0ynZ2voXfIebflD5DVFEWYyyCtdMbagHhGjgtd9fmCR/k9ceiVGhcYbM9c4Mu7NqSQ7Eb1qCGY4w8dJjKbhI1kdirvobZJH2ZzETq xBEe1hWi r+TAkFTHIIzdIm37UVdb1R5+UjCOdHE4RqEp/PHpKogx20IEkb6MEo+AQI4MHyB74PM8EVG9qgm6gvZzt4I/Mv/5dvHCGNV1okTNEutExE+PEWzX2g5+ip8mNdJ4pJnnM5q8PMnIaHjT/B2jAR2oJQ2k3um5v8hE/uMLDKsdRCPakgub7N6DwKK5ilEEewrZTyFWp78cXnhKubjQ8hiSkm4u19rzYJZ9vXVytf56lTSVR7K3hoWuuSJDNx9aa108srZwxoZw/6G86FwlIZIl+Sphx++dtHrSAhQ628LURwle5JUc799d1+dQUpmM+7mU7BLY7uz91LcDbRxKEayuxZEfzd9A60s2TvpSxNC71VzL4YEhrl9eyIii0j/xFYNHKAP+uaUa+mgDf0bDA2gWINdNx1g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/3 00:53, Kevin Brodsky wrote: > On 30/12/2024 10:07, Qi Zheng wrote: >> diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h >> index 551d614d3369c..3466fbe2e508d 100644 >> --- a/arch/riscv/include/asm/pgalloc.h >> +++ b/arch/riscv/include/asm/pgalloc.h >> @@ -108,8 +108,12 @@ static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud, >> static inline void __p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d, >> unsigned long addr) >> { >> - if (pgtable_l5_enabled) >> + if (pgtable_l5_enabled) { >> + struct ptdesc *ptdesc = virt_to_ptdesc(p4d); >> + >> + pagetable_p4d_dtor(ptdesc); >> riscv_tlb_remove_ptdesc(tlb, virt_to_ptdesc(p4d)); > > Nit: could use the new ptdesc variable here instead of calling > virt_to_ptdesc(). Right, but we will remove pagetable_p4d_dtor() in patch #10, so this may not matter. Thanks! > > - Kevin