From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC2F8C6FA82 for ; Fri, 9 Sep 2022 11:28:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 699BD8D0003; Fri, 9 Sep 2022 07:28:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64A128D0002; Fri, 9 Sep 2022 07:28:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EB438D0003; Fri, 9 Sep 2022 07:28:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 41FF08D0002 for ; Fri, 9 Sep 2022 07:28:45 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 184A11613E6 for ; Fri, 9 Sep 2022 11:28:45 +0000 (UTC) X-FDA: 79892324610.28.7B993F6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id A13C818007A for ; Fri, 9 Sep 2022 11:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662722924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zADjijewHqE/ifMUiS21SSfRedrzbyoD3zQRtee5o1s=; b=aySK+C/CSgOySxetymwlRu/ir9zIj/2RJoORs5rMhyz17r4jLnpENDt/DF2vsdLQETTfUP V7yNgiKKrkbZSj/GPnLEf0J+tkSqlM3i/V5dyfNnVqyYPdqWjCOHzT/rtz3VLXs3KsKGvp BCuhOSEQaw8Vf0OjMtSw0yeib9biiWk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-185-pPjyv2geMRy2i7qmx6GWgg-1; Fri, 09 Sep 2022 07:28:43 -0400 X-MC-Unique: pPjyv2geMRy2i7qmx6GWgg-1 Received: by mail-wm1-f71.google.com with SMTP id f18-20020a05600c4e9200b003a5f81299caso715543wmq.7 for ; Fri, 09 Sep 2022 04:28:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=zADjijewHqE/ifMUiS21SSfRedrzbyoD3zQRtee5o1s=; b=gvlBVlLL6SOE565H2pezoaPRvmY0xMCQMmFXpxbV2QDQP0yjGtxXrycz6/W652aEsK xhcpRMT1WzvqPL7hpiW7CJlMDkc+DF4OdGwCqSpJv5oDtAEwc4U8Ihx1Y5/wg3j2NmqC oNVUDXf1ju45QClwf7ZyjRPcTS48LnPWhHCz/805Banyze+U9JS0dvfSJJUBJ5N37hjq k6+RkYttd5vIy0kGQ2QUJ0gSV6O8e+JhE+vEc7RoaUE4MVX1A1pV2zdozbMD8oXHz75I pPLnU+Lk1CrhoZ5pb6jEH/F5+OUv2/bJpi2zz7u/IAf5NuOSg+qdU/0lMPwkOyFjSWpw dgFg== X-Gm-Message-State: ACgBeo0kf1DCQMPCbAT+7f95zwdRNQuZcbz8zwR9wkmlPIQPHAfFiroR kCEfCGXsg3w905LVscDdj/Y3F3H5LdcpZ78KX+OsvLQvHtQluoABmxNgInyYNyE75m/UK2RBeWg LGYt1nC6PrLI= X-Received: by 2002:adf:fb52:0:b0:225:2ada:b741 with SMTP id c18-20020adffb52000000b002252adab741mr7921756wrs.56.1662722922182; Fri, 09 Sep 2022 04:28:42 -0700 (PDT) X-Google-Smtp-Source: AA6agR6EXjNEJoF9ivl3Lb7bmTMXb8vStG/mECAtj/fEXGvK9a7Rd6A9BshsJOiCYcMrA9NoxQZ5Og== X-Received: by 2002:adf:fb52:0:b0:225:2ada:b741 with SMTP id c18-20020adffb52000000b002252adab741mr7921748wrs.56.1662722921959; Fri, 09 Sep 2022 04:28:41 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:6300:1fe0:42e1:62c5:91b6? (p200300cbc70463001fe042e162c591b6.dip0.t-ipconnect.de. [2003:cb:c704:6300:1fe0:42e1:62c5:91b6]) by smtp.gmail.com with ESMTPSA id h17-20020a05600c2cb100b003a5ca627333sm467212wmc.8.2022.09.09.04.28.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 04:28:41 -0700 (PDT) Message-ID: <77c1ccc6-9125-ea91-45d8-7e087b38e196@redhat.com> Date: Fri, 9 Sep 2022 13:28:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 06/16] mm/page_alloc: fix freeing static percpu memory To: Miaohe Lin , akpm@linux-foundation.org Cc: osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-7-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220909092451.24883-7-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662722924; a=rsa-sha256; cv=none; b=TqNEZ4WkYKniEUvOTLW9TOXYH41cDt2ebgM2meNIlgwzArmIfXKUSswj/Ya9+uQskYEivP 78OMV/dlZa4KXSyb4gtUhTqjIfIccWRFbFYOhYTDS7Qh0yj1uGoNz1x3gtVxa/ugfLF0SN 39La+WhkK4SeY87KYPcTF4XFCesWeTc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="aySK+C/C"; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662722924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zADjijewHqE/ifMUiS21SSfRedrzbyoD3zQRtee5o1s=; b=ehmQXgFqv38BiHud8UXSJeW2Mtp4lE2Q260BssjUrAsz/GHi9HMbLzcDFYhIKBNuoWXg0Z MfPoMlzzKowuyP6Nf0mpwc8HuI5r5FRTTlPzxgTz5j8/sGb/b48/MfmuuQjVYfcXnUku48 dwV8osPr4Pq3yi46GfT/PI/TXXs4hHU= X-Stat-Signature: 5k8zwft1pean6fbypk91ygwnnhmd59hr X-Rspamd-Queue-Id: A13C818007A X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="aySK+C/C"; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1662722924-165657 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.09.22 11:24, Miaohe Lin wrote: > The size of struct per_cpu_zonestat can be 0 on !SMP && !NUMA. In that > case, zone->per_cpu_zonestats will always equal to boot_zonestats. But > in zone_pcp_reset(), zone->per_cpu_zonestats is freed via free_percpu() > directly without checking against boot_zonestats first. boot_zonestats > will be released by free_percpu() unexpectedly. > > Fixes: 28f836b6777b ("mm/page_alloc: split per cpu page lists and zone stats") > Signed-off-by: Miaohe Lin > --- > mm/page_alloc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3497919f4ef5..a35ef385d906 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -9510,9 +9510,11 @@ void zone_pcp_reset(struct zone *zone) > drain_zonestat(zone, pzstats); > } > free_percpu(zone->per_cpu_pageset); > - free_percpu(zone->per_cpu_zonestats); > zone->per_cpu_pageset = &boot_pageset; > - zone->per_cpu_zonestats = &boot_zonestats; > + if (zone->per_cpu_zonestats != &boot_zonestats) { > + free_percpu(zone->per_cpu_zonestats); > + zone->per_cpu_zonestats = &boot_zonestats; > + } > } > } > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb