From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A732C433EF for ; Wed, 1 Jun 2022 09:30:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 907106B00A2; Wed, 1 Jun 2022 05:29:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88E9A6B00A3; Wed, 1 Jun 2022 05:29:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 706056B00A4; Wed, 1 Jun 2022 05:29:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5D8B16B00A2 for ; Wed, 1 Jun 2022 05:29:59 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2704C205B6 for ; Wed, 1 Jun 2022 09:29:59 +0000 (UTC) X-FDA: 79529145318.24.0E15B21 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id A95431C0049 for ; Wed, 1 Jun 2022 09:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654075798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xgyHZKDlB7p0BuLqs9M8WohBIMnlgdhuu+3hRlyeW88=; b=AiDy20If9cS9YXS6vLszxDL8mnL3zw7v2h2i4qPsAi2nMXbVDWtZWr9SaRK194n/74fDkg MKNiFkFiVrr7awfsM/EcmBxvBXbrfHQNCqmKFvrU7s33/uDk/Tdwn37e1LzzS1EOvhrSTr 10Ts8ZJltdJ2XLkt+Ie9785i97MvB6Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-599-3innOiiCOICS7hqL0PGveA-1; Wed, 01 Jun 2022 05:29:57 -0400 X-MC-Unique: 3innOiiCOICS7hqL0PGveA-1 Received: by mail-wm1-f70.google.com with SMTP id o3-20020a05600c4fc300b003946a9764baso3068088wmq.1 for ; Wed, 01 Jun 2022 02:29:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=xgyHZKDlB7p0BuLqs9M8WohBIMnlgdhuu+3hRlyeW88=; b=nuq8u4eQgUI4DhIhQBz8ZNijTB98PlKTIYb/8ZCmjPLFAxTuZZjqOizTe4B5GF/2Z2 RoJuMiGbchuEoOf4NIR2Ncen97wvDycvz1VwjQwF9iTF6u0I9S8ylFF9fvUxII2e4JSK TnDFOCe9Wk/A7hQcRE9zSOIlnorHVph+Z+nHGz+5J5z9ltnM9zuQlc00E9Ql1qvR17dI lYxH2iETI859cQB76lNwBnhNkG508uFLQZCBCzasF6zZpkixfa6x16QcazcX59oW3AM2 aOHWwlX/JimjDgIjE9kGpRFf6C4Qncjz+2rbCdvwTJvDvJHUEPMydmNag3EfE1bE1JAs HSKQ== X-Gm-Message-State: AOAM531UDnOiFIPMRcWAA8TjKEsM6yTffYPzcdMuy8ViDu4h+nAq0M+i H/BWS3tFkY0q6FKC/Um0mCcddnc0xKUkPZ6Jbms9nkv1mQ4U3h5XC0LjZwSA3GA9lbCdFQ7+62/ 9GrvPInvMkWU= X-Received: by 2002:a5d:5686:0:b0:20e:63e7:8769 with SMTP id f6-20020a5d5686000000b0020e63e78769mr51278097wrv.419.1654075795909; Wed, 01 Jun 2022 02:29:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcIqqZdHxN0sh9iYav8gIoBSPR/rcvqW5Zg8PD/o3XgcU5QpPwH6r/7z/TzcYhFY+iy06BqQ== X-Received: by 2002:a5d:5686:0:b0:20e:63e7:8769 with SMTP id f6-20020a5d5686000000b0020e63e78769mr51278080wrv.419.1654075795718; Wed, 01 Jun 2022 02:29:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:2600:951d:63df:c091:3b45? (p200300cbc7052600951d63dfc0913b45.dip0.t-ipconnect.de. [2003:cb:c705:2600:951d:63df:c091:3b45]) by smtp.gmail.com with ESMTPSA id y18-20020a05600c365200b003942a244f54sm5510819wmq.45.2022.06.01.02.29.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 02:29:55 -0700 (PDT) Message-ID: <77ae3b7d-a7d7-2484-cac1-d352d873ed1c@redhat.com> Date: Wed, 1 Jun 2022 11:29:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/3] mm: hugetlb_vmemmap: cleanup hugetlb_free_vmemmap_enabled* To: Muchun Song , mike.kravetz@oracle.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, smuchun@bytedance.com References: <20220404074652.68024-1-songmuchun@bytedance.com> <20220404074652.68024-3-songmuchun@bytedance.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220404074652.68024-3-songmuchun@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A95431C0049 X-Stat-Signature: craz97z5b99rnnch178epffqs7cu15kp Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AiDy20If; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf18.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1654075778-326571 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.04.22 09:46, Muchun Song wrote: > The word of "free" is not expressive enough to express the feature of optimizing > vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze". > In this patch , cheanup the static key and hugetlb_free_vmemmap_enabled() to make > code more expressive. > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb