From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E818C433EF for ; Tue, 8 Mar 2022 13:55:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81FEC8D0011; Tue, 8 Mar 2022 08:55:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CEC98D0009; Tue, 8 Mar 2022 08:55:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 696D48D0011; Tue, 8 Mar 2022 08:55:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 57C9E8D0009 for ; Tue, 8 Mar 2022 08:55:45 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 321A3209CF for ; Tue, 8 Mar 2022 13:55:45 +0000 (UTC) X-FDA: 79221367050.10.8ACE306 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 7CDE040009 for ; Tue, 8 Mar 2022 13:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646747744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1IBDuOS2fA0Ut8e4IiZznBpFVrC7yMpgLFek2NZWFfs=; b=L5GW2oAsF8X1Sjj/FvCtjWBzWApFQPuZWH4WQJNi6btP6m1USxQfEQnaAJmjuhWsFz8B7L fqwiVt+o1mwy0ymiXB8hCxZrG5CaAMpgsPX+G8EJq53LDVG0thVElMB7B6Xx8CYYtTUvcB U/Xlwrw8wz79SoDu/MBXGLRjD82uCDA= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-489-GS1Ipm3DOfKqWzplXD0JUQ-1; Tue, 08 Mar 2022 08:55:42 -0500 X-MC-Unique: GS1Ipm3DOfKqWzplXD0JUQ-1 Received: by mail-ed1-f71.google.com with SMTP id b24-20020a50e798000000b0041631767675so4750404edn.23 for ; Tue, 08 Mar 2022 05:55:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1IBDuOS2fA0Ut8e4IiZznBpFVrC7yMpgLFek2NZWFfs=; b=50+8Tf8mH0ZwpmJBmW7z2R7ZO6XiZW/Q+wYdZAsETXpuJqsEboty22hwA0/EzLbQdR AEpQouPCkUC/L2m1CxmkZugo00j5KJ8LwTdPwcVNgsU2tm4KXE59zEW5t6LuLt6oqw7B o+5LWS66O1Q7plN+fkW0Qr1d4/Csb2EUsra8W8AoVD2+OxlhXy1uvKGcQw0rLlKLB7rd 2ngQx+jkBxpVaBbBIgf4nT1OAY17ODN29m/3/VdmvrB56epGrXFOxi94Mx7AvdvdoZWh rkbwAuldMB2Kca9r7Hi5qxJQ29bFKs2YtDt2HQibJ7ZjYGiqMmND3yy68X248Y26EQNj r33A== X-Gm-Message-State: AOAM533qQa5poib50uNaIzVmEkuMDL+D/EZkzHAYromJfAA3lpAC7YZ+ svBSeyHvGoB48dZ6Rn+LlSvJpPBh9BXiQ5VovnEss/n8KhivM3OzCJnTk7FcgG4oRYV4aS2VHbd 0H4DcUzyOS6k= X-Received: by 2002:a17:907:72c5:b0:6da:e99e:226c with SMTP id du5-20020a17090772c500b006dae99e226cmr13706570ejc.515.1646747741396; Tue, 08 Mar 2022 05:55:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJz6WmZv3/KHM1kx7+bdzcMlRqoo8+XkXcFt2ZUztmnvExDivbuO3SMLPcZhEKvKFLdILNTj/A== X-Received: by 2002:a17:907:72c5:b0:6da:e99e:226c with SMTP id du5-20020a17090772c500b006dae99e226cmr13706551ejc.515.1646747741189; Tue, 08 Mar 2022 05:55:41 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id n9-20020a05640205c900b00415fbbdabbbsm6684307edx.9.2022.03.08.05.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 05:55:40 -0800 (PST) Message-ID: <77a34051-2672-88cf-99dd-60f5acfb905e@redhat.com> Date: Tue, 8 Mar 2022 14:55:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/3] mm: vmalloc: introduce array allocation functions To: Michal Hocko Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Michael Ellerman , Andrew Morton , Dennis Zhou , Tejun Heo , Christoph Lameter , Johannes Weiner , Vladimir Davydov , linux-mm@kvack.org, cgroups@vger.kernel.org, stable@vger.kernel.org References: <20220308105918.615575-1-pbonzini@redhat.com> <20220308105918.615575-2-pbonzini@redhat.com> From: Paolo Bonzini In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: s5qfu3w54kfq3kjmqxii5cdz576dwupq Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L5GW2oAs; spf=none (imf27.hostedemail.com: domain of pbonzini@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Queue-Id: 7CDE040009 X-HE-Tag: 1646747744-395352 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/8/22 14:47, Michal Hocko wrote: > Seems useful > Acked-by: Michal Hocko > > Is there any reason you haven't used __alloc_size(1, 2) annotation? It's enough to have them in the header: >> +extern void *__vmalloc_array(size_t n, size_t size, gfp_t flags) __alloc_size(1, 2); >> +extern void *vmalloc_array(size_t n, size_t size) __alloc_size(1, 2); >> +extern void *__vcalloc(size_t n, size_t size, gfp_t flags) __alloc_size(1, 2); >> +extern void *vcalloc(size_t n, size_t size) __alloc_size(1, 2); Thanks for the quick review! Paolo