From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 966A7C25B74 for ; Fri, 24 May 2024 06:21:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02C3C6B0085; Fri, 24 May 2024 02:21:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1DAB6B0088; Fri, 24 May 2024 02:21:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBDDF6B0089; Fri, 24 May 2024 02:21:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BD0776B0085 for ; Fri, 24 May 2024 02:21:13 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6B20F120962 for ; Fri, 24 May 2024 06:21:13 +0000 (UTC) X-FDA: 82152292026.07.671C536 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 253E9A0008 for ; Fri, 24 May 2024 06:21:10 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ezrFfZJb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716531671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lCyAQmYMge2L+lNPKoVDjc9PNeWU5cJtJ6pBdtPLLeQ=; b=v3PdPBaYWk3o7iP1XVButGyyX3KPoBF23BmUu45CZvh7rNbgRh4g3rbIy7yCVHgLFlOW4I sAkRUeKnhMmGKH+67UURpE8BQCN1Tl0tNDvnnIDNnueb9J7SGeQ8UB6GmFrjRMq/A4/hRD KcN7ms/hx++Ts+Y2BzVZTm1XjGx+HMY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ezrFfZJb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716531671; a=rsa-sha256; cv=none; b=OsXV4zmeWNwiwYCbmf3IS+n90lqPqohYpLe4Xntn9Gn3mAz78skhMajCehDXz9lbTqQ5i0 rflECemWYaJQ6tXoQydZ2d3AlA/kklLE/8wm+058TOPFXmGRV5EtAYhUwB5xr6qThstIyA BdMKqhWg7aaG03x74aHEknQYUzN9WbU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716531670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lCyAQmYMge2L+lNPKoVDjc9PNeWU5cJtJ6pBdtPLLeQ=; b=ezrFfZJbq3NUGxxfb/44fHPIExYLlnpyMcQWE7xENMrAfOwRpHW/6O4Op097kDiCxlC6fd cB1Q0+OiXFuMHFJtZlYmeQKsbrf2QH/hhKNGl9Gb8VS7GYBagP85og4MxlJF7Z7v2wCHYU lej5rhOFBJhu8qc7a8bEM4lPUMEIB/8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-355-i3tB1n1_NDabbNGyaZqIpA-1; Fri, 24 May 2024 02:21:08 -0400 X-MC-Unique: i3tB1n1_NDabbNGyaZqIpA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-420122cf3eeso72434375e9.0 for ; Thu, 23 May 2024 23:21:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716531667; x=1717136467; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lCyAQmYMge2L+lNPKoVDjc9PNeWU5cJtJ6pBdtPLLeQ=; b=XU9m8c8kPSv2ChqIgTIFvP4NKEoDHoBkm/9W9uBt+v5tu0JJ4A+UDTupSL5oJz1xKF aXp4o33qPbhEQi7uFe6Iw+/4OaayB6Ym11e3uVGVZS24KZ9nMc5whXqWxphDoehA4T0E SlwGbewSajAishKgJm5q5Z5ARHZBz1rhmTfM/zb2xVLgUJhym99YMss1mP1OZqa9HZ7X mxHVnMSn6rzcP7lKzUFPvhm4Kq+Xg3BuhFtNGkZgriuYP/C+tCpdKv3FJorT/08s0oae m04VfGh/jko/sBqCTJDS9yRrplCHQ1gM6dUjJmf8JQosvaZEO6DFMSXMSzksu6PzFsiw dgHw== X-Forwarded-Encrypted: i=1; AJvYcCUqeV/Gq8KOqSoWxLovUPfsf1SIqjmh8U4BagbX959b7yFSAuVmCRMOzF5B9IQT5ENYCNklGRO1pQupK6dxhiobkEw= X-Gm-Message-State: AOJu0Yz+YZ5vmO0D/Ke+g53954yNeAsmjNBiPrNpiVShXBKzn5bxOmUe 8lQbxBOzS9vhmXwYsjEf045+av02Nm2t8Cx8j8xfykH9rZym7GdRIiIK97KlM6ivZZPNNhdBlKt 7h/Pjx3id7Gbqm0+IrJ0VIUH2B2qfMU/UMXg6J2qUuCFCErhw X-Received: by 2002:a05:600c:5354:b0:41a:7065:430a with SMTP id 5b1f17b1804b1-42108a35a18mr8563405e9.41.1716531667303; Thu, 23 May 2024 23:21:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgIbb4OINbM6dRMJB/iGvr+n+Toqlklv1Vox6SynHazskaNZL2GibikSwEJFjZYpozN3vfBQ== X-Received: by 2002:a05:600c:5354:b0:41a:7065:430a with SMTP id 5b1f17b1804b1-42108a35a18mr8563265e9.41.1716531666778; Thu, 23 May 2024 23:21:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c724:bc00:e919:27a8:d431:782a? (p200300cbc724bc00e91927a8d431782a.dip0.t-ipconnect.de. [2003:cb:c724:bc00:e919:27a8:d431:782a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4210145cbb5sm43242005e9.30.2024.05.23.23.21.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 May 2024 23:21:06 -0700 (PDT) Message-ID: <7792c8ba-39e6-47ee-9b43-108270325c15@redhat.com> Date: Fri, 24 May 2024 08:21:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftest: mm: Test if hugepage does not get leaked during __bio_release_pages() To: Andrew Morton Cc: Donet Tom , Shuah Khan , Matthew Wilcox , Tony Battersby , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Ritesh Harjani , Mike Rapoport , Muchun Song , stable@vger.kernel.org References: <20240523063905.3173-1-donettom@linux.ibm.com> <20240523121344.6a67a109e0af2ba70973b34b@linux-foundation.org> <20240523195734.bc03a8822a34b1a97880fb65@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240523195734.bc03a8822a34b1a97880fb65@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 253E9A0008 X-Stat-Signature: s3bwukhq35r77ydwkkiube8js4919sok X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1716531670-225832 X-HE-Meta: U2FsdGVkX18I0lv/7xnBBtcOVM3XaIcJPU2aIyCQwrNnfdd2nKgQMCNMBkCULe/BPwtEov5LJPYlHzD/adnExJRpaDafhsGTmYBcMIIcT6VEQQpZCWXu5gf0qZgGu7IuiinF/bYhCRIAH5dotrsDgBemXFz2S66jb2P1gH3vfveG9Z0vvbDE9N1XZS/YUgIcx+vj9UDiWDHLGZQVi/l9SxoLUjY4soZPpkZZkrVCQApWTVEgscwAa1FJZgxZisMW7B8Cb4wtf0PP7fdRPH6n/pS2N4Kps7KAvrFew5ip4awPfGEwp39s6R+b8T5HoUe1sc4HgMsnUvFHPX5/WMmuIbAs6SxcFtwP4s8ZcQ5xOy0qbTCgPsejcS3nlmA5ws77woNq2970J6u0tFjvU2pZRToUVEU1hARoKQHwcp+GnM6CdeqN9W7dgIbUR3hpv24s8g5M83g6vijiC0zHqdaJ5ItehAlIeABlv/4WpEyZ83Zx1njU2RQnrxqKh4zwFQF+2Fa7MXsrEJe2d1TprzXEgm7URTzLHRP1o8AuQruclB1aP9bhWM56L1Vy1ZbYWwOHHyL6jjOc+1REYDXUtDt8cgi8q3TZulxr7CsN5dLqr3DmoRTV59IXCePX7JU1MQVIyscYvzDRrpFeJ/9u6fmbsa3BwaDTEgpI/v+oAbrdShACIMkIjKozYUtTzz03MzWVNAXowLibjX8HDXN9EfTasRZ6OiX4ECwWu8iDJR/+Fexc5FHuZn5gNMA2kqRFFEynniEaFw/4cHxwuzZ1KLKwKBrVXX30HvapyhUBXaY4q22UmAWTtSZmGs7/0x/A6OQh8VF+xCYAk4cTpkw9hsExlSabCh/uwjEBeLwwxnPp6WeUn/MdoNoY6FHkpQKxIpFJFwZx367tTKcY/tk3RqShs2EWxLiiGGcDJoAC26UsXVamVQY1IFoAIV2H+L1ocddk4ZZm/jMjHW5krery05D jQyN7yEh 4x6mClPEfXoiTAiAdHr7NPLZDsUYawHuLXL4ZbN+2ulookyW3mGgb+CWZBHa9r7pAeMPlc60n/0RmLQD0l2NUP4MzfBN6/YjO5RA64wHQeRhyQ6Ax5KvhFzC97dH/+AkcgmUus1tJ2Z/Qm2msqXTdpjzowj+J0Spm2AE7ei26f8CHVvdn+X9DZFrMzvjtfiNHXXajkQRCkkWOBzwvM7nEJeR+HjNFqqphiD+wyfTFmR4MCs2iBbBJgpakzy5U2q4yLNg2s1S43+aDl1rBH+qchreQPYKJ+bMQ/MDHn2p+LAJsch532eGbgpGfguulMw3O379le2T4pQKFhNFwxpSdIrF8wm7xvaf7r1+De4BoSYP5jw7acAVuRrcudR4ihFvuW6HxAlzed1vbGDDDTbngCcTXyszMP6DyvIt8i4cpUw/XrEl0ewQGF1fhOkLySk6xLqntO3amVEFRiI+WEFcEtMQHRQ11jVBfTO4qJj/MSXlQei1BdV0sUmGlRkl/13hknoPeFPzLItiieW3lxdoE+aSN3k5LYX6JDy0CEgcWFqw5v63agVmuonCIstlMssIzGODQwP20uVeYHpniwFXEDKYDpO6HeZTiA4XHXcdLegs7cq7qLFCUESG+M95LO3aI5/D4pxOK4hqprEvjdAWIbxwOaSOGPHMQ9RY/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.05.24 04:57, Andrew Morton wrote: > On Thu, 23 May 2024 22:40:25 +0200 David Hildenbrand wrote: > >>> You have stable@vger.kernel.org in the mail headers, so I assume you're >>> proposing this for backporting. When doing this, please include >>> >>> Cc: >>> >>> in the changelog footers and also include a Fixes: target. I'm >>> assuming the suitable Fixes: target for this patch is 38b43539d64b? >> >> This adds a new selfest to make sure what was fixed (and backported to >> stable) remains fixed. > > Sure. But we should provide -stable maintainers guidance for "how far > back to go". There isn't much point in backporting this into kernels > where it's known to fail! I'm probably missing something important. 1) It's a test that does not fall into the common stable kernels categories (see Documentation/process/stable-kernel-rules.rst). 2) If it fails in a kernel *it achieved its goal* of highlighting that something serious is broken. > > I'm still thinking that we want this in kernels which have 38b43539d64b? To hide that the other kernels are seriously broken and miss that fix? Really (1) this shouldn't be backported. I'm not even sure it should be a selftest (sounds more like a reproducer that we usually attach to commits, but that's too late). And if people care about backporting it, (2) you really want this test to succeed everywhere. Especially also to find kernels *without* 38b43539d64b -- Cheers, David / dhildenb