From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBF2C6FD1D for ; Thu, 30 Mar 2023 09:41:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A14346B0072; Thu, 30 Mar 2023 05:41:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99D096B0075; Thu, 30 Mar 2023 05:41:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 847526B0072; Thu, 30 Mar 2023 05:41:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6FD076B0072 for ; Thu, 30 Mar 2023 05:41:40 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0B3351A086B for ; Thu, 30 Mar 2023 09:41:40 +0000 (UTC) X-FDA: 80625072360.14.C728D8F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 2FED740004 for ; Thu, 30 Mar 2023 09:41:38 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d6scwfFD; spf=pass (imf11.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680169298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mdeKPljJ04L5Zu/e3M2HbmrNI2/PIT36ixWTFqAG+bc=; b=hJfx/nLI3rRsr63mmuRKJo/eL8dOgUb1wNk6ZjiyNvO5xsGUn5nvyx4h8xRSA+ePvKEgBs StHJtsHn5l24r1gqnMHZH1npnRDd9wRSF+M80Es+rzm4bAKKRCpmh6qbdXRqNK4zyu0n/3 UyvG3v3dDU3jCTjBysIinNrLRGqBUcU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d6scwfFD; spf=pass (imf11.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680169298; a=rsa-sha256; cv=none; b=lGEnKgoNXkkDfMHwH7CuWt+C6vwMO+durSZN6LwaaGsMTbGS4pEgA3aCoypndtv7/sN4YM nCYO9dDYljITmSQ2kCBpjOpD4jtImNhWXipX/9wiS890YsXGOWE1Ss5sfTEvaQqB0npdW3 g5I2ryepPdyJQhrmLUhBhVNRPAewm5A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680169297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mdeKPljJ04L5Zu/e3M2HbmrNI2/PIT36ixWTFqAG+bc=; b=d6scwfFDJm0FY377uZW/GE5YQUCslEKL56TfB7BKmfhFgPfqB/XxpJ4iumrmqH/brr4qPa 7wbzQZNlRlENJ70mhAuhExOj5Oni8VP3j0iCV74th5R8WWkA17yA7Bhm1bdPyuIk++Ig8m 3Q9rFGaxdzhrA279KvLEqm3Gm2Ede2k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-29-iTWDHOayP72Oh1RXlrE68w-1; Thu, 30 Mar 2023 05:41:21 -0400 X-MC-Unique: iTWDHOayP72Oh1RXlrE68w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F3986185A792; Thu, 30 Mar 2023 09:41:19 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id D4032492C3E; Thu, 30 Mar 2023 09:41:17 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <6F2985FF-2474-4F36-BD94-5F8E97E46AC2@oracle.com> References: <6F2985FF-2474-4F36-BD94-5F8E97E46AC2@oracle.com> <20230329141354.516864-1-dhowells@redhat.com> <20230329141354.516864-41-dhowells@redhat.com> To: Chuck Lever III Cc: dhowells@redhat.com, Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Linus Torvalds , "open list:NETWORKING [GENERAL]" , linux-fsdevel , Linux Kernel Mailing List , Linux Memory Management List , Trond Myklebust , Anna Schumaker , Linux NFS Mailing List Subject: Re: [RFC PATCH v2 40/48] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <778589.1680169277.1@warthog.procyon.org.uk> Date: Thu, 30 Mar 2023 10:41:17 +0100 Message-ID: <778590.1680169277@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Stat-Signature: tmgaq9gcm9rop9ugdpm1nz38baq7k8at X-Rspam-User: X-Rspamd-Queue-Id: 2FED740004 X-Rspamd-Server: rspam06 X-HE-Tag: 1680169298-120097 X-HE-Meta: U2FsdGVkX1/yYdKwcSmGmQz195WhclZ1SvhkhBDY+EtO3T+zP/s4XdPBrnxENYBWHhbPiIJATnYFvoDGcKf48P7vldEUKmaA5gWH/9Y8KAlG3jpwQFox5EXng+BLUJYQmGqp3R+Wkaj/kyiZe2Ghu826u6V+jlr2pZISyNdw5oToZ7mOC/dsAVNbRDdikjnTfuSezAvr+IEowhAiwhDWmyx1w3acUhetglN0G/4sjnBb/H1VwNE7h0DL7YIxTzb1wByDY+G17ThVUcmepjr1z9JntHOBzwhvQF5z3eP5VGWM8xMHkp+jDLHGpSdKFnUneOKclrakCOz/I9TZoKm46+oU8weJ6UVnf7dQesloFcRoqKHipHxAC9RxrgHispBvwzp2I2LhTazGqTXfbx6HQMnOL9GFhVsXAyCy+hiJuuvQUB72eOOauVqCNtnsc0lAWg/imiWwr/s7RCQKGdHT5xaQ7nMInDYxKhj4eB/rcNRJszFKZYdoJ1BdK1Cy+LQRuLFz4UWd7JfEREDOTfdoWqB2gPZi5PcmEAV+cYY2PRgmgoGwUrLGo2xDxFpLLf7Q6MtvN/N7UKaG4zqaWhd2o0/9WqY2TM5FRsUqint06h4hCC/0baTRj2EtaxCbQwcxPwGbYKTK7PQGpTpzhykiRH3qVNmTtZix0JyObpZTrLEVyGkEgUKcV9D6uLgh8OygghsysnXQAeu74Gj0jU6XddKK+S3YXbjdDk8cQkudga+VVCgDcMuUGKOXvWH1wTuo1t2lWrAxOSd7Yqsrmo03VYqss1q0PFuM8M7T61ZLPqVJiC218H7fzMZGXv8CrewuhkrHH4mlvM6xm2CC7gdZirAxb4SJB0xm8vawhQu3H+HJN6Rzei15avc0DUWxU4mZWKvaRJjlB2qkZZb7UfsJZCHkMbAGuU4Er0ca1zDfq9Eo7fob5/ZBwtAN0r5+c17UbIUtchbuLKU/r6roYwb zlUeeuVA DAFsJ7BIPDn7TAewv1w4KuGoeLAZReyft4dKym9CKIkfvI+OR+XHH2PAvcMBHrCye4OkkQazoD9FYuoPBr1GRpSB5WjWW52muBKUvCnsWKTM17WQFgmcqyDouN3XNaR67Jt/fd+ICCWqAht4tKEmjzrwyfTkZpezcdgBU/TJk3py8ldJnnkEaIXhtI44GnhpsFjIPXoO1EFeq4qji7P35ZkEduaY6CxrNM1as08SOcSKhwqnvI3ENXYoz3b8yApjXSrnVwtMcchMmpes= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Chuck Lever III wrote: > > + if (ret > 0) > > + *sentp = ret; Should that be: *sentp = ret - sizeof(marker); David