From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4604AC761A6 for ; Thu, 30 Mar 2023 09:29:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69A196B0072; Thu, 30 Mar 2023 05:29:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 649EF6B0074; Thu, 30 Mar 2023 05:29:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 512CB6B0075; Thu, 30 Mar 2023 05:29:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4104C6B0072 for ; Thu, 30 Mar 2023 05:29:19 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1F54280382 for ; Thu, 30 Mar 2023 09:29:19 +0000 (UTC) X-FDA: 80625041238.24.F5FD5DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 5FA2BA0002 for ; Thu, 30 Mar 2023 09:29:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BhRqo07s; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680168557; a=rsa-sha256; cv=none; b=OI3lcPTSBNtZThPmSt5AuJOtUgYSL5L/gbR5G8+aOoLjCEq0HOg5TjjQ6okqyg0VUIP4Sn 3di63rwPE2bGFHFe+SRDHYpbOog27317iDjJKVZtMYUwSitxKu6vzqW7r0bCUwnbUwV1g1 nH+pJzLvMVMCu7BvVMgwYRtjFGRqRTE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BhRqo07s; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680168557; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+XgWAMkX5gl81w36XkfWKNCMFULxOFJmmzo6Xs6xITY=; b=4iBvrSzK4a00RO8RSoQSAmsl3bRrg3dULAaCbTDm+5TfIJFVUS9zvUClKDU8bbM3nfHbeI cUN4ezTUl2KjJw2kywQ5RtWJhvuCKf13FFnGvludp2yJILDbJbzru/yUcG//GOfbhPlfHA c9JQrAZ2uOvOJgYjaOvNMJUoplvCmDM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680168554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+XgWAMkX5gl81w36XkfWKNCMFULxOFJmmzo6Xs6xITY=; b=BhRqo07sNvcxmLdz85lpMeNZAx3mOcDqYEfD7b+78iweTHSR5zJ/zg+fyp5khHH5WGH/tr 3X3YVyROXnypvJutrheX0nAS0mNEvpEDX1rj+x5hKoicFPyByi5NZdXQ40qeWf+iheULIx 7FxZ9nGetVNxwiWJ52Ftd71xRQY+yrE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-544-jczfNWu4OtqMRHX0J7vacA-1; Thu, 30 Mar 2023 05:29:11 -0400 X-MC-Unique: jczfNWu4OtqMRHX0J7vacA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8C7768828CB; Thu, 30 Mar 2023 09:29:10 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE8D34020C82; Thu, 30 Mar 2023 09:29:07 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <6F2985FF-2474-4F36-BD94-5F8E97E46AC2@oracle.com> References: <6F2985FF-2474-4F36-BD94-5F8E97E46AC2@oracle.com> <20230329141354.516864-1-dhowells@redhat.com> <20230329141354.516864-41-dhowells@redhat.com> To: Chuck Lever III Cc: dhowells@redhat.com, Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Linus Torvalds , "open list:NETWORKING [GENERAL]" , linux-fsdevel , Linux Kernel Mailing List , Linux Memory Management List , Trond Myklebust , Anna Schumaker , Linux NFS Mailing List Subject: Re: [RFC PATCH v2 40/48] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <777294.1680168547.1@warthog.procyon.org.uk> Date: Thu, 30 Mar 2023 10:29:07 +0100 Message-ID: <777295.1680168547@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Rspam-User: X-Rspamd-Queue-Id: 5FA2BA0002 X-Rspamd-Server: rspam01 X-Stat-Signature: yp1e3nt5ygr8dnw7kqnd865smzikh1do X-HE-Tag: 1680168555-580965 X-HE-Meta: U2FsdGVkX1/5kucm3P+FVwAgdxw796lUsZhdBL2ZkEooHYH8CUyLTf9Sq42AWFziK1cLYhBjJymoT448bW8gEyjnIYovtroMcpYqDFYNUfIYjAtD/FMz5FX4NVkx1Q4v+ZWCUEExqxzaw3IvG4/Ybi7epFtaNqBvP//+UWXDZ+kWN9I+7aLXcZJSneK+uE4h4AHZtOJveKEXLGX8UZpo7atfNzR9n0ogIzxgA02giHRgbi/FU9oVludRdhuxlWJcNUPomtsFmpCMRgNn8UG82u3HxbfaTmq7Rae+u24U55NoM1e6Swzd6KlhiHPEyjbJUWf52vHUI1HY0SPcKKsO9KAvR9sDUQPxcjJXGyjv197iuF0sTYb7n3xCcrhw7dL77j1I9r41aghBQTK4ZVZ4TXSoapLCkRP6LKLjS2rXvAJK2GYZga0eOdnSNtlRssqQP3YA3NsA9cYuay+xxaDkLRqR3We86zDIE9s9PYEjAnkMVfNoBv230pTdDNtmp+XQFkJn9MA6OBhqCvjH7HXtDqSY8leir+jfhDBmSuZwybVsfQCve5946shAcvc2qPK4fJtzb9v6K2gnuj6G6fkoVeLboRfIxPu6Vq3RgG5hxNSFfdyueG847/GJ/AvIptHBh85+/s5q6L1wwu67l3nSBRcLMKx0AzOOn61S1UGg8L2+fWT88EWTszv/pSv0Fns47VSDxHTRvibDAMOk4riI1SJW9CvHLvGNB/sQhn6bXZJqQwRdBADiCJmTBEeuk1uBy5CTf4Yt8N/OmSiOp0RhOyk9yK9iv1kc7LVCo8ojaz2xds47iCrvAjME8BmXGqBsP7UJQSZY8Dgdw1amRrrDBaQJ7LF6aRTxxakctEf/xkYnwjkYIxdKtFDdiO2VExULGYG7Rc/d0zVbJYY1Vt5jMDxaHdlgTXokiwmZzRNQrNdAu2w7NUX4ps2UY3C2f6afZjscj/QUETJsnUNCf5J XEWmXDqV 8V9EDTMtH1dQthc70vlSDCxqxR5oGy38l3Tg2wdjIETKOlPmO34VaUSLp9LZV7CNR7SXSWcLvBptVIfhJocGuxL9MgJSX96DXAMoazOitj+P1d8ezOQUWwA2gA+MBm/XEuygrfWDbk6N6kRMeDPt1xp3m8cZ5EAWUV/4+taqv1rA/+2PLONow0+YUpdGHQy8lKD04hpIASvU46L864CsC60R3u0Ct6vKKaEY9yr0ozt6gv3Pb/Yi1HVfq+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Chuck Lever III wrote: > It seems to me that you could eliminate the kernel_sendpage() > consumer here in svc_tcp_sendmsg() without also replacing the > kernel_sendmsg() calls. That would be a conservative step-wise > approach which would carry less risk, and would accomplish > your stated goal without more radical surgery. Note that only the marker is sent with kernel_sendmsg() in the unmodified code; the head and tail are sent with svc_tcp_send_kvec()... which uses kernel_sendpage() which needs to be changed in my patchset. I can make it do individual sendmsg calls for all those for now. David