From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF2A4EB64D9 for ; Mon, 19 Jun 2023 09:28:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B7398D0002; Mon, 19 Jun 2023 05:28:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 466BC8D0001; Mon, 19 Jun 2023 05:28:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32F9E8D0002; Mon, 19 Jun 2023 05:28:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 252A28D0001 for ; Mon, 19 Jun 2023 05:28:34 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D28E2805ED for ; Mon, 19 Jun 2023 09:28:33 +0000 (UTC) X-FDA: 80918972106.14.9EF4A83 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id ECA00A0003 for ; Mon, 19 Jun 2023 09:28:31 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M772NuO1; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687166912; a=rsa-sha256; cv=none; b=k/mOrGbeYD5PGrQgfJPcFiyCHcucEbJFQodj81qbgsabShA6+xKiMaO/LAbAUNeU58aVNy 0s7MXPiKRkZLAKUbqzuPOjDJIuUAoPMK13gNhvxsH6q5F9I5kR/7d/h94ZCTcduiK39kyy ARQz+iRBVc0ZWlEcP3z3UgFkiRV+ezE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M772NuO1; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687166912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GZ67eYp0xidD7yf0q5E58c4Opw2pRmvbtVhqjrSnPYE=; b=caD+4F4Nh6gP0qcR4i/9tF930WTOy98VKg04UfV2947DaF1/CPUaOBF+D1rdCPmzN9X3hT KaBNpAR3Ahogqd8KwLv1Yjd4VGyufFFycBFru3tP+y+2ywLbkfArZ1uSuMDk8TUDx+yGr/ mcNZvEvb6TmWiP88PaCaE4Q/JciqR7s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687166911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GZ67eYp0xidD7yf0q5E58c4Opw2pRmvbtVhqjrSnPYE=; b=M772NuO1mgQOiFzdobOvHbgLSoL76F8oxWtSpf19HMY5bPRN60gKF09xkforigzoAwnO2Q IuvK8Rz3J6KgFNDiadGj1ltSF5c/q8hAKFHeqKFqos6jnyUDJc/GkcWHkbMlJzfOGgzRGp xrbE+cHhl1Y2kpN9JgVSCHl9I3mXJsU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-417-wy7vn5_rOYuWr0fZ_lhqeg-1; Mon, 19 Jun 2023 05:28:29 -0400 X-MC-Unique: wy7vn5_rOYuWr0fZ_lhqeg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 05F2180067D; Mon, 19 Jun 2023 09:28:28 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1AC6112132C; Mon, 19 Jun 2023 09:28:24 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <55e7058b-07d0-3619-3481-2d70e95875ea@grimberg.me> References: <55e7058b-07d0-3619-3481-2d70e95875ea@grimberg.me> <648f353c55ce8_33cfbc29413@willemb.c.googlers.com.notmuch> <20230617121146.716077-1-dhowells@redhat.com> <20230617121146.716077-11-dhowells@redhat.com> <755077.1687109321@warthog.procyon.org.uk> To: Sagi Grimberg Cc: dhowells@redhat.com, Willem de Bruijn , netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Keith Busch , Jens Axboe , Christoph Hellwig , Chaitanya Kulkarni , linux-nvme@lists.infradead.org Subject: Re: [PATCH net-next v2 10/17] nvme: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <775803.1687166903.1@warthog.procyon.org.uk> Date: Mon, 19 Jun 2023 10:28:23 +0100 Message-ID: <775804.1687166903@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: ECA00A0003 X-Stat-Signature: dhiifwnb8u38opka4bn8pj5bmrwgupun X-Rspam-User: X-HE-Tag: 1687166911-279393 X-HE-Meta: U2FsdGVkX19C1UaVPI+yBMevhBATtqmW8aOJ1izSvLYO0E98HYn6F2aVDgf2cn5Q94C5UTjyh8WjPcNY4wQo2e0WH0l/NhoBvhVx+ULddZQ7p1xHlM26VTT7cifJxwgYxUyHQLjWpXyKu0WJ16//Y6Qwa4C0nUFH+48/9nw0UyUbt/hly4J1+sOasjaYdJwWJHwceVANTaO/O1sezS+2YFR9vCzgWIscZm8ZXgLpVrR6adZbZGx6cY6wlDXDr49CMDt0OzlbR9O8HMYxFwF5FyrWNybSRtB8tG88rIOWuXO3putLnSUZMyJS2KLGY53XZbzwF3u6TKuxOEWZaCJ1dexUyW7hZZaARhKgQ+M0Ldl/oJX6aPJssQPtaq2vBEYs+nkvA/NIVLp4AnT6ZDE1YYpDR1A8rkamIQs9T7We4zMsFIvvRSTOhyzbKQgyFcKcGsRa8U/W6vKR//ny1RyAWID5hOoxbb4k6ceGffmSsNypkMpHI7XIbszCQ2qXveub6euu5P0NqwPDTMmKOmJhnnlUa7I6DwV/p7Z28uSEIqs5ZBPpubD1/g0TF0Z5sDXI/OF/9n7mH8rfunNVAFD7z0wIvM3KcDibl6O3n1qXPRjD/usS75bELyWjK6LpxZHCjcOk7OSP+aTMwTimf2XxnsW6PCMYR7RrqnnHZ46q1CHwwbO0PedqUVWoudQxy+NgLQN5f2W17cwBvFSgtUh5YZSreJPW5eC9bJxMgYHazGKu6NRPeHJJmuqZ/zNSgI3GZCrwuLCOqVhOP7YsMCSrL6MMDwJzQJWb7YN5XB0HEHvMzcAgu40WSCXBspw974DiSwyvELHQSPwbMUVTcn4TSP/YNWovUvK33+4WQIyoBQLFUtTlp/K5oHzpdkshTLUnqIXU7M45JUCMAxoAhSABbEp9EaWZsBR8CJtq1uXQ3+L7YaM9sxyXJd3uhfcCPvqG16kSN43PAQVbmwheaeE EnpkRtxx sZm19fUWXKr+A327zVOgSDBscgTkGxk8DutNru9e6hXrsM31rn2VxRUKsYAKhLEXXBB3wtlWzmmcDWxPGPRCMa6+RkOXqLsRunJj9nNcIfV8YIEWWOfGNAJpQns0hX6fVEvkSkp5S7EP3DbzILdHETxNpUD28KoRr8RqTmBXo/0PpCiW4dlENMcs8hqMnAk/MFP+t0aqc/aMAF/wEydy/movB6NeVowiFIAPRUuBhko5zwbyqoYqtRoJU7gW+79EedLXXGG+1DdNjlQ68mP72gU0IE0lwgZDYqMRC3Ky9U1tzI9MQobz+WVPMpZZ5uVzOn1N+vtEPjYzZQKAYCMf5XFwdM2M7Ai+rUf421ig452dj1JU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sagi Grimberg wrote: > The patch looks good to me, taking it to run some tests > (from sendpage-3-frag branch in your kernel.org tree correct?) Yep, but you'll patches 1 also and patch 2 might help with seeing what's going on. David