From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7226AC6FD19 for ; Mon, 13 Mar 2023 10:01:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE2566B0071; Mon, 13 Mar 2023 06:01:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6BD86B0072; Mon, 13 Mar 2023 06:01:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90BF46B0074; Mon, 13 Mar 2023 06:01:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7B3086B0071 for ; Mon, 13 Mar 2023 06:01:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3A7F01A0AA4 for ; Mon, 13 Mar 2023 10:01:47 +0000 (UTC) X-FDA: 80563433454.01.2D1D421 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by imf16.hostedemail.com (Postfix) with ESMTP id 39EAB180035 for ; Mon, 13 Mar 2023 10:01:43 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=none (imf16.hostedemail.com: domain of alex@ghiti.fr has no SPF policy when checking 217.70.183.197) smtp.mailfrom=alex@ghiti.fr; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678701704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BHPmweCr79JT4IpjpCOWA4wf5Ro3si2C7/V1s5bfxRw=; b=Fh/v5dZ0QcZkJ/4B+y9mPMl7MOLuiRAG1YyKIWHoCHgs0d0t9D45jsnSED+zePj+7eZDIK tM+nkGfaMAvhFWNoxkY5gKD9jbTp+kL8ADhqSh2CWho8yoMcIdV7VVQIxj3hUPFowDnOpV KUaqDQRZ2lhU36t5Be1l07vEVFnAPoQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=none (imf16.hostedemail.com: domain of alex@ghiti.fr has no SPF policy when checking 217.70.183.197) smtp.mailfrom=alex@ghiti.fr; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678701704; a=rsa-sha256; cv=none; b=GgL03cfM28LvjfvUGENTUm2hwd2yYa1Sy8T7tJML+ZgdFfa0TqzOZDlLncQDnuP0lJ7QWd ZgX8f00vl8QHruom2/KfDe7VHaJ4SfcErUMKX9mPbZfr9RjaVw123qyxGSd5cMImyr9cO5 nZiboyYqsUCQQAjJo1uHKMzdTLJdP74= Received: (Authenticated sender: alex@ghiti.fr) by mail.gandi.net (Postfix) with ESMTPSA id 3F0261C0019; Mon, 13 Mar 2023 10:01:33 +0000 (UTC) Message-ID: <77564d46-5bca-81b8-8e14-c70624ddce5e@ghiti.fr> Date: Mon, 13 Mar 2023 11:01:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v7 3/4] arm64: Make use of memblock_isolate_memory for the linear mapping Content-Language: en-US To: Andrew Jones , Alexandre Ghiti Cc: Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rob Herring , Frank Rowand , Mike Rapoport , Andrew Morton , Anup Patel , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-mm@kvack.org References: <20230310094539.764357-1-alexghiti@rivosinc.com> <20230310094539.764357-4-alexghiti@rivosinc.com> <20230313094306.6kslmrdixuw75iqf@orel> From: Alexandre Ghiti In-Reply-To: <20230313094306.6kslmrdixuw75iqf@orel> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: am8mr53sznymxmeoac5os38q3rm1d4dw X-Rspamd-Queue-Id: 39EAB180035 X-HE-Tag: 1678701703-961564 X-HE-Meta: U2FsdGVkX19oGjZWmsFTl/Oe0RL16ykVvhwL5PLOr+/8CA5EshodX1e2gphs8JsUbfQImiAKakstWROLZmCSHhJomAdar+Soi48IqrdgmrGffdhc7iQpAKjVapdKTARC7SHwcbT+8W11Gn5Ier5XPhw8bAJaGScgW/oGILp6/7p4MoOTZeEvFwl+QOFLmyu9bRZ4shEYr99+ZmY0IEbSzRBedQAA7+RUfwl4T3g5+u17pZvDve4xq0PPYwwPO3JM5TpntJ9pU8CjMPKvwLM7KykF6nS4L9Na2QYNSsxJy/6y5HysO8Gx/jPDGy44F2SoZhIjl7d+Wn8rgr/8WFNIwkqLEKuOMCWBWnezFqZsPQ46znjMhjjPCADTJLQPwMlMlqQ4M4pEIGzvXaMhjqZ88YEs3mCaOE88W4jJ9/hlvk6fvanCxEPgUYKSYhYXoAOxGnl5iM3+tgBhfuDIGyMzZeuYyBlYwMQ8FHaKQPjNM92LM88R9FEVG9/6+CiiNFVpznTh9EQrcsbb+0fI1eBaJiByrDbysN3R1KwEd2xbrudEEylzIpqyYEgYclz/uiIP8jQjtvxYHdmg8iV40Lhahx7Uh1/HMRa1807o9hyuSnPasECZbohYBxLe1BIksfMkQ8nn8UMl9jCPQV/CdSOQYPUcmcL3u/qriHcTnfny07ldLEXBt0nun6qPxyBCnoQzYqPFbBLHDX8m6Ek0i4hQZuzIa5T4EJqRXcbpENG8uKm/n0ZuJSrnlD967cCoeKB9Me+eVmnjzzDWVvMenY02vIZb8/B1VAc0Ef6I38z0hG3DpCryUe+5T8V77Mn6M18GQBK11h4wc5ZbiR/iS96kbYbO5eHGXFIyImQCA0nu0sXHDq/hWWzKQgQMHMsiNzTEUdHd6d1a80slry+vWmP2MTP13p4O7nFHr0RuY+7pODxqJeDp3lF6pSrQz4ONBqsPyEMlKOguhx1P7Ptq4KA DyC61GBI 39AVWJvVEQFoFpoTpqVMZ6fBbTnQHqfAecvDSWB+QECaF1ecspLY07jBxIxa1zAbPY9FCQiHf3lGwhciwWzlejsrVWYC7eh/jKt6p9u+IRevpqok2GtMh7IiG7tilQQBjhs0MQ3H1pqYKAaVgvdU9OtJ8zdm0csUPpvbBZXiAYRhTYKsNs8Jejd3K4X4c0tY99aq8FfFfhwXjgoUU2bC3t8RlY4Y0JOg0DE/yETrY6ST+g3lAxz31+x4WTsPIz39i0MJoNqd5DebY3HpzM1z1i6+GkQV1PQVULz1LcebTWnNJSfsSSeJr5v7f3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, On 3/13/23 10:43, Andrew Jones wrote: > On Fri, Mar 10, 2023 at 10:45:38AM +0100, Alexandre Ghiti wrote: >> In order to isolate the kernel text mapping, we used some sort of hack >> to isolate the kernel text range which consisted in marking this region >> as not mappable with memblock_mark_nomap. Simply use the newly introduced >> memblock_isolate_memory function which does exactly the same but does not >> uselessly mark the region as not mappable. >> >> Signed-off-by: Alexandre Ghiti >> --- >> arch/arm64/mm/mmu.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >> index 6f9d8898a025..408dc852805c 100644 >> --- a/arch/arm64/mm/mmu.c >> +++ b/arch/arm64/mm/mmu.c >> @@ -552,7 +552,7 @@ static void __init map_mem(pgd_t *pgdp) >> * So temporarily mark them as NOMAP to skip mappings in >> * the following for-loop >> */ > The comment above doesn't apply anymore. Yep, noticed this one after sending, thanks anyway! > >> - memblock_mark_nomap(kernel_start, kernel_end - kernel_start); >> + memblock_isolate_memory(kernel_start, kernel_end - kernel_start); >> >> #ifdef CONFIG_KEXEC_CORE >> if (crash_mem_map) { >> @@ -568,6 +568,7 @@ static void __init map_mem(pgd_t *pgdp) >> for_each_mem_range(i, &start, &end) { >> if (start >= end) >> break; >> + > Mark nomap is also used for the crash kernel. Does the new API not work > for it? Seems you're right, I missed it. Thanks, Alex > > Thanks, > drew > >> /* >> * The linear map must allow allocation tags reading/writing >> * if MTE is present. Otherwise, it has the same attributes as >> @@ -589,7 +590,6 @@ static void __init map_mem(pgd_t *pgdp) >> */ >> __map_memblock(pgdp, kernel_start, kernel_end, >> PAGE_KERNEL, NO_CONT_MAPPINGS); >> - memblock_clear_nomap(kernel_start, kernel_end - kernel_start); >> >> /* >> * Use page-level mappings here so that we can shrink the region >> -- >> 2.37.2 >> >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv