From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EAC3CF34AD for ; Thu, 3 Oct 2024 14:09:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80EDC6B0338; Thu, 3 Oct 2024 10:09:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BEDD6B0339; Thu, 3 Oct 2024 10:09:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 638106B033A; Thu, 3 Oct 2024 10:09:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 44C6A6B0338 for ; Thu, 3 Oct 2024 10:09:35 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 82E15141220 for ; Thu, 3 Oct 2024 14:09:34 +0000 (UTC) X-FDA: 82632473868.17.DB53E0B Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by imf30.hostedemail.com (Postfix) with ESMTP id 80A6A80017 for ; Thu, 3 Oct 2024 14:09:31 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lxacmrFC; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727964429; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=By1z4iIGNEGnajldjqgvTv4FnDoU8JrRtZyLC2Xi5os=; b=CkN+f9Zpd/bE7YMW6mW53f+LRRKHbKBmmFJ2/SEeBjB7vDqXOGDopQjgBmwKA7xhE9ha43 ltgF8fv8MQY8FjV4hVA5+PW4OGkcOBeym/lKzgfUADw5HJa8OQXVlDstDR+qe9jb63iXLA jpwZdhJB2EdlUGTaN0x+5NV14EheFpg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727964429; a=rsa-sha256; cv=none; b=8EFWBQdBOitxP6naVTWYZwk8YbW7bMNUrnL3CP/XGl9WhxWFgBXZu8e2N5vZ9fT5YzfX5M n9/zMhczzuoBD0tZr1InV4lxrS48KuH2iQJIyDfNt/IWam48BjrsFmI+TwvsXqwUF4A+1P EF8Vytm0RIXGfaFaWJXG8j8U2i+Ec7E= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lxacmrFC; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=dave.hansen@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727964572; x=1759500572; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0U4ior0YJDSNRidoy2oTpzU7ZMIyCbsfb4UR4eXpgTI=; b=lxacmrFCt0ZsVVLWUPvpmICQa6S8x1OSYfU4R1CQq18hwtAdTkDhPUsQ pPdHumUNNcFotQx6xNhvt9Ck415VMVlPtoYBnLVpKXkoSd5tsb9h0KRdw Rv7tp/R2CZYgesBMNj5d5UCrgOgU0PWOYJ04d6JHdE4YfNtyc1RBpbnvT U2RpHjXocK642ao+mxjSCLc4VYmOsxtHCd0TVO66ColODaK5TFOEAV/xi K9B/ePahHmAti2APJcyw4ryqQ9Gje6+keO24SL1CIuKlQOCf/M9kaSZ9O ehALTq43HjKAUqsdKfQFvbJ6cTikrNJtlclAUexjXswwza6YtJNfNhTYb A==; X-CSE-ConnectionGUID: gQuBHlIWSPWuy7N4q6Z+Pw== X-CSE-MsgGUID: sX9F4scZSHGPSS67C918dg== X-IronPort-AV: E=McAfee;i="6700,10204,11214"; a="49682255" X-IronPort-AV: E=Sophos;i="6.11,174,1725346800"; d="scan'208";a="49682255" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2024 07:09:30 -0700 X-CSE-ConnectionGUID: Qfp4ODjTRnits0H0xr5g+w== X-CSE-MsgGUID: VDKfSjDjRjiU8uJXydRorw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,174,1725346800"; d="scan'208";a="79217766" Received: from jdoman-desk1.amr.corp.intel.com (HELO [10.124.220.234]) ([10.124.220.234]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2024 07:09:29 -0700 Message-ID: <773d1ac3-51df-4467-9e85-9a3746398dce@intel.com> Date: Thu, 3 Oct 2024 07:09:27 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH] mm: Move set_pxd_safe() helpers from generic to platform To: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org, paul.walmsley@sifive.com, dave.hansen@linux.intel.com Cc: Palmer Dabbelt , Thomas Gleixner , David Hildenbrand , Ryan Roberts , x86@kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241003044842.246016-1-anshuman.khandual@arm.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20241003044842.246016-1-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 80A6A80017 X-Stat-Signature: p7hecic1os9t5xypazb1re8yq35z5qsc X-Rspam-User: X-HE-Tag: 1727964571-697141 X-HE-Meta: U2FsdGVkX1/Lf2vJ6gx520Rx2HeCT02QIkBg8Q9oXxZCQGGQaZp7jJFXYQ6GGH3hZWqnnx7C0gekNduU/Ul7M8EuxA+f4Ae3FMc8rY3Xuo+Dgj7VeZ2FdPFGgNuRK7bgoojALDwtUe0pBKS7iT5hZcXLnoSBAFa0rgZRb7UysSd0EnetzvCrzybBKnjgR9Bjs78UXNZb0sbJnb62Fv8VK+XLK6x2OMilya4FOvyo2AicrrqkH+BiTcb7dx4nJqsKSiJadm0+3Y6K9Uw3aFU/tn0OaWRzdzdU4purbgt7BLa8TB6v+0M4ernEmx4FG1WIlQy48lNJvgkj4W/brkhwBLC/o3t1CKyGdqVeZKjTFR9W9CIp64z4xzJgtYjKTBcQPzDm8BkepuetVd9nX2UzqbanNhJitLQj4GH97pTzmsU8MdBHyWMnlW9dDI92n9AtrUZPoqwL+epCBl/R59uhfopTw2C8YkywaIaxXuW7iRzErLNw1LvGlj9kZoidHIEO3Bdr2hLMzL1are4Hq0mP10lkub49MIIMocb05ZhX1CXDqjZjBvowCOtoEajbPCl2Pu1PEYSU6jUUE0HGrJh4cBXOCzPjCFcV9Z4y4O6GkMM6U/+9xSHWbnegG6Q3TVCteo+s11zrFm3YyfzofLdHgCrLFlmbNlfIBqGo47twA4oYOfNO1XZN0YGO8IOV/bWM+Nu6zUi9dM59+Z0tUckUEOPWZxpI2/pNcmW7+vn8tdYELGD1sy0pAIPgI9yyAq44Eat/xohFtTEb++IkeXWdSq+EA6BEGzebrJAJUS+njWDAvk6EP2PiNaQVxrCPHvy2BzM1YXA1TMOzebWrqDFAqZbUyzEjywN67QooeXzBfR4uyVMyvBs+YlfsNWraAOVjmo8uoA5yy9CLd3bZ5LTEVKs6N9QlAMUOJDdloKcItAxr1vmaCPid2Kgiwb76ksUyATw6E/sF9B74mkg3uU7 wSMsmVKb QGrw039kDAG7AwsY5Gy7jsBONPQC8XATn2hJmsL/NOoDqnUhzW9DYit5/Z1Bp3OFKFxOX3a3G92smsbNkra9Zfj9iXWSRVuDJw6q70wf+FR4RyMgQ971eD2wf8J8c3OaGx6m1SRWGb70b7fjp+dZxUBltU5bfx1axZyi8ecIYkc6tiwjLODN/5+AVB7A9krsXsREQNJ1OcLasim3+RvOL6h1xG30KTjnb1f1dSAJQLeqJLVzyI58inX+MTml7+F1rspEc8hLOnr4DPJSSm+tYLzfEAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/2/24 21:48, Anshuman Khandual wrote: > set_pxd_safe() helpers that serve a specific purpose for both x86 and riscv > platforms, do not need to be in the common memory code. Otherwise they just > unnecessarily make the common API more complicated. This moves the helpers > from common code to platform instead. I looked into the x86 side a bit. I'm pretty sure we can just remove the _safe variants. All they do is spew warnings that don't seem to be doing any good. They're not really safer in any meaningful way. I've got a series cooked up to zap them, but I need to get some eyeballs on it. But if Andrew wants to pick this up any carry it in the meantime since it's cross-arch I'm fine with it: Acked-by: Dave Hansen