From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39CE6E77188 for ; Thu, 26 Dec 2024 10:58:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C01CF6B007B; Thu, 26 Dec 2024 05:58:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB16E6B0088; Thu, 26 Dec 2024 05:58:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A51D86B0089; Thu, 26 Dec 2024 05:58:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 878F06B007B for ; Thu, 26 Dec 2024 05:58:44 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1CA54AF150 for ; Thu, 26 Dec 2024 10:58:44 +0000 (UTC) X-FDA: 82936810110.03.C55F95C Received: from flow-a7-smtp.messagingengine.com (flow-a7-smtp.messagingengine.com [103.168.172.142]) by imf18.hostedemail.com (Postfix) with ESMTP id 378C31C0007 for ; Thu, 26 Dec 2024 10:58:23 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm3 header.b=E5TQUxOu; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="v K1923f"; spf=pass (imf18.hostedemail.com: domain of uwu@coelacanthus.name designates 103.168.172.142 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name; dmarc=pass (policy=quarantine) header.from=coelacanthus.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735210703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T2trfevT8p1FBQocDd7hyc8JcbXfbl6wsDPSsuq2Kj0=; b=Z3ZpGKxzv4zINvgZ/aYKvn5htpAtbVtRgDxBvd6G8mFUKyNGHiNv1kMuiXJWsTrI7uAp0j PjAShceOpex0FZoPuY3gOTEZwMIJzkOoul8jSRgs4rBzgYgkWg5kAhTR8HzNzSNo39QRkr pd0acmN1B8+ixp6bZlBi1wApZNAafuY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm3 header.b=E5TQUxOu; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="v K1923f"; spf=pass (imf18.hostedemail.com: domain of uwu@coelacanthus.name designates 103.168.172.142 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name; dmarc=pass (policy=quarantine) header.from=coelacanthus.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735210703; a=rsa-sha256; cv=none; b=uN3+MDqQuqG5zf9g3CrD5CqBQinGAqbwxis4NkoZwRPKfwtwclKEOSnNx/hZwLIhZJHMgY 9BdQwhKLmCzO7ZS8XJoqpPuLvSyqzaGnCzAW2Nhm+SJt+2pi/y65s+rV66Ja/5VuXWnt11 AAL7dAG6IMRn/9KSzxiDOPhpCNHlpyc= Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailflow.phl.internal (Postfix) with ESMTP id 6AD9E2002CD; Thu, 26 Dec 2024 05:58:41 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Thu, 26 Dec 2024 05:58:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= coelacanthus.name; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1735210721; x=1735217921; bh=T2trfevT8p 1FBQocDd7hyc8JcbXfbl6wsDPSsuq2Kj0=; b=E5TQUxOuaZ4PW12qCy2k4t6zse gMs37gbvmAadsZbe0oAFsshSGacPqBGyj36uz8bFgGDAU3H6rBdmeh02jvSwL3Rq DYmiergAsOO1qOUsatG08dqK3Vsno2GquzkVgtIBEsawaHH4G+5PUN1oI7zfC/8/ wbg3IaLRM9fXIKeUf5LDY/zuxSx/kF4mvpC7h8sPPdAhIPEMXdP6zN0IMrLBPkTk CctpF7nirW2/mCHdwrjKH8dPrhx4oeRfjuMdZaPDPuAMRYU37CokyJCup3Jd3ae2 B2BKWGS7k06sZoM2dt+v4yBqjucM+BCRZidZ6emowDGADipHYPLwrmPqaVvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1735210721; x= 1735217921; bh=T2trfevT8p1FBQocDd7hyc8JcbXfbl6wsDPSsuq2Kj0=; b=v K1923fPglNU0/JlJTFbB+mhxSwWssLvUef21FSOrgVD2+fywBcAUCXnSwMzSJ4aN wtsUuDg/bxN0q4BrPWTdUukSDE2dnLRQ86BxM2k0DBvrQhjVnxhQ37AjcMXx3X0w 9q0DdYLtA38+A3kFW7vz+L0Y7uBZzcbbg184n329ANABus/aCr4/MOltl4a23prY Z3Sx0jMuDcYuFaMxAPPPkSHtlAwcLhr5MTBSWSpxbCRGbNfgVf/om/NPfmNz9w3F dbY8X/CQT6JLaQVzkh96HNs9eDnL/w7Xaa3Pg8PuSK2EpTvyV4HlEiR1VzCEDHK8 VlLUn52BCXFjbXNNYeLiA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddukedgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdej necuhfhrohhmpeevvghlvghsthgvucfnihhuuceouhifuhestghovghlrggtrghnthhhuh hsrdhnrghmvgeqnecuggftrfgrthhtvghrnhepfefhfeefteekgedvfeehhfefvedutedt fefhkeeileehgefgveffvdffudehhfeknecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepuhifuhestghovghlrggtrghnthhhuhhsrdhnrghmvgdp nhgspghrtghpthhtohepvdehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeholh gvghesrhgvughhrghtrdgtohhmpdhrtghpthhtohepphgruhhlrdifrghlmhhslhgvhies shhifhhivhgvrdgtohhmpdhrtghpthhtohepphgrlhhmvghrsegurggssggvlhhtrdgtoh hmpdhrtghpthhtohepvggsihgvuggvrhhmseigmhhishhsihhonhdrtghomhdprhgtphht thhopehkvggvsheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepshhhuhgrhheskhgvrh hnvghlrdhorhhgpdhrtghpthhtoheprghouhesvggvtghsrdgsvghrkhgvlhgvhidrvggu uhdprhgtphhtthhopegrlhgvgiesghhhihhtihdrfhhrpdhrtghpthhtoheplhguvhessh htrhgrtggvrdhioh X-ME-Proxy: Feedback-ID: i95c648bc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Dec 2024 05:58:32 -0500 (EST) Message-ID: <76e57304-3a03-462e-bb82-61d0a0385dda@coelacanthus.name> Date: Thu, 26 Dec 2024 18:58:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] riscv: selftests: Add a ptrace test to verify syscall parameter modification Content-Language: en-GB-large To: Oleg Nesterov , Paul Walmsley , Palmer Dabbelt , Eric Biederman , Kees Cook , Shuah Khan , Albert Ou Cc: Alexandre Ghiti , "Dmitry V. Levin" , Andrea Bolognani , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Thomas Gleixner , Ron Economos , Charlie Jenkins , Andrew Jones , Quan Zhou , Felix Yan , Ruizhe Pan , Guo Ren , Yao Zi , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= References: <20241226-riscv-new-regset-v3-0-f5b96465826b@coelacanthus.name> <20241226-riscv-new-regset-v3-2-f5b96465826b@coelacanthus.name> From: Celeste Liu In-Reply-To: <20241226-riscv-new-regset-v3-2-f5b96465826b@coelacanthus.name> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 378C31C0007 X-Stat-Signature: ca7xuxnuw5c6whgj5op6mds11cjy85ho X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1735210703-392569 X-HE-Meta: U2FsdGVkX1+McNxI/1cZ8A7/0D8vP8BWi7jkUYNg+mm2Qzwi9djoH93dlavGWeWQy6elWM2HSzba2fQUU/z5ZZtkV/2raSh/I6bw8rJNrGt+c46Iiie5eKDck78MZ9EKzLW4Vcagh8hPezAikGP/bzgGgVdY3WTSXwrX8uKYmv9Y63nuRxzxNJxXO1pFjPuNthzDl1dPvXcjk36B60KlawwSwS2M0hhlmTO6e8T2D7EQbXb3jROQtD36XjbaX4XLUJDSNeLpuJMcvVNvboee9ZyINkU23EkMGr6KXIUe+n7VbNAxxRr6sYZnSIcR9KDhXrubWjqI8KAprovq3IJqzq86G6F6FpK33KJDs+NYybkjjaBvVPckiOQ6AZEAl6V2kjsXe+pdIb0eSNhMQ8k/3Z2rXB3RhOau0YqSDeVE0q7FgPVW4TDepk00cX13MCEKCQTQBBFeJmrHZAWlZM6cdosQQ5Y7z3s1EupKT0wpIBgI3pU8CvAmegAAg7Pce5FEc/KvwGNfZ3ZxP/Nt3b1ueROM+jncrdZyUTiLyEA+puPnDFu1285SpYysGQBloMfXRcL8+YJSJ3vdDqegqA0W4UBVSHvhs0jd0ON4Vmc8V4i8W2xq2H43p65IJz+4WjW3MuWjBoe+0Okj3sIAy13qm7ukBRttesdTt7JTSLywo19jrAbNdET0QA108NUEldy7Kf4UZjLgk+zEudQVF1JRqrU3u1C0ZrME/Eg2Ucle4ETyoBlPA2LpBde15AHsEP0DEzgZycNeSc6YViaJSctdES87MO0A9yNJZ9FUCM5Bivp2k39VLwhyd5NcESUzj+DFG3L59x9nSHDWzcUphVjlg61DrrcwkFoBFd6LJdeduprQSxtp0+s9aHDjegahsGiZu72WVg6KxQF8VIaSpn+Jjrv86/7F/RAybzo1tRAKzvVTbKBBP0/a7OJ6F4BEc8F+e21HRr7h4nIHFaYJlFl 4wSBK/vK xIQ82T2BLf16MJtsroISXBFxFsRsUa6CAriLImbBIVjKScD4aFc1RW7BX4W5oSAMCPvBWuLUwdWnGpKNCqHyUs3f2ratq5+hFds6rAe7GCcdHE2h84KP8TUmh3r2TKGOWQM4gwplrwgkn/pKdCcAmQOwwFRQE2/92/EcJI8RrdxCS51XjS7iYBE2zKx8mYNmlPF4+RoLoetDEk8bNqn86Qn4bSSF2PPGJTViwsIRfixNmJ6Akcfdlq9fX912RCoXXeLdWVwu+o21sWBXYrsfnnKqxyuBkU/aHoXZ8okhAmjjhcWC6NUQGpShlAacSmv7GuVpcFALC9TZF2UEzqgmUAbuoUfkwm4vMgom52CiLSswpPRShnBsSQt3wuj5+alaNbTKFK7SQdjh77wfxjK+ncVbOjLN9QCtF8RoNVMwTgVYDbr2ZhflIjp68xO8DqEwLYHsR0ex46prj/aSh/4s9bLiy8RtpNhHw+zQmv3Kx7k/zDVIRt13n7r1oGTdVCvbSE9mAJv3WsJd7HKaiSi7bOcPlW6DR3Fu/dpYmWpSIyRp39WyvqUDtyY/zgG4En6Mlvzc9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-12-26 18:45, Celeste Liu wrote: > This test checks that orig_a0 allows a syscall argument to be modified, > and that changing a0 does not change the syscall argument. > > Co-developed-by: Quan Zhou > Signed-off-by: Quan Zhou > Co-developed-by: Charlie Jenkins > Signed-off-by: Charlie Jenkins > Reviewed-by: Björn Töpel > Signed-off-by: Celeste Liu > --- > tools/testing/selftests/riscv/abi/.gitignore | 1 + > tools/testing/selftests/riscv/abi/Makefile | 5 +- > tools/testing/selftests/riscv/abi/ptrace.c | 151 +++++++++++++++++++++++++++ > 3 files changed, 156 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/riscv/abi/.gitignore b/tools/testing/selftests/riscv/abi/.gitignore > index b38358f91c4d2240ae64892871d9ca98bda1ae58..378c605919a3b3d58eec2701eb7af430cfe315d6 100644 > --- a/tools/testing/selftests/riscv/abi/.gitignore > +++ b/tools/testing/selftests/riscv/abi/.gitignore > @@ -1 +1,2 @@ > pointer_masking > +ptrace > diff --git a/tools/testing/selftests/riscv/abi/Makefile b/tools/testing/selftests/riscv/abi/Makefile > index ed82ff9c664e7eb3f760cbab81fb957ff72579c5..3f74d059dfdcbce4d45d8ff618781ccea1419061 100644 > --- a/tools/testing/selftests/riscv/abi/Makefile > +++ b/tools/testing/selftests/riscv/abi/Makefile > @@ -2,9 +2,12 @@ > > CFLAGS += -I$(top_srcdir)/tools/include > > -TEST_GEN_PROGS := pointer_masking > +TEST_GEN_PROGS := pointer_masking ptrace > > include ../../lib.mk > > $(OUTPUT)/pointer_masking: pointer_masking.c > $(CC) -static -o$@ $(CFLAGS) $(LDFLAGS) $^ > + > +$(OUTPUT)/ptrace: ptrace.c > + $(CC) -static -o$@ $(CFLAGS) $(LDFLAGS) $^ > diff --git a/tools/testing/selftests/riscv/abi/ptrace.c b/tools/testing/selftests/riscv/abi/ptrace.c > new file mode 100644 > index 0000000000000000000000000000000000000000..c89343cb4abc7da57f83879ecce619f503c438bb > --- /dev/null > +++ b/tools/testing/selftests/riscv/abi/ptrace.c > @@ -0,0 +1,151 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "../../kselftest_harness.h" > + > +#define ORIG_A0_MODIFY 0x01 > +#define A0_MODIFY 0x02 > +#define A0_OLD 0x03 > +#define A0_NEW 0x04 > + > +struct a0_regs { > + __s64 orig_a0; > + __u64 a0; > +}; > + > +#define perr_and_exit(fmt, ...) \ > + ({ \ > + char buf[256]; \ > + snprintf(buf, sizeof(buf), "%s:%d:" fmt ": %m\n", \ > + __func__, __LINE__, ##__VA_ARGS__); \ > + ksft_exit_fail_perror(buf); \ > + }) > + > +static inline void resume_and_wait_tracee(pid_t pid, int flag) > +{ > + int status; > + > + if (ptrace(flag, pid, 0, 0)) > + perr_and_exit("failed to resume the tracee %d\n", pid); > + > + if (waitpid(pid, &status, 0) != pid) > + perr_and_exit("failed to wait for the tracee %d\n", pid); > +} > + > +static void ptrace_test(int opt, struct a0_regs *result) > +{ > + int status; > + pid_t pid; > + struct user_regs_struct regs; > + struct iovec iov = { > + .iov_base = ®s, > + .iov_len = sizeof(regs), > + }; > + > + unsigned long orig_a0; > + struct iovec a0_iov = { > + .iov_base = &orig_a0, > + .iov_len = sizeof(orig_a0), > + }; > + struct ptrace_syscall_info syscall_info_entry, syscall_info_exit; > + > + pid = fork(); > + if (pid == 0) { > + /* Mark oneself being traced */ > + long val = ptrace(PTRACE_TRACEME, 0, 0, 0); > + > + if (val) > + perr_and_exit("failed to request for tracer to trace me: %ld\n", val); > + > + kill(getpid(), SIGSTOP); > + > + /* Perform exit syscall that will be intercepted */ > + exit(A0_OLD); > + } > + > + if (pid < 0) > + ksft_exit_fail_perror("failed to fork"); > + > + if (waitpid(pid, &status, 0) != pid) > + perr_and_exit("failed to wait for the tracee %d\n", pid); > + > + /* Stop at the entry point of the syscall */ > + resume_and_wait_tracee(pid, PTRACE_SYSCALL); > + > + /* Check tracee regs before the syscall */ > + if (ptrace(PTRACE_GETREGSET, pid, NT_PRSTATUS, &iov)) > + perr_and_exit("failed to get tracee registers\n"); > + if (ptrace(PTRACE_GETREGSET, pid, NT_RISCV_ORIG_A0, &a0_iov)) > + perr_and_exit("failed to get tracee registers\n"); > + if (orig_a0 != A0_OLD) > + perr_and_exit("unexpected orig_a0: 0x%lx\n", orig_a0); > + > + /* Modify a0/orig_a0 for the syscall */ > + switch (opt) { > + case A0_MODIFY: > + regs.a0 = A0_NEW; > + break; > + case ORIG_A0_MODIFY: > + orig_a0 = A0_NEW; > + break; > + } > + > + if (ptrace(PTRACE_SETREGSET, pid, NT_PRSTATUS, &a0_iov)) > + perr_and_exit("failed to set tracee registers\n"); v4 has been sent because I found a uncommited fix for this... > + if (ptrace(PTRACE_SETREGSET, pid, NT_RISCV_ORIG_A0, &a0_iov)) > + perr_and_exit("failed to set tracee registers\n"); > + > + if (ptrace(PTRACE_GET_SYSCALL_INFO, pid, PTRACE_SYSCALL_INFO_ENTRY, &syscall_info_entry)) > + perr_and_exit("failed to get syscall info of entry\n"); > + result->orig_a0 = syscall_info_entry->entry.args[0]; > + if (ptrace(PTRACE_GET_SYSCALL_INFO, pid, PTRACE_SYSCALL_INFO_EXIT, &syscall_info_exit)) > + perr_and_exit("failed to get syscall info of exit\n"); > + result->a0 = syscall_info_exit->exit.rval; > + > + /* Resume the tracee */ > + ptrace(PTRACE_CONT, pid, 0, 0); > + if (waitpid(pid, &status, 0) != pid) > + perr_and_exit("failed to wait for the tracee\n"); > + > +} > + > +TEST(ptrace_modify_a0) > +{ > + struct a0_regs result; > + > + ptrace_test(A0_MODIFY, &result); > + > + /* The modification of a0 cannot affect the first argument of the syscall */ > + EXPECT_EQ(A0_OLD, result.orig_a0); > + EXPECT_EQ(A0_NEW, result.a0); > +} > + > +TEST(ptrace_modify_orig_a0) > +{ > + struct a0_regs result; > + > + ptrace_test(ORIG_A0_MODIFY, &result); > + > + /* Only modify orig_a0 to change the first argument of the syscall */ > + EXPECT_EQ(A0_NEW, result.orig_a0); > + /* a0 will keep default value, orig_a0 or -ENOSYS, depends on internal. */ > + EXPECT_NE(A0_NEW, result.a0); > +} > + > +TEST_HARNESS_MAIN >