From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95255C4345F for ; Wed, 17 Apr 2024 08:20:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFD0A6B0083; Wed, 17 Apr 2024 04:20:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DADBB6B0085; Wed, 17 Apr 2024 04:20:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C75286B0087; Wed, 17 Apr 2024 04:20:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AB6736B0083 for ; Wed, 17 Apr 2024 04:20:01 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2DBD0120D77 for ; Wed, 17 Apr 2024 08:20:01 +0000 (UTC) X-FDA: 82018325802.14.B263860 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id E83B71C001C for ; Wed, 17 Apr 2024 08:19:57 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fia8TK/J"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713341998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C3uroh1Ppgw+q/4v8TmwH5+NLrGopN54CehRkmgPTBQ=; b=Wka2K6cRaYM+32MC4JBDYzyiznqlmYZLE5Dp8RATc1HYT3LYqKxc8xhsJL1SuFEk34CO0j 6xC0OIdW/aU1N96/dwgB7j3DPfoUtDPHsCN1Bt4MeCPOTz7cIGw1/uEq0+o21PFK7T3mOI l+2ZKMnzEm3Ksh95M1QY8kvpaBddsDI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fia8TK/J"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713341998; a=rsa-sha256; cv=none; b=cOW4QYf/ITZf43zxEu3JMQN4JwEqabLHH3YdV16PCoJrBtkgoiwA3RkTzI9KANDg6f02Ud nP0jc1VNedudiX3whU4xIoOSWktSaeMlcUo+ZaI2IZ5GmsRH+sE6Y9jS6e6c1iKKVy82p6 isMAIzvoVLJL+7POZn8mibk3fwSeptQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713341997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=C3uroh1Ppgw+q/4v8TmwH5+NLrGopN54CehRkmgPTBQ=; b=fia8TK/JJ8rcmD0JEM87LomsT+LhajEsEeTWy0RZlS9uHuTDrzTMDNs7OH1i+gGfrDHLeQ FVZZR1F5FmrEIOHt/SotyIQxQd4WVOK6ME08RhmFwutqCpJMIH7qnf7m+u9G0h1TRgwPIt lhm6KZBGPhW6ncSrJnw/zjIowlttfZA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-QulsUUV2O8Of8GrHRiPe2g-1; Wed, 17 Apr 2024 04:19:55 -0400 X-MC-Unique: QulsUUV2O8Of8GrHRiPe2g-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-349c63ea688so197735f8f.0 for ; Wed, 17 Apr 2024 01:19:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713341994; x=1713946794; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C3uroh1Ppgw+q/4v8TmwH5+NLrGopN54CehRkmgPTBQ=; b=TCrDyRn16Eu82eB96NeEFCFx8eAPuZI/BV8HaqxVefQ8dZuSGL8RE3XhpCsDDIAmHT mXNeLRgYbUpElrhYPSAp94PPeD84HESsuChD0LGOBhoGBemDxPIWyVB5CaLDe3zaCJCV ivtYIQOK5rH0HFJLcJtfq54tZ95/7KKYIntNs9IK2bYVsvNaajsXPu6bLA+Qdtsp+0dk cf1IRgg43yIWIMNtfga/XPLBDGZIfURNVz0g5AbV+H1jhhOqshoF/7l1vLuTf/8Yitu5 0oCYFXXI9ByRD6rEVl4NxP0Z/eZb5FZ7eh5G+9HQuGcRAQuuBovPlDY/xrkdwyuGjsbo U7Ww== X-Forwarded-Encrypted: i=1; AJvYcCVxTKEteDllPbImYNhFICFP+xGQZG33qT/wKZsjyWoB+JJQ7kCoJAC+8QIid6VPkZ1ypHuLXWxbQXWj/Nk+jPWtu0c= X-Gm-Message-State: AOJu0YyjLVcchP4zs9EdHH277tLQOj3UvGs3LD8r3tAhOLlByv/UAKOr 5gugxIVFDjhwsOP98Iz2n7TirPqNYfD0ZICzHsIIewvQH+7FpHFfXCRvoG+uxE4O6Vg8+wNcPBS TfH5JQnkw/nuMfjmKQZ1mv3o7JCiBHyiUIHNee48h3U9i8fhq X-Received: by 2002:a5d:6848:0:b0:343:eb7d:760e with SMTP id o8-20020a5d6848000000b00343eb7d760emr10390446wrw.17.1713341994713; Wed, 17 Apr 2024 01:19:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETf2ergMjQ6KA+vyhRqAinL3LXN7Tts1CSKmLhBURhZhgXjLA5AV5wdTPmRI+reR6RmpI9qw== X-Received: by 2002:a5d:6848:0:b0:343:eb7d:760e with SMTP id o8-20020a5d6848000000b00343eb7d760emr10390433wrw.17.1713341994291; Wed, 17 Apr 2024 01:19:54 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:2300:653:c844:4858:570f? (p200300cbc74523000653c8444858570f.dip0.t-ipconnect.de. [2003:cb:c745:2300:653:c844:4858:570f]) by smtp.gmail.com with ESMTPSA id t11-20020adfe10b000000b00347edb20b6esm6495635wrz.106.2024.04.17.01.19.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Apr 2024 01:19:53 -0700 (PDT) Message-ID: <76d22c08-82db-4ea8-a7cd-c77589e132e3@redhat.com> Date: Wed, 17 Apr 2024 10:19:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/3] mm/madvise: introduce clear_young_dirty_ptes() batch helper To: Lance Yang Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, fengwei.yin@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com, songmuchun@bytedance.com, wangkefeng.wang@huawei.com, xiehuan09@gmail.com, zokeefe@google.com References: <20240417050426.66194-1-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240417050426.66194-1-ioworker0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E83B71C001C X-Stat-Signature: dugrqikwu59znc4zbtg7w1ghdtbksdqg X-HE-Tag: 1713341997-352651 X-HE-Meta: U2FsdGVkX19PFqRR8MZ1FbE2+RNUXRByhpHelH9kjety3iTwAESphDounvDn0X2ljThMJ6xL2QBalQ3IAcVCrIaCpjrd4GkmATCxzKZsjjaBw5KST7OPxcOWSYyTedJsKdQO0JroSdwe30aGfoiJhAbC5XbOgHAICPL9loXK52X/FVWpXcHmU0EapWv3jZdLfPYlPpkZXsP7NxUjqxXF0swYBjGjXSDmLT7ozjpNJXHb6sAeoAqe/XNGrDptOLzE7rENhUKB/58RrLeXAiVkzgMcnOX8xt8Hh6SNjR28AA1FfW3TXB0BwXzJ8xTrUk2Ayx1kZZB++zufcKXUP5NB/atZwnhZhAGsBKKiQQrhGG/8dPfaMwvPgUoUQOKPHsfuB7h9JKAZI+vYYbub0B8dH7AqqJx5JC6kZorcXykyxp9tfqqS0gTfkIR42kTUDXbWlHC2hqGQwMWd1a+1IUsYzCVJPZoNtzMbiSwVM2Du2AoZHxrfupnUvR0HIALnD26ewkZQEHE5Muu5gPoCBp1U6BJsd/iGoUinvHY+5oi8QSwDNaT2d04Q+8/vvOWKP3P8Kr9ZnVhUuCERePKfhYQNoxSlGL4QtdW0LK2hvccMeSY/sM5xRPtK6++QOgn9lHpP6rNSYKiGRxLxn+JivU6wvLw3YejfUsMx1XO2Om3/bfHIv8JHU0VE84YtlxYnvMeKbdnieEXaHKT5mbeUQGPQN4aSRLbwgyK6aEFcaLPzOuwepEZkwVF1JFKSl+6RXrz+KRAF9d34XdOU8uO7WUwIdh/5tAmssuoXqETDBE86zpKOs2a0MDJObO/rbJgrf64Wz29+26RUZYT4/La0Ik2C1Fw22MdzeJJ5/uYp+aKOykylf778vmyXlEhej02w0hj4k0bNK1BFM0uS/fFnYE7AQNPGOXb/vMUO0YFPUzK+i850PbH8JLrau9X647zOrKKBT5WGOUH3wr71z68mm64 YcBMnQLs 9wtTKkOZZnQsuBXS7jo8VdMvc8YqhpDHlcxWTQrnYx4LTWrTWzq74/DEyHnD4UPHSMVDwpGbSgWz3J2lWAPmowCx4a3Mc28mqvRn9TPrd/6bRaottXt3S+EkYgczTY0ZysaenbREFuNHmXXGu6tdcXcQ20sVgVUEEfVT3lm0JSCbzu0aylQw9fNH4HdDRVMRoTUrLaEMdjUv0I2TyfTZfJgcxwh3vjzmAFUUT2sA+W/kFlaoVd76jz31D3sMgV7GARmCgI4a/LOsSadqqDXrH2HX7f0b4+4zL1KD6XDcxh7wR1+D1LWuUoNC0VjQfjWyxFI1VmEnisYqoCM8KwAsOZnLwOBf/HIsvrAhQ02DXjJHLdm5qn8fhdhQoyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.04.24 07:04, Lance Yang wrote: > Hey David, Ryan, > > How about this change? > > static inline void clear_young_dirty_ptes(struct vm_area_struct *vma, > unsigned long addr, pte_t *ptep, > unsigned int nr, cydp_t flags) > { > if (flags == CYDP_CLEAR_YOUNG) { > for (;;) { > ptep_test_and_clear_young(vma, addr, ptep); > if (--nr == 0) > break; > ptep++; > addr += PAGE_SIZE; > } > return; > } > > pte_t pte; > > for (;;) { > pte = ptep_get_and_clear(vma->vm_mm, addr, ptep); > > if (flags & CYDP_CLEAR_YOUNG) > pte = pte_mkold(pte); > if (flags & CYDP_CLEAR_DIRTY) > pte = pte_mkclean(pte); > > if (--nr == 0) > break; > ptep++; > addr += PAGE_SIZE; > } > } Likely it might be best to just KIS for now and leave it as is. The compiler should optimize out based on flags already, that's what I ignored. -- Cheers, David / dhildenb