RE: [PATCH] Fixes, cleanups, compile warning fixes, and documentation update for Xen tmem driver (v2).

RE: [PATCH] Fixes, cleanups, compile warning fixes, and documentation update for Xen tmem driver (v2).

[Dan Magenheimer]

> From: Konrad Rzeszutek [mailto:ketuzsezr@gmail.com] On Behalf Of Konrad Rzeszutek Wilk
> Sent: Tuesday, May 14, 2013 12:09 PM
> To: bob.liu@oracle.com; dan.magenheimer@oracle.com; linux-kernel@vger.kernel.org; akpm@linux-
> foundation.org; linux-mm@kvack.org; xen-devel@lists.xensource.com
> Subject: [PATCH] Fixes, cleanups, compile warning fixes, and documentation update for Xen tmem driver
> (v2).
> 
> Heya,
> 
> These nine patches fix the tmem driver to:
>  - not emit a compile warning anymore (reported by 0 day test compile tool)
>  - remove the various nofrontswap, nocleancache, noselfshrinking, noselfballooning,
>    selfballooning, selfshrinking bootup options.
>  - said options are now folded in the tmem driver as module options and are
>    much shorter (and also there are only four of them now).
>  - add documentation to explain these parameters in kernel-parameters.txt
>  - And lastly add some logic to not enable selfshrinking and selfballooning
>    if frontswap functionality is off.
> 
> That is it. Tested and ready to go. If nobody objects will put on my queue
> for Linus on Monday.

FWIW, I've scanned all of these and they look sane and good.  So consider all:

Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
 
>  Documentation/kernel-parameters.txt |   21 ++++++++
>  drivers/xen/Kconfig                 |    7 +--
>  drivers/xen/tmem.c                  |   87 ++++++++++++++++-------------------
>  drivers/xen/xen-selfballoon.c       |   47 ++----------------
>  4 files changed, 69 insertions(+), 93 deletions(-)
> 
> (oh nice, more deletions!)
> 
> Konrad Rzeszutek Wilk (9):
>       xen/tmem: Cleanup. Remove the parts that say temporary.
>       xen/tmem: Move all of the boot and module parameters to the top of the file.
>       xen/tmem: Split out the different module/boot options.
>       xen/tmem: Fix compile warning.
>       xen/tmem: s/disable_// and change the logic.
>       xen/tmem: Remove the boot options and fold them in the tmem.X parameters.
>       xen/tmem: Remove the usage of 'noselfshrink' and use 'tmem.selfshrink' bool instead.
>       xen/tmem: Remove the usage of '[no|]selfballoon' and use 'tmem.selfballooning' bool instead.
>       xen/tmem: Don't use self[ballooning|shrinking] if frontswap is off.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[PATCH] Fixes, cleanups, compile warning fixes, and documentation update for Xen tmem driver (v2).

[Konrad Rzeszutek Wilk]

Heya,

These nine patches fix the tmem driver to:
 - not emit a compile warning anymore (reported by 0 day test compile tool)
 - remove the various nofrontswap, nocleancache, noselfshrinking, noselfballooning,
   selfballooning, selfshrinking bootup options.
 - said options are now folded in the tmem driver as module options and are
   much shorter (and also there are only four of them now).
 - add documentation to explain these parameters in kernel-parameters.txt
 - And lastly add some logic to not enable selfshrinking and selfballooning
   if frontswap functionality is off.

That is it. Tested and ready to go. If nobody objects will put on my queue
for Linus on Monday.

 Documentation/kernel-parameters.txt |   21 ++++++++
 drivers/xen/Kconfig                 |    7 +--
 drivers/xen/tmem.c                  |   87 ++++++++++++++++-------------------
 drivers/xen/xen-selfballoon.c       |   47 ++----------------
 4 files changed, 69 insertions(+), 93 deletions(-)

(oh nice, more deletions!)

Konrad Rzeszutek Wilk (9):
      xen/tmem: Cleanup. Remove the parts that say temporary.
      xen/tmem: Move all of the boot and module parameters to the top of the file.
      xen/tmem: Split out the different module/boot options.
      xen/tmem: Fix compile warning.
      xen/tmem: s/disable_// and change the logic.
      xen/tmem: Remove the boot options and fold them in the tmem.X parameters.
      xen/tmem: Remove the usage of 'noselfshrink' and use 'tmem.selfshrink' bool instead.
      xen/tmem: Remove the usage of '[no|]selfballoon' and use 'tmem.selfballooning' bool instead.
      xen/tmem: Don't use self[ballooning|shrinking] if frontswap is off.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>