From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 740E4C35274 for ; Fri, 15 Dec 2023 14:28:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3A268D0130; Fri, 15 Dec 2023 09:28:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BEA7D8D0121; Fri, 15 Dec 2023 09:28:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD91C8D0130; Fri, 15 Dec 2023 09:28:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9E4108D0121 for ; Fri, 15 Dec 2023 09:28:37 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6E905805CC for ; Fri, 15 Dec 2023 14:28:37 +0000 (UTC) X-FDA: 81569283474.01.041C1F6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 8968940011 for ; Fri, 15 Dec 2023 14:28:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702650515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P9FKTuPTVrpCJPzpaXCAPGr1/8awNXdxDC4h2EYAFHE=; b=VmCtkU5I7zsxIAM6zsjCLKaEpCskn5GSe49NdXQOHF7imdlze9SfBLFMmKDsAKgA6tr4GB eldCj6L3MFVEtY0wRbPcEql/6uaeoyLjwvMzULPa0Ran5HG+JrIbqEJvzEn1RRBptcFg7e /SugO5oXWEZHe5SZJNP1OQI+z0KmHIc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702650515; a=rsa-sha256; cv=none; b=S/ygGNewjNhp20UNJrU7M7AqviIonI9jMd7miLl7ciaFqhj7zpA2fxAJrCgC/Xxr1KEK8b bUzjIlTPWlfhRkTbtO6t4SChZqBsFQYINTt04Kym1cva6l5YxiUQZfLmUXQu5mQIn3xWg0 GZU/+ptbcdFmZCLiQjAZcywdz/9eTiw= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E751CC15; Fri, 15 Dec 2023 06:29:19 -0800 (PST) Received: from [10.57.76.37] (unknown [10.57.76.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B82363F5A1; Fri, 15 Dec 2023 06:28:33 -0800 (PST) Message-ID: <76abe3b9-3f66-4336-b09d-d5c137ff6582@arm.com> Date: Fri, 15 Dec 2023 14:28:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] selftests/mm: Log run_vmtests.sh results in TAP format Content-Language: en-GB To: Mark Brown Cc: Andrew Morton , Shuah Khan , Peter Xu , Aishwarya TCV , linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20231214162434.3580009-1-ryan.roberts@arm.com> <71228821-cbd3-4a3c-9ed5-18f6d5ebcfc0@arm.com> <07193932-941d-46f6-b152-d6c5fe09b26b@sirena.org.uk> From: Ryan Roberts In-Reply-To: <07193932-941d-46f6-b152-d6c5fe09b26b@sirena.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8968940011 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ogagarpcm685wgj4ronx76dprnpgiwam X-HE-Tag: 1702650515-457746 X-HE-Meta: U2FsdGVkX18YNQaadOY8WfEqmp1dqtwnoQ2xBi4f1/IXjxv9dAbVsCgeLUfAKPcSC+vRRVb77lLdj+0X6KhRi8CPBAQsY3Gc9f281cRzNiLJI2OcwzzDeWpskEAqNDOkPxnYI8kJd1VvOHi/G2wuZx/U7rniYE1OltBoGeG5TKBSreirQDErV4kcYmtIzrOzPNmTkdiA+mK0ihFizZalRnpPmixkoQ2ZtsSn2iH9uKGDPtC+M7eoF2VKdZPGybIJyGqAkwE/zub4hWibXjZoS82jQiJ/wzRoBWY2par2mYoxO+GSWN5AEthv8+nl1vH2sXveChKISKQKPlyGvwRelG/bUAhwX6mvrdjKRZe5ZWJlmhXUcTLO07zl9uCMd6RMzPxPEfLm11SYODKdTBtAjklrw9/IhVSYbjYlj3KirafvbJvzU6H37ZoMgvDDaRSDXuBbZzovlBAMrpU5DjtkUp8NnWkhkdeXCnIYI0RXmZ9Rhkidwmp2JUY6IOVEpSQAbnIxZUCexVBfpdtLjsjn3RPP7QQQFIX2OLPAQqTmKF2zUhUlcD+BhBPB3nwRdAhrsHyLygKNVNJJLs9ndtiAaR8i5AkB0Bgj2J33hSvVMUoseiMjR0czX4hwpMR4s4fJ6Ke4beJImdcRStmalr50RlBMnzFl2OsGW0aHLpwU8peCAO09FLLKy4y3Qamr2FJXPMSbYMMgKQO7IhGlEHbLYBn2zCw/oFzHfMVQqSc/GAWzfBMw472DhTFhpTC55SPBGeVMU5FlbmDTL5ZabexVd6bkFo+MZhhnC+HrW85np2jhj2Vgxh7IfGuec6CxetV8Q/mloOieRRU3iHQ7jj9m1PPma7nIoUjjewkPY06qPV415KAQ/JR4IZ/Ma+juhoWcMFPAHvvHjyo6pzdjPTjeZvG9+muXFW0F0PwxfbKJj7nTATUxYsoBXBf/sClLmLZAwiYpxOvxgVI8e44JQsI CHA5nnhP 2GXiKydxYJxoeii7w2ye2YZVZauLTdK87vtoPtgwvrAOAXmE1oGu2XvaWanliLVsAeV3IoIl1gLgGm4UkHKJuTemfK9sdHMTC0cVXxAaH9FVTsni43tN2zujE5mpJyTpUIdCx7lGveJYLfbjZThl/5lyTpihozcrzGSTipNK32B879XbcFih1P0tXhwh6BMpSk8R9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15/12/2023 14:08, Mark Brown wrote: > On Fri, Dec 15, 2023 at 01:58:45PM +0000, Ryan Roberts wrote: >> On 15/12/2023 13:54, Mark Brown wrote: > >>> What I did for ftrace which had a similar situation was make a wrapper >>> script which invokes the test runner, make the test runner a >>> TEST_PROGS_EXTENDED so it's not run by the kselftest infrastructure >>> automatically and make the wrapper a normal TEST_PROGS. Neither option >>> is especially lovely. > >> Yeah that's a good idea... I'll wait and see if anyone shouts that this has >> broken something. If nothing is broken, I think it is better to just make TAP >> the default rather than adding yet another wrapper. > > I think it depends a bit how ergonomic the non-TAP output is for > interactive use - TAP isn't amazing for humans so if there's something > that's nicer it probably makes sense to keep that as the default. For > these tests I'm not sure it's particularly an issue. I've kept all the existing "pretty" output and results summary as is, it just gets a hash in front of it when TAP is enabled. so this: ----------------------- running ./hugepage-mmap ----------------------- Returned address is 0xffff89e00000 First hex is 0 First hex is 3020100 [PASS] SUMMARY: PASS=1 SKIP=0 FAIL=0 becomes this: TAP version 13 # ----------------------- # running ./hugepage-mmap # ----------------------- # Returned address is 0xffff89e00000 # First hex is 0 # First hex is 3020100 # [PASS] ok 1 hugepage-mmap # SUMMARY: PASS=1 SKIP=0 FAIL=0 1..1 If you think the latter is ofensive, then I can do the wrapping as you suggest.