From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0167C433EF for ; Tue, 17 May 2022 03:49:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23B188D000D; Mon, 16 May 2022 23:49:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C5238D0003; Mon, 16 May 2022 23:49:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03DB68D000D; Mon, 16 May 2022 23:49:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E45098D0003 for ; Mon, 16 May 2022 23:49:08 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id AFC16121213 for ; Tue, 17 May 2022 03:49:08 +0000 (UTC) X-FDA: 79473854376.19.233FE8F Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf02.hostedemail.com (Postfix) with ESMTP id AB47580012 for ; Tue, 17 May 2022 03:48:58 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id t25so29102416lfg.7 for ; Mon, 16 May 2022 20:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=lGiz4p3kxgbMH9lusf5BWvhTcTAA3XuA7I+cyo20aFU=; b=KGPssm/7bmpN1DTbVssXvg9tm6OfO3jm9NFcr2pufN/1/sLBZUGaDWghu23RRa/0Zn x/x0exYJZInOQCGV9Lxc8XiA7JL10BxrgMGhO/zAwUYwkfbY1IVdTtrz9bYhCYkyhBCM VqeWzGjmxZalZh6UDw5GOE69mpmcAFuYsicwAbdaR8+roNrFH7Cz1dqO8BAreDSGyEaJ QZ3KjARK6ZBMibp6AMrxKzm9s24jI+xrU/rFGdu249zu75LTLWKiaffd3YiYHxmQVX8h ECfhmLQ4NXgBHPBctbSBq3ZcV+TiCjSxE9p46x6mG03JYiBu6nGbDPH++ZvXu0AagmZ0 WdQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=lGiz4p3kxgbMH9lusf5BWvhTcTAA3XuA7I+cyo20aFU=; b=dMLaLsi8k4hyJKqqyKoqqcouHvC42EQIS9Uf+ZGGoe8bFlLvrBMVp3xFgoz3uR/PyQ EjNdLQrTaFpbm27pCN/oYSrHlD5F3vrZt8Bc1Vi5MOkUfjb0rum+qsN5pC20kIKoYoDb /KI7qCm0eCv+7vqJmjJ+AvrAgeZzV7KrgDSinRu8mWYhGe6YpvhmNb1Qkz5llRgh5A1B 3pG1U8e2ZfJFZtyt4zFKs0C8cktvLkjHsSjHiwcQOKcIFb5P8tLCl+JqtLOZqcY8ZO9W 5sAXxNC56mhLOtXbBo+QPhof3mXKNUdHeT+xjxPdNX5rQcgyKF/FVDOzo4E8MjOi/m0L Idmw== X-Gm-Message-State: AOAM532UPpGkBCEB9hR6n/+sFSAw3rIsqZqplYaXEwTrubOSPqhURmLd KM5rKnmj4nrnnyNDSNb10wi+pg== X-Google-Smtp-Source: ABdhPJxOHUcBQrR1cJ96BRB3ARHbqZ3B+VU/xSoanrIBMJQJ59fSC2XfpV+rK/KpaxxjhuCX0GtHMQ== X-Received: by 2002:a05:6512:3f13:b0:464:f55f:7806 with SMTP id y19-20020a0565123f1300b00464f55f7806mr16024479lfa.598.1652759346146; Mon, 16 May 2022 20:49:06 -0700 (PDT) Received: from [192.168.1.72] (46-138-221-128.dynamic.spd-mgts.ru. [46.138.221.128]) by smtp.gmail.com with ESMTPSA id 27-20020ac25f5b000000b0047255d210desm1468420lfz.13.2022.05.16.20.49.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 20:49:05 -0700 (PDT) Message-ID: <768859b4-5cae-4e16-1d9c-8b78a7b36ced@openvz.org> Date: Tue, 17 May 2022 06:49:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] tracing: add ACCOUNT flag for allocations from marked slab caches Content-Language: en-US To: Roman Gushchin , Vlastimil Babka Cc: Shakeel Butt , Andrew Morton , Joonsoo Kim , David Rientjes , Pekka Enberg , Christoph Lameter , kernel@openvz.org, Linux MM , LKML , Michal Hocko , Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <1fd21e25-b095-e055-fc2e-abda640a0575@openvz.org> <8eccb3bc-e6b1-354b-e1de-bd3d896dcb35@suse.cz> From: Vasily Averin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: AB47580012 X-Stat-Signature: mpjjub9peu4oddaiorqkyoyd5umagk5p Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=openvz-org.20210112.gappssmtp.com header.s=20210112 header.b="KGPssm/7"; dmarc=pass (policy=none) header.from=openvz.org; spf=pass (imf02.hostedemail.com: domain of vvs@openvz.org designates 209.85.167.50 as permitted sender) smtp.mailfrom=vvs@openvz.org X-Rspam-User: X-HE-Tag: 1652759338-659950 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/17/22 01:08, Roman Gushchin wrote: > On Mon, May 16, 2022 at 11:41:27PM +0200, Vlastimil Babka wrote: >> On 5/16/22 21:10, Shakeel Butt wrote: >>> On Mon, May 16, 2022 at 11:53 AM Vasily Averin wrote: >>>> { >>>> void *ret = slab_alloc(cachep, lru, flags, cachep->object_size, _RET_IP_); >>>> >>>> + if (cachep->flags & SLAB_ACCOUNT) >>> >>> Should this 'if' be unlikely() or should we trace cachep->flags >>> explicitly to avoid this branch altogether? >> >> Hm I think ideally the tracepoint accepts cachep instead of current >> cachep->*size parameters and does the necessary extraction and >> modification in its fast_assign. > > +1 for fast_assign > > Changing flags just for tracing looks a bit excessive. At the kmem_cache_alloc and kmem_alloc use the same tracing template. Ok, I'll try to redesign this.