From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB79AC021A1 for ; Wed, 12 Feb 2025 10:04:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 236476B009E; Wed, 12 Feb 2025 05:04:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E5416B009F; Wed, 12 Feb 2025 05:04:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 037A36B00A0; Wed, 12 Feb 2025 05:03:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D07036B009E for ; Wed, 12 Feb 2025 05:03:59 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 865FB1416CC for ; Wed, 12 Feb 2025 10:03:59 +0000 (UTC) X-FDA: 83110856598.03.17DC90E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id E3B0240012 for ; Wed, 12 Feb 2025 10:03:56 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="i4/MYExZ"; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739354637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XhcLq7P4Ch3DQ7dn4Jx+o/CtEDt+sdWbj2x/uM/C/sw=; b=2XF1bjXpbP4Dh9c/EoGNwViSyLZqpVt/iv+G1TPZD79fA9EEQ0HQJHQeSqtCoN3HsPIwto GpB+WoPcZXTc4gRP6/1gJBeJ2NZPCTL/dWME7iT/x0tPfCCNsJAQLqp/O3Bf5rAKp4Ucmv 3p/C+zR4/TjHS4QTs3FtPubsfMgZGp0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="i4/MYExZ"; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739354637; a=rsa-sha256; cv=none; b=ES+7ovQ4M61CAZGydcOpMyFEAoVIQHARlX37v9zhx9IDbRCRJ8Wyb+aNsUvw+G84eZNEaB tmos4AJN9iS7qHS1RhQlRtyE4qpJQzlWZtNh7OBc+CVbEIfrbZfMkVuMtYORJnNMjWwmWL TCODMe2rTVy7gMBPKCXftazWElHvkNU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739354636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XhcLq7P4Ch3DQ7dn4Jx+o/CtEDt+sdWbj2x/uM/C/sw=; b=i4/MYExZrOPciuDntssTOtBPw4PWGv47bo9bYMorLK4JQR2WLjH1Lop2Rq/6rG9fHIdvi7 Sx3V45lhZ2PQjsAvUf//p1KXVGjw1zUMAem6BSViNRoOELE6HHlh4r4Do3FoaI8xZlSbyB jMnoKnxkSMhVARnTzkJizd5Wykk6ZXk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-508-EVB76ObbOIu1lehor79u7g-1; Wed, 12 Feb 2025 05:03:53 -0500 X-MC-Unique: EVB76ObbOIu1lehor79u7g-1 X-Mimecast-MFC-AGG-ID: EVB76ObbOIu1lehor79u7g Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4393e8738b3so24444235e9.0 for ; Wed, 12 Feb 2025 02:03:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739354632; x=1739959432; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XhcLq7P4Ch3DQ7dn4Jx+o/CtEDt+sdWbj2x/uM/C/sw=; b=SJ1axgbbtwx+Dm9ZJ2dvn6qTdgK/+v2fBWfuHw50puMqnnggBViVaqaBBR/SRNufZk nC345P8l9K9aDKY7COldtHX+L82SP+uYutk2y9GrO75iiPBoJ9qJ/5/IDiBJ4lSGt5xr +rF3CpFCF9GlIhpncbRZzoLnWcAjPImR+vRPUz0pdPDkgJhsWazwXyDiv694AwL63dTa vuKlgpMQG3oTErpotWYUfIvcGOuUjN0PQ3uFKkCliJUm3KgVHRvb8cIVO2cYzVu9cy3Z MU0l8WmkUXOGhOsIadXO98JcRIYuCWCSiVxwySo1sbKuojS6Jlur2UXOySIWHNMm1jjY mmZQ== X-Forwarded-Encrypted: i=1; AJvYcCWPHoy2+wY/bZNI7fWoQM/xH10mo4yE2lQknS6tuoJBGH363ws4ANrLpL4YXNA9O4tlBi+CKIYk1g==@kvack.org X-Gm-Message-State: AOJu0YzcwB8MJUpw42v1ZlbzbkgfT8PK6e5jDxgF8xh3gpvASu4qwPM3 eylszMza1vt/F4MOXMWkQ+mKyOdQMiW6lRC33jEOU2C7yZHEn7IkBMlUZ8Y9lBA5hC9E3lw3/7S wkvwxPicFWdHzKAfPb7G+7aIykrDRrD5StlNCVY/LmAePB+T1 X-Gm-Gg: ASbGncvojSuaxY7orciCdGfo/63+rAm/K/2vammVftnNilHHtmu7R7FB57VZIzEi+1A IhGJpBn7OtwYu0L7pfephipeYZRrFHajNvz8bZNXFvh28cAs7uyV8/A9iweeM7g5M4QTo606vf7 wrUGzrr+y4x/GBbt+E/cKiT7YjqjV91xjwDT2cIogmyQyI7KBrt8aC0AlVjJvH/AnYkxlxwuuiJ fhyUZ/q+UgbqgVHehvrYjtqRQcWKA8sewfV/aWgTW8TbyqNZx2tT+YZFwf+9sSqdd2FZNLPsnaP Vdt/y1ZQ4j7daZEwY0++Ejjh0Jcj9FBGJV5XFs0Z6DwBpS9mXJhpgOHTyHiGRXBrxDzsRTpuAmA qSzavCNGDSJSIPSLTJJ3EOnd5emYQZw== X-Received: by 2002:a05:6000:1545:b0:385:fc70:7f6 with SMTP id ffacd0b85a97d-38dea259d2emr2048292f8f.7.1739354631649; Wed, 12 Feb 2025 02:03:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFxHugYw/Iqt4sZwd2Za9Fpbi+YkAs0W8EwjLNYkgkhaittEQxLCt4uAmlk3fQTkjKrZQJcTQ== X-Received: by 2002:a05:6000:1545:b0:385:fc70:7f6 with SMTP id ffacd0b85a97d-38dea259d2emr2048255f8f.7.1739354631180; Wed, 12 Feb 2025 02:03:51 -0800 (PST) Received: from ?IPV6:2003:cb:c70c:a600:1e3e:c75:d269:867a? (p200300cbc70ca6001e3e0c75d269867a.dip0.t-ipconnect.de. [2003:cb:c70c:a600:1e3e:c75:d269:867a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38e0e7abd1csm1148405f8f.43.2025.02.12.02.03.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Feb 2025 02:03:50 -0800 (PST) Message-ID: <76537454-272b-4fbb-b073-5387bbaaf28d@redhat.com> Date: Wed, 12 Feb 2025 11:03:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v4 1/3] mm/filemap: add mempolicy support to the filemap layer To: Shivank Garg , akpm@linux-foundation.org, willy@infradead.org, pbonzini@redhat.com Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, chao.gao@intel.com, seanjc@google.com, ackerleytng@google.com, vbabka@suse.cz, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, Shivansh Dhiman References: <20250210063227.41125-1-shivankg@amd.com> <20250210063227.41125-2-shivankg@amd.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250210063227.41125-2-shivankg@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lGZaZ_oZTQWrC4qhiiobo0PdGR2CsVdCTaJohN5Z3j8_1739354632 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E3B0240012 X-Stat-Signature: bpc6pn8bq99zsoe8isx8nzq6sf1cjs6w X-Rspam-User: X-HE-Tag: 1739354636-789899 X-HE-Meta: U2FsdGVkX18oE+gfvofRZ+PE4Mjb74RoOm+e/2TAQDW+ABi53gzE+Njs0veYE7BhYz7qoNVwtIGvuHsyQiBuiAac38RXE437JUyEo3k3em21acHFwSEtz+1zq3T4U6J9/9kDhugxQQ65O4pyrvR63EdyjPtc29ZnpxEFmIBUtd/M1R1lR8o4Y2hLHwRSNSBoWODonbCeTS8du5KaBW3soBze5jJ4QIdBal7wbVSgABS7kGk2bGOJGg0xn8DS2/WjNLJL2pVqOb8wy+YvH9TrG5md5NvPHo0cg81PdyjvPm2KM4yiTkmA5sm0Sen/Xq2mFYj/Cmo9nSblg1pq/HIpIiByvK8iIc0QxPUV8WFvr1A5V+IqKYTzh5QqhXQbdAP+ItfgH3XHRtYklttWIfJpUX3LMF6hVRv2bOnbz8Imz6k3GlSTv3cFo8fL0vz6309j6kr5yN77nOHV7zNxW6EjGYRGCvVSSZKvJGV1pwkgX4veAp2wmUYAEO1/RVih8nHdAEWbq9/4UrqaLaWOESTV9vJErQ53uVZzA+5sgQS6MP2XEL69RbLYSREkg1wDyVBkKQIJblT8cr0zslwevTj+H7rf6jvMC1nEy4b+M2Bjm7Lq1r4YskjSoaoEf5BUS/FkMJQhejEQ0Hop39XtmhHtm8+L9XaXTLT2XX11cZlXEGQbWZQeRByVjGN+WVgTIYuFBjmLnYlY119WF0TZCzQ+L7fYY9rm+vCxrIcSOOXk6PmGEp8em8OhF1MsKkH8zuOk9Wrm/J24LSpN+Ym/DajdMnNVqU9XpckcHE6xp/V1R+m0fzqPzBSVxcVuTGb/3118d2FE7Awp5HkQUqN/7QPXchbAfEcTeCqWUZyN60NYN0TwjcN09cBzrmDWkVyeIfwjBcdoU7+gfMoUT1H06JdXJIFtZWbmdTvC+Le4EPWAme2CKqHpHOJd/DtcfCLZXpKibcx5k27Brbo0cXFasFz PSeTvhhw /ICF3TeNwIItVJbgd5hyEM308U4sFZvXyXGxWwKGU3xhRcz3a3ACw/8gL50r0Ze/sjKhI9h95HzEe9V0lziwKGIcd7xtIPGIHzyH7wk82QdOclJP4+zaKfgvgAN46x23HKGROZ771mae8KPB5uREVu5oC5HFuWvKV4Z/3ZdgYqlUS8Y4kyVi84Yrg4F3ly9Y8nLJjbvJ/ueFC9Lkuqvk66LcrE9s63rzgYMcG9s19lRiEe1UYieqRJ4EtUzHJUEXwRRfaJ66qzWKtz08p9oFrKwIisbM5SD6ge3JWuK+hUGiy2cuD6KLFpYHchxLdlvv8LIn/FuVOt3aj0Spx8oyRgk9SYOeVAKIEGBCU8TLFSY63zHE+MLkfdPkUAr15STZUKMxVQqhZ9QykkwuPlv1LqlLNlnXyJO0gP+rcztkSKjZ2sCU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.02.25 07:32, Shivank Garg wrote: > From: Shivansh Dhiman > > Add NUMA mempolicy support to the filemap allocation path by introducing > new APIs that take a mempolicy argument: > - filemap_grab_folio_mpol() > - filemap_alloc_folio_mpol() > - __filemap_get_folio_mpol() > > These APIs allow callers to specify a NUMA policy during page cache > allocations, enabling fine-grained control over memory placement. This is > particularly needed by KVM when using guest-memfd memory backends, where > the guest memory needs to be allocated according to the NUMA policy > specified by VMM. > shmem handles this using custom shmem_alloc_folio()->folio_alloc_mpol(). I'm curious, is there (1) A way to make shmem also use this new API? (2) Handle it in guest_memfd manually, like shmem does? > The existing non-mempolicy APIs remain unchanged and continue to use the > default allocation behavior. > > Signed-off-by: Shivansh Dhiman > Signed-off-by: Shivank Garg > --- > include/linux/pagemap.h | 40 ++++++++++++++++++++++++++++++++++++++++ > mm/filemap.c | 30 +++++++++++++++++++++++++----- > 2 files changed, 65 insertions(+), 5 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index 47bfc6b1b632..4ae7fa63cb26 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -662,15 +662,25 @@ static inline void *detach_page_private(struct page *page) > > #ifdef CONFIG_NUMA > struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order); > +struct folio *filemap_alloc_folio_mpol_noprof(gfp_t gfp, unsigned int order, > + struct mempolicy *mpol); Two tabs indent on second parameter line, please. > #else > static inline struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order) > { > return folio_alloc_noprof(gfp, order); > } > +static inline struct folio *filemap_alloc_folio_mpol_noprof(gfp_t gfp, > + unsigned int order, > + struct mempolicy *mpol) > +{ > + return filemap_alloc_folio_noprof(gfp, order); > +} Dito. > #endif > > #define filemap_alloc_folio(...) \ > alloc_hooks(filemap_alloc_folio_noprof(__VA_ARGS__)) > +#define filemap_alloc_folio_mpol(...) \ > + alloc_hooks(filemap_alloc_folio_mpol_noprof(__VA_ARGS__)) > > static inline struct page *__page_cache_alloc(gfp_t gfp) > { > @@ -762,6 +772,8 @@ static inline fgf_t fgf_set_order(size_t size) > void *filemap_get_entry(struct address_space *mapping, pgoff_t index); > struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > fgf_t fgp_flags, gfp_t gfp); > +struct folio *__filemap_get_folio_mpol(struct address_space *mapping, > + pgoff_t index, fgf_t fgp_flags, gfp_t gfp, struct mempolicy *mpol); > struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index, > fgf_t fgp_flags, gfp_t gfp); > > @@ -820,6 +832,34 @@ static inline struct folio *filemap_grab_folio(struct address_space *mapping, > mapping_gfp_mask(mapping)); > } > > +/** > + * filemap_grab_folio_mpol - grab a folio from the page cache > + * @mapping: The address space to search > + * @index: The page index > + * @mpol: The mempolicy to apply "The mempolicy to apply when allocating a new folio." ? > + * > + * Same as filemap_grab_folio(), except that it allocates the folio using > + * given memory policy. > + * > + * Return: A found or created folio. ERR_PTR(-ENOMEM) if no folio is found > + * and failed to create a folio. > + */ > +#ifdef CONFIG_NUMA > +static inline struct folio *filemap_grab_folio_mpol(struct address_space *mapping, > + pgoff_t index, struct mempolicy *mpol) > +{ > + return __filemap_get_folio_mpol(mapping, index, > + FGP_LOCK | FGP_ACCESSED | FGP_CREAT, > + mapping_gfp_mask(mapping), mpol); > +} > +#else > +static inline struct folio *filemap_grab_folio_mpol(struct address_space *mapping, > + pgoff_t index, struct mempolicy *mpol) > +{ > + return filemap_grab_folio(mapping, index); > +} > +#endif /* CONFIG_NUMA */ > + > /** > * find_get_page - find and get a page reference > * @mapping: the address_space to search > diff --git a/mm/filemap.c b/mm/filemap.c > index 804d7365680c..c5ea32702774 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -1001,8 +1001,13 @@ int filemap_add_folio(struct address_space *mapping, struct folio *folio, > EXPORT_SYMBOL_GPL(filemap_add_folio); > > #ifdef CONFIG_NUMA > -struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order) > +struct folio *filemap_alloc_folio_mpol_noprof(gfp_t gfp, unsigned int order, > + struct mempolicy *mpol) > { > + if (mpol) > + return folio_alloc_mpol_noprof(gfp, order, mpol, > + NO_INTERLEAVE_INDEX, numa_node_id()); > + This should go below the variable declaration. (and indentation on second parameter line should align with the first parameter) > int n; > struct folio *folio; > > @@ -1018,6 +1023,12 @@ struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order) > } > return folio_alloc_noprof(gfp, order); > } > +EXPORT_SYMBOL(filemap_alloc_folio_mpol_noprof); > + > +struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order) > +{ > + return filemap_alloc_folio_mpol_noprof(gfp, order, NULL); > +} > EXPORT_SYMBOL(filemap_alloc_folio_noprof); > #endif > > @@ -1881,11 +1892,12 @@ void *filemap_get_entry(struct address_space *mapping, pgoff_t index) > } > > /** > - * __filemap_get_folio - Find and get a reference to a folio. > + * __filemap_get_folio_mpol - Find and get a reference to a folio. > * @mapping: The address_space to search. > * @index: The page index. > * @fgp_flags: %FGP flags modify how the folio is returned. > * @gfp: Memory allocation flags to use if %FGP_CREAT is specified. > + * @mpol: The mempolicy to apply. "The mempolicy to apply when allocating a new folio." ? > * > * Looks up the page cache entry at @mapping & @index. > * > @@ -1896,8 +1908,8 @@ void *filemap_get_entry(struct address_space *mapping, pgoff_t index) > * > * Return: The found folio or an ERR_PTR() otherwise. > */ > -struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > - fgf_t fgp_flags, gfp_t gfp) > +struct folio *__filemap_get_folio_mpol(struct address_space *mapping, pgoff_t index, > + fgf_t fgp_flags, gfp_t gfp, struct mempolicy *mpol) > { > struct folio *folio; > > @@ -1967,7 +1979,7 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > err = -ENOMEM; > if (order > min_order) > alloc_gfp |= __GFP_NORETRY | __GFP_NOWARN; > - folio = filemap_alloc_folio(alloc_gfp, order); > + folio = filemap_alloc_folio_mpol(alloc_gfp, order, mpol); > if (!folio) > continue; > > @@ -2003,6 +2015,14 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > folio_clear_dropbehind(folio); > return folio; > } > +EXPORT_SYMBOL(__filemap_get_folio_mpol); > + > +struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > + fgf_t fgp_flags, gfp_t gfp) > +{ > + return __filemap_get_folio_mpol(mapping, index, > + fgp_flags, gfp, NULL); > +} > EXPORT_SYMBOL(__filemap_get_folio); > > static inline struct folio *find_get_entry(struct xa_state *xas, pgoff_t max, For guest_memfd, where pages are un-movable and un-swappable, the memory policy will never change later. shmem seems to handle the swap-in case, because it keeps care of allocating pages in that case itself. For ordinary pagecache pages (movable), page migration would likely not be aware of the specified mpol; I assume the same applies to shmem? alloc_migration_target() seems to prefer the current nid (nid = folio_nid(src)), but apart from that, does not lookup any mempolicy. compaction likely handles this by comapcting within a node/zone. Maybe migration to the right target node on misplacement is handled on a higher level lagter (numa hinting faults -> migrate_misplaced_folio). Likely at least for anon memory, not sure about unmapped shmem. -- Cheers, David / dhildenb