From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77B5AC5B552 for ; Wed, 4 Jun 2025 08:12:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14A356B0563; Wed, 4 Jun 2025 04:12:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 121E66B0566; Wed, 4 Jun 2025 04:12:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 011466B0567; Wed, 4 Jun 2025 04:12:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D48316B0563 for ; Wed, 4 Jun 2025 04:12:49 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 77ADA1A0AE8 for ; Wed, 4 Jun 2025 08:12:49 +0000 (UTC) X-FDA: 83517002058.09.B56FCA7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 31A6980004 for ; Wed, 4 Jun 2025 08:12:47 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VWaHO4hw; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749024767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wvgVOukUEEpNaUkwE3gsYqCFfAQ70mfdaWg/jB4/Ezc=; b=mob34avvQLRvogC1zDYSPG41IBKwKzEbtKyyMlDGWOcHOUwarCx0Mt93TsFpnKwkHAzImb erEyyk1sVTVt6Sal/IdCjvVpS7iabg+04BtaYNTXr89QITD/bh2qChk5SaXQ/R1V3ybgI4 4FahAVmeWr75SIyhuJSii830NDwIB6k= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VWaHO4hw; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749024767; a=rsa-sha256; cv=none; b=1VGShAsyB3HeL6zyR7nacvcPDHrQT8kreh7RXmBnhR5mfmNoaRX3RXqSihoOppgCdAWj/f mLn5+VxZJNoy9Jv8HDZA8luxAgZND6Qk/JPXME9DXcmZGbPd8qYv8a+BecPmMnHFKm/Sej r+erNH+AxZY7sGGZJurZVeP/7MU9MuQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749024766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wvgVOukUEEpNaUkwE3gsYqCFfAQ70mfdaWg/jB4/Ezc=; b=VWaHO4hws27QArKyeUeOQcLcHjWNqDbTisv5nj8YwADYIbgFH4hOdB8v10F7Z24xmSqLlH 1EWwHkNb9KPuW0lTcR5NrLE0qd8nc6moDjLslZWOUFngPLgmt6ZG0khODxg+pQkoc4WsSE ZqGyDE4PcVdu4AtCqdxePP04dHkR4hw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-rSOX0n5UNcqtuKKjwvXqyA-1; Wed, 04 Jun 2025 04:12:43 -0400 X-MC-Unique: rSOX0n5UNcqtuKKjwvXqyA-1 X-Mimecast-MFC-AGG-ID: rSOX0n5UNcqtuKKjwvXqyA_1749024763 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-451ecc3be97so5675055e9.0 for ; Wed, 04 Jun 2025 01:12:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749024762; x=1749629562; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wvgVOukUEEpNaUkwE3gsYqCFfAQ70mfdaWg/jB4/Ezc=; b=cNzhZOw9OglQ2fsVklQmTbEXdHyEkO/Bxyb67rQL0gVnpOSe+BN2LDwDhnsfLtr0Op lU3gZTGcErRoBAPTs9Fo75bm+rYGGkGYGS/eJm6qQX4BfH/FEby5RnvbSNmuT7gcUmRY x3TsHp02p9tsFOB1Ohtoxz3XGj7nGUfkjCJiUbmLgIdP9sqvRJlbIigcGRRik0qUNk5T VdBS7Kiw4rlOpMayEkvgQjE9bHvoeSRDdu84mJnDRC+oid4hWR8b4mT+WiSu1D8ZnMsj CMYP1dLZMzRJwu9OqXEzgvfEtKSY31iL83yZy1UEAAc5SV+xtG/qCnV9LvjUBol/qEvj jqmQ== X-Forwarded-Encrypted: i=1; AJvYcCVQacb/5zEnyyFscJdfjHFHwEZzO7MekdoSavRS7hGNNiWfHXtp5CQ1SIvVctTj0J7X8kfHmrR/fg==@kvack.org X-Gm-Message-State: AOJu0YzafB1q8hdttmLVIY/RYUSAglIbztsKgkO+UkzIxphAA9IMFsLG 6yKyZp/lDeYUHkons64yIsHXA62ymP+lRNBALktBBakJQ+4j7WcDYxu2vA51gB4syrsT7gzO1Qj 57tfYtmIMb0p1EKXf9G2CbLwu2Ds+vHpexwCXWeMyef25ISqzLJ68 X-Gm-Gg: ASbGncsYrfEwISNkhYgfDKt0/BdMPCyUI/2FDYVW6XrbLco7SYO2/FIFIHsvwBEqRHh r6hf5K8K380WrXa8+e/HPaKGt3dm+muzKaJTD3ykZrkBZfkN95r5bv+Rj/dYh/UwiG+LHq+barS flSs8HTFCWt+20dvKAxaQXOAXaRloA0HU7u05yrVzl4V7Qx+nOyRMzfck7UfrDhnXYmVvWa6OLl yKrjGgB+TdEbRilMipc5PdbUGVMbuqZqVv8unQ4hEKfLb/P2CHZQWbQa9hk713bFFwFNpoi/HO2 fAHTzcNvgrQBvIQAn5z/H57dGnkthYmEEm7M7jVNs7m87S7PPMwMkF0+v4YUUVS106K1uVHXv3g 6akrRtiaCERBkLSFPN/Aw+ghoYLEsXuCANQGzcchjsOnPikUoJQ== X-Received: by 2002:a05:600c:1c9c:b0:43b:c0fa:f9dd with SMTP id 5b1f17b1804b1-451f0f9ed22mr12282475e9.25.1749024762563; Wed, 04 Jun 2025 01:12:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFzb/FDz43e8wFgbzlacj4yn5C2qA7eJyJaco03PXI5pILsFZJQX31j60ijcZDaWL3tTDSZDQ== X-Received: by 2002:a05:600c:1c9c:b0:43b:c0fa:f9dd with SMTP id 5b1f17b1804b1-451f0f9ed22mr12282135e9.25.1749024762069; Wed, 04 Jun 2025 01:12:42 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf? (p200300d82f1bb8006fdb1af24fbd1fdf.dip0.t-ipconnect.de. [2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7f8edebsm188022035e9.6.2025.06.04.01.12.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 01:12:41 -0700 (PDT) Message-ID: <764d452d-446a-4b5e-aa03-e0d901126931@redhat.com> Date: Wed, 4 Jun 2025 10:12:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] mm/pagewalk: split walk_page_range_novma() into kernel/user parts To: Mike Rapoport Cc: Lorenzo Stoakes , Andrew Morton , Barry Song , "Liam R . Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Muchun Song , Oscar Salvador , Huacai Chen , WANG Xuerui , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Jann Horn , loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org References: <20250603192213.182931-1-lorenzo.stoakes@oracle.com> <51ec4269-b132-4163-9cb5-766042a3769d@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XOiDcA4vN85gamv5RrN8dXEfSeMe595tVJSdpQb2eJ4_1749024763 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 31A6980004 X-Stat-Signature: fjboq8r4bmxc6eu8wqizdi93qjqt91r6 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749024767-655392 X-HE-Meta: U2FsdGVkX18pHX7Qgn5sZ9H3t/veC6p83sJjdE9+zeBq7aUdgAq6DVgqlhEKQ3v2tohDG1iuCBAT4Av3hosLtdHL18/d05rp72t5ecyaYVIThNJNGahRrAzqHIuLqWw/GggyZC67lj+DA0qb/LHFkqwGRchiSvyPNRZ/0mZ5zWbBqFiq13nZRp0gR828M3wkmjMb7ud5bf73xsAB570HxRFWHGEjGMN01CD5H0YN3oUc0Kh9Y+Rsyp9166rhRHSmL3wUxfONdWloFIfMp9TTisuFS2U7mR4gSukwCA6g0DHmnONimwbe/UHAJ+W0Y531UKb/rOzZIJJRihCuBE9rfHYhSUEziOoZeSMtroteZldZNHwN/XQu5tVDXpX1WEJUagG6YWNql2vc03lWjfnnn6eJZUo9qfAA5Eo8QX1RuxY7E+d84+XFnblcVmcnxQchpK51aXpPFXxbjuJH0WfBt/p0OoKjcfsZV4XARiuJRwWs545y4tAZQdniydPnz2FQ5ae/Vcw/4LOdtGzLXWG1y1oyVD+vBMx9MahkgfdpNuOnCf7OiJuA29HW5JpLgzmTxezsnii0K0kEUkwfZsjlQFVW8BX65RuHYdsFmy4K3+lZU/4C/bm/IX2EFQ/rAfSTdC8BULkNA2JTwK/BM88sKbtc+oWgckTaFCqrREssApYAroLyIWUlgO01uzFv52V1bVGQRgES0bieC61S89AWuJ1U1Bmsec7cFT2GAH46f+dvZHa6ZzHSaBPNKsJStpQ+7J50yilCIuhwpPGXjWUjN3Fx/eSmYlTulM7+7yyasMRuwiGAGtp+KGxWvAkcHj2JMnSc4FCYPA2bJLPnQojcopNL/4+ooRj9ywU/9bpkTBEiDbc2tgIH1Oh13Ff48Ox1qwPgCAp/ifnjItG5uPERUxMToNLvSwh9i4bwMqq21QQI8nq05H2XlnptfimYXQZ4nG0T616938olnEMOVn7 aJqR5RD/ 6/WBL3po3LBANGEiqF56Qwr6JyUMTGEil/hG6gMRc5lK012bQv53ba4XOQ7g3ihpcHAx8jIk6Ah1OjgzZhRIUC3AFzDKVz/me/xmvbeCZSJcCttaZBxvuiquXN0VkwfM1JZ9jkNVaXi2tmtBPFl0aQHd/MvJZ17bgBM+NsOZsk+f2aqmcbPe4VVUUYX1A7FbCSKbO84NgyEcFGaO0m/X+eNFm+bczoSTnO/zHm4c1kNOR3jm7X6biHzv+mKP9Cw7mLAM9LMDRRTAoS0PiB59tnYKs5Qce/4XHnB4n/RW3WuGssEEq/2xVSz9yGx0XFKgMvqIOQKQonq3QtxJBLX3bM5FJn//deNzoI1VSSsIiuOq1WbkULs8h7hNhD1yg9BoEfUUvqZxnXU5PBo9bWSjEC4IarWGHHi0DM7SsiFe5ZbU4xev4SyYMXI7pAn6gG1gVm2TtivUNh3rYfvxbfbG2PD1wYkEDsyDedJ/h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.25 10:07, Mike Rapoport wrote: > On Wed, Jun 04, 2025 at 09:39:30AM +0200, David Hildenbrand wrote: >> On 03.06.25 21:22, Lorenzo Stoakes wrote: >>> The walk_page_range_novma() function is rather confusing - it supports two >>> modes, one used often, the other used only for debugging. >>> >>> The first mode is the common case of traversal of kernel page tables, which >>> is what nearly all callers use this for. >> >> ... and what people should be using it for 🙂 >> >>> >>> Secondly it provides an unusual debugging interface that allows for the >>> traversal of page tables in a userland range of memory even for that memory >>> which is not described by a VMA. >>> >>> This is highly unusual and it is far from certain that such page tables >>> should even exist, but perhaps this is precisely why it is useful as a >>> debugging mechanism. >>> >>> As a result, this is utilised by ptdump only. Historically, things were >>> reversed - ptdump was the only user, and other parts of the kernel evolved >>> to use the kernel page table walking here. >>> >>> Since we have some complicated and confusing locking rules for the novma >>> case, it makes sense to separate the two usages into their own functions. >>> >>> Doing this also provide self-documentation as to the intent of the caller - >>> are they doing something rather unusual or are they simply doing a standard >>> kernel page table walk? >>> >>> We therefore maintain walk_page_range_novma() for this single usage, and >>> document the function as such. >> >> If we have to keep this dangerous interface, it should probably be >> >> walk_page_range_debug() or walk_page_range_dump() > > We can also move it from include/linux/pagewalk.h to mm/internal.h Agreed. -- Cheers, David / dhildenb