From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF28CD1284 for ; Thu, 4 Apr 2024 10:04:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED0466B0082; Thu, 4 Apr 2024 06:04:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E806B6B0083; Thu, 4 Apr 2024 06:04:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D20C96B0087; Thu, 4 Apr 2024 06:04:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AF3C86B0082 for ; Thu, 4 Apr 2024 06:04:01 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 75D6D40FF2 for ; Thu, 4 Apr 2024 10:04:01 +0000 (UTC) X-FDA: 81971413482.20.5C9A643 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf15.hostedemail.com (Postfix) with ESMTP id 23FC4A002F for ; Thu, 4 Apr 2024 10:03:57 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2l8lc0ho; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=N7ln2SMq; dmarc=none; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712225038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MvGiU7UVFHT9kv7ZfHgmPgNr6pSwPx8KGlxJN/LryeQ=; b=vXuhwmg0EN3zMmLta5Dqh4f1DOiaAsZQgmsISfZNwbMUdixoEx429mFHFZd4l3tFPua4yd J0Qe0xMN/ULo0reT1EA0E3qB4+17fbaDVUGoFHGfvW7xRX1SseJKkq2Q8y9dqFhyKu6lrC yhHXsQVkuQ4nD4a/inhvsPM7eAwfHPk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2l8lc0ho; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=N7ln2SMq; dmarc=none; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712225038; a=rsa-sha256; cv=none; b=LydujGY6XSVeTX3deDdMjcGHF6aM5EoGwv4iNoMhr+9MDcUWclEhbKgOjrct4jW9Naq5em QX6Mxg544tQIHyr61J2U++21hEKa9NRoPvtLgXyNR3626AYBe75vFOfxB2YLlZDp2Y75li 6wG2MmPJQz7z4YGvkF3PoI6+5Y3zlLM= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9528C5D808; Thu, 4 Apr 2024 10:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712225036; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MvGiU7UVFHT9kv7ZfHgmPgNr6pSwPx8KGlxJN/LryeQ=; b=2l8lc0hos0cD7vLnU30sa2eP2XXCL/StXvisMofrWj9zjoXHqxeyUPJgU0aVngC59gjsVa qYR+4qZ3ZZu9tLAMZhIlPGOAGl7iAls7mSsDY5JhwX4TMWJtRlvaFCgO6YfVmTLfeghReU T7y7YCRDZkYGOrLRqd4DjfYXo21xM5w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712225036; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MvGiU7UVFHT9kv7ZfHgmPgNr6pSwPx8KGlxJN/LryeQ=; b=N7ln2SMqaS9E+fD6H4P3eiu/hwHuQimYpjT4dDZhr/+vdxqOWH1ZCSx5BMBRAxLB3dSTSP ZD5CEB9sImDRPzBA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 8786413298; Thu, 4 Apr 2024 10:03:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id +VTBIAx7DmaGMAAAn2gu4w (envelope-from ); Thu, 04 Apr 2024 10:03:56 +0000 Message-ID: <76457ec5-d789-449b-b8ca-dcb6ceb12445@suse.cz> Date: Thu, 4 Apr 2024 12:03:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: page_alloc: use the correct THP order for THP PCP Content-Language: en-US To: Baolin Wang , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Bar: ++ X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 23FC4A002F X-Stat-Signature: k1juom6u1ni6yhaehpewxo8krzkp581u X-Rspam-User: X-HE-Tag: 1712225037-94472 X-HE-Meta: U2FsdGVkX1+pnXxJCZsW2yCkJoDua/uCL8sGxULYysChRzTr2kM4JvN17zwQX0LsDsGooo4HQgNHrFlmTaSuBE4awcWEwNO+s4eos9PkjZcHO4WDxtU8LAPi8FysDCi9a1B8xoQOAvEGhAf7bMqx6yy8LpH2NwfuFh8SaPASnNbURT/j8rJwaTQp7agpLybo6aRuFOYczqK3NkWTOh5EnF1mmuPLkjbr4ckzuZRupswm9EgWrq5sUME6CeKBIKcpX8L8EYchqC9SgWhy4RG6ptFtj4QlbHvKG3yW0khuooc3mlhKuJ+mEN5Sv2wZsxZBdlTqYCCWxGW94NmwDPf8INTZQ2sKXx6KksoqDNRSQovbrMe8AI5HQ9YCVfdkzIR7fndPJoIUWPuyblHz4cqXBSvk9zaJDVP4blApmZVG5mSYo1SEPkiFr5Au+EmThHGWtlq0OfZGLmDtQZLygvMIckUuqSNXEjeij2OhO+1i0AmiaR1xOj+T2NkwJfOPlW26s0enaCCZHl27wVRZbBLUGknnudFbjOLU8c0vyEeTvJvMpTiNQotp4WRy875cdsskH+3zAMinjnQpMQeMIhjZ8lgsjkE0iirnjZfyrrwZya47au6aEubqCQQCCcxveX+DV/cvaoDtm19rK05EC5Iedqk0xoauF3H3uwEQFphB01Ph+hiHikO5eoGJm0q1AMn7yNOFP1CMwlaKKSARJrIQr0uEjMFbW1401rIQl2l+Hqh73dTATP0oY7BNDjGvSyfVu2bAhWQ8+kKhm0sZoU98+AsN+ctxapftpN/QeqTAeWTS2rcqJpton/wz7UA/x4d1ToT1z8JScKyyUQgyfeyGGidkQ2yO43tNkWv/ZT2iOK4uToFHUTiw1G+BRHrrxx3uvNoq5Z6OToVSBjxI+S978/vRuibdHKWPhNPlMZKK55fhVYR3Y2yCnWHBhZ7XEve06YxHLIeghw+s9mvhIPl CIXSa8xU 2oQTbOmbI/oi1E+v8CsfzPzREebAb6gSHdT4z+I21ms3RLtULeMFsJa4BhcTXq+peQ7ZCH/Uj93FndWudFovdv0xNmNVJPfjyEOJGXcuvknb+zBgaY1zW1+S0YChzOoVpaqV7vE0FRJOtjiKDa1TTjLsPXmZIx4QXIcinozgLkx4fdIMJMWEBNaraDOsmLnGFuZNkqZxgJlWlMUF6A8rsd+2oLOppR2ERmtgkw3g0sTJC8XyleNJvUWbtrAWIBYpA1kZNM5r6tvlQcCCpclPxvx68LecJ1/WQBwQVTFyKl+K0BDXQ3fmEMxDd2uyNccJnIPDrbGWNE9nLSmE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/3/24 3:47 PM, Baolin Wang wrote: > Commit 44042b449872 ("mm/page_alloc: allow high-order pages to be stored > on the per-cpu lists") extends the PCP allocator to store THP pages, and > it determines whether to cache THP pags in PCP by comparing with pageblock_order. > But the pageblock_order is not always equal to THP order, it might also > be MAX_PAGE_ORDER, which could prevent PCP from caching THP pages. > > Therefore, using HPAGE_PMD_ORDER instead to determine the need for caching > THP for PCP can fix this issue > > Fixes: 44042b449872 ("mm/page_alloc: allow high-order pages to be stored on the per-cpu lists") > Signed-off-by: Baolin Wang IIUC this happens with CONFIG_HUGETLB_PAGE disabled because HUGETLBFS is disabled? But THPs are still enabled? I think there might be more of THP working suboptimally in that case with pageblock_order being larger (MAX_PAGE_ORDER). In other words, should be rather make pageblock_order itself defined as min_t(unsigned int, HPAGE_PMD_ORDER, MAX_PAGE_ORDER) in case with !CONFIG_HUGETLB_PAGE but THP enabled. > --- > mm/page_alloc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 1beb56f75319..915f4ef070da 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -506,7 +506,7 @@ static inline unsigned int order_to_pindex(int migratetype, int order) > { > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > if (order > PAGE_ALLOC_COSTLY_ORDER) { > - VM_BUG_ON(order != pageblock_order); > + VM_BUG_ON(order != HPAGE_PMD_ORDER); > return NR_LOWORDER_PCP_LISTS; > } > #else > @@ -522,7 +522,7 @@ static inline int pindex_to_order(unsigned int pindex) > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > if (pindex == NR_LOWORDER_PCP_LISTS) > - order = pageblock_order; > + order = HPAGE_PMD_ORDER; > #else > VM_BUG_ON(order > PAGE_ALLOC_COSTLY_ORDER); > #endif > @@ -535,7 +535,7 @@ static inline bool pcp_allowed_order(unsigned int order) > if (order <= PAGE_ALLOC_COSTLY_ORDER) > return true; > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > - if (order == pageblock_order) > + if (order == HPAGE_PMD_ORDER) > return true; > #endif > return false;