From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77ACEC54E67 for ; Wed, 27 Mar 2024 13:56:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 089316B0085; Wed, 27 Mar 2024 09:56:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0396C6B0087; Wed, 27 Mar 2024 09:56:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF4E76B0088; Wed, 27 Mar 2024 09:56:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BBC936B0085 for ; Wed, 27 Mar 2024 09:56:41 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3ED9A140D75 for ; Wed, 27 Mar 2024 13:56:41 +0000 (UTC) X-FDA: 81942969402.08.5792573 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 6157F140022 for ; Wed, 27 Mar 2024 13:56:38 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MwaGEXxH; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711547798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wwFOu67rAm/jgeVVs/VXwT1nwHyOmGUKbXFLwpopGYg=; b=Falto//uv3kMuvfHF5wOiUsAkWpr79XF4BWmtcfzWLOz0sGy6LTYQJ/0GpH9MiGbnpP0AX XSDcqnOgUw9r3WiI5RBKDQtbIfTcxcdNdFsv5v69BIZSF8KtZZpctE/7+Agq8Vg1Eu3pMc 07nAvRZG43APs4llc21O6yKJQqpRiYo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711547798; a=rsa-sha256; cv=none; b=ECfjmp/eiKEQ8i8ONjQXWhqfiNNzAvypQBQjrt4sP+AO8c7vBNE1W7BPblwIL4cYGFUQrx CRTgH0NiyU8YyLM7NMF2/oRsYJWGXUx1eJlN0gfacGt4ybAkhFZZ49MXchMgZQe41zkD3J oRNRJty1E9AjS2YmQZZmxy3+Jet7bRc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MwaGEXxH; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711547797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wwFOu67rAm/jgeVVs/VXwT1nwHyOmGUKbXFLwpopGYg=; b=MwaGEXxHl6gKs6OCt9bbnGbQCxFk/VSsAZw1UbEK5gwjTABNmbEH/rih9CLJZTdB80lX0d yUVgbyTBei7ihESAWcWPPSam5ebjN24iTYG/XD6+cdteD2I8Vq2o+SxM03NKh4b5v0NpG6 L6agR5BKxHe4sNAXFrBsyDVz9K2jitA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274--Cmq_CuoOMCPFS4lgf0i-g-1; Wed, 27 Mar 2024 09:56:34 -0400 X-MC-Unique: -Cmq_CuoOMCPFS4lgf0i-g-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41485cd7d9dso27596765e9.2 for ; Wed, 27 Mar 2024 06:56:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711547793; x=1712152593; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wwFOu67rAm/jgeVVs/VXwT1nwHyOmGUKbXFLwpopGYg=; b=UDJ+Lg5P50Ap+ZvFkfZ3pxuEltXc+MgPec9tKGQ77KtW2fXG/1Ebn56rflynvIALNU LVYAoSbIgr2uXWGqH935uaenC2cdVInKBQBpxfX3zYThYzBRKbPGir/6TfLVIDUG5oZN GQ7TlXeuDv7b54pB5oAHeVvQBUi9Z6Q2DUsyWJ79bRXSy3uSMcHEhq4AOI2SuM/7nE7m yi792+pspczU/Dk9lzCcHt2Rd+73dDeACv9VEkmzXGMB+1pkwVbK9GMvQQV4uB752uwB Xjx2SEmh93KDZGvk+2OGChXuTaRYOI69N7ho7KVNA2fcEUbeAI+vpfbJMOUWNNfBJE/W 2rOQ== X-Forwarded-Encrypted: i=1; AJvYcCUwLibQ9UBuG5KlooQF+Z+Fm38ExsOTxpmFmfgNRt5xg62oaNA77oprm92TnYjWpvU/NDY4AdZUEw+obXDZhyw/O5M= X-Gm-Message-State: AOJu0Yzdi3mXAqWUSYxCJACIEI4r4ivUrusGEK0R1yIGsSg62dOfjcS5 Inu72P+dU4uifqeY3QHZfFgyO0XdlpwuSlvXBgBMdDHbGCGh2lStrvA/X2jffNabTz+kYfbXCtE EtN53N/PJiRMBQq5151lFg50KxlaYydeGQUTF7U5FviJsJdRK X-Received: by 2002:a05:600c:a08:b0:414:392:38d2 with SMTP id z8-20020a05600c0a0800b00414039238d2mr74560wmp.24.1711547793059; Wed, 27 Mar 2024 06:56:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExpTOhHThCpVA+4b+ZiNKOUdia4Bzq6YqF2zp26xsxLD8eZI4hj+mGwvlthboaboFnQKnRxA== X-Received: by 2002:a05:600c:a08:b0:414:392:38d2 with SMTP id z8-20020a05600c0a0800b00414039238d2mr74531wmp.24.1711547792613; Wed, 27 Mar 2024 06:56:32 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:8a00:362b:7e34:a3bc:9ddf? (p200300cbc7088a00362b7e34a3bc9ddf.dip0.t-ipconnect.de. [2003:cb:c708:8a00:362b:7e34:a3bc:9ddf]) by smtp.gmail.com with ESMTPSA id k33-20020a05600c1ca100b0041409cabb39sm2218013wms.18.2024.03.27.06.56.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 06:56:32 -0700 (PDT) Message-ID: <7631ff56-fa16-4b2b-87b2-1e93691bd110@redhat.com> Date: Wed, 27 Mar 2024 14:56:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 1/3] mm/gup: consistently name GUP-fast functions To: Jason Gunthorpe Cc: linux-kernel@vger.kernel.org, Andrew Morton , Mike Rapoport , John Hubbard , Peter Xu , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, x86@kernel.org References: <20240327130538.680256-1-david@redhat.com> <20240327130538.680256-2-david@redhat.com> <20240327135256.GG946323@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240327135256.GG946323@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: twr4oq4ozd1iubr5xgqar7stzurphp11 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6157F140022 X-Rspam-User: X-HE-Tag: 1711547798-275674 X-HE-Meta: U2FsdGVkX1+v0DghQ3ffT60HBFAboht/8k1Rrd/DXfQEpT560KVyOZhbHGdQWq6vvcxtzng1r7AaGMB1LRCcKFAnJmplSGICOiVRzB0Id7vI7ldQwynfFcqB7eET4g/cmI+kUAeN98IaygGBH8O06VCkVt/zJnhJohx64CWXK9RyGXbUcMYDEfOBuqZGR08xtoT9j/TgngDQpafhlIM020CaZn+JvonbjYlIujXGLPuHxGwCTFOrUM7AN8ct5OzQlSytAzfNuusUrE1UkijABYFRdZmb+ImRvKYNOzLUA44eJr3BYa+RNmdqKrozh3Uayh9BWpa3pStirYXCGs6kFJAWhZ9dBGxlVXlgaWqM3vj3LcYcnqj7r+EQlmxjNVrFN6S70Smk+aP75Bsxb1TRn2VCkdXGjAndC75HSQzSJFlMow0mQKBI56976iA+gf4B7J5fnzl5c0PT73vwacDtOlaBXPQ0wQQJHVErJlYEJBz7n+B+hw33MGS+3L1M5kSa+09D4lygJSBCs57/vyJt49kLWhnQukkMXRPSDPvsewfXNr7bPUY6qLGa10CykuOzIViZSYTsQ4xQ2A5snGh487dcfFIoIvnz5frQxaSolJ1XfnScjXWjbp58ajRlNjz6Cc36rg4eH0frfFr5yzIBoPF+h5SV5PebfSIWbL+wyXfmFnzqxPvU3562XVDIOPclc5x+UTUD3bOPQXsDyp3rSff3mWobQAJK156VoksAtTqxfR9MUVa7ciQWM9aNNcldgNn0OqHyZ3D7/tmX7iTEScalaC/jpOHau7LsuL3PTY3lp69irezXgmjo1IAOjZBdwESx+EcAKLuo35NKX4LvdZo9P3W9cfbjxMWgJt1VAj29E+DVpg63EUGC7VWgOlSd2GeX0nt5BqtPB/3ZmJxTpWAq5aafBJBH1tQ1ywpKjiwlhQGOMC6mIatJz7tfnQ10G/HMxNV3K+CUt1xrfls FAQ/Fefy NZYBKMeu44NWwK+0+img85Y9+ddz7bXa6tlA/yWzYGt8qVEmJvRxYTWcKl2CvmBqkc0Ipx9hC5QBFxMTIFv0GVOpEQP4EfTuOe1Dn16UG+6hZx5GI0NQioPyUDTjyNUdtCzYlyW4qnnTHqRSkDr3nOcMSUyo+HUMzYTWCbQ+sExSiL3cZwZFW0vZnY9Pwo+d/iaVrMTxO7LYETGg3Yj1hSwvhWfGKkS+eJQFwchwvYcNgzVm9M8eRp2u2+GmmFq4mD7OsMY5HnInhwP891J5X8gytDCIjuLKf2cwVtBASy8JopB25ccaqVa4JHneu1LUEb1zsaoNgNErmKDeerEjmhr8HNovix4ey8Uz7gj8pMuaM2ni19yph40sma19oG8HfFehiPFK609JLwIBCpR9XP+wDrKaSnnI5fQWHD+RmKMYV0xjbXWk8pxIo0jHt+SeljGeHeo2rP7WyDcFSvcriUPGwERplLgLYAOljIjniB/oDD1avEhKePAPi13ndCEb++kYh8gGBaK+DfZJFiN01+l9FY3CC68nz9spi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.03.24 14:52, Jason Gunthorpe wrote: > On Wed, Mar 27, 2024 at 02:05:36PM +0100, David Hildenbrand wrote: >> Let's consistently call the "fast-only" part of GUP "GUP-fast" and rename >> all relevant internal functions to start with "gup_fast", to make it >> clearer that this is not ordinary GUP. The current mixture of >> "lockless", "gup" and "gup_fast" is confusing. >> >> Further, avoid the term "huge" when talking about a "leaf" -- for >> example, we nowadays check pmd_leaf() because pmd_huge() is gone. For the >> "hugepd"/"hugepte" stuff, it's part of the name ("is_hugepd"), so that >> says. >> >> What remains is the "external" interface: >> * get_user_pages_fast_only() >> * get_user_pages_fast() >> * pin_user_pages_fast() >> >> And the "internal" interface that handles GUP-fast + fallback: >> * internal_get_user_pages_fast() > > This would like a better name too. How about gup_fast_fallback() ? Yes, I was not able to come up with something I liked. But I do like your proposal, so I'll do that! [...] > > I think it is a great idea, it always takes a moment to figure out if > a function is part of the fast callchain or not.. > > (even better would be to shift the fast stuff into its own file, but I > expect that is too much) Yes, one step at a time :) > > Reviewed-by: Jason Gunthorpe Thanks Jason! -- Cheers, David / dhildenb