From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD7C6E77188 for ; Tue, 14 Jan 2025 09:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DCCB280003; Tue, 14 Jan 2025 04:09:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 463F8280001; Tue, 14 Jan 2025 04:09:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2908E280003; Tue, 14 Jan 2025 04:09:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0681F280001 for ; Tue, 14 Jan 2025 04:09:47 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AEEEDC0854 for ; Tue, 14 Jan 2025 09:09:47 +0000 (UTC) X-FDA: 83005484814.20.F69171A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf18.hostedemail.com (Postfix) with ESMTP id 416121C000D for ; Tue, 14 Jan 2025 09:09:45 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="cDjpPC2/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=j14hrea2; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="cDjpPC2/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=j14hrea2; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736845785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QPSWmBIALfcab60vXy4rEVwFRgtvJbOBsASpBs0vcNs=; b=LwsoreOhkD4rgkjzA2OF/1tej16AHRO5JYrfU5M+zlhzXuURfRz7UDphNNCu2y8wAamn+i FA1wgao3E/WXwPb5wQbaBu5WpXAZSqseOqxnwQshgMXviztPtUgZW2UGJNRkgeKz4kwLKK IQjJQtgTPEdFuOO14UnS9xy6RvpVBlg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736845785; a=rsa-sha256; cv=none; b=qLog1/+SEeEEEkQHNxcXSvvcsRu6Icbdq0v/2Eq/WKxpGyg5X+AE6jiJbgov2R2oe/hS/Q 30+19t26A9bdmamyHltJvh1BUSqSz2M4ZChLPO1+n2GVK7qAq3c+iwTaGlTxCvzZd17lCT nUeRQSnMiEtOcFddYOvO1LOHHomLF+w= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="cDjpPC2/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=j14hrea2; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="cDjpPC2/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=j14hrea2; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3456D1F38F; Tue, 14 Jan 2025 09:09:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736845783; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QPSWmBIALfcab60vXy4rEVwFRgtvJbOBsASpBs0vcNs=; b=cDjpPC2/smHH4iPwtl8MzYeObrsiHzavDSt3eGZxZzK/TyGimGdyWrf6f1uK6Qcg06UNOf RnvamDYIpYsZeH3kbysvOGVggxxxPHSIrZZt8EaNDN6ihsbEJvJWQfVqwdgqcPUtjxrgsu v8195SnbiZYixB1cqReRmp61KNYFhD8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736845783; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QPSWmBIALfcab60vXy4rEVwFRgtvJbOBsASpBs0vcNs=; b=j14hrea209qVh7pD7p2/JifXtOyi5RZwN8kDzwd3ZhhiTA5dOWO5C8+p87/yMdanr1XoKJ 462KCIr0So94IlDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736845783; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QPSWmBIALfcab60vXy4rEVwFRgtvJbOBsASpBs0vcNs=; b=cDjpPC2/smHH4iPwtl8MzYeObrsiHzavDSt3eGZxZzK/TyGimGdyWrf6f1uK6Qcg06UNOf RnvamDYIpYsZeH3kbysvOGVggxxxPHSIrZZt8EaNDN6ihsbEJvJWQfVqwdgqcPUtjxrgsu v8195SnbiZYixB1cqReRmp61KNYFhD8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736845783; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QPSWmBIALfcab60vXy4rEVwFRgtvJbOBsASpBs0vcNs=; b=j14hrea209qVh7pD7p2/JifXtOyi5RZwN8kDzwd3ZhhiTA5dOWO5C8+p87/yMdanr1XoKJ 462KCIr0So94IlDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DFB0A139CB; Tue, 14 Jan 2025 09:09:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Uk0INdYphmeRcQAAD6G6ig (envelope-from ); Tue, 14 Jan 2025 09:09:42 +0000 Message-ID: <762df2fe-d57a-40b3-b921-47f5b6d84ba2@suse.cz> Date: Tue, 14 Jan 2025 10:09:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 00/17] reimplement per-vma lock as a refcount Content-Language: en-US To: Andrew Morton , Suren Baghdasaryan Cc: Lorenzo Stoakes , peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, david.laight.linux@gmail.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20250111042604.3230628-1-surenb@google.com> <20250113174941.8c6d5defe18c8b1a7e477ace@linux-foundation.org> <20250113200908.d821636a39e9ca6130a90e24@linux-foundation.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250113200908.d821636a39e9ca6130a90e24@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: 676o6qxmh9yfbanndn1szs7bs9quwdkj X-Rspamd-Queue-Id: 416121C000D X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736845785-125740 X-HE-Meta: U2FsdGVkX19MeSUa3FNHwqhul3RThcBcMO6sWXzhOAoE11SxMXHAlWG6L23pQ3rWrm1lOOJ2+j3QVJQGxUogBmdVJMk3pRQ19kNXpA18Mq9NWvhrc1ItjgrXQZ2uPRNuUjtlWUObTJ8ApqdNkk0MsAPtPZL2nNJnqNz023c6wyMdSOzuYtU4zCnjYM6mv1Zv1AibAZp9Ffkwsv1CKS8Q1SmiQhIjCrGozpDoJQ1S7TvWPO47TAvjgjGVy2edsqK7yiirTvNs14mm9x86LBq0GLl7S06lmo2yODjH7uIYm3fDN2SzsOAk7C+tpqrY04IRVH5fKXbNy+TISo+lvbrk2zjzhAQ71lnjWEy7Mx546FySu26SvC8kAkcm6yW1kM6FcsbW9WvUFyM4vuWqvdbE9TTlrPrU4BilyOlp5aaSIXON3s7aM3y5CzizYKwGWywzgBk/q1pgFXh5a7wIbzA3gdSWWFxbWEYb63FDHBoDk+ZFwKBYGnGOWFRv+Vf+c5RVXLsOwBCiFerg7N470JDDUeGE96Qt5e3DYAlHhAWDCyOeSuUthcCpev+rvidzyDypMRZY5H1CHDdZUMV+rhdR0hDd8aB/cVyzhzxxET9R8vuKWNocmiLk79LHuuki/MNOCKucdi6LELHwtsKcxLknEB2Kmw4ail2MukADWJnB+CTnYykC9/Q7/HnIywcApgKWHY53n09nX1AQ6xD5Gxr5Ke4jnEEf655xyyvVubwLPWbJEykaQottKmDJisdFpCLwIqtZiobghyi+lz3Gn56yMLkwgPbmRTGHsVUFzRr5n776jyWo4YvOqQkUJhDfEZcZKyTnSVdikUE+jp1rEOMfpFaQso8FCZU9iI2WM20Fbg0CYP20ho8OFJlk8PreugyuSUVgHxLdaSo/32DwV2bhG67kQ8VTQ98KuWnxxuxIKTezBFoOsg7DIlV3AcAJe0TpM5b2zYrMakqJXAra09g f8AkYRbi N0uQMHfG4W1Vj6+yDgFJfXl+H967ElC51zKUltc4qeMxil+u8NZ9j7ersCOUcPDOWIuN2kc0S6v1fGykZQGsLh/VkCjR7iCPyEETEWQtJSXUMzpvPPXAkTmu/wjBMZ0WhNhgy70Nq24DSNmJj6dhUwA1/7QZKBN1xVA9UXrcP/zZ2YJ5+Y5z8/Jn303snsc6EVkBEUU1/yEhAV0Xb6IpsiCSjc0E47x2GFQu4tHA1nxzygCpgPsTNiduPaL5wFqN/mIKA1w1REgarYFJXQL5l9RmDX2bk7Wu6F9WUMmC8DzHqfxG8R3T8+SNmG6oETARdlVUis9RnV9lGPQe3p0CgMUgUMD7hZigFi1rlZJcvq4txklU8Lmlin2G/kr6yixyD8dLwLWsUK7NCjy7Sbv6g03nc9Te9c5X51qddGoF90m1qh5roo/Vqm7Aq2Ke0jaoJRnag8buIEdMIcabOYgKO6sOw2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000030, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/14/25 05:09, Andrew Morton wrote: > On Mon, 13 Jan 2025 18:53:11 -0800 Suren Baghdasaryan wrote: > >> On Mon, Jan 13, 2025 at 5:49 PM Andrew Morton wrote: >> > >> > >> > Yes, we're at -rc7 and this series is rather in panic mode and it seems >> > unnecessarily risky so I'm inclined to set it aside for this cycle. >> > >> > If the series is considered super desirable and if people are confident >> > that we can address any remaining glitches during two months of -rc >> > then sure, we could push the envelope a bit. But I don't believe this >> > is the case so I'm thinking let's give ourselves another cycle to get >> > this all sorted out? >> >> I didn't think this series was in panic mode with one real issue that >> is not hard to address (memory ordering in >> __refcount_inc_not_zero_limited()) but I'm obviously biased and might >> be missing the big picture. In any case, if it makes people nervous I >> have no objections to your plan. > > Well, I'm soliciting opinions here. What do others think? > > And do you see much urgency with these changes? I don't see the urgency and at this point giving it more time seems wise. Seems like v10 won't be exactly trivial as we'll change from refcount_t to atomic_t? And I'd like to see PeterZ review the lockdep parts too.