From: Zi Yan <ziy@nvidia.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-mm@kvack.org, David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
John Hubbard <jhubbard@nvidia.com>,
Yang Shi <shy828301@gmail.com>,
David Rientjes <rientjes@google.com>,
James Houghton <jthoughton@google.com>,
Mike Rapoport <rppt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 12/12] mm: make MAX_ORDER a kernel boot time parameter.
Date: Fri, 12 Aug 2022 22:38:09 -0400 [thread overview]
Message-ID: <762F50AE-E28B-4EB1-B302-14B9596B5FCC@nvidia.com> (raw)
In-Reply-To: <2e15fc72-5483-b901-5a54-d4a4529d61d9@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]
On 12 Aug 2022, at 21:11, Randy Dunlap wrote:
> Hi--
>
> On 8/11/22 16:16, Zi Yan wrote:
>> diff --git a/mm/Kconfig b/mm/Kconfig
>> index e558f5679707..acccb919d72d 100644
>> --- a/mm/Kconfig
>> +++ b/mm/Kconfig
>> @@ -455,6 +455,19 @@ config SET_MAX_ORDER
>> increase this value. A value of 10 means that the largest free memory
>> block is 2^10 pages.
>>
>> +config BOOT_TIME_MAX_ORDER
>> + bool "Set maximum order of buddy allocator at boot time"
>> + depends on SPARSEMEM_VMEMMAP && (ARCH_FORCE_MAX_ORDER != 0 || SET_MAX_ORDER != 0)
>> + help
>> + It enables users to set the maximum order of buddy allocator at system
>> + boot time instead of a static MACRO set at compilation time. Systems with
>> + a lot of memory might want to allocate large pages whereas it is much
>> + less feasible and desirable for systems with less memory. This option
>> + allows different systems to control the largest page they want to
>> + allocate. By default, MAX_ORDER will be set to ARCH_FORCE_MAX_ORDER or
>> + SET_MAX_ORDER, whichever is non-zero, when the boot time parameter is not
>> + set. The maximum of MAX_ORDER is currently limited at 256.
>
> Please make sure that all lines of help text are indented with one tab + 2 spaces,
> as specified in Documentation/process/coding-style.rst.
Thanks. I fixed it locally.
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
prev parent reply other threads:[~2022-08-13 2:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 23:16 [RFC PATCH v2 00/12] Make MAX_ORDER adjustable as " Zi Yan
2022-08-11 23:16 ` [RFC PATCH v2 01/12] arch: mm: rename FORCE_MAX_ZONEORDER to ARCH_FORCE_MAX_ORDER Zi Yan
2022-08-13 15:36 ` Mike Rapoport
2022-08-15 12:53 ` Zi Yan
2022-08-11 23:16 ` [RFC PATCH v2 02/12] mm: rectify MAX_ORDER semantics to be the largest page order from buddy allocator Zi Yan
2022-08-11 23:16 ` [RFC PATCH v2 03/12] mm: replace MAX_ORDER when it is used to indicate max physical contiguity Zi Yan
2022-08-11 23:16 ` [RFC PATCH v2 04/12] mm: adapt deferred struct page init to new MAX_ORDER Zi Yan
2022-08-11 23:16 ` [RFC PATCH v2 05/12] mm: prevent pageblock size being larger than section size Zi Yan
2022-08-11 23:16 ` [RFC PATCH v2 06/12] fs: proc: use pageblock_nr_pages for reschedule period in read_kcore() Zi Yan
2022-08-23 10:36 ` David Hildenbrand
2022-08-11 23:16 ` [RFC PATCH v2 07/12] virtio: virtio_balloon: use pageblock_order instead of MAX_ORDER Zi Yan
2022-08-11 23:16 ` [RFC PATCH v2 08/12] mm/page_reporting: set page_reporting_order to -1 to prevent it running Zi Yan
2022-08-11 23:16 ` [RFC PATCH v2 09/12] mm: Make MAX_ORDER of buddy allocator configurable via Kconfig SET_MAX_ORDER Zi Yan
[not found] ` <becc0751-9ce9-6fab-8e58-477e962e54c5@infradead.org>
2022-08-13 2:37 ` Zi Yan
2022-08-11 23:16 ` [RFC PATCH v2 10/12] mm: convert MAX_ORDER sized static arrays to dynamic ones Zi Yan
2022-08-11 23:16 ` [RFC PATCH v2 11/12] mm: introduce MIN_MAX_ORDER to replace MAX_ORDER as compile time constant Zi Yan
2022-08-11 23:16 ` [RFC PATCH v2 12/12] mm: make MAX_ORDER a kernel boot time parameter Zi Yan
[not found] ` <2e15fc72-5483-b901-5a54-d4a4529d61d9@infradead.org>
2022-08-13 2:38 ` Zi Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=762F50AE-E28B-4EB1-B302-14B9596B5FCC@nvidia.com \
--to=ziy@nvidia.com \
--cc=david@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=jthoughton@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox