From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAB2DC05027 for ; Thu, 26 Jan 2023 23:45:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CAAE6B0071; Thu, 26 Jan 2023 18:45:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 87AA66B0072; Thu, 26 Jan 2023 18:45:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71CCA8E0001; Thu, 26 Jan 2023 18:45:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 623316B0071 for ; Thu, 26 Jan 2023 18:45:44 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 310A01A0845 for ; Thu, 26 Jan 2023 23:45:44 +0000 (UTC) X-FDA: 80398585008.27.28425ED Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 1BC73A0018 for ; Thu, 26 Jan 2023 23:45:41 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Fwkz3NdD; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674776742; a=rsa-sha256; cv=none; b=h7+L2wEGcHeZ0Q7v0mJa6HRnHrZV8MUFgrHgcTPzjIpI/Vdd1oenn7pJCVpz+8cuen8/xq hPyfINPQdadU8A8uS2uqW0bgcHQH/8QUYpqZemmXYUE+tVdYw7ORHoDgB0VE6mYBOfSw4B 1qvRGuo8YlPADT0QT/7edYl0IBg/0OI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Fwkz3NdD; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674776742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FDPidku7XYmtarp/AVuc4betwoJhftsFOw1T5iwHCJo=; b=wtUijrcDtKUfrEy2+CBhP7WXNC9wTgnclKCtPlQE3WfbN1UrMtys/1DZbvBCPBBz3Lsq5+ EoOP8v0WVfctrvRr7Ky2h1hm+cmfXs+8PcWQw4HHHPv9ghxkx9mfPx/OIGAhNxXPThn1N9 2sA9gCAJ0H0FCVvOLWzch2NYYTCRunM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674776741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FDPidku7XYmtarp/AVuc4betwoJhftsFOw1T5iwHCJo=; b=Fwkz3NdDdxliTowrLbXSl1HdrbWCbwCILAqwsdtWDwkS64RaW5xkeyWaNRZQtAEpeNa1/Q VKaqNqIprFMKaRLDgFwc3epzpsrQJQJn0A1l4ThkcqbYQhMLsXyuqh8u94hQ6T0aOHdQS5 g+lfuysbvCwO02qkOTONR4HTvBrGPIM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-209-VjEAef-iOZWTD8EMRVtvAg-1; Thu, 26 Jan 2023 18:45:38 -0500 X-MC-Unique: VjEAef-iOZWTD8EMRVtvAg-1 Received: by mail-wr1-f70.google.com with SMTP id w16-20020a5d4b50000000b002bfca568cdfso491069wrs.0 for ; Thu, 26 Jan 2023 15:45:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FDPidku7XYmtarp/AVuc4betwoJhftsFOw1T5iwHCJo=; b=ri0gOCdMeVd6Q0rSQwz+y1crW0wTf/01HSin0SJsjj2Pwyvh0emeUPOas90iS1y5p7 aKxYFZfwh0RuOcnrm4VpI3mwqcDgCpUJUk/vcmkc63c/vVClZ7KOcsiXzAvQSQtd4H4u sPVdjsRY5Kd48+O++A6sbjW8XiA0Bv2/+mQvpIHM0A8woWVQUze5VDI6pah5sO/UOyxk J8z25XU5GcXPdaTfhD+E0GjtVCKSRu+48X/XK1KAD0fqLcoU39AL8C20eCY7usAdZ1dA /tR9rgajGFtnlLDQzKndmEYycen8BIDgxlo9Us4PzoYZwA21z4eHrz843NEUeDbFZsXi wkFQ== X-Gm-Message-State: AFqh2krBfUbrdL2fDRYrGv2bQAb8AxMOrGv6a6QPMzad4uD++NKjqL4h I2Qv4iw+HR/OBbiwGHiSZvgaH5LlJYBdnVK6PhEIwxZNxrPAMpJkVy5J8Sb0oh/Fxp7nLJPdaNq ozWEx61/BOto= X-Received: by 2002:a05:6000:1049:b0:2bb:ee8a:4282 with SMTP id c9-20020a056000104900b002bbee8a4282mr31802019wrx.34.1674776737005; Thu, 26 Jan 2023 15:45:37 -0800 (PST) X-Google-Smtp-Source: AMrXdXuhVMC6HMmdj7izpzyhUASFO5g0VF0QIXfsOyqbgQyokValMXycp+aM8dqC3EF6J/Z4LUfi0A== X-Received: by 2002:a05:6000:1049:b0:2bb:ee8a:4282 with SMTP id c9-20020a056000104900b002bbee8a4282mr31802010wrx.34.1674776736691; Thu, 26 Jan 2023 15:45:36 -0800 (PST) Received: from ?IPV6:2003:cb:c707:5e00:9e97:86d:5ed5:bb95? (p200300cbc7075e009e97086d5ed5bb95.dip0.t-ipconnect.de. [2003:cb:c707:5e00:9e97:86d:5ed5:bb95]) by smtp.gmail.com with ESMTPSA id t15-20020a0560001a4f00b002bc6c180738sm2925652wry.90.2023.01.26.15.45.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 15:45:36 -0800 (PST) Message-ID: <7622ebe2-7405-ce4f-6bae-2d51dc8bf929@redhat.com> Date: Fri, 27 Jan 2023 00:45:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v11 1/8] iov_iter: Define flags to qualify page extraction. To: Al Viro , David Howells Cc: Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard References: <20230126141626.2809643-1-dhowells@redhat.com> <20230126141626.2809643-2-dhowells@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 1BC73A0018 X-Rspamd-Server: rspam01 X-Stat-Signature: msfpn4q6f81z87qpcticz6bq8t3by9hk X-HE-Tag: 1674776741-703313 X-HE-Meta: U2FsdGVkX1/uBfBdLrI+n4HtzMq+cd5ao7yBjetGp2VU15i7zEOGB4EVUtriwKBBKkNol97ZpwHv3U1cuE/OlaJoEDOr2sMB44XYWlN31LT03QX5r7iq0SL5Jf4fm4loUZ7jJu+jMLJga5B/pm6RwjlUC0VZ8TOe1hyUAXFVi9tLHhXy3mrtJPTF0x1ByoRbbUlkY2BrACdXtyqnMxii1wtkAwkTbhIBUaJDp4MrIUT6zmhSYCcDMm3eMr0HwsJAADdG8g4Xhl78tG4wtyg8QBaquCxcZLILrdwNDKC47d3vxUQ6ZZB9HmiklH+bx/k+NSZNozvkWTWcxglxefXyf/jO+zZfOWrWzoTbImgGtSTdV31UQuTJepgFixDbyGe1ccjk3i0Ci41iamTKkaHw2PWqsYyPNSOAr4JGQBk2uF9mwK9wYJqt5VtZWEMLv6/w9ATTIdTsXkre/0G5HttAYebpPpyIqZyw3TshFSq7g46nq92r1Mne+BDo+bw2I/B0KCIe33oVe03ImVmDkxDap6TgZmsQuLYI0K+H3CkX+7EZqP5q3+tT3WHS+8v3oiPBaC7Fs6YRLjvF37ra0g84qyEFEe/aA99QIyt3fNRI1Xb4IRVsbhGKU2KNkCRICzfWB1Opcj1xkj+46j6lnn7WSYCIzFvFuDLXRcsenLVpNWKSlfXQRWUGsncOUIZsWnEoxRYtpBw1KUimC41dQHSZEjOM/14FLkjHtbQMgdv6inNeivvfCXfqaS+T1Jtr/kBWynlmHOSl4un8bBkczT8y24+DEoACWMTLjHN6+oUCp/bXzw7mzxi/qBJkXF7fMyk67HyY2O7FuI0AP08XSisDMXh7VFtWXoQGeeaZ9oiMlxo+K0cNr5UDM6c+zgbFn4Kmcyg5wJgy+T+0lyUwUa10RwN4MrUgz/sb26j5jmY/sBkYSy1L+1cNwFFVhSLgLMr2lSO71OdvAjx4AYfWben W6Vw7+3V 0m0sxqioktUtdDV53JcVf9qVphW1RoNRzTUoaFXviZk59sKRCpKVNRau3U35m9NjYcwrMlNdLy22v/kev9n0QZaKq8FmX8qxumhCCRxEU3O+X7dfwjL7dkw0tpmnfAJSnME0ipPNkfUZ++SfUuCDh92fBcUTE18tkOsZZ8Zts9P9ZX/ZmrHJdTYZBXph+/W4BfDdNA/zctrnh2jwXLP+rNN0VSaz+8tNmxXSLAexyfom6TmEj0MoraUKC5OMMN6ERxgh+HqZN5PKpxZynA4IRU6CAdAo8yStnLW0mPwvQZ+ub8PoZUXO+qWDJm7VXjnKwg2VjXZLahEy1FxcVJf8bkCmZ9ggGMpFLIU0ZxZwuSgFI9nW2jXfybcNiRIT1qRv7ITxECp7m27SJYnwTMIUkX8i2bvRNxEGLisAnNCblNP3Yp/GAC/edVNBhmKfyfnDX/4Rc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.01.23 22:54, Al Viro wrote: > On Thu, Jan 26, 2023 at 02:16:19PM +0000, David Howells wrote: > >> +typedef unsigned int iov_iter_extraction_t; > >> +/* Flags for iov_iter_get/extract_pages*() */ >> +/* Allow P2PDMA on the extracted pages */ >> +#define ITER_ALLOW_P2PDMA ((__force iov_iter_extraction_t)0x01) > > That __force makes sense only if you make it a bitwise type - > otherwise it's meaningless. IOW, either turn the typedef into > > typedef unsigned int __bitwise iov_iter_extraction_t; > > or lose __force in the cast... > Well spotted, iov_iter_extraction_t is missing __bitwise. -- Thanks, David / dhildenb