From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8660C3DA7F for ; Mon, 12 Aug 2024 09:35:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48BA96B0092; Mon, 12 Aug 2024 05:35:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43C0E6B0098; Mon, 12 Aug 2024 05:35:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3033E6B009A; Mon, 12 Aug 2024 05:35:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 12BBC6B0092 for ; Mon, 12 Aug 2024 05:35:34 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 93320140738 for ; Mon, 12 Aug 2024 09:35:33 +0000 (UTC) X-FDA: 82443085746.20.87EA896 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by imf11.hostedemail.com (Postfix) with ESMTP id A57E74001C for ; Mon, 12 Aug 2024 09:35:30 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=c4paJMxq; spf=pass (imf11.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.160.48 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723455296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LezxPZ2pblaIeFvj/f40IQFP8Cd13qWLMfSEX26uTrg=; b=wIRenL3orGgTRJqRXdIpjDCQgIxG1HBhx1oIwuZPluOCF1WSb0wqMYOHhmdP8jh1CTVSyU pkOiI7NykAl5wPnJPgqOy33DLtGlQZxh5jHm970Cb4ZyvkIU3vyC+sLA2+Tnuy1vONZXid nA9HTKtEdoSWDRiHbFd+ho4PT5nt7bE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=c4paJMxq; spf=pass (imf11.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.160.48 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723455296; a=rsa-sha256; cv=none; b=3KlskHCH4d2wFJVNTCwmwU9RU7nHC9lyGe8X3nr82ynRqVVx6gHSwO9kqKxs3CZySJYA5Z QT9Ka3F+MfXzgOpVZlFhXgxS3dwsybEjsLpstY9w3GBZdq6tWzevfhWQ3MV8w5syn5SJXl QiLvcht5DI/LZQ4/0dNlU7RooLwZyS0= Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-268d0979e90so431342fac.3 for ; Mon, 12 Aug 2024 02:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1723455329; x=1724060129; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LezxPZ2pblaIeFvj/f40IQFP8Cd13qWLMfSEX26uTrg=; b=c4paJMxqB0vl09kUCZYNSA5XLiQu/pU6PAVGnGduCek2ox4ErMmM0v+uEVuThWNnu9 rmoIIGSRSTRBQTeeyDZ98ctns+XWN5T5uJmVvr3JUTLQnpkEjlPlMist1Pl1l2LFAL/D vI5c+vUAQzC6jiN1rhZXmL/wgwHs17+y2D7gQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723455329; x=1724060129; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LezxPZ2pblaIeFvj/f40IQFP8Cd13qWLMfSEX26uTrg=; b=sDAfp2qbZeBWPoJeVLbwOIau3kaOvGiBp9RL0vpLtoQzd6OuIGQMg+ddddKF1lAanX fi0OKfMw6WrwSaoTGjV/Z2Va66nSzsoUdQTKAFm3I83mNOeokvbsVMA23DoQAHQL2ipU wB8A3tG2DfqmG1ThULfhIYZzulBY6aICwlrlmSXY+6X2yUEq1AqYWdOC20dVw7CHgv+L Vm5MToRyViQGFivmbheQ0dDig7cagT8VEvk7beWuyY9elqDfMXKuz+HrP+zRkYk4eu7d B5Grxyxsp9UGjbA9ECMsOYh2kdQ5JB1qc4sHaGqgvq/5Mg9IWIfGGRyRjOsNquEMlbyV Evhg== X-Gm-Message-State: AOJu0YzHsr1X+WY4OLhGxLmXNR/7/Qh7ahNllMgnEJkqI8NoHm13u0a3 31Yjm7nUvKcQ/mDKDlkMo5jMylLBRwYngawXzrt7ghOe34dEZijCbP8A4Bcgnbk= X-Google-Smtp-Source: AGHT+IEvaBJ1EAoM7XMitug7a/NQNwZ2GMcuPj+9Pyp+pxqnYpN4Y2JKVJZhBJ6VgvqO4qrwmTDuKQ== X-Received: by 2002:a05:6871:3390:b0:261:b94:b0b with SMTP id 586e51a60fabf-26c62c1a506mr5354178fac.1.1723455329347; Mon, 12 Aug 2024 02:35:29 -0700 (PDT) Received: from [192.168.104.75] ([223.118.51.122]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-710e58a8f22sm3595976b3a.46.2024.08.12.02.35.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Aug 2024 02:35:28 -0700 (PDT) Message-ID: <7612504c-cd56-4fcd-a287-d3fbc89162ea@linuxfoundation.org> Date: Mon, 12 Aug 2024 03:35:23 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kselftest/cgroup: Add missing newline in test_zswap.c To: Mohammed Anees , hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, mkoutny@suse.com, shuah@kernel.org Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240811145900.433711-1-pvmohammedanees2003@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240811145900.433711-1-pvmohammedanees2003@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A57E74001C X-Stat-Signature: 43ijgbohudgchx1fkym3bze9ijrk7zky X-HE-Tag: 1723455330-961236 X-HE-Meta: U2FsdGVkX18CUXu47oxiYqljrpLLGwu33xe/ajrY3+cKnte5zGPSz/S6GbfXCjvtBzd6KAInsP1coIoF42p0T4Xff7MPdhtTukPYRswttXEihKtQX+CbHFeXiQTeuG/VzC4zUPwzduvlIhjxDH6q8iYWS9DTHBJc5H6ZXwd3MGy5JRz/lRjufEF9D47u/0/cZ1e8jgyXQPc7Ekt0jRJLg2YGfQwUaNj82ixJlCHv+chlpU42Umn/kNkqpyuznwDBRo5HSl2P8SIl0606dukUWHU0JHMtBdAMm+J1CX3sGvtELvjNVrH7wrAE8jma+qmgQKCeIAArAwIpgItej+E+uYzK61mVHzkg0MgUh+QOafmDWLCHGYMFoGjzYNcN1Uqe7sh6SM7datAdjgBcW5KFtFigyXYReYiWfxAw1+xyYJUkm4QvZhx4UVZnQNNNHGYs2HrdCxyIn1YIYfk4fVzhi/5axMARIE7Loa/x9YsIC4NJs3T4kjw5dMB5Djq+T1XvHXtJbWZlQLPOpH2iNJ5U5D/n66QpGKnkwknJniXMNs0a1bJ6rWf+WYOj6zp+cLMZLVoJ06CD/Ycv559aQvXHDnYo+53kZg3+LsCi/W9RqtYY3VDeTisar49NpLJ/KxZzPWik+IYJxZ3uURXNz9WtNLvcnHW0GDhONb7Pvm8oPch9jyGvk1FI66VWpBThjsQMSq+A70QBVqNC5SoUMtfoIVZGDWWRYNZbX0XBesP64s7rF7A71BshuxhLhoPcxvL2J9wwO7BICx+fPHoxpRDDF987NDq6qa1bUrh8xrzZusLjmXL3Eep7LrJkBmf2O6W4IsERyHTIIZYmgyutQif3XmTHOmAn2fVtD4X9X7kofbi62Ca/lLg3hUuWE6PEGf9/lor6WsRBVxtnM1m8k/oRa/3n/vVeLxig870OrS5hYI/pUWOctzPMOYy/VduPRatgf9QTc/kc8AGkrsMBt7G kiJiMq4R fgPpEr3D526tdrEBHU4uPU3eYzlEKJTyKzwJkLr7ou6flDi0U8A7ST6X9UupvGkGLykUYxraKuWfQmKad8SDAkmPSryEdy/QTkuaCqooJrWO3yFWEH0/9qtqQ+w5DcOscq/g9VCUeEDKMOopVwkUGuOlC9/hsujSTcnN34eNAEkdnwBfUov4V0FHf7keflrwvuGas3fezi+R39feFG3IYP2flS39U41aCc3nrqPEpcUT5oPZ2r1QNKDpzlY+LJnHmtiQ1WdqPtO5aSBleoEmC3BLtVDVZPnjIu7j+38w9lByv7/d6xQd+lruh4UKwO4XI5+nxI4N3/Vj9kKut4JEhTCrN09ue4N/Nunt2JTrW7czS6hHO8110m61nTtPfZvp6AMF7g3ppnC1KQKqr8ORS9hAKedAyxu8e7ya/rr45LlxcLG6+4HntGeue3UybVXQWIU5CT+I1OeUi9VY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.269465, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/11/24 08:58, Mohammed Anees wrote: Missing change log > Signed-off-by: Mohammed Anees > --- > tools/testing/selftests/cgroup/test_zswap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c > index 190096017..7c849d836 100644 > --- a/tools/testing/selftests/cgroup/test_zswap.c > +++ b/tools/testing/selftests/cgroup/test_zswap.c > @@ -351,7 +351,7 @@ static int test_zswap_writeback(const char *root, bool wb) > goto out; > > if (wb != !!zswpwb_after) { > - ksft_print_msg("zswpwb_after is %ld while wb is %s", > + ksft_print_msg("zswpwb_after is %ld while wb is %s\n", > zswpwb_after, wb ? "enabled" : "disabled"); > goto out; > } The change looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah