From: Shuah Khan <skhan@linuxfoundation.org>
To: Mohammed Anees <pvmohammedanees2003@gmail.com>,
hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com,
chengming.zhou@linux.dev, tj@kernel.org, lizefan.x@bytedance.com,
mkoutny@suse.com, shuah@kernel.org
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] kselftest/cgroup: Add missing newline in test_zswap.c
Date: Mon, 12 Aug 2024 03:35:23 -0600 [thread overview]
Message-ID: <7612504c-cd56-4fcd-a287-d3fbc89162ea@linuxfoundation.org> (raw)
In-Reply-To: <20240811145900.433711-1-pvmohammedanees2003@gmail.com>
On 8/11/24 08:58, Mohammed Anees wrote:
Missing change log
> Signed-off-by: Mohammed Anees <pvmohammedanees2003@gmail.com>
> ---
> tools/testing/selftests/cgroup/test_zswap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c
> index 190096017..7c849d836 100644
> --- a/tools/testing/selftests/cgroup/test_zswap.c
> +++ b/tools/testing/selftests/cgroup/test_zswap.c
> @@ -351,7 +351,7 @@ static int test_zswap_writeback(const char *root, bool wb)
> goto out;
>
> if (wb != !!zswpwb_after) {
> - ksft_print_msg("zswpwb_after is %ld while wb is %s",
> + ksft_print_msg("zswpwb_after is %ld while wb is %s\n",
> zswpwb_after, wb ? "enabled" : "disabled");
> goto out;
> }
The change looks good to me.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
prev parent reply other threads:[~2024-08-12 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-11 14:58 Mohammed Anees
2024-08-12 9:35 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7612504c-cd56-4fcd-a287-d3fbc89162ea@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=nphamcs@gmail.com \
--cc=pvmohammedanees2003@gmail.com \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox