From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Daniel Cashman <dcashman@android.com>,
Jon Hunter <jonathanh@nvidia.com>,
linux-doc@vger.kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, linux-mm@kvack.org, hpa@zytor.com,
mingo@kernel.org, aarcange@redhat.com, linux@arm.linux.org.uk,
kirill.shutemov@linux.intel.com, corbet@lwn.net,
xypron.glpk@gmx.de, x86@kernel.org, hecmargi@upv.es,
mgorman@suse.de, rientjes@google.com, bp@suse.de, nnk@google.com,
dzickus@redhat.com, keescook@chromium.org, jpoimboe@redhat.com,
tglx@linutronix.de, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, salyzyn@android.com,
ebiederm@xmission.com, jeffv@google.com,
n-horiguchi@ah.jp.nec.com, dcashman@google.com
Subject: Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.
Date: Tue, 08 Dec 2015 11:03:51 +0100 [thread overview]
Message-ID: <7610963.Sys3aageLY@wuerfel> (raw)
In-Reply-To: <5665CF5A.1090207@android.com>
On Monday 07 December 2015 10:26:34 Daniel Cashman wrote:
> > Ideally we'd remove the #ifdef around the mmap_rnd_compat_bits declaration
> > and change this code to use
> >
> > if (IS_ENABLED(CONFIG_COMPAT) && test_thread_flag(TIF_32BIT))
> >
> That would result in "undefined reference to mmap_rnd_compat_bits" in
> the not-defined case, no?
No. The compiler eliminates all code paths that it knows are unused.
The IS_ENABLED() macro is designed to let the compiler figure this out.
Arnd
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-08 10:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 20:10 [PATCH v5 0/4] Allow customizable random offset to mmap_base address Daniel Cashman
2015-12-01 20:10 ` [PATCH v5 1/4] mm: mmap: Add new /proc tunable for mmap_base ASLR Daniel Cashman
2015-12-01 20:10 ` [PATCH v5 2/4] arm: mm: support ARCH_MMAP_RND_BITS Daniel Cashman
2015-12-01 20:10 ` [PATCH v5 3/4] arm64: " Daniel Cashman
2015-12-01 20:10 ` [PATCH v5 4/4] x86: " Daniel Cashman
2015-12-03 12:17 ` [PATCH v5 3/4] arm64: " Will Deacon
2015-12-03 16:12 ` Daniel Cashman
2015-12-07 10:26 ` Jon Hunter
2015-12-07 11:13 ` Arnd Bergmann
2015-12-07 18:26 ` Daniel Cashman
2015-12-08 10:03 ` Arnd Bergmann [this message]
2015-12-01 22:39 ` [PATCH v5 0/4] Allow customizable random offset to mmap_base address Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7610963.Sys3aageLY@wuerfel \
--to=arnd@arndb.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=dcashman@android.com \
--cc=dcashman@google.com \
--cc=dzickus@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hecmargi@upv.es \
--cc=hpa@zytor.com \
--cc=jeffv@google.com \
--cc=jonathanh@nvidia.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=nnk@google.com \
--cc=rientjes@google.com \
--cc=salyzyn@android.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox