From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AA22C4345F for ; Tue, 16 Apr 2024 15:26:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB5AE6B0093; Tue, 16 Apr 2024 11:26:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C66C56B0099; Tue, 16 Apr 2024 11:26:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2D586B009A; Tue, 16 Apr 2024 11:26:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 96CCE6B0093 for ; Tue, 16 Apr 2024 11:26:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 56AC4A171D for ; Tue, 16 Apr 2024 15:26:49 +0000 (UTC) X-FDA: 82015772538.01.9279A96 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf03.hostedemail.com (Postfix) with ESMTP id AB50F2001A for ; Tue, 16 Apr 2024 15:26:47 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=HefGEfta; spf=pass (imf03.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713281207; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AH62+gNelSnZzdOHEa7SUZyDZKY0aJP0NLE1ckRJgeY=; b=cwh5JZQCluz52haKTwNeCnOwo/Wule8UsUvHnkC+U3tQfiMzMNCL6jUCR4c8QRsFeC7xrm ULZ/MqYv0gGnVEXpqxcrG/pd0j4B1bhQ/9CPnF32dAyMDIdhXzzcnKOlhEWpQfyT7YmkyW JrOt1Bkvd4tEaL+QVF3eMuTb+GkdgkE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713281207; a=rsa-sha256; cv=none; b=tl4uOAZXsx7c8zTgZ37rj8l6niFZZKmlcwISmnS5JIU/GpCp9KJ6bSNBqqlv7rCnCZuwHu r0AQXTIl/g2O4SMlBMpYxvCedFYteF/pzm96hcN/ZMYft3u6+/TjDueEcHzLgW4FmkD1ka sQp/qcmsR4ag3U2KIoPyWKsM4WPPXtk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=HefGEfta; spf=pass (imf03.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1713281206; bh=FNHcD4Sgv7zzl0ohaid6qhEVjUCQjGVryAxf4STZYOk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=HefGEftahFgejDtXc8DcfD2s20vgfqbcpqof6CwHu727DcM/DC9SfycAdes0bq8td dOGpLR7g0/h3N2J+Q+7XRmB4z6/tpbhnVqf1h/0NlzgmsfwIsbvw8SRXByijNOgaUB Pg74NYKiXzXd18H1Gaa9/o+AvsXeUsXTkhlSFMmdEtv/7pbaP44U6ISfSaE9OXXcXk ejyArPgJMY6GmxWOyGNCuOkGjGtKnvJ4ojvK0JCCPbvs/ti+5Z35fP6oRJy5HHR4+/ C8kjTlD/6j/lzeq0/YA/ZfpmejzswWwQFAJFkLRut9l6tqVylDet5M0pD0KAzwqvPz eTRSNJcvwEs+w== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 000D937804B2; Tue, 16 Apr 2024 15:26:40 +0000 (UTC) Message-ID: <76103169-4c8c-4c70-9d42-058557115b52@collabora.com> Date: Tue, 16 Apr 2024 20:27:12 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] selftests: exec: make binaries position independent To: Eric Biederman , Kees Cook , Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Yang Yingliang , Andrew Morton References: <20240416152341.3186853-1-usama.anjum@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240416152341.3186853-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ucc7yyiatway7xzmbgq4dor3ni9njzkx X-Rspamd-Queue-Id: AB50F2001A X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1713281207-133889 X-HE-Meta: U2FsdGVkX1/wqDvPpjfQ/ajW0oq7HsXTJuPl5MfVyxSJXBTxvQt71tsw+MeAM1LM4A3XvD/wlKeHHm+GlXBbLOWUGRKnFrkLBvCqq6MnsrPLPfWsviIFEjw3VXZ8OtgegXhX/TEkkEeOneEz1KS+wXGB1f96ZC2rpgWO+N1ICMLxGXwsA+UXNfKiKC1DNwR+NG+u88a/Ji3V33fTpHbrkTHbsIKPKiQVwyHJpxyQm6G8mIg0qaym/hXuOz6LfHTNFCJvOigLVyIJmTRMWJje4QTqqlqytiKa+B2m2A/FcBVyN7GDScDiLyR/82Jf8iR5q16H6JQV6KH36f4gAc7N3Ist+na7LrUzq+W65KWjhRmksWIPdoleD9GYDu0Y+Y78+Cix5Xb0w4TItvgfhGsmTOl0MXzoCBzNb9dWJ8HomzXeFpZtEno/hEDqNJmVqlIUGR2CvJVJRADK9uwim+tJWTxsLTiGurJKQSEWvZc4loagWnXb0mBJzambV2C1gzNTX2UFsjnq42VNtR2jsAuJC60ymkuF6ZSpnDjurMeXW1YFY1CNkw+dOZ/kpCeBDb+KQqlwDStfAHOGqairksrJSz4SFV2uITLckGn8QEyoDxUPiGMJvKYQCmQGdMqlMEG0WuAUoOtBp1wk3tzrkIbQu2H3I2oCbeULs12OgTUXDK3CyNOXzBzJvcPUMnTvWZG3olG662TOCwsIZpiQczcKgB/87G208+rrv3PYUizBtr8jAbpRWtCL+HDGtCT8vDOXvjdGGE5xMuqSrGWQLZnmBPxzOgOU0j35ili6P9cojfFonGAL5ubtmhLFuIDYnSqzLf1U4OQG2WkMTxZewsmgCwBqjRbhj3zMGHhJUBrGp26Jf3zKk+cYDOdOzXsN0xiMRMYu0ihlhbQH+kKAxoJnoL1L08ZyCAx0CwScDixeVjnwIXQWBRgAxzh0rBFHLcj/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/16/24 8:23 PM, Muhammad Usama Anjum wrote: > The -static overrides the -pie and binaries aren't position independent > anymore. Use -static-pie instead which would produce a static and > position independent binary. This has been caught by clang's warnings: > > clang: warning: argument unused during compilation: '-pie' > [-Wunused-command-line-argument] > > Tested with both gcc and clang after this change. > > Fixes: 4d1cd3b2c5c1 ("tools/testing/selftests/exec: fix link error") > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/exec/Makefile | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile > index fb4472ddffd81..01940d9165d67 100644 > --- a/tools/testing/selftests/exec/Makefile > +++ b/tools/testing/selftests/exec/Makefile > @@ -1,5 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > -CFLAGS = -Wall > +CFLAGS = -Wall #-Wunused-command-line-argument Debugging artifact here. I'll resend by removing it as v2 > CFLAGS += -Wno-nonnull > CFLAGS += -D_GNU_SOURCE > > @@ -29,8 +29,8 @@ $(OUTPUT)/execveat.denatured: $(OUTPUT)/execveat > cp $< $@ > chmod -x $@ > $(OUTPUT)/load_address_4096: load_address.c > - $(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x1000 -pie -static $< -o $@ > + $(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x1000 -static-pie $< -o $@ > $(OUTPUT)/load_address_2097152: load_address.c > - $(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x200000 -pie -static $< -o $@ > + $(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x200000 -static-pie $< -o $@ > $(OUTPUT)/load_address_16777216: load_address.c > - $(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x1000000 -pie -static $< -o $@ > + $(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x1000000 -static-pie $< -o $@ -- BR, Muhammad Usama Anjum