From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFBDC4829E for ; Mon, 12 Feb 2024 19:13:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF9D36B007E; Mon, 12 Feb 2024 14:13:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA9916B0080; Mon, 12 Feb 2024 14:13:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D713B6B0082; Mon, 12 Feb 2024 14:13:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C56866B007E for ; Mon, 12 Feb 2024 14:13:33 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 586F2C0A90 for ; Mon, 12 Feb 2024 19:13:33 +0000 (UTC) X-FDA: 81784100706.23.A2F39AD Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id 13C4918002C for ; Mon, 12 Feb 2024 19:13:30 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mVJxBcyW; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707765211; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1wkGTwhk0CjFzMbhCdOBV4phKI3+/i9eAU22GTY6vzA=; b=XX8H5OSN+OoyQyb+MgZJJbIVUtCPQUZIwHiFT/EZ7ay5hTz1AIRFS4POluMYA+kcdCq84D wwN3tA5nHuBG/0EbwE8v1ICNebAq0YXnEbR6OaeZZX3qI0WONcNUR//4o9YS4k2VYGphA/ 515SwVyrO8YjHZKaBCsgyGSj3ol2yNU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mVJxBcyW; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707765211; a=rsa-sha256; cv=none; b=6KUgQDYghrlJsknjDF5Bf+8wipYP6iIJ7UsS1DLlO99seqEmRjvyw7SCqN3fSWpkMhz6al Vkz2nz8ZfwaDCCxaxxhmWcPce6mpFQ5LW4G0IXyKIAls17uGPDpperef0T7YYDR5cIxQxA 1+9I+Iw0Dr7sPv16WnWtF4STt3j+Em4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8A870CE13C5; Mon, 12 Feb 2024 19:13:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 720D6C433C7; Mon, 12 Feb 2024 19:13:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707765205; bh=lVcxz1blE5LkyB5fmTf0yVlJWy7lRWV3QJg/2l55jq0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mVJxBcyWkPzcN+qZv3RfniWWGIxIMuPq7cihILT1zdcW3PpqQpuzEdZHJken6yMyf WAvjW6AvzVC/Co6VuJc360H0F+jOU4dobxIDBhHHRdK8myIQH0o+Noh6jug8t6imf2 wzUqv2t02CDOVpFwfoKz/h+43IHzgh+ccr7S2Yw4lV13r4imNb4G6OvsMjGX10Yl6W RcJB2U4ED2FReuYFniuGnBBtdlP9YtKLEuasCecdh7rChvqi+bwPZ6R5wT6j6aOobN /Gva6vrnLumFDO0SGBhGNz8ANC4jplUx/cK2rMkXBVVP73Zku488B0NWM0o9oTiUFZ GhsLHp6DrGmTg== Date: Mon, 12 Feb 2024 19:13:21 +0000 From: Mark Brown To: Ryan Roberts Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm: Don't needlessly use sudo to obtain root in run_vmtests.sh Message-ID: <75fa3e12-8b0d-407b-b11f-333be70d157e@sirena.org.uk> References: <20240209-kselftest-mm-check-deps-v1-1-19b09b151522@kernel.org> <17c0b7a1-6ec2-4504-8287-f0fa111b9748@arm.com> <9ff817f4-e999-4a95-b00d-6984a7ea6181@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uZViTPliezr/CpYc" Content-Disposition: inline In-Reply-To: <9ff817f4-e999-4a95-b00d-6984a7ea6181@arm.com> X-Cookie: I'm not available for comment.. X-Rspamd-Queue-Id: 13C4918002C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: t3nent88wxudfbb6y63kph8o9hjzq7ms X-HE-Tag: 1707765210-369219 X-HE-Meta: U2FsdGVkX19HhYgzkhNhpxkVaHgoSMKwcFPA0JkRPzmEzd96dowi+/7SeCwkp/rBLeXCUn9+PJBEXj6XgwCxcmK5CdI6GdZLiTVOoNMsxEpV6iM671dhTGQ+GXxB5DkIy6obNcPYbh/0fRc+/X3zk75C1ZMoZLlmlrfpmWdzI6vwvT5BIEPJfVDyzk27QJllzPvwAx5bkChqjkDKyvq/tnaHdzkPpB/DGCD06kX3QyZAWxdK9PYEo5syjXXl2/nIo1Gwq6Ux3nFUtcE5uWKqB8jCHTJlIKfsbR4vLabrT5mtKUQbyP2IcMhz1M02jxLLVwXHjCtKTDQ9/dKwMozNzPvqnFy/7dqjNTxOaeK1ysKaBfnALlqCTgm3+1YrwemAKn/2O7scO23+dBW2U1pO9XwGydg6IoJKOQumTx/VhSbZuR/GT5KiVYRcs4lwn/M7+K4VvJ8MiNxbLQuIopER2kEobDxOjohwH7sudz1bwGHQJHjyWYzcleQstP1OkzGYEiEOlqWR5LwVQPfDV19SBqplX+VedX63QRxhougYTJ0Od8Mj4XOsOFl58MyROPT9YbS5ggV+Y2yq65Ev/4khRXb4AYyzjMRHsxrkxYo0Cv18N6fdid+KY6OzPvpjMe0zPpj96pU1J29Usr0AOeTpPCybwkDyjmRi+gBKPCs2lUDjgprG5V8iloWf2PH7+r3LcDEARxp3tsGSinucAehmvgRovv7mDxE8bGaBJFYET0wuy6lCAV3F933KfnRoSbX66qS9DMZY8Yrv0czOvQmsilpi/2RlsntEAqpErTLM2zY+9eWtRT3wKVHymzkcs3xBQuj6IRFMomgo/bZD9Rj30gII7R7d6ZIGYDfzuCD9CnTrRzCxTqc9Cl7YAWmtCyz63g0SaKLfL5idCVIE42i2wR1VyFAkWqxfX/W9u/KpRemDgaRKdEEOe39ETELG1m2AppmzgXrKq/cmLP4Va+u e5HWU7PO 2PA9IbU4n65MwR28afkUwdminxlYQcgcxeB41EKWB79dOMorBqynqV2f5ivrsR4JE97wXLS4Liv9xl1coI3IWtoXdfP1C42IRyWI9klwCktal5Ro1CsyMo5mhS+U9cyV7kVAOXrg4JH6d+g+MU+cxnayZSqeUmOXtv6DsE4ychQzLisF5P2vJE7Mt3ZUY0jhFzaU919EuVVVAP26jfhEEikc8cfhq00sdHzxSqzRsA1FmFSXgWvSm/M4CvIVc+gqXP3E7wmYCyUeD7NLq9NhUDKGIJKVXJAqqsKei X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --uZViTPliezr/CpYc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 12, 2024 at 08:32:58AM +0000, Ryan Roberts wrote: > On 10/02/2024 12:35, Mark Brown wrote: > > Ah, I was assuming that some of the suite ran usefully as non-root given > > that the only point of that sudo was to acquire root. If the whole > > thing needs to be root then we should instead have a check for root at > > the top of run_vmtests.sh and just skip the whole thing if we aren't > > root, but then I'm unclear why it's invoking sudo in the first place. > I can't speak for how others use the suite, but there are a bunch of setup > operations in the script itself that require root (e.g. reserving huge pages). > Some of the tests will work without root, I'm sure, but I'm not sure its hugely > valuable. Personally, I'd vote for just doing a test for root at the top, as you > suggest. The hugetlb tests appear to be checking for root while running... I'm not super fussed either way myself, I don't really use these tests myself except in a general "keeping an eye on CI" kind of way so I'd not object if people wanted to just go for just requiring root for the whole thing. --uZViTPliezr/CpYc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXKbdAACgkQJNaLcl1U h9C6wgf/RJIOLX4PFd2MsE1xuGjw2/lCoxf8qoDdaoqGpAAVWq86BvYjlgCaB9H4 g6HK0IaPAvY0XWfuPV4ouY6OsbBE9DuvB7mwNbqG7pg7hKIdpod/fuev95pfWZbo SnYocqjGxxYZQwPE+YqWcnbMIvkcboD+8gcIy3yle013yXOkn3dHdndPDpnNzAK0 +Sa8Y8E+pUt4pBJjLIuklEmf9tOfHakk2zMZk0JbF55KQVxcI6hPcENxZ7AGCEOx cG8h/N3e/2luVdi7FqAKo7McRek9EQpIpg96YKBA+QX8xgjzEZ2komh6G9hBdvvL Xd2XSTk7BozvqzbobHD0PGrBro40CQ== =wlBc -----END PGP SIGNATURE----- --uZViTPliezr/CpYc--