From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44B7BE77188 for ; Tue, 14 Jan 2025 15:06:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3CCC280005; Tue, 14 Jan 2025 10:06:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CEC23280002; Tue, 14 Jan 2025 10:06:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B680B280005; Tue, 14 Jan 2025 10:06:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9716C280002 for ; Tue, 14 Jan 2025 10:06:35 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 362E71A0B26 for ; Tue, 14 Jan 2025 15:06:35 +0000 (UTC) X-FDA: 83006383950.06.5F44126 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 9045640021 for ; Tue, 14 Jan 2025 15:06:30 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LsZZnYkV; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736867191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jY3lgdWAPbjtkPZal0q4gpqn+HYdW2IQliylF2Zir60=; b=A8vsDQifcdOfD5Ofuh2YQD/8IHk1mWDkTmUvINDWSQr3fl322xW9yEB35HyPkZP4gTtfMX 6sz8OB5TQpf/ePzFoz8KFo1L3wnMq+D5vV8l93jeLJPVSB24OKXc+MZAkHRBPlJLoNYcfM cPztko+/bkYm8YhiHX0Hor8zKBoHq2o= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LsZZnYkV; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736867191; a=rsa-sha256; cv=none; b=ni8Pj7j3W9to2Yd66QNkBcRAnZ9vGMLj1hDtxEKZ1RznxTJn7zRWqhPr3KlquVVlZDoK7J H4y12fnq1SJFgX1ChusP5l4P3feZk/07a4+PzEZE0VpsvEVjrFqVre9pgJqPixULb9Wnxr lxSpg+mmrp+pXHS66yQlTP4Wm11utf0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736867189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jY3lgdWAPbjtkPZal0q4gpqn+HYdW2IQliylF2Zir60=; b=LsZZnYkV7oQfGVDo9Wz+HaXBRIZwCxfBifAfPh5E2ZKJiNiYB7PnmT/eLf9yMuCoa7noXD DHdqoxK8upgmsde663hxpLRQPXVdtHwqFRXNL3yj/YLmRxvunQ2yQnfP1WPszCe9MFdFsq gqs578BlYyp5ijInFeGZ5x6hAuEFJ00= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-199-1VKM56dMNe2I8FKByLPZ-A-1; Tue, 14 Jan 2025 10:06:27 -0500 X-MC-Unique: 1VKM56dMNe2I8FKByLPZ-A-1 X-Mimecast-MFC-AGG-ID: 1VKM56dMNe2I8FKByLPZ-A Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43621907030so19417425e9.1 for ; Tue, 14 Jan 2025 07:06:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736867186; x=1737471986; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jY3lgdWAPbjtkPZal0q4gpqn+HYdW2IQliylF2Zir60=; b=vAvtOZaN05AG5wE9sSZvAhKS8QtCxePRANzUeZeAmOy7AS3EBhIlE3vDu/Fdy0XVLF kKj437l+rNc+tbZM6RzYHmw2fc4bWOHUHRVMpc4a9Zjvk56JHJCAo9VmRDrzK3NYFj8b OQFu0MOfBUllhrr4mOukxs5zUzontlDZSH1zi49Dk5ZsYktwSRh2U3CMWnpVQfaVCOg2 LfPuRrUoA295pQlFhN6UZCZ6FRSVr2uPBvqlqyYA5VrQajQB+kAaC1owGo0pxELtn5Ma M+QvjnwvEFLQkm2YomLTIE2hXF2uNwRrMAIgUXb/IxJPhZthKI4v0gA9RVvI3h7hlZz8 A7Yw== X-Forwarded-Encrypted: i=1; AJvYcCVlJiU7uV86tG8oUPkZ0EMhxXrNjm7m+zinXqatzCIACMAXFK3d96esh/9Z+EKVShHpsCHXNc1TAw==@kvack.org X-Gm-Message-State: AOJu0Yx5M4MfygmerDe7XhGSGAwz+Z5qBHVtecpEqBgzoq+yxSoj4iMg AufKOTjU41O0nKXOq8Z3ch3ul9r/d2pITcMt9GusnpX+kW1blIzaJSga0Kc2tG7jGSz9WUCbS31 fum1C2nGhwMg3kg7nuMsAeNNAnVDoalog8/rJUqtBcdHr8WvK X-Gm-Gg: ASbGnctuWjuUlgcokGhEjov7SOPxq7eG+KapgqcfkBt3mbIE2ZUfm72NmuA9XrdH3kk QCNy1ISy4YwEzkC/mqc+Xy8F0uXu+y2B7oc133OKbjRS0C+olBwi0a/cSpRNpWgCNBksqWZykIW qMqJw576l40A59TeFxYaT5OiMvyV61Cw5O8x0rmYpNq06zEAYiAx8UjCweJuFzmsOFCN/pjPSac UaOgQHv5I19jNABXO0/rp4GlylmxYOOMkYcVnV/4ZSDiIs05Qk45o7H6EKKF2l9Sz8PF4l44Lxn 9tlL7O8p5GGl5PbfRzRBUZ9hopcPnA92BUmIL5Vhx5ceqPuEIpQ7Koa7yvXN7sMgjRq5lc1X0QI GlDDVR2mu X-Received: by 2002:a05:600c:6004:b0:436:e751:e436 with SMTP id 5b1f17b1804b1-436e751e59cmr196575165e9.19.1736867185816; Tue, 14 Jan 2025 07:06:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGP/+VlMxDFFfronQS6ZdPiAoWj+v+EOLf2k4AjrUnQdxmLz0Q8nmcW5p4VKStJ45UlOLgUwg== X-Received: by 2002:a05:600c:6004:b0:436:e751:e436 with SMTP id 5b1f17b1804b1-436e751e59cmr196574205e9.19.1736867184893; Tue, 14 Jan 2025 07:06:24 -0800 (PST) Received: from ?IPV6:2003:cb:c738:3100:8133:26cf:7877:94aa? (p200300cbc7383100813326cf787794aa.dip0.t-ipconnect.de. [2003:cb:c738:3100:8133:26cf:7877:94aa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e03ffcsm177421925e9.20.2025.01.14.07.06.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 07:06:23 -0800 (PST) Message-ID: <75dbebfa-d13c-436e-a9ac-87f98b140cc6@redhat.com> Date: Tue, 14 Jan 2025 16:06:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] /dev/zero: make private mapping full anonymous mapping To: Lorenzo Stoakes Cc: Yang Shi , arnd@arndb.de, gregkh@linuxfoundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, willy@infradead.org, liushixin2@huawei.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250113223033.4054534-1-yang@os.amperecomputing.com> <08e7f845-6b86-4fdc-830d-23f15ad90475@redhat.com> <8e88bce5-3be3-4e84-a327-841c91906a79@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8e88bce5-3be3-4e84-a327-841c91906a79@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: S6z-oveRN-LFHW-Zz09CdY-ogm1k7fZQvvmCO8_yYIs_1736867186 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Stat-Signature: z6yt83qb3onweu4o5nnjj6ptmhjbxesz X-Rspamd-Queue-Id: 9045640021 X-Rspam-User: X-HE-Tag: 1736867190-281287 X-HE-Meta: U2FsdGVkX1+uNBRdXbJ4A66SsWBjpRALKysz6r9bekjyM1YjuhiXJQvE54QcFZZUrxCevMMEtbqwuR9MTM17bOy5alqXmLwaxykD4Lx1yWo/bYG9iETSYh5QCJLpNVQCo+ta52IHD2U6FlbIbvl7asvmQYSUNaYgjH3cYhmrGxMEtb4CA8inbF7ZPJj5LnL9YRsb9n8NbgotLF8di8EBExm8nHtfxeDuSa/vhCKA5rjH+QP5folRsoTlxIIFqFA1vNOoEGAKu6ThjUHxz0I2gI0tmeJjphJQo1PvTFTyRIRS8r5myBxHvwWmjPV+Sz4mcHuOZmmXt0KZhfvAsgK7XDeffRGTh5oCdQys7tYClYRXjncrH3AiOFl83IKM12aLQyBZrjMW4HCvSmGH9w5CxAZ2l/vY0ejBsD5BBjmVlEOX/5u3sl3TnUwlaveUjIKkEY2h4JQZJ4b8+30IpCoq3GVv1ZhwlnH27Prg57ys4YZNhzQPK+jD3qZD7Ukv4R1Up/0Q1DzADLZdE0YAzkJQZ1K6D1UPU4DxVNUnWvJa0NQYwmWpyGqn9+DqPJAqfoVTEMu8BEtt9KFzjJNel17RA2MkmnRxePgUD/FFEXcU+zhBD0X7DNMeWTa7f3duhlKCuRuM8Kdwj3ooA1+kwsWjgYYFIJ6asQyLzSWFGfZJVOwaJr1cYM1aPPgrNNdlJeboYD/lTWEEeN1HHct+EEmgsX/XIAc7Lc/FvoA3eDg+Zc/v3quQalfJsKWko6NpkiROrTMLHeMIFT1WIAoMKR3LF7VTYDd+Keemsv1vbf2BX852IcP5VYQyZqtVG+h+hn9yW+tntLl5IsnLfZ9w2w6iDORRZUKCBSwpDxYH+Tkda0bVw0PnHruvQt410tkK30U6J+7e5vhQdEAct2ZmyDCUHW4LaE1Yu5RFzyMQF1XvFs5cD4Y0bC0sSVJaW5q/vzV2goiCh01tAvVF+J0TXH8 UxUVRWpZ N87wRlDDU6QddTUBXXPcBgd7VJwHr9Ij2x6WlfJLYSByF4ydsidTDpxS24GWhuayp67jd0M+tg767o0oJ7VMvn15E5TTaNXv2g+Rp3KEuOuH0dO3sVIqiKYCSeUmwU8cVGH+mP3ShabIKtzhPZluE6kRTbbsut4ZM7bnZzzeupqockEbmG/km0iezk4X6/wIDYjekg4ceWVfqvjTYkmEQxAW58FhtIsGxklXSMaS95tl1ml16xGmKm2hsnhHPoWB28MHkH9ixe5KnQobPTtNdV3ZFZDnJl0S0B1vItj63BhIAFAKXyUx988DpI5Mn7KxNvkCCh3+FyLdZm1zS4j3xLE32W7H0y10/d3cMcl1PBlbAhSbEGPj42D+MKYEJRdWsHzAPjVeIKsZ8d4feBlZHfqvJPw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.01.25 15:52, Lorenzo Stoakes wrote: > On Tue, Jan 14, 2025 at 02:01:32PM +0100, David Hildenbrand wrote: >> On 13.01.25 23:30, Yang Shi wrote: >>> When creating private mapping for /dev/zero, the driver makes it an >>> anonymous mapping by calling set_vma_anonymous(). But it just sets >>> vm_ops to NULL, vm_file is still valid and vm_pgoff is also file offset. >>> >>> This is a special case and the VMA doesn't look like either anonymous VMA >>> or file VMA. It confused other kernel subsystem, for example, khugepaged [1]. >>> >>> It seems pointless to keep such special case. Making private /dev/zero> >> mapping a full anonymous mapping doesn't change the semantic of >>> /dev/zero either. >>> >>> The user visible effect is the mapping entry shown in /proc//smaps >>> and /proc//maps. >>> >>> Before the change: >>> ffffb7190000-ffffb7590000 rw-p 00001000 00:06 8 /dev/zero >>> >>> After the change: >>> ffffb6130000-ffffb6530000 rw-p 00000000 00:00 0 >>> >> >> Hm, not sure about this. It's actually quite consistent to have that output >> in smaps the way it is. You mapped a file at an offset, and it behaves like >> an anonymous mapping apart from that. >> >> Not sure if the buggy khugepaged thing is a good indicator to warrant this >> change. > > Yeah, this is a user-facing fundamental change that hides information and > defies expectation so I mean - it's a no go really isn't it? > > I'd rather we _not_ make this anon though, because isn't life confusing > enough David? I thought it was bad enough with 'anon, file and lol shmem' > but 'lol lol also /dev/zero' is enough to make me want to frolick in the > fields... I recall there are users that rely on this memory to get the shared zeropage on reads etc (in comparison to shmem!), so I better not ... mess with this *at all* :) -- Cheers, David / dhildenb