From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A29DC63707 for ; Wed, 7 Dec 2022 05:54:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBCA28E0003; Wed, 7 Dec 2022 00:54:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E6D2C8E0001; Wed, 7 Dec 2022 00:54:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D34168E0003; Wed, 7 Dec 2022 00:54:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C330C8E0001 for ; Wed, 7 Dec 2022 00:54:37 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9671E80150 for ; Wed, 7 Dec 2022 05:54:37 +0000 (UTC) X-FDA: 80214445794.30.E4FE509 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by imf12.hostedemail.com (Postfix) with ESMTP id 36D9F40013 for ; Wed, 7 Dec 2022 05:54:37 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jrMcMWNX; spf=pass (imf12.hostedemail.com: domain of hughd@google.com designates 209.85.167.170 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670392477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WBYgV1mZFl4MlIUpWq//PTUJy0AvbU34Ve81xSxprtQ=; b=BodEmprMVziuHF9WqpskNEW3cmTo3pJLrxK7nUxfQfqVEoljkROilZAU0m81Z8ewAG2pcN pQ9epruxEgxF+eQNe7r6s9AV5EQkotuDbdBX/Ve6YIj3Nb05/z6L1TYYqB8D72WjeZs5ni DuLF+dREt7HOSrZ4DBbEmOQ27VggpIU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jrMcMWNX; spf=pass (imf12.hostedemail.com: domain of hughd@google.com designates 209.85.167.170 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670392477; a=rsa-sha256; cv=none; b=f/AXGnJd07x5s3+uQXcha4Q+h8qLt1Luc97g6NPb5X71btXDjxhCnqDAnFq81QrihP5xqd 0rTtA+88TvFM2zgvkfJ7N0diMHezMyRNlAT6BcrELgMVlnqJm0o7roMMwD510uzFJY/Gjs GqRFzTy1ZdSvQNdOg6Z32uOoeDRgCT8= Received: by mail-oi1-f170.google.com with SMTP id t62so19584885oib.12 for ; Tue, 06 Dec 2022 21:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=WBYgV1mZFl4MlIUpWq//PTUJy0AvbU34Ve81xSxprtQ=; b=jrMcMWNXmDtoPJaOjBj5Nd7lpZZsSVWGDFC1bkW4DdQtU/HsR3lje24Pn3vTXZxk8W KEl4VjGaT/Ihy4rgyPWGoR1rdQ5CQW+uoaoM/6kK91989SsKLKfWyRKOfHZnwa+k/BO/ wP5CPVtIdafh9JvV8ugNuYlaoEmenSWftJvqq2wZ2eF/XTdwBnCtx6MIPmlXysUUOi5g 9RXcjytVNPz1Ztb6P4nCoKVQpKpAxqO9IaND46q2mrPhxrdkOF9zXo28inihqtG0A94P lI8/h5wWZ1RsLKY3I6z7RfJlA+gCva9ODcIfHc3s/rdl/FVs28snheDaFTpIuq7QMRSa N0UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WBYgV1mZFl4MlIUpWq//PTUJy0AvbU34Ve81xSxprtQ=; b=BpG48YmBi8u6kYKVE2GLVa9iIEB9faabBo1znKrv6cBFPrU8G60l8aA1x6IpVVb383 ryd0t8fASZjMgi9HW1qWAloqj2J37G/F+0sVrLajvd8YODNdvx9CRWcPV/Xxzomvmi1R X+uPG+8hMBY8ZqlnlTeIbTuSHOJOEqNPnY5/jOhmRW5sokFXKL8RXipX6TLMWzHbTF/H Hfs82nZVnUD8izz8Xsma+PZXhtRS22eKGymqqTkkE0em5Fo3hxTGm60dlIZSaAcyAPXq 6BmF3sfGu3KDbf0ayxjk3II6RLKccGdVCXAJdFECRq4kEUjQgCbg06W0ThHHFyoJqMK8 g2oQ== X-Gm-Message-State: ANoB5pk9q/Uyp3D774rh0t7j+RIsNiLQ4CS9bWGCnaRwqG3hLSb+KErf 6EFafiXBeEJa9BMx5uxODIuYiA== X-Google-Smtp-Source: AA0mqf7L8b2MBbL62F/T16YRGt5DKfU0aM6bsDE5BREKFfDVa2s9WMxzIVQlQt4nDeCne0xVzxmY7g== X-Received: by 2002:a05:6808:1ab4:b0:35a:6f68:5fdd with SMTP id bm52-20020a0568081ab400b0035a6f685fddmr33494042oib.91.1670392476227; Tue, 06 Dec 2022 21:54:36 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id fo12-20020a0568709a0c00b001431bf4e5a0sm11837268oab.38.2022.12.06.21.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 21:54:35 -0800 (PST) Date: Tue, 6 Dec 2022 21:54:27 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: "Huang, Ying" cc: Linus Torvalds , kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Andrew Morton , Johannes Weiner , Hugh Dickins , Nadav Amit , Linux Memory Management List , linux-arch@vger.kernel.org, feng.tang@intel.com, zhengjun.xing@linux.intel.com, fengwei.yin@intel.com Subject: Re: [linux-next:master] [mm] 5df397dec7: will-it-scale.per_thread_ops -53.3% regression In-Reply-To: <878rjj22mz.fsf@yhuang6-desk2.ccr.corp.intel.com> Message-ID: <75d9bc6-f43f-5169-29af-b3cd5653a77d@google.com> References: <202212051534.852804af-yujie.liu@intel.com> <87ilipffws.fsf@yhuang6-desk2.ccr.corp.intel.com> <878rjj22mz.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463760895-1086260698-1670392475=:5515" X-Rspamd-Queue-Id: 36D9F40013 X-Stat-Signature: 784rn8oz35uo4bqmfka7gwf6mynyh4oq X-Rspam-User: X-Spamd-Result: default: False [5.76 / 9.00]; SORBS_IRL_BL(3.00)[209.85.167.170:from]; SUSPICIOUS_RECIPS(1.50)[]; CTYPE_MIXED_BOGUS(1.00)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; BAYES_HAM(-0.84)[78.26%]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; BAD_REP_POLICIES(0.10)[]; TAGGED_RCPT(0.00)[]; R_DKIM_ALLOW(0.00)[google.com:s=20210112]; DMARC_POLICY_ALLOW(0.00)[google.com,reject]; RCPT_COUNT_TWELVE(0.00)[14]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; DKIM_TRACE(0.00)[google.com:+]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Server: rspam08 X-HE-Tag: 1670392477-999951 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463760895-1086260698-1670392475=:5515 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Wed, 7 Dec 2022, Huang, Ying wrote: > Linus Torvalds writes: > > > > Does this fix the regression? >=20 > I have tested the patch, it does fix the regression, the test result is > as follows, >=20 > 5df397dec7c4c08c 7cc8f9c7146a5c2dad6e71653c4 7763ba2bb16804313aa52bc78ae= =20 > ---------------- --------------------------- ---------------------------= =20 > %stddev %change %stddev %change %stddev > \ | \ | \ = =20 > 2256919 =C2=B1 5% +114.2% 4833919 =C2=B1 2% +116.6% 4889= 199 will-it-scale.16.threads > 8.17 =C2=B1 6% -8.2 0.00 -8.2 0.00 = perf-profile.calltrace.cycles-pp.native_flush_tlb_one_user.flush_tlb_= func.__flush_smp_call_function_queue.__sysvec_call_function.sysvec_call_fun= ction >=20 > Where 5df397dec7c4c08c is first bad commit, 7cc8f9c7146a5c2dad6e71653c4 > is its parent commit, and 7763ba2bb16804313aa52bc78ae is the fix > commit. The benchmark score recovered and CPU cycles for tlb flushing > recovered too. I didn't study the patch.diff at all, but slipped it into my testing of Johannes's no-lock_page_memcg-in-rmap: no ill effect seen in 9 hours load. Hugh ---1463760895-1086260698-1670392475=:5515--