From: Hugh Dickins <hughd@google.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
kernel test robot <yujie.liu@intel.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>,
Nadav Amit <nadav.amit@gmail.com>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-arch@vger.kernel.org, feng.tang@intel.com,
zhengjun.xing@linux.intel.com, fengwei.yin@intel.com
Subject: Re: [linux-next:master] [mm] 5df397dec7: will-it-scale.per_thread_ops -53.3% regression
Date: Tue, 6 Dec 2022 21:54:27 -0800 (PST) [thread overview]
Message-ID: <75d9bc6-f43f-5169-29af-b3cd5653a77d@google.com> (raw)
In-Reply-To: <878rjj22mz.fsf@yhuang6-desk2.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]
On Wed, 7 Dec 2022, Huang, Ying wrote:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
> >
> > Does this fix the regression?
>
> I have tested the patch, it does fix the regression, the test result is
> as follows,
>
> 5df397dec7c4c08c 7cc8f9c7146a5c2dad6e71653c4 7763ba2bb16804313aa52bc78ae
> ---------------- --------------------------- ---------------------------
> %stddev %change %stddev %change %stddev
> \ | \ | \
> 2256919 ± 5% +114.2% 4833919 ± 2% +116.6% 4889199 will-it-scale.16.threads
> 8.17 ± 6% -8.2 0.00 -8.2 0.00 perf-profile.calltrace.cycles-pp.native_flush_tlb_one_user.flush_tlb_func.__flush_smp_call_function_queue.__sysvec_call_function.sysvec_call_function
>
> Where 5df397dec7c4c08c is first bad commit, 7cc8f9c7146a5c2dad6e71653c4
> is its parent commit, and 7763ba2bb16804313aa52bc78ae is the fix
> commit. The benchmark score recovered and CPU cycles for tlb flushing
> recovered too.
I didn't study the patch.diff at all, but slipped it into my testing of
Johannes's no-lock_page_memcg-in-rmap: no ill effect seen in 9 hours load.
Hugh
next prev parent reply other threads:[~2022-12-07 5:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 8:59 kernel test robot
2022-12-05 20:43 ` Linus Torvalds
2022-12-06 2:02 ` Huang, Ying
2022-12-06 18:41 ` Linus Torvalds
[not found] ` <CAHk-=whjis-wTZKH20xoBW3=1qyygYoxJORxXx8ZpJbc6KtROw@mail.gmail.com>
2022-12-07 5:39 ` Huang, Ying
2022-12-07 5:54 ` Hugh Dickins [this message]
2022-12-07 20:17 ` Linus Torvalds
2022-12-07 22:20 ` Andrew Morton
2022-12-07 2:12 ` Yujie Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75d9bc6-f43f-5169-29af-b3cd5653a77d@google.com \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=feng.tang@intel.com \
--cc=fengwei.yin@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=nadav.amit@gmail.com \
--cc=oe-lkp@lists.linux.dev \
--cc=torvalds@linux-foundation.org \
--cc=ying.huang@intel.com \
--cc=yujie.liu@intel.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox