From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF24BC7EE23 for ; Mon, 22 May 2023 01:27:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 285AF900002; Sun, 21 May 2023 21:27:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 235EF6B0075; Sun, 21 May 2023 21:27:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FEE0900002; Sun, 21 May 2023 21:27:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F0CC96B0074 for ; Sun, 21 May 2023 21:26:59 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8E4B714022B for ; Mon, 22 May 2023 01:26:59 +0000 (UTC) X-FDA: 80816152158.17.88C3919 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf29.hostedemail.com (Postfix) with ESMTP id 4F833120015 for ; Mon, 22 May 2023 01:26:55 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684718817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ai2wuByr++Z/Up7fMpyNB1VFMgULX50f1dSZZazF4hM=; b=KtpneTKnGoSIpMLdRH1rsMvtqWD3DmIOS0kOigU/a09kLkLcZxIasVsZ3x/YlvdQPzwIoq G5Abw0ZixRkFnPpzHR5kh2exInmCsOZisvnmcnQr9GMbb6d5SYRe25Mf/EVFeQrr49fdCn j8i1hJ890UjOdwGBtOKLRNzMTvqSKtU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684718817; a=rsa-sha256; cv=none; b=gFAvz5LPWKz4ztxzChg/ZNpgWrVJ+3jaF7cEr9VijNXLbm8YUQPx8X5DRtnd/QZbQcSDa9 sEAs6re0FjhzbBrrV0+hjdwDEy2n4qw86o/Btsm3j+xynp5RKYoLsOk2wFLN0bgj/g7HEY NWlJysOip12ac94bnmWWVSWAjwMvhnc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4QPfs215rWzLmGq; Mon, 22 May 2023 09:25:26 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 22 May 2023 09:26:51 +0800 Message-ID: <75d8452c-695b-b22a-30d0-15302cd072ef@huawei.com> Date: Mon, 22 May 2023 09:26:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] x86/mce: set MCE_IN_KERNEL_COPYIN for all MC-Safe Copy Content-Language: en-US To: "Luck, Tony" , Borislav Petkov , Naoya Horiguchi CC: Thomas Gleixner , Ingo Molnar , Dave Hansen , "x86@kernel.org" , Andrew Morton , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "chu, jane" References: <20230508022233.13890-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 4F833120015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 9q7aqtfii695us9yu6uc5emti1ag3sx6 X-HE-Tag: 1684718815-438807 X-HE-Meta: U2FsdGVkX19L1DCu6hbyeBxBQ05rsZsxlpimiudga86NERHbTTYMR9eLWvYU+Rg7ALVoIatXEBoUmEaALUXGOXOXsatxAB2eIbHiVCuk9gcBZTxelea3Ua+SWfY3HGKyHVeqj7vUfSAT5hrew5pg22Dn3Dk3GZ2QRAGPZp6Y247Q1kt73CLp+DP+IdKbEBhZ8UNBFSA8sQqtTgUz7wIiDPaqXttb/4Dv0Y3yiFhQVjxk7d92ORPEqifs5+Uu6490Zl7EH1BEQlHe8BUxlp0SaXFLV6YnPvImPYlW+/yZkDcUseFI9pEL3uiBhgtc6kmgJPK8OBk2+F/814I1Zh39lBZbSfcDCrNu053hp+XtQiLlWAKfXixH8agSwi0TCFWIObRtNfSBzIq1SIIbXdI+EJY14/OIU1bcJ8jAAhnL+F+2hDa2Nx2OYD3AE2qID2SKvg0tx/B7boZYjmbWWDeUPTfyE3CW05fFvFpkr0Yze9R84dz/4maly8UvyXv1VpOrPuO96amu8JX7pXRuOf6EmZ4tYUYCBOFTejsK/HZ8BES8M4EStiUCa79I4gO4Cwrpi1a+VS+8HQeD/4oR8bugnyEmylexovsenGFAmh6+sv9nayDK8XPfAr1roazgkxVBX9i5MBpVxXJbp+nCSrr+8Z0em+GzRj+sZYHNTU3254WVTDnp36Zo6GD7Xq1BPCPaysTdqoQTOhBYUCJdMECMkcUfQ2Ao2pH8jhyIEG1b1pm8aknAfItWY6ujXe0FY8rvMWMgnRHrCmFMBWcwslnybwpZjGZ4SExTPkYS+n8faDCFosy3oIDKxetP/zaCzX6zA8S8lw8i3BLfjdZf1vrlyUUtjoBywtHe9fhlOQo/xapxcia+kWqK9Qn8XDUED0Tz23V0gwesNzcr9cQP8dWPHhykCW5+A+UVoJxaB64Tvy4XCpR7PTT4bKJp4+1M37Xyzo+KqT3Wy5MkSzRyUxa eVr7QZXS 1dN5A+UDkEVZqTfosOF4GP17t+dqzjTqJspmUJiYGyFkDiZmmmF3E7QUs5i/QN1nvEEzES1tNGfXsRUsMIrl2GP/axPhERXK3s4NyaW+YO8yVl+wyP/GjyOMIFG8gTMPT+DjyegZxomQWFixGNdS1A8tZwFzk09U8odL+B+kX2MYoHbERBcqu9XX6T2Kv/3MBuAEjvTm5F/rOJlumMoorReSBkhmXkJHGp4UlLvHr4Q1MwMV1YyOW1zUefPYpzihluBc8iBI2R1g5+h3LmvbF7/JwE4MOx0pG/usgEqtfQavWFudq7aGZAOIomw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/5/20 0:17, Luck, Tony wrote: >> For now, the MCE_IN_KERNEL_COPYIN flag is only set for EX_TYPE_COPY >> and EX_TYPE_UACCESS when copy from user, and corrupted page is >> isolated in this case, for MC-safe copy, memory_failure() is not >> always called, some places, like __wp_page_copy_user, copy_subpage, >> copy_user_gigantic_page and ksm_might_need_to_copy manually call >> memory_failure_queue() to cope with such unhandled error pages, >> recently coredump hwposion recovery support[1] is asked to do the >> same thing, and there are some other already existed MC-safe copy >> scenarios, eg, nvdimm, dm-writecache, dax, which has similar issue. >> >> The best way to fix them is set MCE_IN_KERNEL_COPYIN to MCE_SAFE >> exception, then kill_me_never() will be queued to call memory_failure() >> in do_machine_check() to isolate corrupted page, which avoid calling >> memory_failure_queue() after every MC-safe copy return. >> >> [1] https://lkml.kernel.org/r/20230417045323.11054-1-wangkefeng.wang@huawei.com > > Is this patch in addition to, or instead of, the earlier core dump patch? This is an addition, in previous coredump patch, manually call memory_failure_queue() to be asked to cope with corrupted page, and it is similar to your "Copy-on-write poison recovery"[1], but after some discussion, I think we could add MCE_IN_KERNEL_COPYIN to all MC-safe copy, which will cope with corrupted page in the core do_machine_check() instead of do it one-by-one. The related patch is normal page CoW [1] huge page CoW [2] coredump [3] ksm might copy [4] [1] d302c2398ba2 ("mm, hwpoison: when copy-on-write hits poison, take page offline") a873dfe1032a ("mm, hwpoison: try to recover from copy-on write faults") [2] 1cb9dc4b475c ("mm: hwpoison: support recovery from HugePage copy-on-write faults") [3] 245f09226893 ("mm: hwpoison: coredump: support recovery from dump_user_range()") [4] 6b970599e807 ("mm: hwpoison: support recovery from ksm_might_need_to_copy()") All of them are in v6.4-rc1. Thanks. Kefeng > > I'd like to run some tests. Can you point me a the precise set of patches > that I should apply please? > > -Tony >