From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD5D4C54E58 for ; Mon, 25 Mar 2024 06:33:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 128746B0082; Mon, 25 Mar 2024 02:33:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B1C96B0083; Mon, 25 Mar 2024 02:33:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E94586B0085; Mon, 25 Mar 2024 02:33:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D651C6B0082 for ; Mon, 25 Mar 2024 02:33:42 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7BEAB120A15 for ; Mon, 25 Mar 2024 06:33:42 +0000 (UTC) X-FDA: 81934595484.16.5B23BB0 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf11.hostedemail.com (Postfix) with ESMTP id 3C14E4000C for ; Mon, 25 Mar 2024 06:33:38 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711348420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VVqHOzf8Nxrj5IIh2nHJU46I8dmyVfVzwGWm8DlE02s=; b=VWoUx1s9CKYvhcdiuNCWEZGLw+9HuV/mPGV0X07O1xrC+CZrfcow+1DOpG+1MkBfSWz8dj 7bjdRm/V/DRoDMfPEqi/kQsOb/suOkevpfwyQe/JOju+jZIzLDtioE6uo7yx28fXz/gUar juZzQ9F1FSc8zGn+EfGErlYVqQUdvmw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711348420; a=rsa-sha256; cv=none; b=ajzXR1LTgpt/ApqVOyoDCCto3QUgtShdxrtqe9CAA+fhWW1hrEjoxokYcvZA3larTowx3o UHpxjVcL4vnA9TXCvc05oYHvfK6WhqTFhEycSkcfItpQIXzeyugmRYUa5W048vMOptf9Wx SHXQ1GJ4ly1SctNGRGdjMlNEqTn8yKs= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4V333N3Dn9z1R7sw; Mon, 25 Mar 2024 14:30:56 +0800 (CST) Received: from dggpeml500011.china.huawei.com (unknown [7.185.36.84]) by mail.maildlp.com (Postfix) with ESMTPS id 6CC041A016C; Mon, 25 Mar 2024 14:33:34 +0800 (CST) Received: from [10.174.179.13] (10.174.179.13) by dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 25 Mar 2024 14:33:33 +0800 Message-ID: <75cc40ee-38b3-0bee-7b41-15ab5fc6dc17@huawei.com> Date: Mon, 25 Mar 2024 14:33:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v2 1/2] mm/ksm: fix ksm exec support for prctl To: Dan Carpenter , , , , , , , , , CC: , References: <4005efd4-06a5-4c91-845a-f0ad2cc792e2@moroto.mountain> From: Jinjiang Tu In-Reply-To: <4005efd4-06a5-4c91-845a-f0ad2cc792e2@moroto.mountain> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.13] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500011.china.huawei.com (7.185.36.84) X-Rspamd-Queue-Id: 3C14E4000C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: xxhk3mqqx7qhyt1dmaaukqtxqt59fyu8 X-HE-Tag: 1711348418-6536 X-HE-Meta: U2FsdGVkX19YJbC6yNrvzIiaCBftipUqCM9pu2ZRZzk4a2VV/hA0VckKqBe24eJy/s+nI935Kj2AuFgnXUZdsqzjDs9K4gNONtpjLTrwVLJ13/w/47Tz8JVr2/dlIvHcaP1Yv/G4hWgbRJtL/hgukzUs7G5AfBKog/P+YcofHPum0JhRLC7/TVSnhxm3irlM5B6rdZt50k9Q4L7samHSCZDKMdVXfM62rBEgV1LxcaOkA0iW7rNWUOsI09Y3suhWQsTpLIvEZ7aAfT7Mnz2FoCUlK9nIRMmi7v1HGOpirVM5oUKAC3mlmR6fs5h6twAo9bFTjcjsmuzGoWDRiJj3e/RWNVHKa10SNcytR0IR7bO5hWa8YiSq5NFNZsDrOT1m8EhqtJ8dnX697OkVBAN+XcfBvYap25QzdSqiE97w4DVTLO4Z5AymtjvfWLChtU9k9mnJS5hey/oMcTtzQSvc0S3S0954N2QLX4C9MtexelWvfe6MPEJaEL4ITCTYxg45jizwSQ09JDIbox5I+Bx14ufO7nV+ZBFtjLcDmu73Ad07yqkGHJgMJjDBzpfRzqbUbOeOiQFrsSqWdsgVZZ8PbSXlWGqMB7lKPIOro6bCa9pMds6fiTgL1S9UkIJRiq+4MU4pRaKOAzdVmOv5uVfVvoxhX5ZMd1bxHFsTahpm/Dlw9KpSYJv/+oBm76Y6qVV/rLcVIVZgkKB6vJ9FnEy4qkZQLECj0ljmW7rVfAOh3U9QngBTV7/YmVhcdX82GOJRT86A8efSQb7EFPd+HlOcTAEbREhYnKdN7WPZ8hhQp+zuFqwuRUTDRungteM937NulOsNPQPipWVlTYa/hSgsi7g6a5G7lCdmcDHz2gpatlhPMDaosfQVp3wwhd5w9EByh3uIMQij3FqmgjljCdmnVEmO6dTWhCouaF2NNLoa2+fYlUQEvCZ37vkPbpF44X3k1ppnI5KV5A6dlhGF5v3 VFNPciVG fXKuwGGfcmg3piLiPJh8Q+lXuH40w0kHMunDFqhx/+N5whfe3cthZpE0Uw9bnSEh0w7LUHL33i86LX+xMc2uHktKrMfLumzrM1iugszNLuzEHJtEwXbU77+Sbq6ZfDLMe17dNr5cLLMGv75VBXL+T5MEPHo3eR6YKCKLI+/vqQfUGopyPox3FlHgGPhmzSluiY0vZ8g5W2ikaKxzzG2oBw3Q9uwu8swH9+SkAvRf+aJHGzRSacW3Ns0/knBk8TAFfrYB/2Rn2xyrwuqHNXg4t81C1zyek5GsIrGl45KQdHDqrjvhZOzuirZO4hHH6hxFL5RgWNXe7uluZk88z89kVEMqKWxCaaxxRD2y4sgIsL6pKQXqMSeVROD/N6cshsGWt000FlPnyG76H3DtAYi50H8X3yg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/3/25 13:44, Dan Carpenter 写道: > Hi Jinjiang, > > kernel test robot noticed the following build warnings: > > url: https://github.com/intel-lab-lkp/linux/commits/Jinjiang-Tu/mm-ksm-fix-ksm-exec-support-for-prctl/20240322-141317 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20240322060947.3254967-2-tujinjiang%40huawei.com > patch subject: [PATCH v2 1/2] mm/ksm: fix ksm exec support for prctl > config: openrisc-randconfig-r081-20240322 (https://download.01.org/0day-ci/archive/20240324/202403240146.Pv4gVc5N-lkp@intel.com/config) > compiler: or1k-linux-gcc (GCC) 13.2.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202403240146.Pv4gVc5N-lkp@intel.com/ > > smatch warnings: > fs/exec.c:305 __bprm_mm_init() error: uninitialized symbol 'err'. > > vim +/err +305 fs/exec.c > > b6a2fea39318e43 Ollie Wild 2007-07-19 255 static int __bprm_mm_init(struct linux_binprm *bprm) > b6a2fea39318e43 Ollie Wild 2007-07-19 256 { > eaccbfa564e48c8 Luiz Fernando N. Capitulino 2009-01-06 257 int err; > b6a2fea39318e43 Ollie Wild 2007-07-19 258 struct vm_area_struct *vma = NULL; > b6a2fea39318e43 Ollie Wild 2007-07-19 259 struct mm_struct *mm = bprm->mm; > b6a2fea39318e43 Ollie Wild 2007-07-19 260 > 490fc053865c9cc Linus Torvalds 2018-07-21 261 bprm->vma = vma = vm_area_alloc(mm); > b6a2fea39318e43 Ollie Wild 2007-07-19 262 if (!vma) > eaccbfa564e48c8 Luiz Fernando N. Capitulino 2009-01-06 263 return -ENOMEM; > bfd40eaff5abb9f Kirill A. Shutemov 2018-07-26 264 vma_set_anonymous(vma); > b6a2fea39318e43 Ollie Wild 2007-07-19 265 > d8ed45c5dcd455f Michel Lespinasse 2020-06-08 266 if (mmap_write_lock_killable(mm)) { > f268dfe905d4682 Michal Hocko 2016-05-23 267 err = -EINTR; > f268dfe905d4682 Michal Hocko 2016-05-23 268 goto err_free; > f268dfe905d4682 Michal Hocko 2016-05-23 269 } > b6a2fea39318e43 Ollie Wild 2007-07-19 270 > d282f6b19afd1a9 Jinjiang Tu 2024-03-22 271 /* > d282f6b19afd1a9 Jinjiang Tu 2024-03-22 272 * Need to be called with mmap write lock > d282f6b19afd1a9 Jinjiang Tu 2024-03-22 273 * held, to avoid race with ksmd. > d282f6b19afd1a9 Jinjiang Tu 2024-03-22 274 */ > d282f6b19afd1a9 Jinjiang Tu 2024-03-22 275 if (ksm_execve(mm)) > d282f6b19afd1a9 Jinjiang Tu 2024-03-22 276 goto err_ksm; > > "err" not set before the goto. The code should be: err = ksm_execve(mm); if (err)     goto err_ksm; I will fix in the next version. > > d282f6b19afd1a9 Jinjiang Tu 2024-03-22 277 > b6a2fea39318e43 Ollie Wild 2007-07-19 278 /* > b6a2fea39318e43 Ollie Wild 2007-07-19 279 * Place the stack at the largest stack address the architecture > b6a2fea39318e43 Ollie Wild 2007-07-19 280 * supports. Later, we'll move this to an appropriate place. We don't > b6a2fea39318e43 Ollie Wild 2007-07-19 281 * use STACK_TOP because that can depend on attributes which aren't > b6a2fea39318e43 Ollie Wild 2007-07-19 282 * configured yet. > b6a2fea39318e43 Ollie Wild 2007-07-19 283 */ > aacb3d17a73f644 Michal Hocko 2011-07-26 284 BUILD_BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP); > b6a2fea39318e43 Ollie Wild 2007-07-19 285 vma->vm_end = STACK_TOP_MAX; > b6a2fea39318e43 Ollie Wild 2007-07-19 286 vma->vm_start = vma->vm_end - PAGE_SIZE; > 1c71222e5f2393b Suren Baghdasaryan 2023-01-26 287 vm_flags_init(vma, VM_SOFTDIRTY | VM_STACK_FLAGS | VM_STACK_INCOMPLETE_SETUP); > 3ed75eb8f1cd895 Coly Li 2007-10-18 288 vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); > 462e635e5b73ba9 Tavis Ormandy 2010-12-09 289 > b6a2fea39318e43 Ollie Wild 2007-07-19 290 err = insert_vm_struct(mm, vma); > eaccbfa564e48c8 Luiz Fernando N. Capitulino 2009-01-06 291 if (err) > b6a2fea39318e43 Ollie Wild 2007-07-19 292 goto err; > b6a2fea39318e43 Ollie Wild 2007-07-19 293 > b6a2fea39318e43 Ollie Wild 2007-07-19 294 mm->stack_vm = mm->total_vm = 1; > d8ed45c5dcd455f Michel Lespinasse 2020-06-08 295 mmap_write_unlock(mm); > b6a2fea39318e43 Ollie Wild 2007-07-19 296 bprm->p = vma->vm_end - sizeof(void *); > b6a2fea39318e43 Ollie Wild 2007-07-19 297 return 0; > b6a2fea39318e43 Ollie Wild 2007-07-19 298 err: > d282f6b19afd1a9 Jinjiang Tu 2024-03-22 299 ksm_exit(mm); > d282f6b19afd1a9 Jinjiang Tu 2024-03-22 300 err_ksm: > d8ed45c5dcd455f Michel Lespinasse 2020-06-08 301 mmap_write_unlock(mm); > f268dfe905d4682 Michal Hocko 2016-05-23 302 err_free: > b6a2fea39318e43 Ollie Wild 2007-07-19 303 bprm->vma = NULL; > 3928d4f5ee37cdc Linus Torvalds 2018-07-21 304 vm_area_free(vma); > b6a2fea39318e43 Ollie Wild 2007-07-19 @305 return err; > b6a2fea39318e43 Ollie Wild 2007-07-19 306 } >