From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E335DE77188 for ; Fri, 20 Dec 2024 10:49:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49CD76B007B; Fri, 20 Dec 2024 05:49:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44D2E6B0083; Fri, 20 Dec 2024 05:49:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 314E16B0085; Fri, 20 Dec 2024 05:49:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 176136B007B for ; Fri, 20 Dec 2024 05:49:55 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BF9901A0940 for ; Fri, 20 Dec 2024 10:49:54 +0000 (UTC) X-FDA: 82915016730.02.1FF94CA Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id 144878000B for ; Fri, 20 Dec 2024 10:48:45 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf30.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734691755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Od24o/cE3dtNorFseNwnS40GUx5zkUNJ9JRmngZ+A8=; b=zwFaTiUUiZUsL6MjLidurdQZqspyTKCHIUyVnVTJ5uk4TT2wdF3zlSchoHD3jL/fgrUmov gQFbD+WOVg5e89nHebN1HpiUdWKRWr6VlWLCTqOBKZJBHZWgKPVayVPPsFvl4ArQWb/+i9 iSQy31CN2J/ldTTysDPEwhkBkxr/DEA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734691755; a=rsa-sha256; cv=none; b=GaxtoyAu7ec7DVMsXJ3dQWi+d5/zFsQC28EcmRx1Ay1+wGOxsYyhLkje8Cp96jnVsJAhwI Bshp6vRxnFhI2sBM+Bljah3hnH88SZmPOR31ijhVMYCkm6lyn1lro01NX1x8RHJEH5WwOe alZaXFOwP9KV69RgIjdW1KOKnq3w6zY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf30.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8D0A81480; Fri, 20 Dec 2024 02:50:18 -0800 (PST) Received: from [10.57.72.191] (unknown [10.57.72.191]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8254C3F58B; Fri, 20 Dec 2024 02:49:44 -0800 (PST) Message-ID: <75cb4ff8-eb0c-4519-a30a-f8be717ba278@arm.com> Date: Fri, 20 Dec 2024 11:49:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers To: Peter Zijlstra , Qi Zheng Cc: linux-mm@kvack.org, Andrew Morton , Catalin Marinas , Dave Hansen , Linus Walleij , Andy Lutomirski , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, x86@kernel.org, Alexander Gordeev References: <20241219164425.2277022-1-kevin.brodsky@arm.com> <20241219164425.2277022-2-kevin.brodsky@arm.com> <20241219171920.GB26279@noisy.programming.kicks-ass.net> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: <20241219171920.GB26279@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 144878000B X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 1xeppwbja4819g5x9bpuy964qjfcboe8 X-HE-Tag: 1734691725-446119 X-HE-Meta: U2FsdGVkX18juvTI3ZhAnQ5cXBHe534P9u2M3WJGu7nlfQP0NWK7Hso1xx03s/r7ozzEcj5wyrexmQxVCjKOoWfNYlNbIzFlbmu0CTsUkIIyZty6jKhKyhhUawPnvjJ7iLMP4i7SFWppeBNAGhUCcHNC6kf4p5tGBPKiEgbVFtG75+Yyv44qKccsjMvGf/7i81HIHRMtSmMmFatOQRtSwnmNRWPOEBAXOuxcAKQ1RRth3SBCgNuCJ9iHnzA+5b3OcfB4f9jiXh/CNp9cDIalLtaH+wZDvTVcL+p2vDMXdHYMV/p9iKHZzFsnjYmFk2uQCr3cZUqnWcE8z2PEUZmOMX6QYqTVIISnMDpsxVLvEmEgPVfhdN7kcPRHMrz6lvX5bdF/H60s/UZfEd8hWlYcg/6hMW9P9/1hUrQjE0HJMteDdBxFsFxpOwGVjwXkfiBDfAZi2ZiThdR9DaoMOSkmFx37siZD/a7MafSh+zJDd3kUkaJQXIBaN5hBJM/iVABZICpykZysBXBIWi9rj9HhyK6CyMA5o44buBNTD2ozUCIzMBPiBqrpPjTyRdr9PD2/n88tyu+ZATteVa1gtaWvod+Ya1f1eIC4U62jFBuEynaB29I7zOnB/fEmwJvapAHbiMQKTWHP6+3/HOxscTDwqWV+l7ZVv9cycMVKNCc4qv5S2G91fvW/OIj042ihB34xp8NDNUdCTvPoMvbppiBDKxpvFD9RWlaRNL8GbnJ5sne5NotWZaT57wRQTSDlwFdMhUi5lUYUcHV9XEgJEXgJgzORxAVSKCdMW82AZ0/Cka1GO3QpeWKluwymAyYl+hs6k4wQ2RNqdbcbku91pMSosZ+sZJsTVQnP9yizJzaF/aq7MY0aaxjq/UQYEl7t2rT0J/4I8LtYp3f4zdQA+lEUru8jQpzfb2kB1m6GhIjKYReTcErAQ+HoEXoM9sY81SDgWKjpjbc3Qhug0yyRhip mtBEPEF8 cSmtmK5zrU6+uobh5xOShru8dfdCZ1pA2m+qpX/6/NwUrU9fRM/3BXFnSzUxJ28s16k+as41+Zvq2KxL0YJPhhVcrp7eowNRp+yLNLEUz8cyk/X2cbIhju3Pd16lvb9AF2ynh2pf0LDeot5albva2CL2PPFROSFeZda9r12U9ZVIQOFudif+tR67sKYiFhAnrY8h6Iaw7pQk42SBNylL4SDuVGhPi3CBoKQ0IsCyQar/nNFViHb8DCPs9g/c98xhYDW1tgO2PCIySE5ljSLYfCfi+KzVAUbUrAWUoqBndvbXPD6KOKFxiCg7ughExFkK5k++EBek/NGn+Ci7HzNCgAz6wmazpY8ZtzrPtfZ4PN6LTv5E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Peter, Qi, On 19/12/2024 18:19, Peter Zijlstra wrote: > On Thu, Dec 19, 2024 at 04:44:16PM +0000, Kevin Brodsky wrote: >> Besides the ptlock management at PTE/PMD level, all the >> pagetable_*_[cd]tor have the same implementation. Introduce common >> helpers for all levels to reduce the duplication. > Uff, I forgot to Cc you on the discussion here, sorry!: > > https://lkml.kernel.org/r/cover.1734526570.git.zhengqi.arch@bytedance.com > > we now have two series doing more or less overlapping things :/ > > You can in fact trivially merge the all the implementations -- the > apparent non-common bit (ptlock_free) is a no-op for all those other > levels because they'll be having ptdesc->lock == NULL. Ah that is good to know, thanks for letting me know about that and Qi's series! Fortunately there isn't that much overlap between our series - I think we can easily sort this out. Qi, shall we collaborate to make our series complementary? I believe my series covers patch 2 and 4 of your series, but it goes further by covering all levels and all architectures, and patches introducing ctor/dtor are already split as Alexander suggested on your series. So my suggestion would be: * Remove patch 1 in my series - I'd just introduce pagetable_{p4d,pgd}_[cd]tor with the same implementation as pagetable_pud_[cd]tor. * Remove patch 2 and 4 from your series and rebase it on mine. Let me know if that makes sense, if so I'll post a v2. Cheers, - Kevin