From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 659FAC433EF for ; Wed, 27 Apr 2022 06:10:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0B526B0073; Wed, 27 Apr 2022 02:10:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBB986B0075; Wed, 27 Apr 2022 02:10:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C836C6B0078; Wed, 27 Apr 2022 02:10:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id B87C46B0073 for ; Wed, 27 Apr 2022 02:10:32 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 8B78381A46 for ; Wed, 27 Apr 2022 06:10:32 +0000 (UTC) X-FDA: 79401634704.17.3C2B1DF Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf24.hostedemail.com (Postfix) with ESMTP id 265E218005A for ; Wed, 27 Apr 2022 06:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651039831; x=1682575831; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=8Xsmzpfs2gKjq0TcuQXIkZffXbq8rph1B7NCGu2V/ac=; b=QFueno80a32cMDpNgBMyv3202rIPBPbS2t7HVi8b4i14R2iCt8uDAYGE 61fiK2cnuTOHA0iMUapa2OC/7i4efjT3WIe/b8fcXS6NxfhM3aYaWR8tg 9yDuDwVXG1K2BLQKa/IKIklTMOC7gl3TzAZuCYOEEp0ZWZspU+ztwxnbn 2k/+k2AMPnMOtxHU6TsYW7qyNYHm1NHffZWpzwErlaKNqVP3uXH1ryIxK dlfSKOfnlyk2xZ/z2bh2leE/WSTMKIQB35H148wEv/jIq7t9ChVpSl/un 5fdyqvYgYvax3zrcAaxzXp14Q2DSEoYXghlFXAHMEVDXKy24m4izYlwGP g==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="328770058" X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="328770058" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 23:10:30 -0700 X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="580400044" Received: from kang1-mobl1.ccr.corp.intel.com ([10.254.212.35]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 23:10:27 -0700 Message-ID: <75adcfe33483d5e30855226b6efcd8dcd2f52925.camel@intel.com> Subject: Re: [PATCH v3 3/6] mm/vmscan: activate swap-backed executable folios after first usage From: "ying.huang@intel.com" To: Joonsoo Kim , Miaohe Lin Cc: Andrew Morton , Joonsoo Kim , Christoph Hellwig , Oscar Salvador , Linux Memory Management List , LKML Date: Wed, 27 Apr 2022 14:10:25 +0800 In-Reply-To: References: <20220425111232.23182-1-linmiaohe@huawei.com> <20220425111232.23182-4-linmiaohe@huawei.com> <20220425140711.0c1898862fc817135bbbc56e@linux-foundation.org> <6b74e6f3799032d4f12bae0d97a453dc85d03028.camel@intel.com> <5a108252-4eb8-e353-da3d-a96b8799fadf@huawei.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 265E218005A X-Stat-Signature: m6ec81c56xx9b7cbiwuwdt4ud4i45a5r X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QFueno80; spf=none (imf24.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1651039827-897801 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2022-04-27 at 13:08 +0900, Joonsoo Kim wrote: > Hello, > > 2022년 4월 26일 (화) 오후 3:58, Miaohe Lin 님이 작성: > > > > On 2022/4/26 10:02, ying.huang@intel.com wrote: > > > On Mon, 2022-04-25 at 14:07 -0700, Andrew Morton wrote: > > > > On Mon, 25 Apr 2022 19:12:29 +0800 Miaohe Lin wrote: > > > > > > > > > We should activate swap-backed executable folios (e.g. tmpfs) after first > > > > > usage so that executable code gets yet better chance to stay in memory. > > Missing activation for swap-backed executable page is the intended operation. > So, I disagree with this patch until some numbers are provided. > See following discussion. > > https://lore.kernel.org/all/20200316161208.GB67986@cmpxchg.org/T/#u Thanks for your pointer. Now I understood more about this. I agree to keep the original behavior unless we can prove the change with numbers. Best Regards, Huang, Ying