From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B5BEB64D7 for ; Tue, 20 Jun 2023 08:01:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1817E8D0005; Tue, 20 Jun 2023 04:01:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1313B8D0001; Tue, 20 Jun 2023 04:01:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EED478D0005; Tue, 20 Jun 2023 04:01:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DEC068D0001 for ; Tue, 20 Jun 2023 04:01:52 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A366380698 for ; Tue, 20 Jun 2023 08:01:52 +0000 (UTC) X-FDA: 80922382464.20.29BFA7A Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf28.hostedemail.com (Postfix) with ESMTP id 546CBC0005 for ; Tue, 20 Jun 2023 08:01:48 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YUyVXSI3; spf=pass (imf28.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1687248109; a=rsa-sha256; cv=fail; b=jQB09u8h5+LagKITYMBSai0fVHLzXclVmy9Ox2oOIPE3QkdLm2EIOfbLNy439G13+NGDv0 +laGAy23GKsNWzlLOY6s6IBzVcRh7l5MqNlmmmOTMeAR0HV7alhTfBc3VVJvLtfVpc6a1Z bm8s1N4ca3w2M8LVYmnv8flxVIjYHIM= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YUyVXSI3; spf=pass (imf28.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687248109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tPqBO+Fi3TXyvM1zXhrDRpvqn6g9BP0/rkxYv6MkZw8=; b=R6YZEkfJpyD8fRtKmA5LipwmjJ1Ok2RSxVPCYodrk7/IjqmyoK2t25dg3Ym9W/sf8NeCHl vSKbgJz8yzd51Dd/UeB3CYfX+20fTPesb3Y4ZNF0mBcab3ttu3Fo2S/j3DWTszZd2xdW9o CqV9BsBuH0kSJu/bn21ft2FKlf3SPBE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687248108; x=1718784108; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=QvRD+ecHIXMecskP6L30GfqAk80zn6VdlyICt6Qpvpc=; b=YUyVXSI3Y/auoZXJRSuHMUXGRC3jZJVsGL1SMrwyrmEXpMOCLQNXvqQZ JjADsUL4WNRC0r3vlD6yfAYcy4UhKo84bk7VAzEfL2l7RZaPrQGSkAEJU CVL9dHSa9kaLTGqc21g8jTqJgqLkMtqEL+DZ3lfBvlo6i8oU7r7bGzgH4 8hMbysyuELPUwdr+FkXSkZYByc58HhYW3zYZJq4/+X3URjIDpoCR+DOiu q5lPFiMaOGE0A8UfZK0rTywnMtsam6a3pnRz5bsBe+VE2F8+1yDqnYCO3 hgk0ajQ15Sbix9heifWXd+4GZPqi+m32aBO0ItVJGU/780aLgtAjpbGXV Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="362336991" X-IronPort-AV: E=Sophos;i="6.00,256,1681196400"; d="scan'208";a="362336991" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 01:01:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="888164194" X-IronPort-AV: E=Sophos;i="6.00,256,1681196400"; d="scan'208";a="888164194" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 20 Jun 2023 01:01:45 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 20 Jun 2023 01:01:45 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Jun 2023 01:01:45 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 20 Jun 2023 01:01:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gvVP8ZrlByJCl34xv6AB5qzR7Y4Orn3SnrDxCvcWg6r4LOrTSSlQMn3hyH/qPvBCLXHEoMIl3asK9bPGBVznowYdK/4v0jlFfzC2V9Lo5RAdFa1csytl2NkS2DnFGj+MRZ069LdP9otq7zeO3vYKJRAFjmym9qE/YcPwJ/VEEMfr7JFmcyypgdSZSkufZIe67CDUDh9fPZKAbV4c/pixfXxw1Qzva1tzIOTbzPK5Z70Rq5K5io1O9HyW4rZezWwdcz0ozQr2BHSl4FzPaQOUrhJv704FT0F74h2g2Zzs/cP1Q2YLY4ghMy0iuuuzaZSn4VkYLB2drblBOmjJTXXy3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPqBO+Fi3TXyvM1zXhrDRpvqn6g9BP0/rkxYv6MkZw8=; b=mb2jqGJS+5ZVn+ey8NBpHARkLxnlA3XHl745/mwYFIMqNzlZ60wOOzYQijOm7mcMlDcu7nFP10FA39Mn7TD7BcSRnYzXaB8f2cXK78y9QJyw6PJpNaA6N2QPpjqrAuF69j0qvP2goUDJX6vye+V+N9x0vnCyUEyirpaA73bCn7l3ihIFtF80EYUu11yQTqepPK/oG5GGDphYJPJiGBgu7oAXv0G5WQzSJq2964N24LXenEaHo8JtoGb8tkC0/7LqSNAJ8hvecsQ7DTDGV/rc280NqgwhXIgALqCfjciJmvKXzz3BeN95VG2NXMM9tyKiORLocndtDJlkB9Aqx22NqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by PH7PR11MB6673.namprd11.prod.outlook.com (2603:10b6:510:1ab::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.21; Tue, 20 Jun 2023 08:01:43 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::e6c7:a86d:68d6:f2f3]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::e6c7:a86d:68d6:f2f3%5]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 08:01:43 +0000 Message-ID: <759392a5-dba0-0e51-adfe-f5bac4fe1863@intel.com> Date: Tue, 20 Jun 2023 16:01:41 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.0 Subject: Re: [PATCH v3 2/2] lru: allow large batched add large folio to lru list To: Matthew Wilcox CC: , , , , , References: <20230429082759.1600796-1-fengwei.yin@intel.com> <20230429082759.1600796-3-fengwei.yin@intel.com> Content-Language: en-US From: Yin Fengwei In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR01CA0158.apcprd01.prod.exchangelabs.com (2603:1096:4:28::14) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|PH7PR11MB6673:EE_ X-MS-Office365-Filtering-Correlation-Id: 3bc08e53-b645-45cb-b97e-08db716495d7 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iF8+vVmyMxl4S4LRE9r6NihUmjv78DSeH0uR3sdmSb4/uSCiQanPKD0Cgep+W/D+iqUxxfvSq9hyUrmBaKLf0zpMgcMD1UaYmfTtFAjcK0+73gwvoMHPiTU6eU39w9HbCt8a7RRE1ontwePknWO6henlkfAHJikWgmb1YVfyk2rLLJK3IEJgDivCDsAUldE9eVld/12ErjFc6ECdu41el5/z5WmKW0YTEW1BPIM79Bj0iIwIZETAXkz2s9JcWN8prt3jSiqr7yB7blu6S36e6rAyQ/dkT/jbKjaPnVx+7f4H/3cSfPc55WG0L38QB/dxLhCy6AiCf9rnt/EkisuVxQsYLfF35/OpE/TgYHRcUbhAhSmOdVtCY9uXnc1EEdKrO4sG9xXlgcaOUYTOkjfMstNYkSz1BdhKtrKXpBHbpxVXGkn5eR7M3/V9svBxsqI6KuI0pkpMdXatI4pTTCKTnj6S1Ax5ZpC7hLYTYjM1fDgzLFDjiu3hMBj7KVndJiql+EukvRtJ+thGJf4b+QY8KVTWUZ1nIUp+4trZLJbakPDj/W9XpzJkKCsJDFRRurmH1hUQ2prF3VibZYadp5nJjIRTf1v9sq7dGKepf8FwAWRezuhKJF6hKvGQ1NBIfA8dzeiqIHxFr2K5eqiTBovdMA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(39860400002)(396003)(376002)(366004)(451199021)(6486002)(478600001)(83380400001)(186003)(107886003)(6512007)(6506007)(53546011)(26005)(2616005)(36756003)(38100700002)(86362001)(31696002)(82960400001)(66556008)(66476007)(6916009)(66946007)(4326008)(316002)(41300700001)(2906002)(5660300002)(31686004)(8936002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUlPT1JOQTlQZ3VzQzBMTVcrMFY0Z2tkamJSM1FMeHVjQ2N2dmFpdEFqSEU2?= =?utf-8?B?OWdqV0ZTaFVBcnZ4VmhYalpmVFU0aVluVGlncnpWRUx4YXVxbzVIaGVGSitE?= =?utf-8?B?ck02ZkVJT0krUTg5ZHdzK01HUTIzL1g2RzJCcUk2Z2xtUjFqeDdOaEU0NUdC?= =?utf-8?B?ZFVwT0dpR1N0N1JMWEpNZElXTTA1YmROTVF3S2FzemFpK3p5Z094bGdUc3Np?= =?utf-8?B?bXdsd2V3eE5BSXhuczFMOXBEMlJsVG1obHdoQXM0L0duUVd3UFZqSktxR3RE?= =?utf-8?B?V3IzbWVVZTlCcXBqbmtOQ2g5SFpFWm9nMXI2WHNMYklVRDg5TFJldTlRVzJB?= =?utf-8?B?bUUyUXoxa1dFcXJaaXFNNEkxRndrMlJCRURoemVNOFl5YlAzYWtrbTh6ZEcv?= =?utf-8?B?K2JaRkJqMkRUVGNDM1BvRmFScFpscHc5dURHRFhTeGhTMTBqMXNHVDdpajhU?= =?utf-8?B?bVpyNk51K0ZXcEhJQ0FGcThwTzdjbllLeGEwMWhEM1BocTlXcTFlSDI3RDRE?= =?utf-8?B?VGdVeGR5bnhicWtPallsdjU5YktXQ2JlcDc0VGdxYWNLWjlIUFB1NXZBK2pl?= =?utf-8?B?NW10Z3UreHdQeWlqOGh5VjJBL3FDWDNNTEVEaDZjaERHaHN4ZTIraUJsWkg4?= =?utf-8?B?dzlWUFpibkdkeEFCTFFjYU5pSy9wb0pZMTNLUm1WV0lwME1lQ0Z2ZUJ1aGt2?= =?utf-8?B?WWdKSVhvZDNsS1FMVkt6TUFOZEdYYndacFRTM25oVXpxd2NSM3M1LzI3aWgw?= =?utf-8?B?Tjk5S3pmVnBRbVdBcHJMMWJwWFBLMWtMaFZaaHZqek1NV1IxYVZtV1Y4cENG?= =?utf-8?B?SDJWN1hXUlZhVHpkek9Qc2tsdDgyNlpkeitpa2pIL2NicEovb0luTkY2NnBO?= =?utf-8?B?d1lVR2NoZ3RpNkMrd0p4Z21WMm1TNzNqeG5WYWJudW9qK1RkbkY4SGtXdXBn?= =?utf-8?B?VHZxUXUzS3E0T0JxMU51K2JrVTZINGwxdFFiVWRrNHFQWTVYNHNZNG5kYUFS?= =?utf-8?B?eUtteW16MWdjUTdZL0NoT0ZaT0tJZ1dnL1hhYjE5a1M4STBjc1g3dXhDMUt2?= =?utf-8?B?NFF6M1FLdjd3TDJFbUtvOERXNDVUV3dXUFFJUi8yZGtIOUpFL2QxbDhUN2xR?= =?utf-8?B?NVZzV0dQSmhtZDlZZkVlclZ2SG1KK2VwOTUyTTBBMGN1NFRyWWhQTG1aSXFp?= =?utf-8?B?MFQzdjFjcDVkYXdxb2VpVHU0RjJkWTR3cEVtcnczcGFsRjBpNkZveldJWHNT?= =?utf-8?B?TktuTHEvV2pRTWhIZWFjSUw5VmJWUVBJMEw3UHpvSm1FS2U3clZ0Qlc0STBW?= =?utf-8?B?Q0YzN1hCNi9PTXcydFVWMThZc2s5VGQzUXE0Zi83b2gybmU0L3lJYjBUY0Vy?= =?utf-8?B?bGhxeU5qaHpWQlcwTmcrNGhrL1luOWtMRzR4RTVsMFdjTXloMjBxcm9DMm5l?= =?utf-8?B?M0RaaGVsS05jY05MY29UVWhSYjNabm9UY1pDUmVldGRmOFFtS21ZRFowamVD?= =?utf-8?B?VHQxV2RtZVFqYnYyNmVPZWY5RHMzU0Qxck1yVXo2K0hrZHRQQ1Y5aGFid3Qr?= =?utf-8?B?YjNoUHhCQTQ4YmFlOUxMZGVOZnF1MVFNVDNnYkR4aXY3SkpGR0dLWDhSdXI3?= =?utf-8?B?dVd0YzhibjJHSS80OVQ4aVJPQmwvWUlLS2lscnhqbGdrbFpHQjdlc3JPSERv?= =?utf-8?B?SHN1TXNta3lpTFRFRXVhZXdkcEdDMXBxNXZBTlVSZVhFSW5MRXIyLzFEdGw1?= =?utf-8?B?ZGo1YS8ycTV2VnpqV3MrUnVHUjZFZHJMREZ5Tmd1d3pWYVRVMzJKR21GRXhv?= =?utf-8?B?djRMSXM0VnVnYWNES0NyQ0pWdHRzUWdBd0UxN1RiM3ZZaVN5Vll5enVkakZE?= =?utf-8?B?cW5LMU4rNUREOXhHeE5ORFZSRFBleFJ5MERqQ3l3aTBmcW9pcUlyeUZqNG5W?= =?utf-8?B?UUJsOGgyWXFWSFZDa3RXR1ZWaVRUKzVZZURkMCtCNkdabUM4QlhvM0tOSmNR?= =?utf-8?B?TUVnNmwzNzhsSHlDQW44MTkwWlBsenVIU0QvbFJiZGR3K3BSTE5qS2JkUVRt?= =?utf-8?B?UU5mWE9tRUxicXV0Q1RJQmUzSWlYblZ4S2p0NFM0MGpNcG1ZaDhwYzhKZWxK?= =?utf-8?Q?7HXiv/ulq7tOzVjuaJjqBdSun?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3bc08e53-b645-45cb-b97e-08db716495d7 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 08:01:43.3157 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c27XAVl5MiOJvCq67Nm4gUwSmlzzmsJ7ekpZ9CLLpJMG2LoY+VLY0ff+WOL5fsZafLejC3cpuyE6/9CYLfDn+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6673 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 546CBC0005 X-Stat-Signature: nxjfqmbznozyr6rz85sme4fh6awycnsf X-Rspam-User: X-HE-Tag: 1687248108-677127 X-HE-Meta: U2FsdGVkX1+jKx888lmgkLd/dQjHUoufKddHZA8dr50muWufJSgTmZxAAi63e1tb/OGSUs5tAzungYt8WZFb+pSDNe2ZN0GhdDvrEtHd0TLcdtn+8utF9qYYc70PHhogVutpRXgqLE9wZRTSrQlP9KLuugf+uHGSbwnQnQG9mLuUv4YEoxyyovCJShjRRtAyvC0rNC3iZdDv11UtKCiZVe8U23SyuflpqXAKruGIgHhWzAAYOd8d9Ahy/Va86QcKbxqoiPaESYaKjW7lH/++a1gEHNwPFfhebmGV+e+PasRp3EgHuVPPcZ95BjFj1OUqsoYERy8pL29GM5GAvssdJUrwah4oPTTrMtpMS0/orTV8zJemC7mbY4Ni76Sdqi98uPXwT4CFAFnqdZLROD8V968QeriqbZh0UxebceHf5KNvYJwxM619KNE0nPSVbtte5t/PEINcmu8HADLQJh9wHhcg3AaLQpSI6fGwcUzCjfA/nLJi2UvUWhfzTOs5L18nDb3OuLEIR0d7+zPd4F601zua97wVSQuo2cv2VsLi1FS+kS3/+k6YDXwi366b+r4pAc9ER9lTkQthbkuX7B5EArjE13o0vF/itcMbL0RYK8S54pmZfDGj5d9HWVFTpNZpQjOeqAzYeHbFbMcjPsgUK5MCeWm7VoZjhXWWqbOTmpV+Qf3z27lPwi9DlKWOL4DZzDB7YvFIuNjYYvrGmjwi3iPUcAmp7Xh0wG0Q+Q96y4nlCo5qlgv8txrfczsi2yopeom9Br9OX8Awz7r7ovVyEH7nKtKm5esSPf4UKWdlCAf11LiP3IC1z8mPNN8+BeSXh6QR9guUSkqXj38CiljeTHgBiYZeev6OiU2fo7cc7HTAXujtcbRTyEe7E5N+r9uCUyO0f6G+iCg/uro0ZWCyOx1MFw00plMOTtSIWsNFvjQN4XKgXgqmusXV9MRa2lwJ0BG7jStRKG6i5eWzbCH I2aOy58Q 8wur13bPPtqR1jSD8E87wK0KuNOlDBH64iezSuTVq8LLuJrHJgTBJWuobXilr8EK5AXRDdMkJlt66uqEOvJA2BQdfXVTuiTiiC00kuA0tL8fxWRsKKeQtAww/D4Z239NqbR4cf9ARVOi4VBq4D10mMpClGL4/Ujjs7xBQaUiycsDx7sWtIptXR1R2NXFVE3X3rf1BPYpG6s4XV2RJuV1lhFT0aaFRipFBhFUaXVZeVMV4ZLXIKla1/DYHz3zlZw8GwXyDqb669QD42czSt1541bTV+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/20/23 11:22, Matthew Wilcox wrote: > On Sat, Apr 29, 2023 at 04:27:59PM +0800, Yin Fengwei wrote: >> diff --git a/mm/swap.c b/mm/swap.c >> index 57cb01b042f6..0f8554aeb338 100644 >> --- a/mm/swap.c >> +++ b/mm/swap.c >> @@ -228,8 +228,7 @@ static void folio_batch_move_lru(struct folio_batch *fbatch, move_fn_t move_fn) >> static void folio_batch_add_and_move(struct folio_batch *fbatch, >> struct folio *folio, move_fn_t move_fn) >> { >> - if (folio_batch_add(fbatch, folio) && !folio_test_large(folio) && >> - !lru_cache_disabled()) >> + if (folio_batch_add(fbatch, folio) && !lru_cache_disabled()) >> return; >> folio_batch_move_lru(fbatch, move_fn); >> } > > What if all you do is: > > - if (folio_batch_add(fbatch, folio) && !folio_test_large(folio) && > - !lru_cache_disabled()) > + if (folio_batch_add(fbatch, folio) && !lru_cache_disabled()) > > > How does that perform? With same hardware: IceLake 48C/96T and using order 2, the test result is as following: order2_without_the_patch: - 65.53% 0.22% page_fault1_pro [kernel.kallsyms] [k] folio_lruvec_lock_irqsave - 65.30% folio_lruvec_lock_irqsave + 65.30% _raw_spin_lock_irqsave order2_with_the_patch: - 19.94% 0.26% page_fault1_pro [kernel.vmlinux] [k] folio_lruvec_lock_irqsave - 19.67% folio_lruvec_lock_irqsave + 19.67% _raw_spin_lock_irqsave Regards Yin, Fengwei