From: Yin Fengwei <fengwei.yin@intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <linux-mm@kvack.org>, <akpm@linux-foundation.org>,
<kirill@shutemov.name>, <yuzhao@google.com>,
<ryan.roberts@arm.com>, <ying.huang@intel.com>
Subject: Re: [PATCH v3 2/2] lru: allow large batched add large folio to lru list
Date: Tue, 20 Jun 2023 16:01:41 +0800 [thread overview]
Message-ID: <759392a5-dba0-0e51-adfe-f5bac4fe1863@intel.com> (raw)
In-Reply-To: <ZJEbZqHyyROu7UpW@casper.infradead.org>
On 6/20/23 11:22, Matthew Wilcox wrote:
> On Sat, Apr 29, 2023 at 04:27:59PM +0800, Yin Fengwei wrote:
>> diff --git a/mm/swap.c b/mm/swap.c
>> index 57cb01b042f6..0f8554aeb338 100644
>> --- a/mm/swap.c
>> +++ b/mm/swap.c
>> @@ -228,8 +228,7 @@ static void folio_batch_move_lru(struct folio_batch *fbatch, move_fn_t move_fn)
>> static void folio_batch_add_and_move(struct folio_batch *fbatch,
>> struct folio *folio, move_fn_t move_fn)
>> {
>> - if (folio_batch_add(fbatch, folio) && !folio_test_large(folio) &&
>> - !lru_cache_disabled())
>> + if (folio_batch_add(fbatch, folio) && !lru_cache_disabled())
>> return;
>> folio_batch_move_lru(fbatch, move_fn);
>> }
>
> What if all you do is:
>
> - if (folio_batch_add(fbatch, folio) && !folio_test_large(folio) &&
> - !lru_cache_disabled())
> + if (folio_batch_add(fbatch, folio) && !lru_cache_disabled())
>
>
> How does that perform?
With same hardware: IceLake 48C/96T and using order 2, the test result is as following:
order2_without_the_patch:
- 65.53% 0.22% page_fault1_pro [kernel.kallsyms] [k] folio_lruvec_lock_irqsave
- 65.30% folio_lruvec_lock_irqsave
+ 65.30% _raw_spin_lock_irqsave
order2_with_the_patch:
- 19.94% 0.26% page_fault1_pro [kernel.vmlinux] [k] folio_lruvec_lock_irqsave
- 19.67% folio_lruvec_lock_irqsave
+ 19.67% _raw_spin_lock_irqsave
Regards
Yin, Fengwei
prev parent reply other threads:[~2023-06-20 8:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 8:27 [PATCH v3 0/2] Reduce lock contention related with large folio Yin Fengwei
2023-04-29 8:27 ` [PATCH v3 1/2] THP: avoid lock when check whether THP is in deferred list Yin Fengwei
2023-05-04 11:48 ` kirill
2023-05-05 1:09 ` Yin, Fengwei
2023-05-29 2:58 ` Yin Fengwei
2023-05-05 0:52 ` Huang, Ying
2023-05-05 1:09 ` Yin, Fengwei
2023-04-29 8:27 ` [PATCH v3 2/2] lru: allow large batched add large folio to lru list Yin Fengwei
2023-04-29 22:35 ` Matthew Wilcox
2023-05-01 5:52 ` Yin, Fengwei
2023-05-05 5:51 ` Yin, Fengwei
2023-05-15 2:14 ` Yin, Fengwei
2023-06-20 3:22 ` Matthew Wilcox
2023-06-20 4:39 ` Yin Fengwei
2023-06-20 8:01 ` Yin Fengwei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=759392a5-dba0-0e51-adfe-f5bac4fe1863@intel.com \
--to=fengwei.yin@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox