From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57DCDE77199 for ; Tue, 7 Jan 2025 11:37:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2F006B00C1; Tue, 7 Jan 2025 06:37:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ADDD26B00C2; Tue, 7 Jan 2025 06:37:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908436B00C3; Tue, 7 Jan 2025 06:37:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6AA706B00C1 for ; Tue, 7 Jan 2025 06:37:02 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1D2D5A04CD for ; Tue, 7 Jan 2025 11:37:02 +0000 (UTC) X-FDA: 82980454284.20.CDA2628 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 8CAA4180002 for ; Tue, 7 Jan 2025 11:36:59 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Jtgof/lK"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736249819; a=rsa-sha256; cv=none; b=I4zqRPif6yQWXXmBO+WD6pwxq2M5zo4R6TDi7jyId+PYwDwDAy2J0yIoApgWHZk+6lj7w4 TqabqZqJeiqC9Lig1ksVKKrfbGFBYAIAu4VvZUtj8kwo09ogcI6AsLQVqx6S1URSqcBVT0 O4netp+FGfMcfUSqZqYGX63bvpN9Mbg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Jtgof/lK"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736249819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EPWLOfPPpQOf9nQB18V4X5aXAnWnhoDaHH+uIltQ4Xk=; b=6ZPDlWCKZ+YgFt37SwDcmRa938RSEGQMpeFzSk19LmMXi9WiTT/skZWUL5E7E95ba9NoSU /K7LU5iMlSyODusC1SSAZrfA7q0lu1tk1X+Wp1ecQEP+cLBd9XwuC5FgzvgXuYlByKJrn+ FcDlGlKmVow6vLSyNMsv3ohlGWJgMD8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736249819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EPWLOfPPpQOf9nQB18V4X5aXAnWnhoDaHH+uIltQ4Xk=; b=Jtgof/lKu0Tm5zJLEbTAlesqcaGtffjwM+qeV0AhwIJ2JkSQUICatjuc10aA6Pw7iGb3WL 7mSEKdF3YZZ3c40PhS5LyjgYo3a5gbRjMFkI0/OykqoxxAaO2ZWk5dOeeKDWqfFF8ZlfWj 0zlYO7tW3u1JwvKtoeYt7U/7GOohbKw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-tsdFAkc-MSagHQLqwbjA9A-1; Tue, 07 Jan 2025 06:36:57 -0500 X-MC-Unique: tsdFAkc-MSagHQLqwbjA9A-1 X-Mimecast-MFC-AGG-ID: tsdFAkc-MSagHQLqwbjA9A Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-436723db6c4so88119295e9.3 for ; Tue, 07 Jan 2025 03:36:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736249816; x=1736854616; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EPWLOfPPpQOf9nQB18V4X5aXAnWnhoDaHH+uIltQ4Xk=; b=NsxMPCwIEe5qZdRPxxFnBtFWF7mHK4pWJDY7lcelxBrSkYxZnEgstR7l47GNnSaXvj H0QklHVlni2PbZ7FtsTYdZJtYDeK0hDwSrQ0GqSXx64gK85Fadc2rVZybo9D1+emnJjN xHQp/M6vEFSYQgtlg7BDN1+gfyq7nhFsQGYOrwNW2M39W2FAPVawAA2HXBhl7S4rmVX0 a/6bWE5fBQRdnKr57eu/bF0tvZT0NH5tCI1s3rGip7+PWD2CbHjZWjE/wi3XvI9C1GS3 WlOh4TKOHEmEmZLE0FqguH3ZnkY0T9md38SiTJjM9nWSy6Fv5za+Z8CfvcLV58vApO1W r7cg== X-Forwarded-Encrypted: i=1; AJvYcCVi7oZoyew5Zpv98TQh6+UGuNCqwWKt4Z+xeYt+Oj2hlFRm54ijjYdIHYjYJCvRIcQnu3W0d/vynQ==@kvack.org X-Gm-Message-State: AOJu0YyXyOo/NxYTVqyLlNxFoCYI8twgwmYnhUoQlSejQEPwfc6W77Go TrBm4CYnrl2TybFO9KnCUpci6HFZuCn0OvC+cFoRejYN0DDlJU+mg2FdVYh1sbQnqOGIfeA21PK zRZfoX1XRhU8g/TsFJsRtwflC/h4nBBgCpJRXWvqmSOgzOb2d X-Gm-Gg: ASbGncusQitQDtgSZW1Z7P6uCIitI7ynzuEFQUaLgR+plfOYOBqYxMCeuppw7SDF9Zq PXDi+JY2+Q7LB0zIGh3v5fwmrxUwtau1KIXanPeaO/yTJYyfCqSsgopXW0kg5DrEtA/YtLiOwMJ hIZmL6O7y+/+0ytUqBTLRsXlctGhTcKHUGn0/AgAPosWYhxj1ZdCz7D/CjFfAwZ1CB9CNKzwStw LzQY2UhMvbL34LKLkHcY9t9NvQDQC1i0JALMmvKPRMaQ75YD7tTU9cDe3KHoxLY2pjBc6DJ1TLf yJX8iY9kNcxasWm9j9Evjl1jEr6WNi/f/2u8L/PWUXf0sYhp9FradWbKy/cZYSSBQ3y61uVG/cg +aYz4sELV X-Received: by 2002:a05:6000:704:b0:385:df2c:91b5 with SMTP id ffacd0b85a97d-38a2213d33emr54453869f8f.0.1736249816140; Tue, 07 Jan 2025 03:36:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IEaT18MaorKDc8f0dPQnq8Hx4Fd5WTGife38GGjyhvgZNdMgf0zcRP1rbdU6qLK3Zfzio44ww== X-Received: by 2002:a05:6000:704:b0:385:df2c:91b5 with SMTP id ffacd0b85a97d-38a2213d33emr54453824f8f.0.1736249815752; Tue, 07 Jan 2025 03:36:55 -0800 (PST) Received: from ?IPV6:2003:cb:c719:1700:56dc:6a88:b509:d3f3? (p200300cbc719170056dc6a88b509d3f3.dip0.t-ipconnect.de. [2003:cb:c719:1700:56dc:6a88:b509:d3f3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8292f4sm51029779f8f.3.2025.01.07.03.36.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 03:36:55 -0800 (PST) Message-ID: <758c0441-2cb9-41c4-bf70-c5810726779c@redhat.com> Date: Tue, 7 Jan 2025 12:36:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 14/25] rmap: Add support for PUD sized mappings to rmap To: Alistair Popple , akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com References: <8830827577fec4c6c2a0135e338723a5b532a2ee.1736221254.git-series.apopple@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8830827577fec4c6c2a0135e338723a5b532a2ee.1736221254.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7F3Y3G4vdGXSiumS62lPE0PVfuZmIZ66GgPMp-8v5yM_1736249816 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 4ha67i3ac1rwao9butpg3gjhiwnfge7b X-Rspam-User: X-Rspamd-Queue-Id: 8CAA4180002 X-Rspamd-Server: rspam08 X-HE-Tag: 1736249819-423473 X-HE-Meta: U2FsdGVkX1/3PORTT73S58NAKUZyChIVDNxEFGAapb5Vg8d8ufWAAr3VBIVyr4kyl7Euu5OyXOVxEzBo0sVuocHQjnYoFNKYPLj0rp5ndp5f3RzdK0dC0OWfA8QUxbHwaLU8baccc7ZsXnTyfEWNSNDLbaBgunLbm07H2g5zeK2cfIz7S+FD8EYlyoxnpP27z1mqowjVJGJWHYQdwv/Ngx2m6eCzvrv06yEXr0U0N8Xf0FyGq7rTfWv+ixymng+ga0RyYO5SlfrP5N4fVqMzeLFcYhcuKIQ7wbYGOs6VFJf5vfkk+wWMEhX1PnUkDzNHOsX43p4hdwGUDUFY0z0e07hHeRWxDdG6IEh2gCu+ysdfvKB/w3e+y/zjKaEalSM8gZaIgO+jbuV4eBih8LBudNIu2TdZyIPmA/Rtz7hUkAIG9K4xTTz9Bla9yTXP8ALxTRZGlrh9+QllaAZkxEpIlnAfhX2tWWRvguP6CT9up1yNPK+FVu+pyibAt02B+TeXKN038SfVdSkd7wN94SwOp2YubU6yuCGfF4+RnorK715WJZefmgoetDii6rdzTKmWmB37szsZfwkr0seBYkbEnT+1CoxuhdN7aiBYnj+VGNpHkwOTivG11n22vXAw40fWpK4OqPlG/daGfPPhrpRv0QXTt7Cip0A4IoF0s4S/pXE4j5vDyi+7KGzknmt7RfMEm5E25q1xn+Hhd6ezjibjmwUf+r0bfg6UAEHfBwHB9JXS4NWle8S3rEUMFZ0RkTYgoW0aO4ge5PMLTubcKqxzbyUxpSjrWzJ1I92oRSi456m8rAkHMQwQ3+TcMUxvEQQZrUZquftCsianXsPKoe0zPzOLBbUBF/MnqDOOSQIc1enpO6Y1XfriKgd65hAK/20ripmKhIz+/SR4LFYLxHMfXLw1TL4HTKTK1v1zOiU0OnJc2AprU9zlalmV2iUdHj8LEAy2aOXZfEScReV6vV+ VdXkGxjN JvecDgVq5xeJ4hep5/ac8zFY4XHRpAsx1rutcoXeMkI2sQl2sQKuQTNl2qKsraqPpPbNm98sEwebJvMQjI/dHiSZohjXErBnDloBF+gdU0PmgMRRnWc2eF5L5KHFDFSgmWFWRV/ATarKJqdu2Z3B8BfGW1dh2y/4Qq9ZpBxXSd5I1zchT7Bp2Vc8tKUCTpuSVQKSktXfc+7uLzf6aJztcabJPaqrGZVnHVVCJtrqgYoDwzdW7gxx5zQK2UeXDdrozvmNkfGlHnm03XMlc/X9T0hXHettnBWpT7xXlNqryw1MjUTW4TPQ7W5nMDzRO/0hNXHUxsLfNJrUEkFYMaAZYhkJSrERC+SpsPBIBKSKzxEfZJgUnLTypZx/JvInfy8GTHpidFY0coh0btpb/JcEwyGfe2rvEIEkw8XsSjPe6SBgbgpcsCDV0/kVhCRTsGR1IWC5a/Z+bdCaiZXeyWUaoCpLboft8O4rRZ+Hxd+igm1fTZsPe7/E+qbir2CtH/8pZcQWLQSfzczkVVwFvTfXAlWb76I3LdDO8sOaNUI36eDynFjmFpHMBVradLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.01.25 04:42, Alistair Popple wrote: > The rmap doesn't currently support adding a PUD mapping of a > folio. This patch adds support for entire PUD mappings of folios, > primarily to allow for more standard refcounting of device DAX > folios. Currently DAX is the only user of this and it doesn't require > support for partially mapped PUD-sized folios so we don't support for > that for now. > > Signed-off-by: Alistair Popple > > --- > > Changes for v5: > - Fixed accounting as suggested by David. > > Changes for v4: > > - New for v4, split out rmap changes as suggested by David. > --- > include/linux/rmap.h | 15 ++++++++++- > mm/rmap.c | 65 ++++++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 76 insertions(+), 4 deletions(-) > > diff --git a/include/linux/rmap.h b/include/linux/rmap.h > index 683a040..7043914 100644 > --- a/include/linux/rmap.h > +++ b/include/linux/rmap.h > @@ -192,6 +192,7 @@ typedef int __bitwise rmap_t; > enum rmap_level { > RMAP_LEVEL_PTE = 0, > RMAP_LEVEL_PMD, > + RMAP_LEVEL_PUD, > }; > > static inline void __folio_rmap_sanity_checks(const struct folio *folio, > @@ -228,6 +229,14 @@ static inline void __folio_rmap_sanity_checks(const struct folio *folio, > VM_WARN_ON_FOLIO(folio_nr_pages(folio) != HPAGE_PMD_NR, folio); > VM_WARN_ON_FOLIO(nr_pages != HPAGE_PMD_NR, folio); > break; > + case RMAP_LEVEL_PUD: > + /* > + * Assume that we are creating * a single "entire" mapping of the > + * folio. Misplaced " *", can likely be fixed up when applying. Apart from that LGTM Acked-by: David Hildenbrand -- Cheers, David / dhildenb