From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C604E77188 for ; Thu, 26 Dec 2024 11:05:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 071DC6B007B; Thu, 26 Dec 2024 06:05:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3A956B0083; Thu, 26 Dec 2024 06:05:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB3CD6B0085; Thu, 26 Dec 2024 06:05:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B9ADE6B007B for ; Thu, 26 Dec 2024 06:05:01 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1A2281C7B3F for ; Thu, 26 Dec 2024 11:05:01 +0000 (UTC) X-FDA: 82936827498.28.C1FE9B1 Received: from flow-a7-smtp.messagingengine.com (flow-a7-smtp.messagingengine.com [103.168.172.142]) by imf28.hostedemail.com (Postfix) with ESMTP id E61C4C0003 for ; Thu, 26 Dec 2024 11:04:13 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm3 header.b=osJQTCRB; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="b 1+5zgY"; spf=pass (imf28.hostedemail.com: domain of uwu@coelacanthus.name designates 103.168.172.142 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name; dmarc=pass (policy=quarantine) header.from=coelacanthus.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735211067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PZ1yD1zFxij2IMu4FxJMiGtPa+gds2YF5EDXDrbqMws=; b=N5r+tE5Ca9tyFVgguuKBfAuNlF1dnc0X70df+p/LWtOj6No8FRBgGiUWtd+xJPmqGqrFxK EQcs1XbtrCANgUsMcuOuP4Pwoa9onkaYHI824y9yIlSJv3BUtM/6f0tk7iEnmuOUSrn69m kfieTfgLJFAP/eGLvSUCMxjA3A8sdzw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm3 header.b=osJQTCRB; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="b 1+5zgY"; spf=pass (imf28.hostedemail.com: domain of uwu@coelacanthus.name designates 103.168.172.142 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name; dmarc=pass (policy=quarantine) header.from=coelacanthus.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735211067; a=rsa-sha256; cv=none; b=eUAEirA5xSiOqpJwWS10OqUGEfi8TnMU+YWN0Xh5m/w/67bv1ADZxman+5EqUHNWB0776W iawUcAE19b8d7ADp0lS/Q/MKrO2wDI4xJrvkZLdnoRbc0VrMTiS0mZkNxzhsJRreVwiybV GOLJ6DOnG13GN36cuSG283+fzxps11Y= Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailflow.phl.internal (Postfix) with ESMTP id 705222002C3; Thu, 26 Dec 2024 06:04:58 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Thu, 26 Dec 2024 06:04:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= coelacanthus.name; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1735211098; x=1735218298; bh=PZ1yD1zFxi j2IMu4FxJMiGtPa+gds2YF5EDXDrbqMws=; b=osJQTCRBMvc3BenT7MsTtuGwzd mdlomsiYxZU1dqBKICcLhVjFTjwVkVWpFUyeSJBr62k+6dLJqMjPeTv1IaQf11hZ zb5Niaq6SfqD50qmjItKyZ53A30vR/gU7BAuQPPjyL6o6bSRHUNU818nhFBlxCh9 lEnlektWTwnmCk7RKuLXak5vLClgcAfhKDHc1wHBD6pp+/zwi6zFGCAjzEJUgAye rVnEj+RUcvv4jH4KXymUWyavVMh11fB6N7J0XnVB1zOvprPRFpH9i7BzXUt8wJyO zmC2OLSdGldxIKLmLDL6V9u4cLpjDoX1TUuo7Yd2PW5HlWHl1A2Ad4hx7F4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1735211098; x= 1735218298; bh=PZ1yD1zFxij2IMu4FxJMiGtPa+gds2YF5EDXDrbqMws=; b=b 1+5zgYwThmA5dkNo4UfeRI7VkKuyZMcwX02fcdem1krLniH3RzsNGnolqq7fIS86 shU7bz1Fg2O700dDErGvgMnRYTfoynqtyx+Jh6VbqAWZ6VDLekXVPz2VN58Jumpm +nj2+JGeKHqIh/6g9EenFGeM/bbFNpZBs2DLHAQR21B1f3g+shp8L8ttdj84fTeD Rail5B9CsAJsMxVFDG1SXI7L/16vTYEk4T3HECqJYStY9dTI44/+vLIxSq5i/zl6 Sl8zq8qEtF5tfQ83h6i9M7TKqBeQeH2b/yMdIrTrMF7rTC9GLSy5QsJCZw/GI1nG Y69ncP1+6BEvb3Vin2QYw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddukedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeevvghlvghsthgvucfnihhuuceouhifuhestghovghlrggtrghnthhhuh hsrdhnrghmvgeqnecuggftrfgrthhtvghrnhepfefgvdfgteevveekheelffetkedvhfev vdehudeuheekvdeuvdfhieeijedukeeunecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepuhifuhestghovghlrggtrghnthhhuhhsrdhnrghmvgdp nhgspghrtghpthhtohepvddvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegthh grrhhlihgvsehrihhvohhsihhntgdrtghomhdprhgtphhtthhopegrjhhonhgvshesvhgv nhhtrghnrghmihgtrhhordgtohhmpdhrtghpthhtohepohhlvghgsehrvgguhhgrthdrtg homhdprhgtphhtthhopehprghulhdrfigrlhhmshhlvgihsehsihhfihhvvgdrtghomhdp rhgtphhtthhopehprghlmhgvrhesuggrsggsvghlthdrtghomhdprhgtphhtthhopegroh husegvvggtshdrsggvrhhkvghlvgihrdgvughupdhrtghpthhtohepvggsihgvuggvrhhm seigmhhishhsihhonhdrtghomhdprhgtphhtthhopehkvggvsheskhgvrhhnvghlrdhorh hgpdhrtghpthhtohepshhhuhgrhheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i95c648bc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Dec 2024 06:04:50 -0500 (EST) Message-ID: <75877caa-1c29-4a85-9e09-f4a37114f58d@coelacanthus.name> Date: Thu, 26 Dec 2024 19:04:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] riscv: selftests: Add a ptrace test to verify syscall parameter modification Content-Language: en-GB-large To: Charlie Jenkins Cc: Andrew Jones , Oleg Nesterov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Eric Biederman , Kees Cook , Shuah Khan , Alexandre Ghiti , "Dmitry V. Levin" , Andrea Bolognani , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Thomas Gleixner , Ron Economos , Quan Zhou , Guo Ren , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20241203-riscv-new-regset-v2-0-d37da8c0cba6@coelacanthus.name> <20241203-riscv-new-regset-v2-2-d37da8c0cba6@coelacanthus.name> <20241203-55c76715e16422ddaf8d7edf@orel> <50a62291-5ae1-47b0-8f64-a42271820789@coelacanthus.name> From: Celeste Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E61C4C0003 X-Rspamd-Server: rspam12 X-Stat-Signature: pqd58fd1weqg57ynhz5gggjstkdw4bb7 X-Rspam-User: X-HE-Tag: 1735211053-244037 X-HE-Meta: U2FsdGVkX1+Cs7BIPJ76mfCf0loOZ2l3mcxPd+qFlmPilD5zQqhvH7zpZIaQkbOconhHS3PJlCEcv4zAnJJqe2BkZkmenIzfrJFRrMJunB7cmQ962i3mZbx1vX9X4v94+OzFejYk4416D9vZOUDjrskmQQ7IC3oCF5GpisdyDfnD7H//pgbgGf1dZoc85k08Ob79Lgxq6n8SvXoNhTd5g4sZ3O1934w/0sfhFu7mE6cptyaAie6SFJ3wN1aUVUWRt/Xv+eGGjiJIP7dI8xaUWQnkmdLg91BpnFuYf6nqYuSVRBzXJo51CwBGRij7jOt9WZntvKIb7OBEQ/IPgn5Op1F3EtBGj32N9+4xHvOsU2i4ZJ+8X6NYc8K1nS59tzr7YGnz39dpWNV8f+CBpikhPy7du+S8BOIjk+qEy8rIzZ42eGSDekRrS8Mq+gZAU8m5EQIdxFG2SW7cImVuLdxNKbcAeufgU2CJZzqjg5Dxir3mhjF+pnuLDgYXrDUbk64PjOD6s2racNNehgL71b8MfF9i0N/NNfa3WOThVP0hlNfQuGLAOUNk7spFoESWynkHKDF+cknsN1kn/WDcGbBSG7WkK5vNwitGMOouUII1ZHl3xHRS9SZDoO3ylh+bUyIVsHgr/F2vCHLGPDgGpYbjkIGzfM+VefihjAsRVJ7vSc6B7Fmtu3vPVMns7Lh47GB54J5O0bG3U7uqVvNgzMTPeQ2FlWWXjEVbNVnvuLoU5dheilo38AhQpd9V/97zmkneF257flLaTI+kDUUrEK3Q6SOLyETLDBzTvgmqOd2RFdFUHNggKXa7whtUM/ufkbOEhjDK0G8qu0PNFr57NQcyxSH9eBo9slthMCNEHs1A7xgNu7UVMnMUM6Tam9SU55/594xpSCN72gi5xSNDfSrOaGXT3q5n0fu5omkdXjoqgy4o1GGhnAzfjub7+N8FdrSgeflT7pALeUjhyuRjjRy vkuMUbK4 NhX2kaSftbxndmXONftkrG0jy7GXcmIJJUldra2n8GO3COgwY9RI7brBTq/ysoNw1TyicVJqOmahC/8jci6ejRqPiTtzUexwExw+q0qjRecwM0HOR58Eb4zaivkx4yXDSAbT79sTleNLP9vxtnX6IIbMkLTqVKwo/3mY/e7xt2DKufz8W5GOLfr/jkalt8vfBzjTBC22tVKnjxJjz2BbglAAuRuRL1Pa9B5dEWz2eBny1pxTjyZ43FIzgd5BDTNaoTCZ5zV6OatYPMzqZAy7YbKykyMy4UPj+5g5zyz22tJ9tBcTI14l9m7l+dlE5+bOe3OiY+0CRYVZFKasOTy8ZvmoODMis0YtT8fpBoxge/WPckJ7e6fxj9QJ38KOp8umZ+8+mO2xZQlrNUc6xP/I400CwXdsTqbGD0P1/P5Pm5xoiJ8Uzee8vYDiBQ3/9ycc7xtjr7ZQYa0FNEXai+WVypyxraXPLvB8GhF04Z77f5esspfM1aBQFqNXquynAsgAAI8FGtGoQwRz5JFURefzNGhLO3ctRymjASEAN2L33THfWodiFtwYOhEkjfOZfjZZmn48U X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-12-20 05:36, Charlie Jenkins wrote: > On Fri, Dec 20, 2024 at 05:29:45AM +0800, Celeste Liu wrote: >> >> On 2024-12-20 02:26, Charlie Jenkins wrote: >>> On Tue, Dec 03, 2024 at 01:55:07PM +0100, Andrew Jones wrote: >>>> On Tue, Dec 03, 2024 at 05:30:05PM +0800, Celeste Liu wrote: >>>>> From: Charlie Jenkins >>>>> >>>>> This test checks that orig_a0 allows a syscall argument to be modified, >>>>> and that changing a0 does not change the syscall argument. >>>>> >>>>> Cc: stable@vger.kernel.org >>>>> Co-developed-by: Quan Zhou >>>>> Signed-off-by: Quan Zhou >>>>> Co-developed-by: Celeste Liu >>>>> Signed-off-by: Celeste Liu >>>>> Signed-off-by: Charlie Jenkins >>>>> --- >>>>> tools/testing/selftests/riscv/abi/.gitignore | 1 + >>>>> tools/testing/selftests/riscv/abi/Makefile | 5 +- >>>>> tools/testing/selftests/riscv/abi/ptrace.c | 134 +++++++++++++++++++++++++++ >>>>> 3 files changed, 139 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/tools/testing/selftests/riscv/abi/.gitignore b/tools/testing/selftests/riscv/abi/.gitignore >>>>> index b38358f91c4d2240ae64892871d9ca98bda1ae58..378c605919a3b3d58eec2701eb7af430cfe315d6 100644 >>>>> --- a/tools/testing/selftests/riscv/abi/.gitignore >>>>> +++ b/tools/testing/selftests/riscv/abi/.gitignore >>>>> @@ -1 +1,2 @@ >>>>> pointer_masking >>>>> +ptrace >>>>> diff --git a/tools/testing/selftests/riscv/abi/Makefile b/tools/testing/selftests/riscv/abi/Makefile >>>>> index ed82ff9c664e7eb3f760cbab81fb957ff72579c5..3f74d059dfdcbce4d45d8ff618781ccea1419061 100644 >>>>> --- a/tools/testing/selftests/riscv/abi/Makefile >>>>> +++ b/tools/testing/selftests/riscv/abi/Makefile >>>>> @@ -2,9 +2,12 @@ >>>>> >>>>> CFLAGS += -I$(top_srcdir)/tools/include >>>>> >>>>> -TEST_GEN_PROGS := pointer_masking >>>>> +TEST_GEN_PROGS := pointer_masking ptrace >>>>> >>>>> include ../../lib.mk >>>>> >>>>> $(OUTPUT)/pointer_masking: pointer_masking.c >>>>> $(CC) -static -o$@ $(CFLAGS) $(LDFLAGS) $^ >>>>> + >>>>> +$(OUTPUT)/ptrace: ptrace.c >>>>> + $(CC) -static -o$@ $(CFLAGS) $(LDFLAGS) $^ >>>>> diff --git a/tools/testing/selftests/riscv/abi/ptrace.c b/tools/testing/selftests/riscv/abi/ptrace.c >>>>> new file mode 100644 >>>>> index 0000000000000000000000000000000000000000..d192764b428d1f1c442f3957c6fedeb01a48d556 >>>>> --- /dev/null >>>>> +++ b/tools/testing/selftests/riscv/abi/ptrace.c >>>>> @@ -0,0 +1,134 @@ >>>>> +// SPDX-License-Identifier: GPL-2.0-only >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> + >>>>> +#include "../../kselftest_harness.h" >>>>> + >>>>> +#define ORIG_A0_MODIFY 0x01 >>>>> +#define A0_MODIFY 0x02 >>>>> +#define A0_OLD 0x03 >>>>> +#define A0_NEW 0x04 >>>> >>>> Shouldn't A0_OLD and A0_NEW set more bits, since 3 and 4 aren't very >>>> unique (we could have those values by accident)? And should we include >>>> setting bits over 31 for 64-bit targets? >>>> >>>>> + >>>>> +#define perr_and_exit(fmt, ...) \ >>>>> + ({ \ >>>>> + char buf[256]; \ >>>>> + snprintf(buf, sizeof(buf), "%s:%d:" fmt ": %m\n", \ >>>>> + __func__, __LINE__, ##__VA_ARGS__); \ >>>>> + perror(buf); \ >>>>> + exit(-1); \ >>>>> + }) >>>> >>>> Can we use e.g. ksft_exit_fail_perror() instead? I'd prefer we try to >>>> consolidate testing/selftests/riscv/* tests on a common format for >>>> errors and exit codes and we're already using other kselftest stuff. >>>> >>>>> + >>>>> +static inline void resume_and_wait_tracee(pid_t pid, int flag) >>>>> +{ >>>>> + int status; >>>>> + >>>>> + if (ptrace(flag, pid, 0, 0)) >>>>> + perr_and_exit("failed to resume the tracee %d\n", pid); >>>>> + >>>>> + if (waitpid(pid, &status, 0) != pid) >>>>> + perr_and_exit("failed to wait for the tracee %d\n", pid); >>>>> +} >>>>> + >>>>> +static void ptrace_test(int opt, int *result) >>>>> +{ >>>>> + int status; >>>>> + pid_t pid; >>>>> + struct user_regs_struct regs; >>>>> + struct iovec iov = { >>>>> + .iov_base = ®s, >>>>> + .iov_len = sizeof(regs), >>>>> + }; >>>>> + >>>>> + unsigned long orig_a0; >>>>> + struct iovec a0_iov = { >>>>> + .iov_base = &orig_a0, >>>>> + .iov_len = sizeof(orig_a0), >>>>> + }; >>>>> + >>>>> + pid = fork(); >>>>> + if (pid == 0) { >>>>> + /* Mark oneself being traced */ >>>>> + long val = ptrace(PTRACE_TRACEME, 0, 0, 0); >>>>> + >>>>> + if (val) >>>>> + perr_and_exit("failed to request for tracer to trace me: %ld\n", val); >>>>> + >>>>> + kill(getpid(), SIGSTOP); >>>>> + >>>>> + /* Perform exit syscall that will be intercepted */ >>>>> + exit(A0_OLD); >>>>> + } >>>>> + >>>>> + if (pid < 0) >>>>> + exit(1); >>>> >>>> This unexpected error condition deserves a message, so I'd use >>>> ksft_exit_fail_perror() here. >>>> >>>>> + >>>>> + if (waitpid(pid, &status, 0) != pid) >>>>> + perr_and_exit("failed to wait for the tracee %d\n", pid); >>>>> + >>>>> + /* Stop at the entry point of the syscall */ >>>>> + resume_and_wait_tracee(pid, PTRACE_SYSCALL); >>>>> + >>>>> + /* Check tracee regs before the syscall */ >>>>> + if (ptrace(PTRACE_GETREGSET, pid, NT_PRSTATUS, &iov)) >>>>> + perr_and_exit("failed to get tracee registers\n"); >>>>> + if (ptrace(PTRACE_GETREGSET, pid, NT_RISCV_ORIG_A0, &a0_iov)) >>>>> + perr_and_exit("failed to get tracee registers\n"); >>>>> + if (orig_a0 != A0_OLD) >>>>> + perr_and_exit("unexpected orig_a0: 0x%lx\n", orig_a0); >>>>> + >>>>> + /* Modify a0/orig_a0 for the syscall */ >>>>> + switch (opt) { >>>>> + case A0_MODIFY: >>>>> + regs.a0 = A0_NEW; >>>>> + break; >>>>> + case ORIG_A0_MODIFY: >>>>> + orig_a0 = A0_NEW; >>>>> + break; >>>>> + } >>>>> + >>>>> + if (ptrace(PTRACE_SETREGSET, pid, NT_RISCV_ORIG_A0, &a0_iov)) >>>>> + perr_and_exit("failed to set tracee registers\n"); >>>>> + >>>>> + /* Resume the tracee */ >>>>> + ptrace(PTRACE_CONT, pid, 0, 0); >>>>> + if (waitpid(pid, &status, 0) != pid) >>>>> + perr_and_exit("failed to wait for the tracee\n"); >>>>> + >>>>> + *result = WEXITSTATUS(status); >>>>> +} >>>>> + >>>>> +TEST(ptrace_modify_a0) >>>>> +{ >>>>> + int result; >>>>> + >>>>> + ptrace_test(A0_MODIFY, &result); >>>>> + >>>>> + /* The modification of a0 cannot affect the first argument of the syscall */ >>>>> + EXPECT_EQ(A0_OLD, result); >>>> >>>> What about checking that we actually set regs.a0 to A0_NEW? We'd need >>>> A0_NEW to be more unique than 4, though. >>>> >>>>> +} >>>>> + >>>>> +TEST(ptrace_modify_orig_a0) >>>>> +{ >>>>> + int result; >>>>> + >>>>> + ptrace_test(ORIG_A0_MODIFY, &result); >>>>> + >>>>> + /* Only modify orig_a0 to change the first argument of the syscall */ >>>> >>>> If we run ptrace_modify_a0 first then we've already set regs.a0 to A0_NEW >>>> and can't check with this test that we don't set it to A0_NEW. We should >>>> probably have two different test values, one for regs.a0 and one for >>>> orig_a0 and ensure on both tests that we aren't writing both. >>>> >>> >>> Celeste, do you want to fix this up or are you waiting for me to? >> >> Sorry for delay. I was busy with household affairs in the past few weeks. >> v3 will be sent tomorrow or the day after tomorrow. >> >> I am deeply sorry for this. > > No need to apologize! Just wanted to make sure you weren't expected me > to update the test :) > > - Charlie > >> >>> >>> - Charlie >>> >>>>> + EXPECT_EQ(A0_NEW, result); >>>>> +} >>>>> + >>>>> +TEST_HARNESS_MAIN >>>>> >>>>> -- >>>>> 2.47.0 >>>>> >>>> >>>> Thanks, >>>> drew >> v4 has been sent.