From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B09C77B7C for ; Tue, 24 Jun 2025 09:40:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C61756B00A8; Tue, 24 Jun 2025 05:40:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C393D6B00A9; Tue, 24 Jun 2025 05:40:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4F156B00AE; Tue, 24 Jun 2025 05:40:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A2A246B00A8 for ; Tue, 24 Jun 2025 05:40:15 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6FE12102F14 for ; Tue, 24 Jun 2025 09:40:15 +0000 (UTC) X-FDA: 83589798390.22.51985D1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id E0092A0007 for ; Tue, 24 Jun 2025 09:40:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AGyO3n4f; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750758013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wkz2HmRnrtAFPO13Q5j0a0RO64CPiFWvlD9dGHL1glU=; b=7MuJIveaCLaoZiwfUHyPo8x/znHnodf6SD+Hk8TLDMqcb4pe1ZI3o8JrI/3DJSNf5n064R XXo/m6co2FDHcYMSxS8eUfumWOe9PZc2F6uWoqtMu28o6HaDemdEKgS5ChVz1ua/efmOL0 43NCEThVQcn0sPkwfMoYUyZGqv8/P1Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750758013; a=rsa-sha256; cv=none; b=XJlBn1imV4RysV0Ywykpn4xkDErcO9/TDLLExvj2hIV5lRcwHk7qUPEEQkV4WyMxRpKzNv Lmc1xd8EzrmTgbffpb9/X+axFR1yG16nkhRq+Ov65EtAYIO10ksEfh0V6fLmeHhXsSejmH k5KRUDSI09Bqrd0jNqY8kJrNZaWLD2w= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AGyO3n4f; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750758012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Wkz2HmRnrtAFPO13Q5j0a0RO64CPiFWvlD9dGHL1glU=; b=AGyO3n4f7I4qt1kf8SXtTpNnZT2WoPW5DLsZ2aDX6p+pf1MG7pj137qwZC5qShM/6UE64M YeMVqgHfckN/fKdAizMxoF+EtKclCyDzSyFlY29BUuXv3qBfusA9rDXHHV1Mk4UV40zoLL kIP96TmzBZ8upfG3HKjGPBIGIqsnSyc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-udU6_rU-M2W7kQAV8o4_pQ-1; Tue, 24 Jun 2025 05:40:09 -0400 X-MC-Unique: udU6_rU-M2W7kQAV8o4_pQ-1 X-Mimecast-MFC-AGG-ID: udU6_rU-M2W7kQAV8o4_pQ_1750758008 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-450d50eacafso1769015e9.3 for ; Tue, 24 Jun 2025 02:40:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750758008; x=1751362808; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Wkz2HmRnrtAFPO13Q5j0a0RO64CPiFWvlD9dGHL1glU=; b=YQDgi+3VVBRW34rlRJAQrOblc+nscmbACLblDrXW9rlp5n5VPA6honPODEfhJ9upXF 60ADBXyt/qJX5Y+hVa/N1cqDvtMuibUjN+8S5UxUhNSMX3FeJkj2rHAWrlGj1Nuoa0U1 wlA9xyBNqrEmdFBerIm9h+U1n+JuHutEP/ZzcDWP0ypxcgChvaawJ/+cYvPpU41SgMFH mKRIx/91bSNwQ/sqKhJpIlj2UsjOYxsJc0Impgxb1BV4/eAFg2sCFti8YRvV8JiXIS91 cn1wKLm5lLsPJnTnrN7dIV+OOs/8w2buGgM8Xx5dMBTNCjGnxHelZeVTgpljvbmuEUMP m+Uw== X-Forwarded-Encrypted: i=1; AJvYcCWfpGhcFhBoIBwHzMLn5wV4n/vcAQn8m77E5dR/6SgU9j0fdi3efrRo9wHLIeB/U8beWc8/D2Ag/w==@kvack.org X-Gm-Message-State: AOJu0Ywz31RFZShSRb6ACgA7+0BsVRZcAGVSU5vLF1mNhZifnbx01JSq Q8YRKwp1iMd8B+i74Q1RJMy6NEKwBLr6GWLL5c+jQcYSgbbvmBRkUExqEs89J7q5524y3jEoZhW QI7GGlj72a1lrrgStI6nYS2J+NX7rB0QnNMeaV2FqTYaMyUgQfzqzj0wpn6mhPzQ= X-Gm-Gg: ASbGncuS50xi3wgDJ/4cTY47PoqwcvUtmkM4pCWSpYGGJ4gf5O3C+IOIF4OtfQXubH9 QS3sEKZ7jBrDvVKbPh+mm5UUACu3y+PFGFWbXpsHy2TrwlZ7QeegzFOoYlRAmmbzTgGzFr98si6 v11oI/mHKC63OfVMwZGkyd6v67ocgeQMvH08nxwtp+coOaVar26VryCdrXYysgFeYQ8F1wgtTR9 y32TPuOCVlHw2GvCYg1PLPjm0AVBFA0QhtN8X1hxRXVb8KdvRWXjMDFIXyAXw9dVj5jogLVVqLz RI/WtMbYkh2AjNXUEMYyMld+XaSUvrggt6LaFySc7hSs1KvMJzjNIUo= X-Received: by 2002:a05:600c:468b:b0:442:f98e:f37 with SMTP id 5b1f17b1804b1-453658ba2e3mr140094465e9.21.1750758007827; Tue, 24 Jun 2025 02:40:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJQC0liegHgcGebdfeGF2STlfVSp0cZcixQYIvtKZpGiiJJKAUUGgl09iG8B8dw+f4ZD8h6w== X-Received: by 2002:a05:600c:468b:b0:442:f98e:f37 with SMTP id 5b1f17b1804b1-453658ba2e3mr140094245e9.21.1750758007399; Tue, 24 Jun 2025 02:40:07 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4536470370fsm136043985e9.29.2025.06.24.02.40.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jun 2025 02:40:06 -0700 (PDT) Message-ID: <75717e4e-51d0-41a2-8463-45097fc3875b@redhat.com> Date: Tue, 24 Jun 2025 11:40:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: move mask update out of the atomic context To: Alexander Gordeev Cc: Dev Jain , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250623080440.3005693-1-agordeev@linux.ibm.com> <4214d6d6-f8d5-43b3-a413-f576fdaf215d@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hMkuMBxx1EbHucX-HzEbdJMEbkZiDZ_52-A1mGaHfWI_1750758008 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E0092A0007 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: u1n5hi71hnwd7ce6bb93kpuzocxkhm9u X-HE-Tag: 1750758012-445442 X-HE-Meta: U2FsdGVkX1+oSSzdEx9In4EEHVL7PGvdkvpCb3Eyuv3tZfve6CNCbGKTJrI4sT3h3ppFYCAVbQe0fZfD0f4fXxcz/sWcO1AFlZ03IokY9U12xfh2DE07MDbzu1oP1lS5nsG7OpmqsDKoKzWHJoZtnj+jsJMTlgoa5BIlOH1TWYxwYf0rwIEkEf6//tzn3K8MtMDzVfWeYlPNW3uVMDlRM3w7piB967mbTz3n+v1uh+caif5cpVzFCPJCOHDdyiTmTXT6XKwRIgRpeyTLLX2hp3jHKcbjsKmdAAum6IZmfh7BcUJGOb27RgKEfi3Ppb3Q2+y00r3DX8mH67kuhsI6Wb2I48AKt2xa+Ri++t2x0wKtG1K65btag3GZjlCB8x11Be/FlyZ3GeBbYKRJt2aSCVTK2Eedhc9tbtkoHcJOtIR82U7rF1bZ8NjeyCrvQAXoWchfijXKUaMAbmd8tS1FZVeXeDMp8CsLg2LLWy3n/WA5hBJW1b2emDFHAffMKP7nykAySlNY0RsmbEKSRiG0FISlTteTREl02YZuFZ9pxaukpe/+8KXQpXxiEHmX7GwB9TY0FguuknWCaLy85c6EYqK2Q3og8GlnHZy0VWysdprpZBpnY69U2zKQZEaNNbRusKwVv2si30E29p4fla0zp9kZFSrdU7SI+gbet2DGr5naGdu4a/iCPMwgNiNSx+9XQ45XlzVzoL9Uo0uYzNynkIHCvSKfvvr/Fc4EN5NazuZMbaFy5cwqdpFLrzGY7qd4JVTBt5DzRXeu6H0MZk1YT+4wv8rITqbMIZoo4OEQnijvTDGiKKwDaxTDyp4SBiX67rp9uYUZE5q5IE4vlgqu8HeDMqTQAz1VbPVAjgMD3Ibnw2B/nvXhTBoQ1rnBgEG17W8h8GLn7OSgUeJ69XI/wmLvCLddtEqYLnJ1zsUF4anNN1kGxCRtkXtWxpdlTlVZu4jg4GarE3eYfottnSe RMDkknPx qM3+tLwKqqwRoF/TNCIAxAXP82eXD2QtZZabOPv08zZwONO+lXF5p1wwIg0nFB6BrYGSv9tKnyxw4SwP8hcVahXiwksu/EoR9ksI9Pxs2YGpEiasHTsiizLvb0lNDgx61LKHceTtB4f6wGvk/sOoq+ttmqIArM57L39et7Klr5VJsobUr2KjyNLYLpV+w27/tPMJw491BSd+UgyHQ37Ykxodbrxxw/X8XnwZmsmX8LISVEIT6DMPBH3BBPnQ1vzaCwwYBx9E2nLoWEjdizeZGOtrlqtP5qRBsRxJPmO/TeIu9YUkKdf+1kPHydbLy6PdvOFhKBDrOMZygv+3/jRvrPg8ZqvqZXwV1qxnb96nrqY/c4t8EwtkmGC9WHTHDC8dGJq+eMUY7NtUtI0ot3iQxsIffT9YL7usBwWrB8g5CalnnmUonjLnCZWdTgLvR0ZwIXOvbXDzelFCu/8YGArH6dmYaNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.06.25 11:37, Alexander Gordeev wrote: > On Mon, Jun 23, 2025 at 09:45:34PM +0200, David Hildenbrand wrote: > ... >> Let's ask the real questions: who checks PGTBL_PTE_MODIFIED? >> >> I see >> >> if (mask & ARCH_PAGE_TABLE_SYNC_MASK) >> arch_sync_kernel_mappings(start, start + size); >> >> And then >> >> arch/arm/include/asm/page.h:#define ARCH_PAGE_TABLE_SYNC_MASK PGTBL_PMD_MODIFIED >> arch/x86/include/asm/pgtable-2level_types.h:#define ARCH_PAGE_TABLE_SYNC_MASK PGTBL_PMD_MODIFIED >> arch/x86/include/asm/pgtable-3level_types.h:#define ARCH_PAGE_TABLE_SYNC_MASK PGTBL_PMD_MODIFIED >> >> >> Which makes me wonder why we need PGTBL_PTE_MODIFIED at all? Is there some other check I am missing? >> >> (same question regarding everything excepy PGTBL_PMD_MODIFIED, because that actually seems to be used) > > AFAICT it was thought as architecture-specific: > > /* > * Architectures can set this mask to a combination of PGTBL_P?D_MODIFIED values > * and let generic vmalloc and ioremap code know when arch_sync_kernel_mappings() > * needs to be called. > */ > #ifndef ARCH_PAGE_TABLE_SYNC_MASK > #define ARCH_PAGE_TABLE_SYNC_MASK 0 > #endif > > Not sure if that needs to be addressed at all. Okay, if there are no users of PGTBL_PTE_MODIFIED we could just ... remove it. Dead code. -- Cheers, David / dhildenb