From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E467D2D0E6 for ; Tue, 13 Jan 2026 12:28:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DC536B0089; Tue, 13 Jan 2026 07:28:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BDF36B008A; Tue, 13 Jan 2026 07:28:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B3826B008C; Tue, 13 Jan 2026 07:28:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 796AC6B0089 for ; Tue, 13 Jan 2026 07:28:18 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 19C501AD54B for ; Tue, 13 Jan 2026 12:28:18 +0000 (UTC) X-FDA: 84326868276.10.766E272 Received: from smtp-out3.simply.com (smtp-out3.simply.com [94.231.106.210]) by imf16.hostedemail.com (Postfix) with ESMTP id ED262180003 for ; Tue, 13 Jan 2026 12:28:15 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none ("invalid DKIM record") header.d=gaisler.com header.s=simplycom2 header.b=NC76RtxI; spf=pass (imf16.hostedemail.com: domain of andreas@gaisler.com designates 94.231.106.210 as permitted sender) smtp.mailfrom=andreas@gaisler.com; dmarc=pass (policy=none) header.from=gaisler.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1768307296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=guD8ZDnRvesT5KvXlXi5P5IpxaFCA5kIle2X5/2VdEk=; b=YcVAxCr+KCOTIZMIFdG/fESMmjSP7r26Mw3/Dbe7NdKHLi8AbgL/Emo08fX4WPpVXPCd5K ZKtI7s6c1TY9vUeA9/d4qgcjU6nXRFxwOOcoXepIT8fpvCHi9V+YuQ7I2lGkxlqg9HabjH WU40j0dq96lcuedF0DpsjRrlUH+suBc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none ("invalid DKIM record") header.d=gaisler.com header.s=simplycom2 header.b=NC76RtxI; spf=pass (imf16.hostedemail.com: domain of andreas@gaisler.com designates 94.231.106.210 as permitted sender) smtp.mailfrom=andreas@gaisler.com; dmarc=pass (policy=none) header.from=gaisler.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1768307296; a=rsa-sha256; cv=none; b=FmwCIgb7eM6WHe1Qqh0NkU29i3yI35149hZqrM3MNw/5WI5MUDONlsYQWipp5sRHqcRqlC TwexsJm1Konom1b/CcPdBi7p6/vudH6c4mDR8vKm97rR2sZF/wEwA7ifYwQLIyW7fdrsSq G3K+bwIA6tn1TQJ21GeSKsVUjW1V79s= Received: from localhost (localhost [127.0.0.1]) by smtp.simply.com (Simply.com) with ESMTP id 4dr7nT4yQ4z1FDXl; Tue, 13 Jan 2026 13:28:13 +0100 (CET) Received: from [192.168.0.25] (h-98-128-223-123.NA.cust.bahnhof.se [98.128.223.123]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by smtp.simply.com (Simply.com) with ESMTPSA id 4dr7nQ25vMz1DDgf; Tue, 13 Jan 2026 13:28:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gaisler.com; s=simplycom2; t=1768307293; bh=guD8ZDnRvesT5KvXlXi5P5IpxaFCA5kIle2X5/2VdEk=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=NC76RtxIq9CvKMBZ8e8fqDdeh4TXwyvNkvf30sHXNOLOnEVZmRBj+bHCDi8FufU/c kWfZWHOIxSWOKL03enthax76m8YsczdRizVAQDjKjHPFRaRl/L5Y0iqK2UA8boHs2h YUuM9qT6Ba/QEyyAn4GTFzIGpGi10RKIEp9TlTeLGd8zC+Hr/coq6gBL6LosZXZTF1 gt8Mie1XHzB/bpnFnld9TZavLmhYmlgBWFsXaCVZw4vobFyvtSEkURaEmNJU94ewFm w3pY4SkxqHFB/QXGBXfUllqNu8tQIWuZ/XTNBQs4TvEhLsgrM+Wzf2b59+1+UOXxo8 bJQ987lvmGGqA== Message-ID: <7566eef3-bce4-4100-8a11-d88ef1e887a9@gaisler.com> Date: Tue, 13 Jan 2026 13:28:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 19/29] sparc: introduce arch_zone_limits_init() To: Mike Rapoport , Andrew Morton Cc: Alex Shi , Alexander Gordeev , Borislav Petkov , Brian Cain , "Christophe Leroy (CS GROUP)" , Catalin Marinas , "David S. Miller" , Dave Hansen , David Hildenbrand , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Heiko Carstens , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Jonathan Corbet , Klara Modin , "Liam R. Howlett" , Lorenzo Stoakes , Magnus Lindholm , Matt Turner , Max Filippov , Michael Ellerman , Michal Hocko , Michal Simek , Muchun Song , Oscar Salvador , Palmer Dabbelt , Pratyush Yadav , Richard Weinberger , Ritesh Harjani , Russell King , Stafford Horne , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Vineet Gupta , Vlastimil Babka , Will Deacon , x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org References: <20260111082105.290734-1-rppt@kernel.org> <20260111082105.290734-20-rppt@kernel.org> Content-Language: en-US From: Andreas Larsson In-Reply-To: <20260111082105.290734-20-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: zd5shqyxeuitfdkifqu5aw9ii79ope88 X-Rspamd-Queue-Id: ED262180003 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1768307295-661341 X-HE-Meta: U2FsdGVkX1+WCja5BgU6nLrhzmOjkfT52d1LVB+omWCGfdKO0IZWNzeI1lWJNtw2rHurzofaXoa4Wd/hljxdhsYHMuyMFyCEOMpYtr4mXtDHygeCNKU48HMtv21WNPkgqUrNpDEnW2l8r4RAdzWwFeLMMa7vRJ4aug/mMfukPDUKPazffDKm3WRIswk+17WmUcwyq76M7UoyOZYeaqlxn2Wsu8/dwsVDYKISlVZ1bS5a5d7gFsBaQlcRsKZwwf8otxE6Q7OziK2Rs3z2KdOLVWiAy4RmbTFCIWWe7E6Y2y458ckLtjp3tMX+4HChQmgF7/t0BCP4DK9YhbAcXApvCLeKDqM3QK98HG4/kuVAXPRdpzMSvofOZ2OkcnUUPCKU1mJpcVSnctSn8ygyZn08iu4YYNFi4LMZ5MB9+qxYsKHvUHBRl+qvMqr00E+k6xMr2kTgz7xHogGZ2u7FBSPh7MoTa36xP90z4vBVG1wot2JxyiYj9Zmg2oCL7XhqhUGFQIuCGTuTmKUpdxRMSRpq2gWZYG5t9PQdtnXrBfMRRQgo+ck3x1bS6aR1S5GyLE/wMHPZn/rOOBYQvVv1lvScgoF/idKF4ovLVMelFFtjh2A1WdM9S4dgvyfwonVaTgaBcRnYjurSig8sSyVcv9H7XkgnFPp6x7j+YdDd4E9FgOSVc6wehmCM89G3iIQD0x2lfL/V5fPYzWuj/r/pVuQZ6hldIZ4GufAjPFeGNcPOmuUc2Ob9rXasOnq7wDmiKi1NeqCQTukiQN8JY8Zzm7zsOnCyY0gl1bnjeyuaNzHRZ2uVYd6OMImiO1YPIlwL/8jRRoJ1e02VAjO+C+zuDcgXkNbTkqdklUcOyvt2m0c/7Kxlp6ofeFNqkXg9IvZ1VIMGUdydpO9C+XblpfKqCZIVRhX+g7Pn0J2/X8401+hAmcLnZY0KuOW78R0kOEX5L8dTtUYNwgA2tCKWYyW5QvN /RTT2FZ3 TdbpMdNf1Erdf5F963fXNTP1TUdYh8KTEmjsq6BY5dzmKEihGHX+hobAwsEg9lJKmL2tZRaiCIIYr0vSQHzs/iDTVJPQAbO9HHYirhfq1V6O6AclP9FJ37YbrWVMl/ytw9CApF2X9GzXmz1GkX1p1O0zsMd/tpioAzt0i2XD7qWw5PXJO2i5L8VVg9Mz+lO1zRLREvAhfsESgN0+u+YsH8zT8ehqlATUWjzCK9qQRLXIJsyWDpjqn0huTxls2hCtNfiXzCQ1XgloDzSz4S2Y/mMMEnUjINAnoh0rWZKNxKUAOJH40bX+wU5eEoLVDozYUwWTsgHtNjtwB6Ha6DF6XbbLSwkVtYKHPtjUOmPAJG7rvdMZ8lzENkK2aSbytLmu1WUGyxkC4OntmYs27XKcmb5KaerEEeJt7GvXWre3YSwhu4T+J0w/POUWr/21i9laZ5CArSA3T1zapSpldTGA1xVHHBgxwjPbqFXb3jUJGHGNMN4oC5NxZsvvhJ/4qaQSyhyj2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2026-01-11 09:20, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Move calculations of zone limits to a dedicated arch_zone_limits_init() > function. > > Later MM core will use this function as an architecture specific callback > during nodes and zones initialization and thus there won't be a need to > call free_area_init() from every architecture. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > arch/sparc/mm/init_64.c | 6 ++++++ > arch/sparc/mm/srmmu.c | 12 ++++++++---- > 2 files changed, 14 insertions(+), 4 deletions(-) Hi Mike, Thanks for this nice cleanup series. > diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c > index df9f7c444c39..fbaad449dfc9 100644 > --- a/arch/sparc/mm/init_64.c > +++ b/arch/sparc/mm/init_64.c > @@ -2279,6 +2279,11 @@ static void __init reduce_memory(phys_addr_t limit_ram) > memblock_enforce_memory_limit(limit_ram); > } > > +void __init arch_zone_limits_init(unsigned long *max_zone_pfns) > +{ > + max_zone_pfns[ZONE_NORMAL] = last_valid_pfn; > +} > + > void __init paging_init(void) > { > unsigned long end_pfn, shift, phys_base; > @@ -2461,6 +2466,7 @@ void __init paging_init(void) > > max_zone_pfns[ZONE_NORMAL] = end_pfn; This old initialization of max_zone_pfns[ZONE_NORMAL] should also be removed, right? With that removed it makes the local end_pfn variable set but unused, so could you please also remove that one? I know that this whole code block gets removed later, but the cleanup max_zone_pfns[ZONE_NORMAL] and the removal of end_pfn (that is not done later in this version of the series) fits logically in this patch. > > + arch_zone_limits_init(max_zone_pfns); > free_area_init(max_zone_pfns); > } > > diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c > index f8fb4911d360..81e90151db90 100644 > --- a/arch/sparc/mm/srmmu.c > +++ b/arch/sparc/mm/srmmu.c > @@ -884,6 +884,13 @@ static void __init map_kernel(void) > > void (*poke_srmmu)(void) = NULL; > > +void __init arch_zone_limits_init(unsigned long *max_zone_pfns) > +{ > + max_zone_pfns[ZONE_DMA] = max_low_pfn; > + max_zone_pfns[ZONE_NORMAL] = max_low_pfn; > + max_zone_pfns[ZONE_HIGHMEM] = highend_pfn; > +} > + > void __init srmmu_paging_init(void) > { > int i; > @@ -967,10 +974,7 @@ void __init srmmu_paging_init(void) > { > unsigned long max_zone_pfn[MAX_NR_ZONES] = { 0 }; > > - max_zone_pfn[ZONE_DMA] = max_low_pfn; > - max_zone_pfn[ZONE_NORMAL] = max_low_pfn; > - max_zone_pfn[ZONE_HIGHMEM] = highend_pfn; > - > + arch_zone_limits_init(max_zone_pfn); > free_area_init(max_zone_pfn); > } > } With the feedback for arch/sparc/mm/init_64.c addressed: Acked-by: Andreas Larsson Cheers, Andreas