From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5627FE77182 for ; Wed, 11 Dec 2024 08:11:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF21E8D0016; Wed, 11 Dec 2024 03:11:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA0F88D0013; Wed, 11 Dec 2024 03:11:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 941758D0016; Wed, 11 Dec 2024 03:11:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 779398D0013 for ; Wed, 11 Dec 2024 03:11:02 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 175741A0732 for ; Wed, 11 Dec 2024 08:11:02 +0000 (UTC) X-FDA: 82881956640.06.5A41676 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf22.hostedemail.com (Postfix) with ESMTP id 6B603C0008 for ; Wed, 11 Dec 2024 08:10:35 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="VUX9onN/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TEDhe5xB; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="VUX9onN/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TEDhe5xB; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733904649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=097BQ8xEoKDP8wU1Y3Ab7JyNcpEUvq7xz9/PVN0G0Vs=; b=YLVERSbzPCqBWKubq7UQNIKzd86o5UTM6xbZe8aOTR58ZhFI9dv1A3VkioHDNY3ldqpvm+ vVCT2pSd8dE9VfFGpvzswTsdeuAUqe+6UqF2uULVQcIxr07RLdk/sdgKWBiG3grHBVubbl 5ImcZYsATNa4uHsO+kiWfU8w4lzW+YM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733904649; a=rsa-sha256; cv=none; b=Mi4A45qlLyoz+Q65DtvODJx8Tm4TVBV6CSJHt3JyGRxLjOYVDUabMztI24tnvFBoCmU2zk gaQtc4/opEXESGNVtLm0Dcl/5KpVRbxW/Njp7YoG0hUx0p49YC4cC09vQcojN6ZCzUr/0o TurF6u79XBPSSLksgDIQXKUgq1vo/10= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="VUX9onN/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TEDhe5xB; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="VUX9onN/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TEDhe5xB; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8F3291F38C; Wed, 11 Dec 2024 08:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733904657; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=097BQ8xEoKDP8wU1Y3Ab7JyNcpEUvq7xz9/PVN0G0Vs=; b=VUX9onN/9u0iLPzKDVZ45cWqcTuqs/cWmiloOn5D1IRDvKUtS7vQ3Ef6gP0b5QmWCdoC4g Z5XySk6oNu/kCWKZUmbbiLyZbFmJ/2M4+ITszMYYVF6nDVfRTqcnkIuQNedtWw8Kuw1Ak1 5nAvf0umQM9VZSZxBYHEckhw3tAcDro= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733904657; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=097BQ8xEoKDP8wU1Y3Ab7JyNcpEUvq7xz9/PVN0G0Vs=; b=TEDhe5xBX9tbV2wjr1d9YN/WcEJjY5Q63eJbk5Cln5Ideh79YQVFcJMZXxKebPUr1dH0LW jS/QwbJbAvqO9kCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733904657; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=097BQ8xEoKDP8wU1Y3Ab7JyNcpEUvq7xz9/PVN0G0Vs=; b=VUX9onN/9u0iLPzKDVZ45cWqcTuqs/cWmiloOn5D1IRDvKUtS7vQ3Ef6gP0b5QmWCdoC4g Z5XySk6oNu/kCWKZUmbbiLyZbFmJ/2M4+ITszMYYVF6nDVfRTqcnkIuQNedtWw8Kuw1Ak1 5nAvf0umQM9VZSZxBYHEckhw3tAcDro= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733904657; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=097BQ8xEoKDP8wU1Y3Ab7JyNcpEUvq7xz9/PVN0G0Vs=; b=TEDhe5xBX9tbV2wjr1d9YN/WcEJjY5Q63eJbk5Cln5Ideh79YQVFcJMZXxKebPUr1dH0LW jS/QwbJbAvqO9kCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 70D001344A; Wed, 11 Dec 2024 08:10:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id t0WyGRFJWWdGMgAAD6G6ig (envelope-from ); Wed, 11 Dec 2024 08:10:57 +0000 Message-ID: <75619318-6b68-4ce4-a3e2-891a41eb43c9@suse.cz> Date: Wed, 11 Dec 2024 09:10:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 mm-unstable] mm/migrate: Remove slab checks in isolate_movable_page() To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Matthew Wilcox , Andrew Morton , David Hildenbrand , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , linux-mm@kvack.org References: <20241210124807.8584-1-42.hyeyoo@gmail.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241210124807.8584-1-42.hyeyoo@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: dq4oimum5k4dbatuirxxy3odo5un8yd3 X-Rspamd-Queue-Id: 6B603C0008 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733904635-979228 X-HE-Meta: U2FsdGVkX19Vnq9bvW1kwmNpDKhedoC4Pqycoiq85czuCsnhiPxHGY5mWYYSSG6HEeLej1c2cmlJEB34LQqvg1yT3EdGd5JPpSWnVgBU1NExqLPvpmCpH+pXFb/uHDwc6T11kTEpfGdwbSsXHEXeCO48X4cZCEx76/02y4H0bpIuexYSdLUaESIbLrvrYkADIUSElmIbYaSUcEG9zeHDFFK5p1icfZ2/XMAqOD+DuYvDzufdRHUboV67etlBLVrhbAiflMfEQ2/XI2pJO1uB9FMwldVi77zzqLkKCpaY87shyZYHpy9ZP8KbLwBwUUYlIS2puiqCONtoBpmRf+0+CW2g1PH0R8QowdWk6rw90M2gIMZ01vAY4oDEa1PEfBJ0gKpLR7gXM1/v0OBeQtw85JIbIrVmLWueURxSJuwyC7rNv+M8IBEqYD+FXITmWXuuxUwAU9aLv64rQ2nzCOerhjhJMYA+CYfLls1hz68ZQlq91pRCoMeDihIrr6GCGOQRGGz4L0eRMgbekEul3SUEIIOfs4DgU38Kw6DPPlicPv5P2RTFa3t6dP4/rSD+UM5ORKeH1Po7YEG/slPagUv/fQtW4b2waaq+jMQVSr6A+6xnbfjAPF/9lE+6LSgAl15St4hK5okZYf1ub+dX67dFmycUmVHH20g9M5CYsSzxVBwn+Y2AbH5Y1PamrmR47TDd1deCcxNpqP4slLtKxVtbO3KIg6NB87i7Aw8A0+D/3VxxtotwFIrMPkriI0QDvvJXXOSo/1QCEG/Qd1MCCk/R0OXB6Ih1ZM3bFhcM3V1kFqRWcJAfyJFhd3eaNppD5YmTcFgnsLrJq1JihFCcl1RQ9GcirXaGMLilpeOU2hr7i6xVh758fla1ojFQ3/8ztzX0JS17svUQi9w0y9M6aJvcLcEl2ZxKkRxAPfASiXEPlnKMIgt0RhGYd+gzBrJLruCGd65yha0vx+XiFVjWrJM PdEbkYOx 67ETX5MXBNOTup8w1SYe0Z+1zumCv7+RqqSBmd6CVnr1Vd5zUWlCcFJEls2PfYm7n/3XF5hPQR7BuifQ05IfudM9QtBsD2D4BrFYxN5AK5xZwJrIs7ccNsNpUcEaEzKhsEqALU7bShy91i1xjGqnQp6HkAwi7cfiesLquK+qI8pITdpDn92lVb7jiPyphHFyYSZo5otkbDOshd8xC1eHAYoxI/2iqsGlnNJJLZl9q6iqhcGDT31Qy1BeS16syq86dGdsmXYduzbzx2izLwuYWcUtQhw34vdyl/v1zRhsWBqoFs+59igQFiGgUwz63p43S32GLHG9LybCYnZZK+ZEAatu8HztsbF0VEwRu7hskAAY32mYjZsPzd/OfYIPACFbJLApud7JAXY0LoGx2yD7xjgVCEdh4bTVcSRcWPVfW7kNDdFc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/10/24 13:48, Hyeonggon Yoo wrote: > Commit 8b8817630ae8 ("mm/migrate: make isolate_movable_page() skip slab > pages") introduced slab checks to prevent mis-identification of slab > pages as movable kernel pages. > > However, after Matthew's frozen folio series, these slab checks became > unnecessary as the migration logic fails to increase the reference count > for frozen slab folios. Remove these redundant slab checks and associated > memory barriers. > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reviewed-by: Vlastimil Babka Thanks!