From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 985ACCDE02F for ; Fri, 27 Sep 2024 12:30:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 357A46B00B6; Fri, 27 Sep 2024 08:30:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3086F6B00D8; Fri, 27 Sep 2024 08:30:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15A456B00D9; Fri, 27 Sep 2024 08:30:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EA6196B00D8 for ; Fri, 27 Sep 2024 08:30:26 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5007B1C3C0B for ; Fri, 27 Sep 2024 12:30:26 +0000 (UTC) X-FDA: 82610451252.15.5E52BC7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 1FE3E80020 for ; Fri, 27 Sep 2024 12:30:23 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AfzDtLwD; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727440101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b70emq1asFc0837pR5hOySriSfg2vpMiOIzL46iGcG0=; b=uGdQM9lTnV7uohBvT4xJ6Q0JwEq+GWCURbx4gkPZlPI/AJG5mDI/zUxQeqHOkXf/o3p9ga /AHpNaYh/iQI9BSHCkaONeV3VthtMt57Buv48rrXfTWAXISeFFdsFJrCH7tJMRDcHC+v+/ t8XxhnV52AHmCal9xdF+U6QzG84Q5gw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727440101; a=rsa-sha256; cv=none; b=R9hRpXxkJ3nSypMH2DYHIB2WgqyeTj1xcN7IbRp1s3oliVju/eXA/gfmmPRNMLcdV3y6Vs 18HWfHs95K1upOS15/UMfuXX0Ak4KkLp3RzlP2IZU8sYUcGpx290gfZpE1qDIz7ytBvasR iJ25yZ4ORJgOSxahAS3kcjtjrRXxT+o= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AfzDtLwD; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727440223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=b70emq1asFc0837pR5hOySriSfg2vpMiOIzL46iGcG0=; b=AfzDtLwDv2CDEwBDc8hUBhFBck2qMMuB16E/eCZw4XXDKt38q0TbbVvqxSMazMQxvq2O4P U5AcECgrE97ACUQ2SLCDTscghCD55pqYh30eUMAHNQsKMMEu9iKyuhCp4C0eSyMmC+v3yo 2Mmttj3enmNFqApEuAjjFtNV/e4gODo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-YyAuX3bJPfOi8FDk4uV7Lw-1; Fri, 27 Sep 2024 08:30:22 -0400 X-MC-Unique: YyAuX3bJPfOi8FDk4uV7Lw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42cb2c9027dso15227435e9.1 for ; Fri, 27 Sep 2024 05:30:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727440221; x=1728045021; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=b70emq1asFc0837pR5hOySriSfg2vpMiOIzL46iGcG0=; b=VGxn991szgWsEDH/dwAp89CMmfRnVR+I6OVlkyKRIpyK1e2TLf9M5EUoOhrqGGjU7z T8FO+T91oozSxuA2stNv5Xz6dvDLK+8t3AeOKe31dImrbflwOSK0oN3HgV9M3B9FpNvi +N4QnONYcNCjXSKWmWsS74t9ut8/ATHeNWkMCIFmnNixT/Ymr1kX5e5Alz3JU87afX23 XMCZBl5ggEszz/XfaPRiPWsaR3/R3nb8gUPwGEc7bPNdmhqMn32YDIpUWb6aro8gdAd4 VvIVI+nmvveBaKuUmUAOWHdpCjA+gpR2o/4CVA6JOLIM5AAqDPSNkLnddXm1QpTsEwue 5p9Q== X-Gm-Message-State: AOJu0Yx0z3DmYPjURYIYJT56gdsReFCO4/OuRrLtXdgux5IcztRUP2t4 9Xxgp75nw5pHYdpLvlfmsF/ugQU4L60i1OJ6zQpy5+z1d23y57MkWFRGnwTh0oZbnmETPEWqAeF UHc5Us0kHhtxmqaKk0ZGShtHZTNAd2/4cRabvAMf1mtSxXltg X-Received: by 2002:a05:600c:4e8f:b0:42c:b950:680b with SMTP id 5b1f17b1804b1-42f5844b9e9mr21067945e9.20.1727440220885; Fri, 27 Sep 2024 05:30:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHbeKokqzPe5HzgTC9M987h8/ulPeXqAyPBJYVCgaBKlgmGQE/SiUjYvPIcdpIf0Eah4AKNjg== X-Received: by 2002:a05:600c:4e8f:b0:42c:b950:680b with SMTP id 5b1f17b1804b1-42f5844b9e9mr21067725e9.20.1727440220462; Fri, 27 Sep 2024 05:30:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:8000:b502:8c1c:3624:99d4? (p200300cbc7098000b5028c1c362499d4.dip0.t-ipconnect.de. [2003:cb:c709:8000:b502:8c1c:3624:99d4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e969f2083sm72248885e9.15.2024.09.27.05.30.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2024 05:30:20 -0700 (PDT) Message-ID: <755ff53a-2727-4993-92b4-95be668f3b67@redhat.com> Date: Fri, 27 Sep 2024 14:30:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/cma: print total and used count in cma_alloc() To: Xiang Gao , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, gaoxiang17 References: <20240926120049.321514-1-gxxa03070307@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240926120049.321514-1-gxxa03070307@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: kqbeomajk9u3o8w37fca6mutrmhc7iiu X-Rspamd-Queue-Id: 1FE3E80020 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727440223-373136 X-HE-Meta: U2FsdGVkX1+ug88hIwiZmLGgrdVLryvYhjclHHVFzHn1SBctgpE2o7duWl2wvNgFqLhYibjGalfVSlSBparjb9VAqZy/X87BBOuNMwTTVUeHnVe9z7UETLIpbEwXMQ/cNldQa+yk+kR4Mgs+sXOeAlSI6CJemn0jFdOJJmp9KP3pDIAd9ZY80W6F+9SYU3dqsYJkISwJ7OrPv8ORWT7WqY8Ovtj01HTgAMwaJXSaoQwXrx5G9uNYFDwkj4zkGUlgwp9g4wk7qhkmjm0no+Nv0EfiY89M2U4f92HnAhwLxNIVWTgzZBzTzAJCrsqHDzjURhUcBP0I96NJSP/JRcqU+C1UT0MoEb19Ds7y6jsXh/Rs9ereBv1azmgCH6BqKxBMa1ZMXPupyiCcf84OftOeWCsffm72SVEMM8fiszOn9laSHOaY9755WkDDpsPJdVfE5q4dryv3wp399IXlC8NXv2XJ/UKPqIQAjN6iTtphjiL3LIg6UP+w6LYhAAcscmy3Dv+bIaQnYM5hMiLBMVHVVd2mSFzl3FkH+URnXAPlBTLVjRi+X8hCms6wKmG5k8KZ6ie9CmnPlHDUAnzHBSG8m/jVxHYu6mWAqCRZ3IxqAmTF1VUMOR2q9Awmlnpwc+MMS0vuCJWzAI2doB8Nrexm5ZIsql5veeBgtwraGMUUSaJM9S5J4e4rxExtLRB42gwEudgKyGcSsbFkFWEEmq/Pc0z4r5Pxp9WzznRq70rwuqheg8XaA6foizST8ZXPrHgQJ4Ey3R5tsmwEuBNPqfFhDW580ikgd4BBGKeaUH8kkK8LFYgcBzCfE/06NJ5Lfdk7Gz84rHnC7BcssNTfLuXUAKF2edf1gw3yEjUJHDAHmqxsb95GVHby6ltjzN5EDvmPTP0jhHyq3rByPRNUv+Pl4LXlYAevym5Dh4L2Lki11lQy67FN9WHrEsLYGyjmt4jmXX++q2VnqwdHCM8r7Jb QyuyxHPu 41rgHDOz9QHOVkz8st0FDY/rMIP/gXTRf5V2Gi3BZsSl8W7Ypz9BFZvn49nQntrCngLMJgS7jFxkhl5Wj/UXyOt8JjHBQ3cnhxXJnPhoi/VbURxOno2kYMMdZDt6IbT1PVtZnBkTt/7OK3praeO+qAzf/TjZjDSskqOCMN/a4+oQneKb/lYF0zQSIgUF9PTa8wtofyDW4v/ZguIAlj8bOddqFmwGi3ERsMSCXmkKbKSH7x+yjJIj4vVEslCvs91cd9YtEbiG2hTtrUT4rsZiSajJpCQTCZ10KVXwMhKw8pvPRzyxLpcyHQmmKx91AeG80ZnWN3zoueyY9DeLmlqtepA3yZ5QfCJELmXU+JNh1qhVfBE/moclifzQ9G/lBxyMR2G7KNnbmVIdkt/QsGHv2euzUDztFIXzuOXpWI9ZnUWvQxBVrZSObb8rKjX7PHCJTf17GA4sc2ZAig5DUtQvENPzBAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.09.24 14:00, Xiang Gao wrote: > From: gaoxiang17 > > before: > [ 24.407814] cma: cma_alloc(cma (____ptrval____), name: reserved, count 1, align 0) > [ 24.413397] cma: cma_alloc(cma (____ptrval____), name: reserved, count 1, align 0) > [ 24.415886] cma: cma_alloc(cma (____ptrval____), name: reserved, count 1, align 0) > > after: > [ 24.097989] cma: cma_alloc(cma (____ptrval____), name: reserved, total count 16384, used count: 64, request count 1, align 0) > [ 24.104260] cma: cma_alloc(cma (____ptrval____), name: reserved, total count 16384, used count: 65, request count 1, align 0) > [ 24.107504] cma: cma_alloc(cma (____ptrval____), name: reserved, total count 16384, used count: 66, request count 1, align 0) > > Signed-off-by: gaoxiang17 > --- > mm/cma.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 2d9fae939283..fc35a86aa82f 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -403,6 +403,17 @@ static void cma_debug_show_areas(struct cma *cma) > spin_unlock_irq(&cma->lock); > } > > +static unsigned long cma_get_used(struct cma *cma) I would call it "cma_get_used_pages()" > +{ > + unsigned long used; > + > + spin_lock_irq(&cma->lock); > + used = bitmap_weight(cma->bitmap, (int)cma_bitmap_maxno(cma)); > + spin_unlock_irq(&cma->lock); > + > + return used << cma->order_per_bit; > +} > + > static struct page *__cma_alloc(struct cma *cma, unsigned long count, > unsigned int align, gfp_t gfp) > { > @@ -420,8 +431,8 @@ static struct page *__cma_alloc(struct cma *cma, unsigned long count, > if (!cma || !cma->count || !cma->bitmap) > return page; > > - pr_debug("%s(cma %p, name: %s, count %lu, align %d)\n", __func__, > - (void *)cma, cma->name, count, align); > + pr_debug("%s(cma %p, name: %s, total count %lu, used count: %lu, request count %lu, align %d)\n", __func__, I would suggest dropping the "count", or using "pages" instead. Also, inconsistent usage of ":". Either: pr_debug("%s(cma %p, name: %s, total: %lu, used: %lu, requested: %lu, ..." or pr_debug("%s(cma %p, name: %s, total pages: %lu, used pages: %lu, requested pages: %lu, ..." > + (void *)cma, cma->name, cma->count, cma_get_used(cma), count, align); > > if (!count) > return page; -- Cheers, David / dhildenb