From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17C8AC3601E for ; Thu, 10 Apr 2025 13:25:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDF112800FE; Thu, 10 Apr 2025 09:25:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8D342800FC; Thu, 10 Apr 2025 09:25:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A558C2800FE; Thu, 10 Apr 2025 09:25:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 86B312800FC for ; Thu, 10 Apr 2025 09:25:26 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DEC581209C2 for ; Thu, 10 Apr 2025 13:25:27 +0000 (UTC) X-FDA: 83318205894.20.119FBCE Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf04.hostedemail.com (Postfix) with ESMTP id 5AF4A40005 for ; Thu, 10 Apr 2025 13:25:25 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744291526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XvX4DyBsb9MU6aJaWGWb9e/+x1GWdPmizM18WinUPhs=; b=f0kfcyapXAYKEwBGpZoo/bhOQRTLBALjw2FWbvQGSPiLubOhwob5lNTIgK/e2s3JJtS2PG WRjGmS96wbyR7y2lN3F0Tq5ZNKRFsWy+WPdHFH5B7MjxswkuUv04ygQ1i+SBJyE1a6bWoF 2ABTLsDkYhe7LMP/pGonyWaKUiHXpNY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744291526; a=rsa-sha256; cv=none; b=o6x7VgMFPtG0c31LPag8ctwLIvGFbT7VlbRXhT+/yNykcWON5MpLncZdpU+nbCD0gaJHx6 JmumZsWipvzs1cVWUkezzVhpseM6b532VmYmzmrmHMmyui71vSnBfhT8QFd3vkENgKhqga fgQJQz5puC0YabMa9BOMBSRQfs1EdCc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com; dmarc=none X-AuditID: a67dfc5b-669ff7000002311f-c8-67f7c6c2b057 Message-ID: <755ad3ff-17d5-4610-94ce-2f2d775b518d@sk.com> Date: Thu, 10 Apr 2025 22:25:22 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: kernel_team@skhynix.com, gourry@gourry.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, Jonathan.Cameron@huawei.com, osalvador@suse.de, yunjeong.mun@sk.com Subject: Re: [PATCH v7 3/3] mm/mempolicy: Support memory hotplug in weighted interleave To: David Hildenbrand , Rakie Kim , akpm@linux-foundation.org References: <20250408073243.488-1-rakie.kim@sk.com> <20250408073243.488-4-rakie.kim@sk.com> <19562f7e-38ce-41fc-8dfc-bfd6b1259291@redhat.com> <203ed4e9-4691-483c-bf42-3035b3ad3539@redhat.com> Content-Language: ko From: Honggyu Kim In-Reply-To: <203ed4e9-4691-483c-bf42-3035b3ad3539@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsXC9ZZnke7hY9/TDdYeZbKYs34Nm8X0qRcY Lb6u/8Vs8fPucXaLVQuvsVkc3zqP3eL8rFMsFpd3zWGzuLfmP6vFmWlFFqvXZDhwe+ycdZfd o7vtMrtHy5G3rB6L97xk8tj0aRK7x4kZv1k8dj609Hi/7yqbx+bT1R6fN8kFcEVx2aSk5mSW pRbp2yVwZaz+dpOxYIdExZrTixkbGD8JdzFyckgImEjs//SQHcbe862LFcTmFbCUmL3oOlCc g4NFQFVixi9NiLCgxMmZT1hAbFEBeYn7t2YAlXBxMAvMZJJ4cXQtK0i9sECkxM9+Z5AaEYFk icNnzjCD1AgJfGWUWL1oMdguZgERidmdbcwgNpuAmsSVl5OYQHo5Bewkun5YQZSYSXRt7WKE sOUlmrfOBpsjITCZXWLim+lQN0tKHFxxg2UCo+AsJPfNQrJiFpJZs5DMWsDIsopRKDOvLDcx M8dEL6MyL7NCLzk/dxMjML6W1f6J3sH46ULwIUYBDkYlHt4dq7+nC7EmlhVX5h5ilOBgVhLh 9TQECvGmJFZWpRblxxeV5qQWH2KU5mBREuc1+laeIiSQnliSmp2aWpBaBJNl4uCUamBcPLkn RmWdBnPkE6bEvC1MQWYH3S5tuVOz3kqy5dNm/6tt8zO/memvqg5hFJLW+3diqzJ3tGHktGub H27ctP3P39BYr3IGwSO8b4y1DPinuC2cISi+oXG73NPAifHX3pWcs19WFOo3I9k9nO+K0O3i lqDfQnLOD/+nLdDekSHZznqp7/P1DxxKLMUZiYZazEXFiQA9tucpqwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplkeLIzCtJLcpLzFFi42LhmqGlp3vo2Pd0gx1/DCzmrF/DZjF96gVG i6/rfzFb/Lx7nN1i1cJrbBbHt85jtzg89ySrxflZp1gsLu+aw2Zxb81/Vosz04osDl17zmqx ek2Gxe9tK9gc+Dx2zrrL7tHddpndo+XIW1aPxXteMnls+jSJ3ePEjN8sHjsfWnq833eVzePb bQ+PxS8+MHlsPl3t8XmTXABPFJdNSmpOZllqkb5dAlfG6m83GQt2SFSsOb2YsYHxk3AXIyeH hICJxJ5vXawgNq+ApcTsRdfZuxg5OFgEVCVm/NKECAtKnJz5hAXEFhWQl7h/awZQCRcHs8BM JokXR9eygtQLC0RK/Ox3BqkREUiWOHzmDDNIjZDAV0aJ1YsWs4MkmAVEJGZ3tjGD2GwCahJX Xk5iAunlFLCT6PphBVFiJtG1tYsRwpaXaN46m3kCI98sJGfMQjJpFpKWWUhaFjCyrGIUycwr y03MzDHVK87OqMzLrNBLzs/dxAiMpGW1fybuYPxy2f0QowAHoxIP747V39OFWBPLiitzDzFK cDArifB6GgKFeFMSK6tSi/Lji0pzUosPMUpzsCiJ83qFpyYICaQnlqRmp6YWpBbBZJk4OKUa GAsWqrxXqJmR9+Djt/XnC1UiJFXknyuEL9N8dddXk00xV1xb/Xpo8cabtrP8HtzfeLVwwsW/ YeqM29+aL1zVcnAdwxJlTst0049XskU6Lbfea1lSNPnw+pWp3Zm9PxZNLv967/PvE3HuKlc3 SKhfi7ab6sDCxZ59i6dke+XJmbynXL3VeHtnT1FiKc5INNRiLipOBADJCk+zoAIAAA== X-CFilter-Loop: Reflected X-Stat-Signature: n7kgwt3tdyp543zbhpz5i53pnwegn1b4 X-Rspam-User: X-Rspamd-Queue-Id: 5AF4A40005 X-Rspamd-Server: rspam08 X-HE-Tag: 1744291525-634395 X-HE-Meta: U2FsdGVkX1+j4qN2WbB9atuyWg5pLD+rI++IuRaq4O6peYbtIuIyBh5LzecNBfXrenhXes1vF2H4Tz7gzL3ct+KjptqIZFsyQHdi6XFm26cBE9Gel/+Et411WXRruhWsTOwaFEJsb1AFKYrCA9MNiqL1SE2QU4BDMJ6yKBL7NkZJ6EjoxCYc11tazhMTKjSekgFjx44BStM3NA2SG7q7Mpt38nvzjQ7bBOgxw+Q4kk7Hs9AlV5W3AvdbaFixN3HY7ktcVRLDihlrIeRqEHq4bzJiACazjmdL/JBEBnoyCqzG1bnR9cBAMa7Jxu0kclxHDn1DlEsxi4ScsipaHFeXPjoX6QtfR1X6SY+WqJOH/wrnMutJ5bFXgpyAqba/czUKLVG8ZJnn+1qOO6fmIBJ4vOVeibCbNFHvq97gkgXiOwrhMTYkjNzhkvbR0C44GztViuOzDKduGkPv8zSWuvyGeg1aAYS1mdXDYdZcu2wFug2MaGtcznK7AlvJtp5EwLMOOLUHw6OAyOwIVT8zRYXZ9OTP6wyUH3EdnyViBG85RYUKxaiqfX4m7xfOos6EkFYSkMaxMwNkbcDL7YtVBam9UKSUiZeLA5FN/aqfdTm+KlULfZWFamiYdxcR69J3LNJkMUCF5KpvAm/5UsgZubvUe9NFNoWLR/9wYlAiVYkicLT9AiDm80MLSkVkI0iMiAQHZnWHDzMkCxiwjIh8Sdjm3MZXkq0oWeXrC6GUcNt2/CHk6V5M9gU4gBuMwUsFmfA5zf6/knq7Bsfe7DN0chdsaBh7cfv6WJN0eRV8y7VIwlWZW0CWxjg8ULvypqAXl8zl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, On 4/9/2025 8:52 PM, David Hildenbrand wrote: > On 09.04.25 13:39, Honggyu Kim wrote: >> Hi David, >> >> On 4/9/2025 6:05 PM, David Hildenbrand wrote: >>> On 08.04.25 09:32, Rakie Kim wrote: [...snip...] >>>> Signed-off-by: Rakie Kim >>>> Signed-off-by: Honggyu Kim >>>> Signed-off-by: Yunjeong Mun >>> >>> Why are the other SOF in there? Are there Co-developed-by missing? >> >> I initially found the problem and fixed it with my internal implementation but >> Rakie also had his idea so he started working on it.  His initial implementation >> has almost been similar to mine. >> >> I thought Signed-off-by is a way to express the patch series contains our >> contribution, but if you think it's unusual, then I can add this. > > Please see Documentation/process/submitting-patches.rst, Thanks for the info. > and note that these are not "patch delivery" SOB. > > " > The Signed-off-by: tag indicates that the signer was involved in the > development of the patch, or that he/she was in the patch's delivery path. Yunjeong and I have been involved in finding the problem and also concluded this issue is related to hotplug together with our initial implementations before this patch. So I guess it is the former case. > " > > and > > " > Co-developed-by: states that the patch was co-created by multiple developers; > it is used to give attribution to co-authors (in addition to the author > attributed by the From: tag) when several people work on a single patch.  Since > Co-developed-by: denotes authorship, every Co-developed-by: must be immediately > followed by a Signed-off-by: of the associated co-author.  Standard sign-off So the Co-developed-by comes before Signed-off-by. > procedure applies, i.e. the ordering of Signed-off-by: tags should reflect the > chronological history of the patch insofar as possible, regardless of whether > the author is attributed via From: or Co-developed-by:.  Notably, the last > Signed-off-by: must always be that of the developer submitting the patch. > " > > The SOB order here is also not correct. It looks the below order is correct. I saw this order in the official document example as well. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15-rc1#n516 >>     Co-developed-by: Honggyu Kim >>     Signed-off-by: Honggyu Kim >> >> For Yunjeong, the following can be added. >> >>     Tested-by: Yunjeong Mun > > That is probably the right thing to do if contribution was focused on testing. > >> >> However, this patch series is already in Andrew's mm-new so I don't want to >> bother him again unless we need to update this patches for other reasons. > > mm-new is exactly for these kind of things. We can ask Andrew to fix it up. Rakie already asked him and he will update signinig tags at the next spin. Thanks very much for your help! Thanks, Honggyu