From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4843CC001DF for ; Mon, 24 Jul 2023 12:17:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C215E8E0001; Mon, 24 Jul 2023 08:17:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD2376B0078; Mon, 24 Jul 2023 08:17:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A99438E0001; Mon, 24 Jul 2023 08:17:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 968776B0075 for ; Mon, 24 Jul 2023 08:17:39 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 568A9140841 for ; Mon, 24 Jul 2023 12:17:39 +0000 (UTC) X-FDA: 81046406238.21.20C9CC8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 36B7540027 for ; Mon, 24 Jul 2023 12:17:35 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NtNZDCL+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690201056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rw38L/Q8Z4s8bYibZZQKRAeS223PBas54MnJkEMI578=; b=C2rRNfZ+L1E2gToMxr0jwOqOPhdC8/Qo+4Hoc2hYbz55Ab78lGTXcuCb/W3ibGgb37NLAA 9WMGwEHCaxs8l3PgGKxQVy1Y4G5bnZMmDvVkALD1PhxXdDgFfN3sYVr1t7nQnLwzjVkkrN 7FrP3lpZRzQqwph0MMfdbhgvFNRQWI0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NtNZDCL+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690201056; a=rsa-sha256; cv=none; b=N9WXLbnydq/IVXwAyQGhnnsT6qa63ucSq82xImIF3a46mZDnnua+uhoTC6HMlR2+mXhJZw tg/vi4nPGJMGKKs4PBo4fqNSejczphsoY+k/AJWWvgY/cWdj1SFNvAVGNdcBVtRLUUoB/w Ou6bLzpDyo59xbyNA7hrPHx2oAN6Qtc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690201055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rw38L/Q8Z4s8bYibZZQKRAeS223PBas54MnJkEMI578=; b=NtNZDCL+DLMI9wpCXI+UUtrBkSbityNJZ4zgpzv8+WzoNtSf9m8/FR/5/uSuOm1riAtOY9 NsMN7+ujt33n0a35FFx7Eotk8U78jckt6lB1Lqhp8RPWWnLHG0D106rXElKRr8Cw2reJZ0 v6xUEEgJzxucTVOkOYQe4zmofUObWhg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-97-ebBpFScJN2GFoK3EFllY9w-1; Mon, 24 Jul 2023 08:17:32 -0400 X-MC-Unique: ebBpFScJN2GFoK3EFllY9w-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3faabd8fd33so20775445e9.0 for ; Mon, 24 Jul 2023 05:17:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690201051; x=1690805851; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rw38L/Q8Z4s8bYibZZQKRAeS223PBas54MnJkEMI578=; b=Sg7Hafexr5igFJtIoXHurORoyIQyRKB3M6fy6rkOTUsL8Yri+uo6kXAN6HiIkvHFYC x5pXNf683bI9h8AAmj6XUHEd0Zar8xcXwlEI+GcRP18tVEO2m+uKd7IXIKHJhPVKe0i2 4rRccnx2NX99Y9s9EGvu/6kh7yjfq79C29gZz80c4EoLZokl/Zt2oK8GU7XG2uMzAker vAuqtVJPuQocTX66HMQnK3r3gXVMAsMxrmOUygleE9OsEOjgzcpwtmG8dmNTJV/ubFcT 0wod8PgJUnHLLSxgsG+XX84dvIb0t4Ynem0/j82DjYUjy248+hBfy1B3k5vp7+MaUDX1 sNKw== X-Gm-Message-State: ABy/qLYsYuNrrLb5IQuAgzieFcGlCEbD5euL3f7qFDTyNUvfiUPWP3vi naFoGYhhLyALlT/uD3U6TstDkVAkn8HTlF3JZ+fCUvLifSzTIUhuJX1EGNtGHXsZCJF5upHcGit 8ildE8HSLqUk= X-Received: by 2002:a5d:61c5:0:b0:30f:af19:81f3 with SMTP id q5-20020a5d61c5000000b0030faf1981f3mr6477784wrv.41.1690201050959; Mon, 24 Jul 2023 05:17:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlEYkw/lGxF1vjEi65r5E6yxlhuiVPGxjyLJAPmxRiUwT8XJoqElxkVFhxzMFJGpNUQbu+34jA== X-Received: by 2002:a5d:61c5:0:b0:30f:af19:81f3 with SMTP id q5-20020a5d61c5000000b0030faf1981f3mr6477770wrv.41.1690201050535; Mon, 24 Jul 2023 05:17:30 -0700 (PDT) Received: from ?IPV6:2003:cb:c73d:bb00:91a5:d1c:3a7e:4c77? (p200300cbc73dbb0091a50d1c3a7e4c77.dip0.t-ipconnect.de. [2003:cb:c73d:bb00:91a5:d1c:3a7e:4c77]) by smtp.gmail.com with ESMTPSA id o26-20020a5d58da000000b0030ae499da59sm12758358wrf.111.2023.07.24.05.17.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 05:17:30 -0700 (PDT) Message-ID: <754fa87f-48a1-b086-c258-6f74375dec29@redhat.com> Date: Mon, 24 Jul 2023 14:17:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 2/2] mm/compaction: avoid unneeded pageblock_end_pfn when no_set_skip_hint is set To: Kemeng Shi , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com References: <20230721150957.2058634-1-shikemeng@huawei.com> <20230721150957.2058634-3-shikemeng@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230721150957.2058634-3-shikemeng@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 36B7540027 X-Stat-Signature: 9hgmoq5wu5tictwdjryaoch1gxqnhqd8 X-HE-Tag: 1690201055-762392 X-HE-Meta: U2FsdGVkX183Al1rQpR1yQfuYE2s7Qam+Mg2Gyvs8EHQCgr2n2rp/gUa528mOEV/xKbOGDSMW/09v4nYBEkrpxnF7IWRpp3UbvRDdUCVnNhG7KUeCYXW29NMHOpPec6bQpdHTkzWs74X6XJc9Pk+ovuTEtAALQDqYg7VMHETt7Fk0fbk9w9FzOa+aO08gH/A1lEYY6Sbb8JE7CK6O3+CPg0cN/8N3RuQkMU2K4sytk42RDSNsVn5+IJ6c1pojUUFosmnBRlR/bnsi3zWRtwICCe7kMFYRDxm74+z9kIzH4Ri3+enBUBCVZUe+QICmfs4II4Iv1EczFvQ/LjaoAXSw/9zJQPkuWooVkS8TfMpxEViWU8kIeJzsR1cpDz0vTyH3kGLLrboMLVNZzS+OaQmO3tmxIroGz3ZhOSlZ3kk33nbb+A2CMEDz+QQ59E30MfDkrH4oCAbjzx7jsnte+wdS91lfT398txndA0tw0uP9/Dy03MmJLl3z6qgR2tcUvqtpTuD0d0dh3YrDt4fAxsDQ5S9QE5RN+vPqad/puU61bjDeCeF9f4FaS0oWYXpsfXNWS/NKvI5lrTsE0jftyg6D0sv+rRZYoXdyd+w3d83LQ78dIdFs13VaMh9zFlj1PMpI2aNI9jwmg9VXOmrv9OoM0YQDYFFRasATWRY+3hsvuhCrdjBO/lRzJDx8Wz8D2SMpmQj0Rh/ftKgZCZh7NRo0FSTgeAb5sLrDtD1s/zBbDW1by5K2oWQ5+nkYM3yZhMfPGsdqI/j9A1jjhYzVZXisVjUWyaY+5i3rrWfFvjg+AUo8McNWxvaHYkzKEeviRyRzvVVaPrcrtCl0196gogXKbbLFvECByIurh2UyIfkBo449GRmW6TOTeSCiHmyVRZJZpX85Wngjq3HFOH+x9zRTMtKsIHDPUariilNLU8K+hWFudKY9lCuh4nY5D2wzApLco54dt8hvY3WGVDTm4y 0cm/2Lxe wSMP/6Kaj3bGy24P/19cFObgRQ5YiuYHIYkXhvxz25aTodKttoqoVP9i089RAiL/J9Rs5I6HxeIg8+0hywVgHxpI6AWPWUrJtliaGQspLE73zHADwhueeX1GPmV00AuAG7paJ5aBEhKDaFbpsltI9BGE/WkdvvbtoO445SOPoL55SMX8dVh9oQ7wRlhGG2P9LdmHUPywSK3PDXBnivPz8kjhmuALjmdp58qrSzoJx0/sOHVeEGsaHSMQ2WLNRHRoF0D0FIGcWgIjdHwVIfoywJxgdsYRhMBDzvdmZ9FWgyxz1zOL63pJa/4Eh5P1ruRFPHMfN9UP8xzjZ/I7apQ3wJNTqq+U9pbOSzIoYpp+BT15bop7LKvyAt4yAf9Oplj2arorBGmUO341bBlL/+zlV9gfvioms612AUIur85MXWraXPgIPQ85W4rjq0Nd2/HGvDpAh2T+wLa4XI+9pOpvB8BZTkQJYhG/RaHh+XoMVr2EEbQcuYK1lPP6gQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.07.23 17:09, Kemeng Shi wrote: > Move pageblock_end_pfn after no_set_skip_hint check to avoid unneeded > pageblock_end_pfn if no_set_skip_hint is set. > > Signed-off-by: Kemeng Shi > Reviewed-by: Baolin Wang > --- > mm/compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index c0d8d08fc163..9b7a0a69e19f 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -458,12 +458,12 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn) > { > struct zone *zone = cc->zone; > > - pfn = pageblock_end_pfn(pfn); > - > /* Set for isolation rather than compaction */ > if (cc->no_set_skip_hint) > return; > > + pfn = pageblock_end_pfn(pfn); > + > if (pfn > zone->compact_cached_migrate_pfn[0]) > zone->compact_cached_migrate_pfn[0] = pfn; > if (cc->mode != MIGRATE_ASYNC && I'm pretty sure the compiler can to optimize this -- there should not be any function call involved, so the compiler can reorder as it pleases. Anyhow, change itself looks good. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb